feat: rename payer_dni to transfer_payer_dni across purchase handling and update related tests
This commit is contained in:
@@ -54,7 +54,7 @@ class TelepagosWebhookService
|
|||||||
$dni = substr($cuit, 2, -1);
|
$dni = substr($cuit, 2, -1);
|
||||||
|
|
||||||
$compra = Purchase::where('tenant_codigo', $tenantCodigo)
|
$compra = Purchase::where('tenant_codigo', $tenantCodigo)
|
||||||
->where('payer_dni', $dni)
|
->where('transfer_payer_dni', $dni)
|
||||||
->whereIn('status', [Purchase::STATUS_CREATED, Purchase::STATUS_PENDING_PAYMENT])
|
->whereIn('status', [Purchase::STATUS_CREATED, Purchase::STATUS_PENDING_PAYMENT])
|
||||||
->where('payment_method', 'transfer')
|
->where('payment_method', 'transfer')
|
||||||
->where('total', $amount)
|
->where('total', $amount)
|
||||||
|
|||||||
@@ -74,7 +74,7 @@ class PurchaseController extends Controller
|
|||||||
];
|
];
|
||||||
|
|
||||||
if ($method === 'transfer') {
|
if ($method === 'transfer') {
|
||||||
$purchaseUpdate['payer_dni'] = preg_replace('/\D+/', '', (string) $request->validated('payer_dni'));
|
$purchaseUpdate['transfer_payer_dni'] = preg_replace('/\D+/', '', (string) $request->validated('transfer_payer_dni'));
|
||||||
}
|
}
|
||||||
|
|
||||||
$compra->update($purchaseUpdate);
|
$compra->update($purchaseUpdate);
|
||||||
|
|||||||
@@ -20,7 +20,7 @@ use Illuminate\Database\Eloquent\Relations\HasOne;
|
|||||||
'payment_method',
|
'payment_method',
|
||||||
'total',
|
'total',
|
||||||
'dni',
|
'dni',
|
||||||
'payer_dni',
|
'transfer_payer_dni',
|
||||||
'telefono',
|
'telefono',
|
||||||
'nombre_apellido',
|
'nombre_apellido',
|
||||||
'email',
|
'email',
|
||||||
|
|||||||
@@ -19,7 +19,7 @@ class PaymentIntentRequest extends FormRequest
|
|||||||
{
|
{
|
||||||
return [
|
return [
|
||||||
'method' => ['required', 'string', Rule::in(['qr', 'transfer'])],
|
'method' => ['required', 'string', Rule::in(['qr', 'transfer'])],
|
||||||
'payer_dni' => [
|
'transfer_payer_dni' => [
|
||||||
Rule::requiredIf(fn (): bool => $this->input('method') === 'transfer'),
|
Rule::requiredIf(fn (): bool => $this->input('method') === 'transfer'),
|
||||||
'string',
|
'string',
|
||||||
'regex:/^\d{7,8}$/',
|
'regex:/^\d{7,8}$/',
|
||||||
|
|||||||
@@ -44,7 +44,7 @@ class PurchaseResource extends JsonResource
|
|||||||
'status' => $this->status,
|
'status' => $this->status,
|
||||||
'payment_method' => $this->payment_method,
|
'payment_method' => $this->payment_method,
|
||||||
'dni' => $this->dni,
|
'dni' => $this->dni,
|
||||||
'payer_dni' => $this->payer_dni,
|
'transfer_payer_dni' => $this->transfer_payer_dni,
|
||||||
'telefono' => $this->telefono,
|
'telefono' => $this->telefono,
|
||||||
'nombre_apellido' => $this->nombre_apellido,
|
'nombre_apellido' => $this->nombre_apellido,
|
||||||
'email' => $this->email,
|
'email' => $this->email,
|
||||||
|
|||||||
@@ -9,14 +9,14 @@ return new class extends Migration
|
|||||||
public function up(): void
|
public function up(): void
|
||||||
{
|
{
|
||||||
Schema::table('compras', function (Blueprint $table) {
|
Schema::table('compras', function (Blueprint $table) {
|
||||||
$table->string('payer_dni', 8)->nullable()->after('dni');
|
$table->string('transfer_payer_dni', 8)->nullable()->after('dni');
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
public function down(): void
|
public function down(): void
|
||||||
{
|
{
|
||||||
Schema::table('compras', function (Blueprint $table) {
|
Schema::table('compras', function (Blueprint $table) {
|
||||||
$table->dropColumn('payer_dni');
|
$table->dropColumn('transfer_payer_dni');
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -33,7 +33,7 @@ class TelepagosWebhookTest extends TestCase
|
|||||||
Cache::flush();
|
Cache::flush();
|
||||||
}
|
}
|
||||||
|
|
||||||
public function test_transfer_payment_intent_requires_a_valid_payer_dni(): void
|
public function test_transfer_payment_intent_requires_a_valid_transfer_payer_dni(): void
|
||||||
{
|
{
|
||||||
$tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
|
$tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
|
||||||
$user = User::factory()->create();
|
$user = User::factory()->create();
|
||||||
@@ -45,18 +45,18 @@ class TelepagosWebhookTest extends TestCase
|
|||||||
'method' => 'transfer',
|
'method' => 'transfer',
|
||||||
])
|
])
|
||||||
->assertUnprocessable()
|
->assertUnprocessable()
|
||||||
->assertJsonValidationErrors(['payer_dni']);
|
->assertJsonValidationErrors(['transfer_payer_dni']);
|
||||||
|
|
||||||
$this->actingAs($user, 'sanctum')
|
$this->actingAs($user, 'sanctum')
|
||||||
->postJson("/api/tenants/sonder/compras/{$purchase->id}/payment-intent", [
|
->postJson("/api/tenants/sonder/compras/{$purchase->id}/payment-intent", [
|
||||||
'method' => 'transfer',
|
'method' => 'transfer',
|
||||||
'payer_dni' => '12.345.678',
|
'transfer_payer_dni' => '12.345.678',
|
||||||
])
|
])
|
||||||
->assertUnprocessable()
|
->assertUnprocessable()
|
||||||
->assertJsonValidationErrors(['payer_dni']);
|
->assertJsonValidationErrors(['transfer_payer_dni']);
|
||||||
}
|
}
|
||||||
|
|
||||||
public function test_transfer_payment_intent_persists_payer_dni_without_replacing_customer_dni(): void
|
public function test_transfer_payment_intent_persists_transfer_payer_dni_without_replacing_customer_dni(): void
|
||||||
{
|
{
|
||||||
$tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
|
$tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
|
||||||
$this->configureTelepagosIntegration($tenant);
|
$this->configureTelepagosIntegration($tenant);
|
||||||
@@ -82,7 +82,7 @@ class TelepagosWebhookTest extends TestCase
|
|||||||
$this->actingAs($user, 'sanctum')
|
$this->actingAs($user, 'sanctum')
|
||||||
->postJson("/api/tenants/sonder/compras/{$purchase->id}/payment-intent", [
|
->postJson("/api/tenants/sonder/compras/{$purchase->id}/payment-intent", [
|
||||||
'method' => 'transfer',
|
'method' => 'transfer',
|
||||||
'payer_dni' => '23456789',
|
'transfer_payer_dni' => '23456789',
|
||||||
])
|
])
|
||||||
->assertOk()
|
->assertOk()
|
||||||
->assertJsonPath('transfer_data.alias', 'telepagos.test');
|
->assertJsonPath('transfer_data.alias', 'telepagos.test');
|
||||||
@@ -90,7 +90,7 @@ class TelepagosWebhookTest extends TestCase
|
|||||||
$this->assertDatabaseHas('compras', [
|
$this->assertDatabaseHas('compras', [
|
||||||
'id' => $purchase->id,
|
'id' => $purchase->id,
|
||||||
'dni' => '87654321',
|
'dni' => '87654321',
|
||||||
'payer_dni' => '23456789',
|
'transfer_payer_dni' => '23456789',
|
||||||
'payment_method' => 'transfer',
|
'payment_method' => 'transfer',
|
||||||
]);
|
]);
|
||||||
}
|
}
|
||||||
@@ -279,7 +279,7 @@ class TelepagosWebhookTest extends TestCase
|
|||||||
|
|
||||||
$purchase->update([
|
$purchase->update([
|
||||||
'payment_method' => 'transfer',
|
'payment_method' => 'transfer',
|
||||||
'payer_dni' => $dni,
|
'transfer_payer_dni' => $dni,
|
||||||
]);
|
]);
|
||||||
|
|
||||||
$checkoutService->completePurchase($purchase);
|
$checkoutService->completePurchase($purchase);
|
||||||
|
|||||||
Reference in New Issue
Block a user