From b3d06431e570d4f65b897d5d5c1e0bd635676586 Mon Sep 17 00:00:00 2001 From: ncoronel Date: Thu, 16 Jul 2026 11:45:34 -0300 Subject: [PATCH] feat: rename payer_dni to transfer_payer_dni across purchase handling and update related tests --- .../Services/TelepagosWebhookService.php | 2 +- .../Purchase/Controllers/PurchaseController.php | 2 +- app/Domains/Purchase/Models/Purchase.php | 2 +- .../Purchase/Requests/PaymentIntentRequest.php | 2 +- .../Purchase/Resources/PurchaseResource.php | 2 +- ..._12_000000_add_payer_dni_to_compras_table.php | 4 ++-- .../Feature/Integration/TelepagosWebhookTest.php | 16 ++++++++-------- 7 files changed, 15 insertions(+), 15 deletions(-) diff --git a/app/Domains/Integration/Services/TelepagosWebhookService.php b/app/Domains/Integration/Services/TelepagosWebhookService.php index ac0a2b6..0ff5002 100644 --- a/app/Domains/Integration/Services/TelepagosWebhookService.php +++ b/app/Domains/Integration/Services/TelepagosWebhookService.php @@ -54,7 +54,7 @@ class TelepagosWebhookService $dni = substr($cuit, 2, -1); $compra = Purchase::where('tenant_codigo', $tenantCodigo) - ->where('payer_dni', $dni) + ->where('transfer_payer_dni', $dni) ->whereIn('status', [Purchase::STATUS_CREATED, Purchase::STATUS_PENDING_PAYMENT]) ->where('payment_method', 'transfer') ->where('total', $amount) diff --git a/app/Domains/Purchase/Controllers/PurchaseController.php b/app/Domains/Purchase/Controllers/PurchaseController.php index 1557dcc..86cbf3c 100644 --- a/app/Domains/Purchase/Controllers/PurchaseController.php +++ b/app/Domains/Purchase/Controllers/PurchaseController.php @@ -74,7 +74,7 @@ class PurchaseController extends Controller ]; if ($method === 'transfer') { - $purchaseUpdate['payer_dni'] = preg_replace('/\D+/', '', (string) $request->validated('payer_dni')); + $purchaseUpdate['transfer_payer_dni'] = preg_replace('/\D+/', '', (string) $request->validated('transfer_payer_dni')); } $compra->update($purchaseUpdate); diff --git a/app/Domains/Purchase/Models/Purchase.php b/app/Domains/Purchase/Models/Purchase.php index c1cd132..fd09ece 100644 --- a/app/Domains/Purchase/Models/Purchase.php +++ b/app/Domains/Purchase/Models/Purchase.php @@ -20,7 +20,7 @@ use Illuminate\Database\Eloquent\Relations\HasOne; 'payment_method', 'total', 'dni', - 'payer_dni', + 'transfer_payer_dni', 'telefono', 'nombre_apellido', 'email', diff --git a/app/Domains/Purchase/Requests/PaymentIntentRequest.php b/app/Domains/Purchase/Requests/PaymentIntentRequest.php index 095f4b9..61d523b 100644 --- a/app/Domains/Purchase/Requests/PaymentIntentRequest.php +++ b/app/Domains/Purchase/Requests/PaymentIntentRequest.php @@ -19,7 +19,7 @@ class PaymentIntentRequest extends FormRequest { return [ 'method' => ['required', 'string', Rule::in(['qr', 'transfer'])], - 'payer_dni' => [ + 'transfer_payer_dni' => [ Rule::requiredIf(fn (): bool => $this->input('method') === 'transfer'), 'string', 'regex:/^\d{7,8}$/', diff --git a/app/Domains/Purchase/Resources/PurchaseResource.php b/app/Domains/Purchase/Resources/PurchaseResource.php index 8fdc774..2e0f6b8 100644 --- a/app/Domains/Purchase/Resources/PurchaseResource.php +++ b/app/Domains/Purchase/Resources/PurchaseResource.php @@ -44,7 +44,7 @@ class PurchaseResource extends JsonResource 'status' => $this->status, 'payment_method' => $this->payment_method, 'dni' => $this->dni, - 'payer_dni' => $this->payer_dni, + 'transfer_payer_dni' => $this->transfer_payer_dni, 'telefono' => $this->telefono, 'nombre_apellido' => $this->nombre_apellido, 'email' => $this->email, diff --git a/database/migrations/2026_07_12_000000_add_payer_dni_to_compras_table.php b/database/migrations/2026_07_12_000000_add_payer_dni_to_compras_table.php index 298b385..f2e1149 100644 --- a/database/migrations/2026_07_12_000000_add_payer_dni_to_compras_table.php +++ b/database/migrations/2026_07_12_000000_add_payer_dni_to_compras_table.php @@ -9,14 +9,14 @@ return new class extends Migration public function up(): void { Schema::table('compras', function (Blueprint $table) { - $table->string('payer_dni', 8)->nullable()->after('dni'); + $table->string('transfer_payer_dni', 8)->nullable()->after('dni'); }); } public function down(): void { Schema::table('compras', function (Blueprint $table) { - $table->dropColumn('payer_dni'); + $table->dropColumn('transfer_payer_dni'); }); } }; diff --git a/tests/Feature/Integration/TelepagosWebhookTest.php b/tests/Feature/Integration/TelepagosWebhookTest.php index 99eafef..47f8f77 100644 --- a/tests/Feature/Integration/TelepagosWebhookTest.php +++ b/tests/Feature/Integration/TelepagosWebhookTest.php @@ -33,7 +33,7 @@ class TelepagosWebhookTest extends TestCase Cache::flush(); } - public function test_transfer_payment_intent_requires_a_valid_payer_dni(): void + public function test_transfer_payment_intent_requires_a_valid_transfer_payer_dni(): void { $tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar'); $user = User::factory()->create(); @@ -45,18 +45,18 @@ class TelepagosWebhookTest extends TestCase 'method' => 'transfer', ]) ->assertUnprocessable() - ->assertJsonValidationErrors(['payer_dni']); + ->assertJsonValidationErrors(['transfer_payer_dni']); $this->actingAs($user, 'sanctum') ->postJson("/api/tenants/sonder/compras/{$purchase->id}/payment-intent", [ 'method' => 'transfer', - 'payer_dni' => '12.345.678', + 'transfer_payer_dni' => '12.345.678', ]) ->assertUnprocessable() - ->assertJsonValidationErrors(['payer_dni']); + ->assertJsonValidationErrors(['transfer_payer_dni']); } - public function test_transfer_payment_intent_persists_payer_dni_without_replacing_customer_dni(): void + public function test_transfer_payment_intent_persists_transfer_payer_dni_without_replacing_customer_dni(): void { $tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar'); $this->configureTelepagosIntegration($tenant); @@ -82,7 +82,7 @@ class TelepagosWebhookTest extends TestCase $this->actingAs($user, 'sanctum') ->postJson("/api/tenants/sonder/compras/{$purchase->id}/payment-intent", [ 'method' => 'transfer', - 'payer_dni' => '23456789', + 'transfer_payer_dni' => '23456789', ]) ->assertOk() ->assertJsonPath('transfer_data.alias', 'telepagos.test'); @@ -90,7 +90,7 @@ class TelepagosWebhookTest extends TestCase $this->assertDatabaseHas('compras', [ 'id' => $purchase->id, 'dni' => '87654321', - 'payer_dni' => '23456789', + 'transfer_payer_dni' => '23456789', 'payment_method' => 'transfer', ]); } @@ -279,7 +279,7 @@ class TelepagosWebhookTest extends TestCase $purchase->update([ 'payment_method' => 'transfer', - 'payer_dni' => $dni, + 'transfer_payer_dni' => $dni, ]); $checkoutService->completePurchase($purchase);