tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(auth): correct tenant code handling in login failure registration

Browse Source
This commit is contained in:
ncoronel
2026-08-11 16:05:37 -03:00
parent 7d9489169d
commit 498b4d9eac
2 changed files with 39 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Domains/Auth/Services/PasswordLoginService.php
View File

@@ -159,8 +159,8 @@ class PasswordLoginService
}
if ($user === null || ! Hash::check($password, $user->password)) {
if ($user !== null) {
$this->registerFailure($user, $now, $tenantCode);
if ($user !== null && $attemptTenantCode !== null) {
$this->registerFailure($user, $now, $attemptTenantCode);
}
$outcome = $user?->locked_until?->isFuture()

37
tests/Feature/Auth/ScannerLoginControllerTest.php
View File

@@ -2,6 +2,7 @@
namespace Tests\Feature\Auth;
use App\Domains\Auth\Models\LoginAttempt;
use App\Domains\Auth\Models\User;
use App\Domains\Authorization\Enums\PermissionCode;
use App\Domains\Authorization\Enums\RoleCode;
@@ -76,4 +77,40 @@ class ScannerLoginControllerTest extends TestCase
'password' => 'secret123',
])->assertUnprocessable()->assertJsonValidationErrors(['email']);
}
public function test_an_invalid_password_is_recorded_with_the_users_tenant(): void
{
$role = Role::query()->create([
'codigo' => RoleCode::Scanner->value,
'nombre' => 'Scanner',
]);
$permission = Permission::query()->create([
'codigo' => PermissionCode::ScanTickets->value,
'nombre' => 'Escanear tickets',
]);
$role->permissions()->attach($permission->codigo);
$tenant = Tenant::query()->create([
'codigo' => 'acme',
'nombre' => 'Acme',
'dominio' => 'acme.test',
]);
$user = User::factory()->create([
'email' => 'scanner@example.com',
'password' => Hash::make('correct-password'),
'rol_codigo' => $role->codigo,
'tenant_codigo' => $tenant->codigo,
]);
$this->postJson('/api/v1/scanner/login', [
'email' => $user->email,
'password' => 'wrong-password',
])->assertUnprocessable()->assertJsonValidationErrors(['email']);
$this->assertSame(1, $user->refresh()->failed_login_attempts);
$this->assertDatabaseHas('login_attempts', [
'user_id' => $user->id,
'tenant_codigo' => $tenant->codigo,
'outcome' => LoginAttempt::OUTCOME_INVALID_CREDENTIALS,
]);
}
}