tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(menu): remove unused management API

Browse Source
This commit is contained in:
ncoronel
2026-08-27 12:10:33 -03:00
parent 3adef9341e
commit 44f75185a1
6 changed files with 0 additions and 369 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
app/Domains/Menu/Controllers/MenuController.php
View File

@@ -1,79 +0,0 @@
<?php
namespace App\Domains\Menu\Controllers;
use App\Domains\Menu\Models\Menu;
use App\Http\Controllers\Controller;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Validation\Rule;
class MenuController extends Controller
{
public function index(): JsonResponse
{
$menues = Menu::all();
return response()->json($menues);
}
public function store(Request $request): JsonResponse
{
$validated = $request->validate([
'code' => 'required|string|unique:menues,code',
'label' => 'required|string|max:255',
'parent_menu_code' => [
'nullable',
'string',
Rule::exists('menues', 'code'),
'different:code',
],
'content_type' => [
'sometimes',
Rule::in([Menu::CONTENT_TYPE_STATIC, Menu::CONTENT_TYPE_DYNAMIC]),
],
'static_content_schema' => 'required_if:content_type,static|nullable|array',
'route' => 'required|string',
]);
$menu = Menu::create($validated);
return response()->json($menu, 201);
}
public function show(Menu $menu): JsonResponse
{
return response()->json($menu);
}
public function update(Request $request, Menu $menu): JsonResponse
{
$validated = $request->validate([
'code' => 'sometimes|required|string|unique:menues,code,'.$menu->id,
'label' => 'sometimes|required|string|max:255',
'parent_menu_code' => [
'nullable',
'string',
Rule::exists('menues', 'code'),
Rule::notIn([$menu->code]),
],
'content_type' => [
'sometimes',
Rule::in([Menu::CONTENT_TYPE_STATIC, Menu::CONTENT_TYPE_DYNAMIC]),
],
'static_content_schema' => 'required_if:content_type,static|nullable|array',
'route' => 'sometimes|required|string',
]);
$menu->update($validated);
return response()->json($menu);
}
public function destroy(Menu $menu): JsonResponse
{
$menu->delete();
return response()->json(null, 204);
}
}

32
app/Domains/Menu/Controllers/TenantMenuController.php
View File

@@ -1,32 +0,0 @@
<?php
namespace App\Domains\Menu\Controllers;
use App\Domains\Menu\Models\Menu;
use App\Domains\Menu\Requests\StoreTenantMenuRequest;
use App\Domains\Menu\Services\TenantMenuService;
use App\Domains\Tenant\Models\Tenant;
use App\Http\Controllers\Controller;
use Illuminate\Http\JsonResponse;
class TenantMenuController extends Controller
{
public function __construct(private readonly TenantMenuService $tenantMenuService) {}
public function store(
StoreTenantMenuRequest $request,
string $tenantCode,
string $menuCode,
): JsonResponse {
$tenant = Tenant::query()->where('codigo', $tenantCode)->firstOrFail();
$menu = Menu::query()->where('code', $menuCode)->firstOrFail();
$tenantMenu = $this->tenantMenuService->configure(
$tenant,
$menu,
$request->validated('static_content'),
);
return response()->json($tenantMenu);
}
}

49
app/Domains/Menu/Requests/StoreTenantMenuRequest.php
View File

@@ -1,49 +0,0 @@
<?php
namespace App\Domains\Menu\Requests;
use App\Domains\Menu\Models\Menu;
use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Validation\ValidationException;
class StoreTenantMenuRequest extends FormRequest
{
private ?Menu $menuModel = null;
public function authorize(): bool
{
return true;
}
protected function prepareForValidation(): void
{
$this->menuModel = Menu::query()
->where('code', $this->route('menu_code'))
->first();
if (! $this->menuModel) {
throw ValidationException::withMessages([
'menu_code' => __('api.menu.not_found'),
]);
}
}
public function rules(): array
{
if ($this->menuModel?->content_type !== Menu::CONTENT_TYPE_STATIC) {
return [
'static_content' => ['nullable', 'array'],
];
}
$rules = [
'static_content' => ['required', 'array'],
];
foreach ($this->menuModel->static_content_schema as $field => $rule) {
$rules["static_content.{$field}"] = $rule;
}
return $rules;
}
}

26
app/Domains/Menu/Services/TenantMenuService.php
View File

@@ -1,26 +0,0 @@
<?php
namespace App\Domains\Menu\Services;
use App\Domains\Menu\Models\Menu;
use App\Domains\Menu\Models\TenantMenu;
use App\Domains\Tenant\Models\Tenant;
use Illuminate\Support\Facades\DB;
class TenantMenuService
{
public function configure(Tenant $tenant, Menu $menu, ?array $staticContent): TenantMenu
{
return DB::transaction(fn () => TenantMenu::query()->updateOrCreate(
[
'tenant_code' => $tenant->codigo,
'menu_code' => $menu->code,
],
[
'static_content' => $menu->content_type === Menu::CONTENT_TYPE_STATIC
? $staticContent
: null,
],
));
}
}

12
app/Domains/Menu/routes/api.php
View File

@@ -1,12 +0,0 @@
<?php
use App\Domains\Menu\Controllers\MenuController;
use App\Domains\Menu\Controllers\TenantMenuController;
use Illuminate\Support\Facades\Route;
Route::apiResource('menues', MenuController::class);
Route::post(
'{tenant_code}/menues/{menu_code}',
[TenantMenuController::class, 'store']
);

171
tests/Feature/Menu/TenantMenuControllerTest.php
View File

@@ -1,171 +0,0 @@
<?php
namespace Tests\Feature\Menu;
use App\Domains\Attachable\Enums\AttachmentType;
use App\Domains\Attachable\Models\Attachment;
use App\Domains\Menu\Models\Menu;
use App\Domains\Tenant\Models\Tenant;
use Database\Seeders\MenuSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
class TenantMenuControllerTest extends TestCase
{
use RefreshDatabase;
public function test_it_validates_static_content_with_the_menu_schema(): void
{
$tenant = $this->createTenant();
$menu = Menu::query()->create([
'code' => 'about',
'label' => 'Nosotros',
'content_type' => Menu::CONTENT_TYPE_STATIC,
'static_content_schema' => [
'title' => 'required|string|max:20',
'sections' => 'required|array|min:1',
'sections.*.body' => 'required|string',
],
'route' => '/about',
]);
$this->postJson("/api/{$tenant->codigo}/menues/{$menu->code}", [
'static_content' => [
'title' => 123,
'sections' => [],
],
])
->assertUnprocessable()
->assertJsonValidationErrors([
'static_content.title',
'static_content.sections',
]);
$this->assertDatabaseMissing('tenants_menues', [
'tenant_code' => $tenant->codigo,
'menu_code' => $menu->code,
]);
}
public function test_it_configures_a_static_menu_when_content_matches_the_schema(): void
{
$tenant = $this->createTenant();
$menu = Menu::query()->create([
'code' => 'about',
'label' => 'Nosotros',
'content_type' => Menu::CONTENT_TYPE_STATIC,
'static_content_schema' => [
'title' => 'required|string|max:20',
'sections' => 'required|array|min:1',
'sections.*.body' => 'required|string',
],
'route' => '/about',
]);
$content = [
'title' => 'Nosotros',
'sections' => [
['body' => 'Nuestra historia'],
],
];
$this->postJson("/api/{$tenant->codigo}/menues/{$menu->code}", [
'static_content' => $content,
])
->assertOk()
->assertJsonPath('static_content.title', 'Nosotros')
->assertJsonPath('static_content.sections.0.body', 'Nuestra historia');
$this->assertSame(
$content,
$tenant->menues()->where('menues.code', $menu->code)->firstOrFail()->pivot->static_content
);
}
public function test_dynamic_menus_do_not_require_static_content(): void
{
$tenant = $this->createTenant();
$menu = Menu::query()->create([
'code' => 'catalog',
'label' => 'Catálogo',
'route' => '/catalog',
]);
$this->postJson("/api/{$tenant->codigo}/menues/{$menu->code}")
->assertOk()
->assertJsonPath('static_content', null);
$this->assertDatabaseHas('tenants_menues', [
'tenant_code' => $tenant->codigo,
'menu_code' => $menu->code,
'static_content' => null,
]);
}
public function test_contact_content_requires_coordinates_inside_each_address(): void
{
$tenant = $this->createTenant();
$this->seed(MenuSeeder::class);
$this->postJson("/api/{$tenant->codigo}/menues/help.contact", [
'static_content' => [
'whatsapp' => [
'whatsapp_url' => 'https://wa.me/543412602222',
'whatsapp_label' => 'Chatea con nosotros',
],
'phone' => '+54 9 (0341) 6658247',
'locations' => [
'rosario' => [
'label' => 'Rosario',
'addresses' => [
[
'label' => 'Av. San Lorenzo 1542',
'address' => 'Av. San Lorenzo 1542, Rosario',
'coordinates' => [-91, -181],
],
],
],
],
'map_locations' => [
'legacy_point' => [-32.946820, -60.639320],
],
],
])
->assertUnprocessable()
->assertJsonValidationErrors([
'static_content.locations.rosario.addresses.0.coordinates.0',
'static_content.locations.rosario.addresses.0.coordinates.1',
'static_content.map_locations',
]);
}
private function createTenant(): Tenant
{
$headerLogo = $this->createAttachment('header.png');
$footerLogo = $this->createAttachment('footer.png');
return Tenant::query()->create([
'codigo' => 'acme',
'nombre' => 'Acme',
'dominio' => 'acme.com',
'primary_color' => '#111111',
'secondary_color' => '#222222',
'danger_color' => '#333333',
'success_color' => '#444444',
'header_bg_color' => '#ffffff',
'footer_bg_color' => '#ffffff',
'header_logo_id' => $headerLogo->id,
'footer_logo_id' => $footerLogo->id,
]);
}
private function createAttachment(string $filename): Attachment
{
return Attachment::query()->create([
'path' => "test/{$filename}",
'filename' => $filename,
'type' => AttachmentType::Image,
'mime_type' => 'image/png',
]);
}
}