7 Commits

Author SHA1 Message Date
8c2f00bcbc refactor: remove loading state management from category and search pages 2026-07-29 12:06:29 -03:00
da61067c6a feat: introduce loading context management across services
- Refactor AuthService, CartService, CatalogService, CheckoutService, TenantService, and TicketService to extend BaseApiService for consistent loading context handling.
- Implement loading modes ('global', 'custom', 'none') using HttpContext for API requests.
- Update existing service methods to accept loading mode parameters and propagate them to HTTP requests.
- Enhance global loading interceptor to respect loading modes and prevent global loading for specific requests.
- Add unit tests to verify loading mode propagation in services and interceptors.
- Update component interactions to utilize the new loading mode functionality.
2026-07-29 11:54:31 -03:00
125d9137fb feat: implement global loading state with interceptor and component 2026-07-29 11:03:35 -03:00
1fb9789abf fix: correct language attribute from 'en' to 'e' in HTML tag 2026-07-29 11:02:59 -03:00
7ebf383c89 refactor: change password input type to password-toggle and update icon class 2026-07-29 10:25:33 -03:00
c14f740dbb Merge branch 'refactor/purchase_screen' into develop 2026-07-29 09:37:40 -03:00
3ab73a395a Squashed commit of the following:
commit 9bb3374ba0
Author: ncoronel <ncoronel@quo.ar>
Date:   Wed Jul 29 09:20:17 2026 -0300

    feat: add submitPurchaseForReview method and update checkout flow to handle purchase review status

commit 76327d34ec
Author: ncoronel <ncoronel@quo.ar>
Date:   Wed Jul 29 08:33:54 2026 -0300

    refactor: update styles for category items page header and title

commit 4cb81ed70d
Author: ncoronel <ncoronel@quo.ar>
Date:   Tue Jul 28 17:02:12 2026 -0300

    feat: implement payment verification error component and update checkout flow

commit c233845ce0
Author: ncoronel <ncoronel@quo.ar>
Date:   Tue Jul 28 16:57:00 2026 -0300

    feat: add WhatsApp support and improve payment timeout handling in checkout process

commit 15a74bb56e
Author: ncoronel <ncoronel@quo.ar>
Date:   Tue Jul 28 16:26:45 2026 -0300

    feat: enhance purchase status page with ticket handling and WhatsApp integration

commit 58e9dc06b1
Author: ncoronel <ncoronel@quo.ar>
Date:   Tue Jul 28 16:03:17 2026 -0300

    refactor: simplify purchase status page by removing polling logic and updating messages
2026-07-29 09:30:24 -03:00
43 changed files with 736 additions and 117 deletions

View File

@@ -10,6 +10,7 @@ import { provideClientHydration, withHttpTransferCacheOptions } from '@angular/p
import { routes } from './app.routes'; import { routes } from './app.routes';
import { authBootstrap } from './core/services/auth/auth-bootstrap'; import { authBootstrap } from './core/services/auth/auth-bootstrap';
import { authInterceptor } from './core/services/auth/auth.interceptor'; import { authInterceptor } from './core/services/auth/auth.interceptor';
import { globalLoadingInterceptor } from './core/services/global-loading/global-loading.interceptor';
import { tenantBootstrap } from './core/services/tenant-bootstrap'; import { tenantBootstrap } from './core/services/tenant-bootstrap';
function isStoreCatalogRequest(request: HttpRequest<unknown>): boolean { function isStoreCatalogRequest(request: HttpRequest<unknown>): boolean {
@@ -29,7 +30,10 @@ export const appConfig: ApplicationConfig = {
filter: isStoreCatalogRequest, filter: isStoreCatalogRequest,
}), }),
), ),
provideHttpClient(withFetch(), withInterceptors([authInterceptor])), provideHttpClient(
withFetch(),
withInterceptors([authInterceptor, globalLoadingInterceptor])
),
provideAppInitializer(authBootstrap), provideAppInitializer(authBootstrap),
provideAppInitializer(tenantBootstrap), provideAppInitializer(tenantBootstrap),
], ],

View File

@@ -2,6 +2,7 @@
<router-outlet /> <router-outlet />
<app-toast-container /> <app-toast-container />
<app-modal-host /> <app-modal-host />
<app-global-loading />
} @else if (status() === 'not-found') { } @else if (status() === 'not-found') {
<section class="tenant-status"> <section class="tenant-status">
<div class="tenant-status__card"> <div class="tenant-status__card">

View File

@@ -3,6 +3,7 @@ import { RouterOutlet } from '@angular/router';
import { TenantService } from './core/services/tenant.service'; import { TenantService } from './core/services/tenant.service';
import { DEFAULT_TENANT_BRANDING } from './core/services/tenant-ssr-cache.store'; import { DEFAULT_TENANT_BRANDING } from './core/services/tenant-ssr-cache.store';
import { GlobalLoadingComponent } from './shared/components/global-loading/global-loading.component';
import { ModalHostComponent } from './shared/components/modal-host/modal-host.component'; import { ModalHostComponent } from './shared/components/modal-host/modal-host.component';
import { ToastContainerComponent } from './shared/components/toast-container/toast-container.component'; import { ToastContainerComponent } from './shared/components/toast-container/toast-container.component';
@@ -23,7 +24,12 @@ function hexToRgb(hex: string): string {
@Component({ @Component({
selector: 'app-root', selector: 'app-root',
imports: [RouterOutlet, ToastContainerComponent, ModalHostComponent], imports: [
RouterOutlet,
ToastContainerComponent,
ModalHostComponent,
GlobalLoadingComponent
],
templateUrl: './app.html', templateUrl: './app.html',
styleUrl: './app.scss', styleUrl: './app.scss',
host: { host: {

View File

@@ -1,10 +1,11 @@
import { DOCUMENT } from '@angular/common'; import { DOCUMENT } from '@angular/common';
import { HttpClient, HttpErrorResponse, HttpResponse } from '@angular/common/http'; import { HttpErrorResponse, HttpResponse } from '@angular/common/http';
import { isPlatformBrowser, isPlatformServer } from '@angular/common'; import { isPlatformBrowser, isPlatformServer } from '@angular/common';
import { computed, inject, Injectable, PLATFORM_ID, signal, TransferState, makeStateKey } from '@angular/core'; import { computed, inject, Injectable, PLATFORM_ID, signal, TransferState, makeStateKey } from '@angular/core';
import { firstValueFrom, map, Observable, of, tap } from 'rxjs'; import { firstValueFrom, map, Observable, of, tap } from 'rxjs';
import { environment } from '../../../../environments/environment'; import { environment } from '../../../../environments/environment';
import { BaseApiService } from '../base-api.service';
import { import {
AuthUser, AuthUser,
LoginPayload, LoginPayload,
@@ -26,8 +27,7 @@ const AUTH_USER_SSR_STATE_KEY = makeStateKey<AuthUser>('shopit.auth.user');
@Injectable({ @Injectable({
providedIn: 'root' providedIn: 'root'
}) })
export class AuthService { export class AuthService extends BaseApiService {
private readonly http = inject(HttpClient);
private readonly document = inject(DOCUMENT); private readonly document = inject(DOCUMENT);
private readonly platformId = inject(PLATFORM_ID); private readonly platformId = inject(PLATFORM_ID);
private readonly cookieService = inject(CookieService); private readonly cookieService = inject(CookieService);
@@ -51,7 +51,9 @@ export class AuthService {
.post<LoginResponse>( .post<LoginResponse>(
`${environment.url}login`, `${environment.url}login`,
{ ...payload, tenant_codigo: tenant.codigo }, { ...payload, tenant_codigo: tenant.codigo },
{ withCredentials: true } {
withCredentials: true
}
) )
.pipe( .pipe(
tap((response) => this.applyAuthenticatedState(response.token, response.user)), tap((response) => this.applyAuthenticatedState(response.token, response.user)),
@@ -62,13 +64,18 @@ export class AuthService {
register(payload: RegisterPayload): Observable<RegisterResponse> { register(payload: RegisterPayload): Observable<RegisterResponse> {
const tenantCode = this.tenantService.getTenant()?.codigo; const tenantCode = this.tenantService.getTenant()?.codigo;
return this.http.post<RegisterResponse>(`${environment.url}register`, { return this.http.post<RegisterResponse>(
...payload, `${environment.url}register`,
...(tenantCode ? { tenant_codigo: tenantCode } : {}) {
}); ...payload,
...(tenantCode ? { tenant_codigo: tenantCode } : {})
},
);
} }
requestPasswordReset(email: string): Observable<HttpResponse<ResetPasswordAttemptResponse>> { requestPasswordReset(
email: string
): Observable<HttpResponse<ResetPasswordAttemptResponse>> {
const tenantCode = this.tenantService.getTenant()?.codigo; const tenantCode = this.tenantService.getTenant()?.codigo;
return this.http.post<ResetPasswordAttemptResponse>( return this.http.post<ResetPasswordAttemptResponse>(
@@ -77,7 +84,9 @@ export class AuthService {
email, email,
...(tenantCode ? { tenant_codigo: tenantCode } : {}) ...(tenantCode ? { tenant_codigo: tenantCode } : {})
}, },
{ observe: 'response' } {
observe: 'response'
}
); );
} }
@@ -88,7 +97,9 @@ export class AuthService {
return this.http.post<ValidateResetPasswordAttemptResponse>( return this.http.post<ValidateResetPasswordAttemptResponse>(
`${environment.url}password/reset-attempts/validate`, `${environment.url}password/reset-attempts/validate`,
{ email, codigo }, { email, codigo },
{ observe: 'response' } {
observe: 'response'
}
); );
} }
@@ -122,7 +133,9 @@ export class AuthService {
.post<LoginResponse>( .post<LoginResponse>(
`${environment.url}auth/google/exchange`, `${environment.url}auth/google/exchange`,
{ oauth_code: oauthCode, tenant_codigo: tenant.codigo }, { oauth_code: oauthCode, tenant_codigo: tenant.codigo },
{ withCredentials: true } {
withCredentials: true
}
) )
.pipe( .pipe(
tap((response) => this.applyAuthenticatedState(response.token, response.user)), tap((response) => this.applyAuthenticatedState(response.token, response.user)),
@@ -131,7 +144,9 @@ export class AuthService {
} }
updateProfile(payload: UpdateProfilePayload): Observable<AuthUser> { updateProfile(payload: UpdateProfilePayload): Observable<AuthUser> {
return this.http.put<AuthUser>(`${environment.url}me`, payload).pipe(tap((user) => this.userState.set(user))); return this.http
.put<AuthUser>(`${environment.url}me`, payload)
.pipe(tap((user) => this.userState.set(user)));
} }
logout(): Observable<void> { logout(): Observable<void> {
@@ -140,7 +155,9 @@ export class AuthService {
return of(void 0); return of(void 0);
} }
return this.http.post<void>(`${environment.url}logout`, {}).pipe(tap(() => this.clearSession())); return this.http
.post<void>(`${environment.url}logout`, {})
.pipe(tap(() => this.clearSession()));
} }
async bootstrap(): Promise<void> { async bootstrap(): Promise<void> {
@@ -179,7 +196,9 @@ export class AuthService {
} }
loadCurrentUser(): Observable<AuthUser> { loadCurrentUser(): Observable<AuthUser> {
return this.http.get<AuthUser>(`${environment.url}me`).pipe(tap((user) => this.userState.set(user))); return this.http
.get<AuthUser>(`${environment.url}me`)
.pipe(tap((user) => this.userState.set(user)));
} }
hydrateSession(): void { hydrateSession(): void {

View File

@@ -0,0 +1,42 @@
import '@angular/compiler';
import { provideHttpClient } from '@angular/common/http';
import { TestBed } from '@angular/core/testing';
import { afterEach, describe, expect, it } from 'vitest';
import { BaseApiService } from './base-api.service';
import { LOADING_MODE } from './global-loading/loading-mode';
class TestApiService extends BaseApiService {
contextFor() {
return this.loadingContext();
}
}
describe('BaseApiService', () => {
afterEach(() => {
TestBed.resetTestingModule();
});
it('uses global loading by default', () => {
TestBed.configureTestingModule({ providers: [provideHttpClient()] });
const service = TestBed.runInInjectionContext(() => new TestApiService());
expect(service.contextFor().get(LOADING_MODE)).toBe('global');
});
it('creates an isolated custom-loading scope', () => {
TestBed.configureTestingModule({ providers: [provideHttpClient()] });
const service = TestBed.runInInjectionContext(() => new TestApiService());
expect(service.withCustomLoading().contextFor().get(LOADING_MODE)).toBe('custom');
expect(service.contextFor().get(LOADING_MODE)).toBe('global');
});
it('creates an isolated scope without a loading indicator', () => {
TestBed.configureTestingModule({ providers: [provideHttpClient()] });
const service = TestBed.runInInjectionContext(() => new TestApiService());
expect(service.withoutLoading().contextFor().get(LOADING_MODE)).toBe('none');
expect(service.contextFor().get(LOADING_MODE)).toBe('global');
});
});

View File

@@ -0,0 +1,79 @@
import { HttpClient, HttpContext } from '@angular/common/http';
import { inject } from '@angular/core';
import {
LOADING_MODE,
LoadingMode
} from './global-loading/loading-mode';
const REQUEST_LOADING_MODE = Symbol('request-loading-mode');
class LoadingHttpClient {
readonly get: HttpClient['get'];
readonly post: HttpClient['post'];
readonly put: HttpClient['put'];
readonly patch: HttpClient['patch'];
readonly delete: HttpClient['delete'];
constructor(
http: HttpClient,
private readonly buildContext: (context?: HttpContext) => HttpContext
) {
this.get = ((url: string, options?: object) =>
http.get(url, this.withLoadingContext(options))) as HttpClient['get'];
this.post = ((url: string, body: unknown, options?: object) =>
http.post(url, body, this.withLoadingContext(options))) as HttpClient['post'];
this.put = ((url: string, body: unknown, options?: object) =>
http.put(url, body, this.withLoadingContext(options))) as HttpClient['put'];
this.patch = ((url: string, body: unknown, options?: object) =>
http.patch(url, body, this.withLoadingContext(options))) as HttpClient['patch'];
this.delete = ((url: string, options?: object) =>
http.delete(url, this.withLoadingContext(options))) as HttpClient['delete'];
}
private withLoadingContext(options?: object): object {
const requestOptions = options as { context?: HttpContext } | undefined;
return {
...requestOptions,
context: this.buildContext(requestOptions?.context)
};
}
}
export abstract class BaseApiService {
private readonly rawHttp = inject(HttpClient);
private readonly [REQUEST_LOADING_MODE]: LoadingMode = 'global';
protected get http(): LoadingHttpClient {
return new LoadingHttpClient(
this.rawHttp,
(context) => this.loadingContext(context)
);
}
withLoading(loadingMode: LoadingMode): this {
const scopedService = Object.create(this) as this;
Object.defineProperty(scopedService, REQUEST_LOADING_MODE, {
configurable: false,
enumerable: false,
value: loadingMode,
writable: false
});
return scopedService;
}
withCustomLoading(): this {
return this.withLoading('custom');
}
withoutLoading(): this {
return this.withLoading('none');
}
protected loadingContext(context: HttpContext = new HttpContext()): HttpContext {
return context.set(LOADING_MODE, this[REQUEST_LOADING_MODE]);
}
}

View File

@@ -6,6 +6,7 @@ import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
import { CartService } from './cart.service'; import { CartService } from './cart.service';
import { TenantService } from '../tenant.service'; import { TenantService } from '../tenant.service';
import { Cart } from './cart.interface'; import { Cart } from './cart.interface';
import { LOADING_MODE } from '../global-loading/loading-mode';
describe('CartService', () => { describe('CartService', () => {
let service: CartService; let service: CartService;
@@ -75,6 +76,14 @@ describe('CartService', () => {
req.flush({ data: mockCart }); req.flush({ data: mockCart });
}); });
it('propagates a custom loading mode to the request context', () => {
service.withCustomLoading().loadCart().subscribe();
const req = httpMock.expectOne('http://api.test/tenants/acme/cart');
expect(req.request.context.get(LOADING_MODE)).toBe('custom');
req.flush({ data: mockCart });
});
it('should clear cart state locally', () => { it('should clear cart state locally', () => {
service.clearCart(); service.clearCart();

View File

@@ -1,16 +1,15 @@
import { inject, Injectable, signal } from '@angular/core'; import { inject, Injectable, signal } from '@angular/core';
import { HttpClient } from '@angular/common/http';
import { catchError, map, Observable, tap } from 'rxjs'; import { catchError, map, Observable, tap } from 'rxjs';
import { ApiResponse } from '../api-response.interface'; import { ApiResponse } from '../api-response.interface';
import { BaseApiService } from '../base-api.service';
import { TenantService } from '../tenant.service'; import { TenantService } from '../tenant.service';
import { Cart } from './cart.interface'; import { Cart } from './cart.interface';
@Injectable({ @Injectable({
providedIn: 'root', providedIn: 'root',
}) })
export class CartService { export class CartService extends BaseApiService {
private readonly http = inject(HttpClient);
private readonly tenantService = inject(TenantService); private readonly tenantService = inject(TenantService);
private readonly cartState = signal<Cart | null>(null); private readonly cartState = signal<Cart | null>(null);
@@ -53,7 +52,13 @@ export class CartService {
return this.http return this.http
.post< .post<
ApiResponse<Cart> ApiResponse<Cart>
>(`${this.tenantApiUrl}/cart/items`, { catalog_item_id: catalogItemId, variant_id: variantId, cantidad }, { withCredentials: true }) >(
`${this.tenantApiUrl}/cart/items`,
{ catalog_item_id: catalogItemId, variant_id: variantId, cantidad },
{
withCredentials: true,
},
)
.pipe( .pipe(
tap((response) => { tap((response) => {
this.cartState.set(response.data); this.cartState.set(response.data);
@@ -66,12 +71,21 @@ export class CartService {
); );
} }
updateItemQuantity(cartItemId: number, cantidad: number): Observable<ApiResponse<Cart>> { updateItemQuantity(
cartItemId: number,
cantidad: number,
): Observable<ApiResponse<Cart>> {
this.isUpdatingState.set(true); this.isUpdatingState.set(true);
return this.http return this.http
.patch< .patch<
ApiResponse<Cart> ApiResponse<Cart>
>(`${this.tenantApiUrl}/cart/items/${cartItemId}`, { cantidad }, { withCredentials: true }) >(
`${this.tenantApiUrl}/cart/items/${cartItemId}`,
{ cantidad },
{
withCredentials: true,
},
)
.pipe( .pipe(
tap((response) => { tap((response) => {
this.cartState.set(response.data); this.cartState.set(response.data);
@@ -89,7 +103,9 @@ export class CartService {
return this.http return this.http
.delete< .delete<
ApiResponse<Cart> ApiResponse<Cart>
>(`${this.tenantApiUrl}/cart/items/${cartItemId}`, { withCredentials: true }) >(`${this.tenantApiUrl}/cart/items/${cartItemId}`, {
withCredentials: true,
})
.pipe( .pipe(
tap((response) => { tap((response) => {
this.cartState.set(response.data); this.cartState.set(response.data);

View File

@@ -1,10 +1,11 @@
import { HttpParams } from '@angular/common/http';
import { inject, Injectable } from '@angular/core'; import { inject, Injectable } from '@angular/core';
import { HttpClient, HttpParams } from '@angular/common/http';
import { map, Observable } from 'rxjs'; import { map, Observable } from 'rxjs';
import { ApiPaginationQueryParams } from '../api-pagination-query-params.interface'; import { ApiPaginationQueryParams } from '../api-pagination-query-params.interface';
import { ApiPaginatedResponse } from '../api-paginated-response.interface'; import { ApiPaginatedResponse } from '../api-paginated-response.interface';
import { ApiResponse } from '../api-response.interface'; import { ApiResponse } from '../api-response.interface';
import { BaseApiService } from '../base-api.service';
import { TenantService } from '../tenant.service'; import { TenantService } from '../tenant.service';
import { import {
CatalogFeaturedGroup, CatalogFeaturedGroup,
@@ -24,8 +25,7 @@ export interface CatalogSearchQueryParams extends ApiPaginationQueryParams {
@Injectable({ @Injectable({
providedIn: 'root', providedIn: 'root',
}) })
export class CatalogService { export class CatalogService extends BaseApiService {
private readonly http = inject(HttpClient);
private readonly tenantService = inject(TenantService); private readonly tenantService = inject(TenantService);
private get tenantApiUrl(): string { private get tenantApiUrl(): string {
@@ -47,7 +47,9 @@ export class CatalogService {
): Observable<ApiPaginatedResponse<CatalogFeaturedItem[]>> { ): Observable<ApiPaginatedResponse<CatalogFeaturedItem[]>> {
return this.http.get<ApiPaginatedResponse<CatalogFeaturedItem[]>>( return this.http.get<ApiPaginatedResponse<CatalogFeaturedItem[]>>(
`${this.tenantApiUrl}/catalog-items`, `${this.tenantApiUrl}/catalog-items`,
{ params: this.buildHttpParams(params) }, {
params: this.buildHttpParams(params),
},
); );
} }
@@ -66,18 +68,25 @@ export class CatalogService {
): Observable<CatalogFeaturedItems> { ): Observable<CatalogFeaturedItems> {
return this.http.get<CatalogFeaturedItems>( return this.http.get<CatalogFeaturedItems>(
`${this.tenantApiUrl}/catalog/featured-groups/${featuredGroupId}/items`, `${this.tenantApiUrl}/catalog/featured-groups/${featuredGroupId}/items`,
{ params: this.buildHttpParams(params) }, {
params: this.buildHttpParams(params),
},
); );
} }
getCatalogItem(id: number, variantId?: number): Observable<CatalogItemDetail> { getCatalogItem(
id: number,
variantId?: number,
): Observable<CatalogItemDetail> {
let params = new HttpParams(); let params = new HttpParams();
if (variantId) { if (variantId) {
params = params.set('variant_id', variantId); params = params.set('variant_id', variantId);
} }
return this.http return this.http
.get<ApiResponse<CatalogItemDetail>>(`${this.tenantApiUrl}/catalog-items/${id}`, { params }) .get<ApiResponse<CatalogItemDetail>>(`${this.tenantApiUrl}/catalog-items/${id}`, {
params,
})
.pipe(map((response) => response.data)); .pipe(map((response) => response.data));
} }

View File

@@ -1,8 +1,8 @@
import { inject, Injectable } from '@angular/core'; import { Injectable } from '@angular/core';
import { HttpClient } from '@angular/common/http';
import { firstValueFrom } from 'rxjs'; import { firstValueFrom } from 'rxjs';
import { environment } from '../../../environments/environment'; import { environment } from '../../../environments/environment';
import { BaseApiService } from './base-api.service';
export interface UpdatePurchaseCustomerPayload { export interface UpdatePurchaseCustomerPayload {
dni: string; dni: string;
@@ -77,9 +77,7 @@ export interface PurchaseDetailResponse extends PurchaseStatusResponse {
@Injectable({ @Injectable({
providedIn: 'root', providedIn: 'root',
}) })
export class CheckoutService { export class CheckoutService extends BaseApiService {
private readonly http = inject(HttpClient);
async startCheckout( async startCheckout(
tenantCode: string, tenantCode: string,
payload: StartCheckoutPayload, payload: StartCheckoutPayload,
@@ -182,7 +180,10 @@ export class CheckoutService {
return purchase; return purchase;
} }
async completePurchase(tenantCode: string, purchaseId: number): Promise<PurchaseStatusResponse> { async completePurchase(
tenantCode: string,
purchaseId: number,
): Promise<PurchaseStatusResponse> {
const response = await firstValueFrom( const response = await firstValueFrom(
this.http.post<{ data?: PurchaseStatusResponse } | PurchaseStatusResponse>( this.http.post<{ data?: PurchaseStatusResponse } | PurchaseStatusResponse>(
`${environment.url}tenants/${tenantCode}/compras/${purchaseId}/complete`, `${environment.url}tenants/${tenantCode}/compras/${purchaseId}/complete`,
@@ -220,7 +221,10 @@ export class CheckoutService {
return { status: purchase.status ?? null }; return { status: purchase.status ?? null };
} }
async cancelPurchase(tenantCode: string, purchaseId: number): Promise<PurchaseStatusResponse> { async cancelPurchase(
tenantCode: string,
purchaseId: number,
): Promise<PurchaseStatusResponse> {
const response = await firstValueFrom( const response = await firstValueFrom(
this.http.post<{ data?: PurchaseStatusResponse } | PurchaseStatusResponse>( this.http.post<{ data?: PurchaseStatusResponse } | PurchaseStatusResponse>(
`${environment.url}tenants/${tenantCode}/compras/${purchaseId}/cancel`, `${environment.url}tenants/${tenantCode}/compras/${purchaseId}/cancel`,
@@ -244,7 +248,9 @@ export class CheckoutService {
if (status) { if (status) {
url += `?status=${status}`; url += `?status=${status}`;
} }
const response = await firstValueFrom(this.http.get<{ data: PurchaseSummaryResponse[] }>(url)); const response = await firstValueFrom(
this.http.get<{ data: PurchaseSummaryResponse[] }>(url),
);
if (!response) { if (!response) {
throw new Error('Error al obtener las compras.'); throw new Error('Error al obtener las compras.');
} }

View File

@@ -0,0 +1,80 @@
import '@angular/compiler';
import { HttpClient, HttpContext, provideHttpClient, withInterceptors } from '@angular/common/http';
import {
HttpTestingController,
provideHttpClientTesting
} from '@angular/common/http/testing';
import { TestBed } from '@angular/core/testing';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { globalLoadingInterceptor } from './global-loading.interceptor';
import { GlobalLoadingService } from './global-loading.service';
import { LOADING_MODE, LoadingMode } from './loading-mode';
describe('globalLoadingInterceptor', () => {
let client: HttpClient;
let httpTesting: HttpTestingController;
let loadingService: GlobalLoadingService;
beforeEach(() => {
vi.useFakeTimers();
TestBed.configureTestingModule({
providers: [
provideHttpClient(withInterceptors([globalLoadingInterceptor])),
provideHttpClientTesting()
]
});
client = TestBed.inject(HttpClient);
httpTesting = TestBed.inject(HttpTestingController);
loadingService = TestBed.inject(GlobalLoadingService);
});
afterEach(() => {
httpTesting.verify();
TestBed.resetTestingModule();
vi.useRealTimers();
});
it('tracks concurrent requests until the last one completes', () => {
client.get('/api/first').subscribe();
client.get('/api/second').subscribe();
vi.advanceTimersByTime(150);
expect(loadingService.isLoading()).toBe(true);
httpTesting.expectOne('/api/first').flush({});
expect(loadingService.isLoading()).toBe(true);
httpTesting.expectOne('/api/second').flush({});
expect(loadingService.isLoading()).toBe(false);
});
it('stops loading when a request fails', () => {
client.get('/api/failing').subscribe({ error: () => undefined });
vi.advanceTimersByTime(150);
expect(loadingService.isLoading()).toBe(true);
httpTesting.expectOne('/api/failing').flush(
{ message: 'Error' },
{ status: 500, statusText: 'Server Error' }
);
expect(loadingService.isLoading()).toBe(false);
});
it.each<LoadingMode>(['custom', 'none'])(
'does not show the global loader for %s requests',
(loadingMode) => {
const context = new HttpContext().set(LOADING_MODE, loadingMode);
client.get(`/api/${loadingMode}`, { context }).subscribe();
vi.advanceTimersByTime(150);
expect(loadingService.isLoading()).toBe(false);
httpTesting.expectOne(`/api/${loadingMode}`).flush({});
}
);
});

View File

@@ -0,0 +1,20 @@
import { HttpEvent, HttpHandlerFn, HttpInterceptorFn, HttpRequest } from '@angular/common/http';
import { inject } from '@angular/core';
import { Observable, finalize } from 'rxjs';
import { GlobalLoadingService } from './global-loading.service';
import { LOADING_MODE } from './loading-mode';
export const globalLoadingInterceptor: HttpInterceptorFn = (
request: HttpRequest<unknown>,
next: HttpHandlerFn
): Observable<HttpEvent<unknown>> => {
if (request.context.get(LOADING_MODE) !== 'global') {
return next(request);
}
const loadingService = inject(GlobalLoadingService);
loadingService.start();
return next(request).pipe(finalize(() => loadingService.stop()));
};

View File

@@ -0,0 +1,65 @@
import '@angular/compiler';
import { TestBed } from '@angular/core/testing';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { GlobalLoadingService } from './global-loading.service';
describe('GlobalLoadingService', () => {
let service: GlobalLoadingService;
beforeEach(() => {
vi.useFakeTimers();
TestBed.configureTestingModule({});
service = TestBed.inject(GlobalLoadingService);
});
afterEach(() => {
TestBed.resetTestingModule();
vi.useRealTimers();
});
it('delays the loading state to avoid flashes on fast operations', () => {
service.start();
expect(service.isLoading()).toBe(false);
service.stop();
vi.advanceTimersByTime(150);
expect(service.isLoading()).toBe(false);
});
it('shows the loading state for an operation that exceeds the delay', () => {
service.start();
vi.advanceTimersByTime(150);
expect(service.isLoading()).toBe(true);
service.stop();
expect(service.isLoading()).toBe(false);
});
it('stays visible until all concurrent operations finish', () => {
service.start();
service.start();
vi.advanceTimersByTime(150);
service.stop();
expect(service.isLoading()).toBe(true);
service.stop();
expect(service.isLoading()).toBe(false);
});
it('ignores extra stop calls without corrupting the counter', () => {
service.stop();
service.start();
vi.advanceTimersByTime(150);
expect(service.isLoading()).toBe(true);
service.stop();
expect(service.isLoading()).toBe(false);
});
});

View File

@@ -0,0 +1,58 @@
import { isPlatformBrowser } from '@angular/common';
import { Injectable, PLATFORM_ID, inject, signal } from '@angular/core';
const SHOW_DELAY_MS = 150;
@Injectable({ providedIn: 'root' })
export class GlobalLoadingService {
private readonly isBrowser = isPlatformBrowser(inject(PLATFORM_ID));
private readonly loadingState = signal(false);
private pendingOperations = 0;
private showTimer: ReturnType<typeof setTimeout> | undefined;
readonly isLoading = this.loadingState.asReadonly();
start(): void {
if (!this.isBrowser) {
return;
}
this.pendingOperations += 1;
if (this.pendingOperations > 1 || this.loadingState()) {
return;
}
this.showTimer = setTimeout(() => {
this.showTimer = undefined;
if (this.pendingOperations > 0) {
this.loadingState.set(true);
}
}, SHOW_DELAY_MS);
}
stop(): void {
if (!this.isBrowser || this.pendingOperations === 0) {
return;
}
this.pendingOperations -= 1;
if (this.pendingOperations > 0) {
return;
}
this.cancelShowTimer();
this.loadingState.set(false);
}
private cancelShowTimer(): void {
if (this.showTimer === undefined) {
return;
}
clearTimeout(this.showTimer);
this.showTimer = undefined;
}
}

View File

@@ -0,0 +1,5 @@
import { HttpContextToken } from '@angular/common/http';
export type LoadingMode = 'global' | 'custom' | 'none';
export const LOADING_MODE = new HttpContextToken<LoadingMode>(() => 'global');

View File

@@ -1,5 +1,5 @@
import { isPlatformBrowser, isPlatformServer } from '@angular/common'; import { isPlatformBrowser, isPlatformServer } from '@angular/common';
import { HttpClient, HttpErrorResponse } from '@angular/common/http'; import { HttpErrorResponse } from '@angular/common/http';
import { import {
inject, inject,
Injectable, Injectable,
@@ -13,6 +13,7 @@ import { IS_DISCOVERING_ROUTES } from '@angular/ssr';
import { firstValueFrom } from 'rxjs'; import { firstValueFrom } from 'rxjs';
import { environment } from '../../../environments/environment'; import { environment } from '../../../environments/environment';
import { BaseApiService } from './base-api.service';
import { Tenant, TenantBootstrapResponse } from './tenant.interface'; import { Tenant, TenantBootstrapResponse } from './tenant.interface';
import { import {
TENANT_SSR_STATE_KEY, TENANT_SSR_STATE_KEY,
@@ -23,8 +24,7 @@ import {
@Injectable({ @Injectable({
providedIn: 'root' providedIn: 'root'
}) })
export class TenantService { export class TenantService extends BaseApiService {
private readonly http = inject(HttpClient);
private readonly platformId = inject(PLATFORM_ID); private readonly platformId = inject(PLATFORM_ID);
private readonly request = inject(REQUEST, { optional: true }); private readonly request = inject(REQUEST, { optional: true });
private readonly responseInit = inject(RESPONSE_INIT, { optional: true }); private readonly responseInit = inject(RESPONSE_INIT, { optional: true });
@@ -73,7 +73,9 @@ export class TenantService {
try { try {
const response = await firstValueFrom( const response = await firstValueFrom(
this.http.get<TenantBootstrapResponse>(`${environment.url}tenants/bootstrap/${domain}`) this.http.get<TenantBootstrapResponse>(
`${environment.url}tenants/bootstrap/${domain}`
)
); );
if (!response?.data) { if (!response?.data) {

View File

@@ -29,7 +29,9 @@ export class PurchaseList implements OnInit {
try { try {
const tenantCode = this.tenantService.tenant()?.codigo || ''; const tenantCode = this.tenantService.tenant()?.codigo || '';
const response = await this.checkoutService.getPurchases(tenantCode, 'paid'); const response = await this.checkoutService
.withCustomLoading()
.getPurchases(tenantCode, 'paid');
const mappedPurchases = response.data.map((purchase: PurchaseSummaryResponse) => ({ const mappedPurchases = response.data.map((purchase: PurchaseSummaryResponse) => ({
id: purchase.id, id: purchase.id,
date: this.formatDate(purchase.created_at), date: this.formatDate(purchase.created_at),

View File

@@ -44,7 +44,9 @@ export class PurchaseDetailPage implements OnInit {
} }
try { try {
const response = await this.checkoutService.getPurchase(tenant.codigo, purchaseId); const response = await this.checkoutService
.withCustomLoading()
.getPurchase(tenant.codigo, purchaseId);
this.purchase.set({ this.purchase.set({
id: response.id, id: response.id,

View File

@@ -1,7 +1,7 @@
import { HttpClient } from '@angular/common/http';
import { inject, Injectable } from '@angular/core'; import { inject, Injectable } from '@angular/core';
import { firstValueFrom } from 'rxjs'; import { firstValueFrom } from 'rxjs';
import { BaseApiService } from '../../../../../../core/services/base-api.service';
import { TenantService } from '../../../../../../core/services/tenant.service'; import { TenantService } from '../../../../../../core/services/tenant.service';
export interface TicketResponse { export interface TicketResponse {
@@ -21,13 +21,14 @@ export interface TicketResponse {
} }
@Injectable() @Injectable()
export class TicketService { export class TicketService extends BaseApiService {
private readonly http = inject(HttpClient);
private readonly tenantService = inject(TenantService); private readonly tenantService = inject(TenantService);
getTickets(): Promise<TicketResponse[]> { getTickets(): Promise<TicketResponse[]> {
return firstValueFrom( return firstValueFrom(
this.http.get<{ data: TicketResponse[] }>(`${this.tenantService.getTenantApiUrl()}/tickets`), this.http.get<{ data: TicketResponse[] }>(
`${this.tenantService.getTenantApiUrl()}/tickets`,
),
).then((response) => response.data ?? []); ).then((response) => response.data ?? []);
} }
@@ -36,7 +37,9 @@ export class TicketService {
this.http.post( this.http.post(
`${this.tenantService.getTenantApiUrl()}/tickets/pdf`, `${this.tenantService.getTenantApiUrl()}/tickets/pdf`,
{ ticket_ids: ticketIds }, { ticket_ids: ticketIds },
{ responseType: 'blob' }, {
responseType: 'blob',
},
), ),
); );
} }

View File

@@ -8,6 +8,14 @@ import { TicketComponent } from './components/ticket/ticket.component';
import { TicketResponse, TicketService } from './ticket.service'; import { TicketResponse, TicketService } from './ticket.service';
import { TicketsPage } from './tickets-page'; import { TicketsPage } from './tickets-page';
function withCustomLoading<T extends object>(
service: T,
): T & { withCustomLoading: () => T } {
return Object.assign(service, {
withCustomLoading: () => service,
});
}
const ticket = (overrides: Partial<TicketResponse>): TicketResponse => ({ const ticket = (overrides: Partial<TicketResponse>): TicketResponse => ({
id: 1, id: 1,
tenant_code: 'tenant', tenant_code: 'tenant',
@@ -40,10 +48,10 @@ describe('TicketsPage', () => {
providers: [ providers: [
{ {
provide: TicketService, provide: TicketService,
useValue: { useValue: withCustomLoading({
getTickets: () => Promise.resolve([ticket({})]), getTickets: () => Promise.resolve([ticket({})]),
downloadPdf: () => Promise.resolve(new Blob(['pdf-content'])), downloadPdf: () => Promise.resolve(new Blob(['pdf-content'])),
}, }),
}, },
], ],
}, },
@@ -99,10 +107,10 @@ describe('TicketsPage', () => {
providers: [ providers: [
{ {
provide: TicketService, provide: TicketService,
useValue: { useValue: withCustomLoading({
getTickets: () => Promise.resolve([ticket({})]), getTickets: () => Promise.resolve([ticket({})]),
downloadPdf, downloadPdf,
}, }),
}, },
], ],
}, },
@@ -150,7 +158,10 @@ describe('TicketsPage', () => {
.overrideComponent(TicketsPage, { .overrideComponent(TicketsPage, {
set: { set: {
providers: [ providers: [
{ provide: TicketService, useValue: { getTickets: () => Promise.resolve([]) } }, {
provide: TicketService,
useValue: withCustomLoading({ getTickets: () => Promise.resolve([]) }),
},
], ],
}, },
}) })
@@ -183,7 +194,10 @@ describe('TicketsPage', () => {
.overrideComponent(TicketsPage, { .overrideComponent(TicketsPage, {
set: { set: {
providers: [ providers: [
{ provide: TicketService, useValue: { getTickets: () => Promise.resolve(tickets) } }, {
provide: TicketService,
useValue: withCustomLoading({ getTickets: () => Promise.resolve(tickets) }),
},
], ],
}, },
}) })
@@ -236,7 +250,9 @@ describe('TicketsPage', () => {
providers: [ providers: [
{ {
provide: TicketService, provide: TicketService,
useValue: { getTickets: () => Promise.resolve([ticket({})]) }, useValue: withCustomLoading({
getTickets: () => Promise.resolve([ticket({})]),
}),
}, },
], ],
}, },

View File

@@ -35,7 +35,7 @@ export class TicketsPage implements OnInit {
async ngOnInit(): Promise<void> { async ngOnInit(): Promise<void> {
try { try {
this.tickets.set(await this.ticketService.getTickets()); this.tickets.set(await this.ticketService.withCustomLoading().getTickets());
} catch { } catch {
this.toastService.danger('Hubo un error al cargar los tickets'); this.toastService.danger('Hubo un error al cargar los tickets');
} finally { } finally {
@@ -151,7 +151,9 @@ export class TicketsPage implements OnInit {
this.isGeneratingPdf.set(true); this.isGeneratingPdf.set(true);
try { try {
return await this.ticketService.downloadPdf(tickets.map((ticket) => ticket.id)); return await this.ticketService
.withCustomLoading()
.downloadPdf(tickets.map((ticket) => ticket.id));
} catch { } catch {
this.toastService.danger('No se pudo generar el PDF de los tickets.'); this.toastService.danger('No se pudo generar el PDF de los tickets.');
return null; return null;

View File

@@ -1,8 +1,6 @@
<section class="category-items" aria-labelledby="category-items-title"> <section class="category-items" aria-labelledby="category-items-title">
@if (error()) { @if (error()) {
<p class="alert text-center mb-0 category-items__alert-error">{{ error() }}</p> <p class="alert text-center mb-0 category-items__alert-error">{{ error() }}</p>
} @else if (loading()) {
<p class="alert alert-light border text-center mb-0">Cargando productos...</p>
} @else if (results(); as categoryResults) { } @else if (results(); as categoryResults) {
<header class="category-items__header mb-5"> <header class="category-items__header mb-5">
<h1 id="category-items-title" class="category-items__title mb-0"> <h1 id="category-items-title" class="category-items__title mb-0">
@@ -19,7 +17,6 @@
[layout]="categoryResults.layout" [layout]="categoryResults.layout"
[groupLayout]="paginatedLayout" [groupLayout]="paginatedLayout"
[items]="categoryResults" [items]="categoryResults"
[loading]="loading()"
(buy)="onBuyProduct($event)" (buy)="onBuyProduct($event)"
(addToCart)="onAddToCart($event)" (addToCart)="onAddToCart($event)"
(pageChange)="onPageChange($event)" (pageChange)="onPageChange($event)"

View File

@@ -69,7 +69,9 @@ describe('CategoryItemsPageComponent', () => {
}, },
{ {
provide: CatalogService, provide: CatalogService,
useValue: { getCategoryItems }, useValue: {
getCategoryItems,
},
}, },
{ {
provide: TenantService, provide: TenantService,

View File

@@ -50,7 +50,6 @@ export class CategoryItemsPageComponent {
private readonly toastService = inject(ToastService); private readonly toastService = inject(ToastService);
protected readonly results = signal<CategoryItemsResponse | null>(null); protected readonly results = signal<CategoryItemsResponse | null>(null);
protected readonly loading = signal(true);
protected readonly error = signal<string | null>(null); protected readonly error = signal<string | null>(null);
protected readonly creatingDirectPurchase = signal(false); protected readonly creatingDirectPurchase = signal(false);
protected readonly paginatedLayout: CatalogGroupLayout = 'paginated'; protected readonly paginatedLayout: CatalogGroupLayout = 'paginated';
@@ -71,7 +70,6 @@ export class CategoryItemsPageComponent {
tap(() => { tap(() => {
this.results.set(null); this.results.set(null);
this.error.set(null); this.error.set(null);
this.loading.set(true);
}), }),
switchMap(({ categoryId, page }) => { switchMap(({ categoryId, page }) => {
if (categoryId === 0) { if (categoryId === 0) {
@@ -92,7 +90,6 @@ export class CategoryItemsPageComponent {
) )
.subscribe((results) => { .subscribe((results) => {
this.results.set(results); this.results.set(results);
this.loading.set(false);
}); });
} }

View File

@@ -22,6 +22,7 @@ describe('CheckoutPageComponent payment validation', () => {
generatePaymentIntent: ReturnType<typeof vi.fn>; generatePaymentIntent: ReturnType<typeof vi.fn>;
getPurchase: ReturnType<typeof vi.fn>; getPurchase: ReturnType<typeof vi.fn>;
submitPurchaseForReview: ReturnType<typeof vi.fn>; submitPurchaseForReview: ReturnType<typeof vi.fn>;
withCustomLoading: ReturnType<typeof vi.fn>;
}; };
let cartServiceStub: { let cartServiceStub: {
cart: ReturnType<typeof signal>; cart: ReturnType<typeof signal>;
@@ -60,7 +61,9 @@ describe('CheckoutPageComponent payment validation', () => {
}), }),
getPurchase: vi.fn().mockResolvedValue({ status: 'pending_payment' }), getPurchase: vi.fn().mockResolvedValue({ status: 'pending_payment' }),
submitPurchaseForReview: vi.fn().mockResolvedValue({ status: 'in_review' }), submitPurchaseForReview: vi.fn().mockResolvedValue({ status: 'in_review' }),
withCustomLoading: vi.fn(),
}; };
checkoutServiceStub.withCustomLoading.mockReturnValue(checkoutServiceStub);
cartServiceStub = { cartServiceStub = {
cart: signal({ cart: signal({
id: 10, id: 10,
@@ -191,24 +194,25 @@ describe('CheckoutPageComponent payment validation', () => {
expect(checkoutServiceStub.getPurchase).not.toHaveBeenCalled(); expect(checkoutServiceStub.getPurchase).not.toHaveBeenCalled();
}); });
it.each(['created', 'pending_payment', 'in_review'])( it('checks a transfer once and redirects to purchase status while pending', async () => {
'shows the payment error when a transfer remains %s', const { component } = createComponent();
async (status) => { component.selectedPaymentMethod.set('transfer');
checkoutServiceStub.submitPurchaseForReview.mockResolvedValue({ status });
const { component } = createComponent();
component.selectedPaymentMethod.set('transfer');
await component.onComplete(); await component.onComplete();
expect(checkoutServiceStub.getPurchase).toHaveBeenCalledTimes(1);
expect(component.transferValidationStatus()).toBe('pending');
expect(cartServiceStub.clearCart).not.toHaveBeenCalled();
expect(routerStub.navigate).toHaveBeenCalledWith(['/checkout/status', 25]);
expect(checkoutServiceStub.submitPurchaseForReview).toHaveBeenCalledWith('tenant-test', 25); await vi.advanceTimersByTimeAsync(30_000);
expect(component.transferValidationStatus()).toBe('error'); expect(checkoutServiceStub.getPurchase).toHaveBeenCalledTimes(1);
expect(cartServiceStub.clearCart).not.toHaveBeenCalled();
expect(routerStub.navigate).not.toHaveBeenCalled();
},
);
it('submits a paid transfer and navigates to its confirmation page', async () => { await component.onComplete();
checkoutServiceStub.submitPurchaseForReview.mockResolvedValue({ status: 'paid' }); expect(checkoutServiceStub.getPurchase).toHaveBeenCalledTimes(1);
});
it('navigates after a transfer is confirmed as paid', async () => {
checkoutServiceStub.getPurchase.mockResolvedValue({ status: 'paid' });
const { component } = createComponent(); const { component } = createComponent();
component.selectedPaymentMethod.set('transfer'); component.selectedPaymentMethod.set('transfer');
@@ -362,7 +366,11 @@ describe('CheckoutPageComponent payment validation', () => {
expect(component.checkoutStepIndex()).toBe(1); expect(component.checkoutStepIndex()).toBe(1);
expect(component.selectedPaymentMethod()).toBe('qr'); expect(component.selectedPaymentMethod()).toBe('qr');
expect(checkoutServiceStub.generatePaymentIntent).toHaveBeenCalledWith('tenant-test', 25, 'qr'); expect(checkoutServiceStub.generatePaymentIntent).toHaveBeenCalledWith(
'tenant-test',
25,
'qr',
);
expect(component.qrData()).toBe('qr-value'); expect(component.qrData()).toBe('qr-value');
expect(component.qrPaymentStatus()).toBe('waiting'); expect(component.qrPaymentStatus()).toBe('waiting');
}); });

View File

@@ -343,11 +343,9 @@ export class CheckoutPageComponent implements OnInit, OnDestroy {
this.isGeneratingIntent.set(true); this.isGeneratingIntent.set(true);
try { try {
const response = await this.checkoutService.generatePaymentIntent( const response = await this.checkoutService
tenant.codigo, .withCustomLoading()
purchaseId, .generatePaymentIntent(tenant.codigo, purchaseId, method);
method,
);
if (method === 'qr' && response.qr_data?.qr_code) { if (method === 'qr' && response.qr_data?.qr_code) {
if (requestId !== this.paymentMethodRequestId || this.selectedPaymentMethod() !== 'qr') { if (requestId !== this.paymentMethodRequestId || this.selectedPaymentMethod() !== 'qr') {
@@ -381,12 +379,9 @@ export class CheckoutPageComponent implements OnInit, OnDestroy {
this.transferValidationStatus.set('idle'); this.transferValidationStatus.set('idle');
this.isGeneratingIntent.set(true); this.isGeneratingIntent.set(true);
try { try {
const response = await this.checkoutService.generatePaymentIntent( const response = await this.checkoutService
tenant.codigo, .withCustomLoading()
purchaseId, .generatePaymentIntent(tenant.codigo, purchaseId, 'transfer', dni);
'transfer',
dni,
);
if (response.transfer_data) { if (response.transfer_data) {
this.markPurchasePendingPayment(); this.markPurchasePendingPayment();
@@ -438,10 +433,9 @@ export class CheckoutPageComponent implements OnInit, OnDestroy {
this.transferValidationStatus.set('checking'); this.transferValidationStatus.set('checking');
try { try {
const purchase = await this.checkoutService.submitPurchaseForReview( const purchase = await this.checkoutService
tenant.codigo, .withCustomLoading()
purchaseId, .submitPurchaseForReview(tenant.codigo, purchaseId);
);
if (purchase.status === 'paid') { if (purchase.status === 'paid') {
this.navigateToPurchaseStatus(purchaseId); this.navigateToPurchaseStatus(purchaseId);
@@ -494,7 +488,9 @@ export class CheckoutPageComponent implements OnInit, OnDestroy {
this.isCheckingQrPayment.set(true); this.isCheckingQrPayment.set(true);
try { try {
const purchase = await this.checkoutService.getPurchase(tenant.codigo, purchaseId); const purchase = await this.checkoutService
.withCustomLoading()
.getPurchase(tenant.codigo, purchaseId);
if (runId !== this.qrPollingRunId) { if (runId !== this.qrPollingRunId) {
return; return;
@@ -575,7 +571,9 @@ export class CheckoutPageComponent implements OnInit, OnDestroy {
} }
try { try {
const purchase = await this.checkoutService.getPurchase(tenant.codigo, purchaseId); const purchase = await this.checkoutService
.withCustomLoading()
.getPurchase(tenant.codigo, purchaseId);
if ( if (
purchase.status === 'in_review' || purchase.status === 'in_review' ||

View File

@@ -30,7 +30,7 @@
<label class="visually-hidden" for="login-password">Contraseña</label> <label class="visually-hidden" for="login-password">Contraseña</label>
<app-input <app-input
id="login-password" id="login-password"
type="password" type="password-toggle"
placeholder="Contraseña" placeholder="Contraseña"
[value]="form.controls.password.value" [value]="form.controls.password.value"
[invalid]="showControlError('password')" [invalid]="showControlError('password')"

View File

@@ -65,13 +65,17 @@ describe('ProductDetailPageComponent', () => {
}); });
catalogServiceStub = { catalogServiceStub = {
getCatalogItem: vi.fn(), getCatalogItem: vi.fn(),
withCustomLoading: vi.fn(),
}; };
catalogServiceStub.withCustomLoading.mockReturnValue(catalogServiceStub);
routerStub = { routerStub = {
navigate: vi.fn(), navigate: vi.fn(),
}; };
cartServiceStub = { cartServiceStub = {
addItem: vi.fn().mockReturnValue(of({ message: 'Producto agregado al carrito' })), addItem: vi.fn().mockReturnValue(of({ message: 'Producto agregado al carrito' })),
withCustomLoading: vi.fn(),
}; };
cartServiceStub.withCustomLoading.mockReturnValue(cartServiceStub);
toastServiceStub = { toastServiceStub = {
success: vi.fn(), success: vi.fn(),
danger: vi.fn(), danger: vi.fn(),

View File

@@ -155,7 +155,10 @@ export class ProductDetailPageComponent implements OnInit, OnDestroy {
this.variantLoading.set(true); this.variantLoading.set(true);
this.productSub?.unsubscribe(); this.productSub?.unsubscribe();
this.productSub = this.catalogService.getCatalogItem(productId, variantId).subscribe({ this.productSub = this.catalogService
.withCustomLoading()
.getCatalogItem(productId, variantId)
.subscribe({
next: (prod) => { next: (prod) => {
this.applyProduct(prod, false); this.applyProduct(prod, false);
this.variantLoading.set(false); this.variantLoading.set(false);
@@ -246,7 +249,10 @@ export class ProductDetailPageComponent implements OnInit, OnDestroy {
} }
this.addingToCart.set(true); this.addingToCart.set(true);
this.cartService.addItem(currentProduct.id, variant?.id ?? null, this.quantity()).subscribe({ this.cartService
.withCustomLoading()
.addItem(currentProduct.id, variant?.id ?? null, this.quantity())
.subscribe({
next: (res) => { next: (res) => {
const msg = res.message || 'Producto agregado al carrito'; const msg = res.message || 'Producto agregado al carrito';
this.toastService.success(msg); this.toastService.success(msg);

View File

@@ -66,6 +66,9 @@ describe('PurchaseStatusPageComponent', () => {
async function render(hasGeneratedTickets: boolean) { async function render(hasGeneratedTickets: boolean) {
const checkoutService = { const checkoutService = {
getPurchase: vi.fn().mockResolvedValue(purchase(hasGeneratedTickets)), getPurchase: vi.fn().mockResolvedValue(purchase(hasGeneratedTickets)),
withCustomLoading() {
return this;
},
}; };
const router = { const router = {
navigate: vi.fn().mockResolvedValue(true), navigate: vi.fn().mockResolvedValue(true),

View File

@@ -63,7 +63,9 @@ export class PurchaseStatusPageComponent implements OnInit {
} }
try { try {
const purchase = await this.checkoutService.getPurchase(this.tenantCode, this.purchaseId); const purchase = await this.checkoutService
.withCustomLoading()
.getPurchase(this.tenantCode, this.purchaseId);
this.status.set(this.resolveStatus(purchase)); this.status.set(this.resolveStatus(purchase));
this.hasGeneratedTickets.set(purchase.has_generated_tickets === true); this.hasGeneratedTickets.set(purchase.has_generated_tickets === true);
} catch (error) { } catch (error) {

View File

@@ -1,8 +1,8 @@
<section class="search-results" aria-labelledby="search-results-title"> <section class="search-results" aria-labelledby="search-results-title">
<header class="search-results__header mb-4"> <header class="search-results__header mb-5">
<h1 id="search-results-title" class="h3 mb-2">Resultados de búsqueda</h1> <h1 id="search-results-title" class="search-results__title mb-0">Resultados de búsqueda</h1>
@if (query()) { @if (query()) {
<p class="text-body-secondary mb-0"> <p class="search-results__subtitle text-body-secondary mb-0">
Resultados para <strong>“{{ query() }}”</strong> Resultados para <strong>“{{ query() }}”</strong>
</p> </p>
} }
@@ -10,8 +10,6 @@
@if (error()) { @if (error()) {
<p class="alert text-center mb-0 search-results__alert-error">{{ error() }}</p> <p class="alert text-center mb-0 search-results__alert-error">{{ error() }}</p>
} @else if (loading()) {
<p class="alert alert-light border text-center mb-0">Buscando productos...</p>
} @else if (results(); as searchResults) { } @else if (results(); as searchResults) {
@if (!searchResults.data.length) { @if (!searchResults.data.length) {
<p class="alert alert-light border text-center mb-0"> <p class="alert alert-light border text-center mb-0">

View File

@@ -1,3 +1,24 @@
.search-results__header {
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
gap: 8px;
padding: 16px 28px;
text-align: center;
}
.search-results__title {
color: var(--bs-primary);
font-size: 24px;
font-weight: bold;
line-height: 1.2;
}
.search-results__subtitle {
line-height: 1.2;
}
.search-results__alert-error { .search-results__alert-error {
color: var(--tenant-danger-color, var(--bs-danger)); color: var(--tenant-danger-color, var(--bs-danger));
} }

View File

@@ -65,7 +65,9 @@ describe('SearchPageComponent', () => {
}, },
{ {
provide: CatalogService, provide: CatalogService,
useValue: { searchCatalog }, useValue: {
searchCatalog,
},
}, },
{ {
provide: TenantService, provide: TenantService,
@@ -106,6 +108,22 @@ describe('SearchPageComponent', () => {
); );
}); });
it('renders the search title and query subtitle with the category header layout', () => {
const fixture = TestBed.createComponent(SearchPageComponent);
fixture.detectChanges();
const element = fixture.nativeElement as HTMLElement;
const header = element.querySelector('.search-results__header');
const title = element.querySelector('#search-results-title');
const subtitle = element.querySelector('.search-results__subtitle');
expect(header?.classList).toContain('mb-5');
expect(title?.classList).toContain('search-results__title');
expect(title?.classList).toContain('mb-0');
expect(subtitle?.textContent).toContain('Resultados para');
expect(subtitle?.textContent).toContain('running');
});
it('does not search when the query has fewer than three characters', () => { it('does not search when the query has fewer than three characters', () => {
TestBed.overrideProvider(ActivatedRoute, { TestBed.overrideProvider(ActivatedRoute, {
useValue: { useValue: {

View File

@@ -56,7 +56,6 @@ export class SearchPageComponent {
protected readonly query = signal(''); protected readonly query = signal('');
protected readonly results = signal<ApiPaginatedResponse<CatalogFeaturedItem[]> | null>(null); protected readonly results = signal<ApiPaginatedResponse<CatalogFeaturedItem[]> | null>(null);
protected readonly loading = signal(false);
protected readonly error = signal<string | null>(null); protected readonly error = signal<string | null>(null);
protected readonly creatingDirectPurchase = signal(false); protected readonly creatingDirectPurchase = signal(false);
@@ -105,7 +104,6 @@ export class SearchPageComponent {
? null ? null
: `Ingresá al menos ${this.minSearchLength} caracteres para buscar.`, : `Ingresá al menos ${this.minSearchLength} caracteres para buscar.`,
); );
this.loading.set(query.length >= this.minSearchLength);
}), }),
switchMap(({ query, page }) => { switchMap(({ query, page }) => {
if (query.length < this.minSearchLength) { if (query.length < this.minSearchLength) {
@@ -124,7 +122,6 @@ export class SearchPageComponent {
) )
.subscribe((results) => { .subscribe((results) => {
this.results.set(results); this.results.set(results);
this.loading.set(false);
}); });
} }

View File

@@ -216,7 +216,9 @@ describe('StoreHomePageComponent', () => {
const catalogServiceStub = { const catalogServiceStub = {
getCatalog: vi.fn(), getCatalog: vi.fn(),
getFeaturedGroupItems: vi.fn().mockReturnValue(of(createItemsPage(pageTwoItems, 2, 2))), getFeaturedGroupItems: vi.fn().mockReturnValue(of(createItemsPage(pageTwoItems, 2, 2))),
withCustomLoading: vi.fn(),
}; };
catalogServiceStub.withCustomLoading.mockReturnValue(catalogServiceStub);
await TestBed.configureTestingModule({ await TestBed.configureTestingModule({
imports: [StoreHomePageComponent], imports: [StoreHomePageComponent],
@@ -232,6 +234,7 @@ describe('StoreHomePageComponent', () => {
(element.querySelector('[data-testid="paginator-next"]') as HTMLButtonElement).click(); (element.querySelector('[data-testid="paginator-next"]') as HTMLButtonElement).click();
fixture.detectChanges(); fixture.detectChanges();
expect(catalogServiceStub.withCustomLoading).toHaveBeenCalledOnce();
expect(catalogServiceStub.getFeaturedGroupItems).toHaveBeenCalledWith(7, { page: 2 }); expect(catalogServiceStub.getFeaturedGroupItems).toHaveBeenCalledWith(7, { page: 2 });
expect(element.textContent).toContain('Mouse Gamer'); expect(element.textContent).toContain('Mouse Gamer');
expect(element.querySelector('[data-testid="paginator-status"]')?.textContent?.trim()).toBe( expect(element.querySelector('[data-testid="paginator-status"]')?.textContent?.trim()).toBe(
@@ -244,7 +247,9 @@ describe('StoreHomePageComponent', () => {
const catalogServiceStub = { const catalogServiceStub = {
getCatalog: vi.fn(), getCatalog: vi.fn(),
getFeaturedGroupItems: vi.fn().mockReturnValue(nextPage.asObservable()), getFeaturedGroupItems: vi.fn().mockReturnValue(nextPage.asObservable()),
withCustomLoading: vi.fn(),
}; };
catalogServiceStub.withCustomLoading.mockReturnValue(catalogServiceStub);
await TestBed.configureTestingModule({ await TestBed.configureTestingModule({
imports: [StoreHomePageComponent], imports: [StoreHomePageComponent],

View File

@@ -105,7 +105,10 @@ export class StoreHomePageComponent implements OnInit, OnDestroy {
this.setGroupLoading(groupId, true); this.setGroupLoading(groupId, true);
this.groupRequestSubscriptions.get(groupId)?.unsubscribe(); this.groupRequestSubscriptions.get(groupId)?.unsubscribe();
const subscription = this.catalogService.getFeaturedGroupItems(groupId, { page }).subscribe({ const subscription = this.catalogService
.withCustomLoading()
.getFeaturedGroupItems(groupId, { page })
.subscribe({
next: (items) => { next: (items) => {
this.catalog.update((groups) => this.catalog.update((groups) =>
groups.map((candidate) => groups.map((candidate) =>
@@ -182,7 +185,10 @@ export class StoreHomePageComponent implements OnInit, OnDestroy {
this.error.set(null); this.error.set(null);
this.catalogRequestSubscription?.unsubscribe(); this.catalogRequestSubscription?.unsubscribe();
this.catalogRequestSubscription = this.catalogService.getCatalog().subscribe({ this.catalogRequestSubscription = this.catalogService
.withCustomLoading()
.getCatalog()
.subscribe({
next: (catalog) => this.catalog.set(catalog), next: (catalog) => this.catalog.set(catalog),
error: () => { error: () => {
this.catalog.set([]); this.catalog.set([]);

View File

@@ -0,0 +1,11 @@
@if (isLoading()) {
<div
class="global-loading"
role="status"
aria-live="polite"
aria-label="Cargando"
>
<span class="global-loading__spinner" aria-hidden="true"></span>
<span class="visually-hidden">Cargando...</span>
</div>
}

View File

@@ -0,0 +1,31 @@
.global-loading {
position: fixed;
inset: 0;
z-index: 3000;
display: grid;
place-items: center;
background: rgba(255, 255, 255, 0.64);
backdrop-filter: blur(2px);
cursor: wait;
}
.global-loading__spinner {
width: 3rem;
height: 3rem;
border: 0.25rem solid rgba(32, 32, 32, 0.12);
border-top-color: var(--tenant-primary, #6376f3);
border-radius: 50%;
animation: global-loading-spin 0.75s linear infinite;
}
@keyframes global-loading-spin {
to {
transform: rotate(360deg);
}
}
@media (prefers-reduced-motion: reduce) {
.global-loading__spinner {
animation-duration: 1.5s;
}
}

View File

@@ -0,0 +1,54 @@
import '@angular/compiler';
import { signal } from '@angular/core';
import { TestBed } from '@angular/core/testing';
import { afterEach, describe, expect, it } from 'vitest';
import { GlobalLoadingService } from '../../../core/services/global-loading/global-loading.service';
import { GlobalLoadingComponent } from './global-loading.component';
describe('GlobalLoadingComponent', () => {
afterEach(() => {
TestBed.resetTestingModule();
});
it('renders an accessible overlay while the app is loading', async () => {
const loadingState = signal(true);
await TestBed.configureTestingModule({
imports: [GlobalLoadingComponent],
providers: [
{
provide: GlobalLoadingService,
useValue: { isLoading: loadingState.asReadonly() }
}
]
}).compileComponents();
const fixture = TestBed.createComponent(GlobalLoadingComponent);
fixture.detectChanges();
const overlay = fixture.nativeElement.querySelector('.global-loading');
expect(overlay).not.toBeNull();
expect(overlay.getAttribute('role')).toBe('status');
expect(overlay.getAttribute('aria-label')).toBe('Cargando');
});
it('does not render the overlay while the app is idle', async () => {
const loadingState = signal(false);
await TestBed.configureTestingModule({
imports: [GlobalLoadingComponent],
providers: [
{
provide: GlobalLoadingService,
useValue: { isLoading: loadingState.asReadonly() }
}
]
}).compileComponents();
const fixture = TestBed.createComponent(GlobalLoadingComponent);
fixture.detectChanges();
expect(fixture.nativeElement.querySelector('.global-loading')).toBeNull();
});
});

View File

@@ -0,0 +1,15 @@
import { ChangeDetectionStrategy, Component, inject } from '@angular/core';
import { GlobalLoadingService } from '../../../core/services/global-loading/global-loading.service';
@Component({
selector: 'app-global-loading',
templateUrl: './global-loading.component.html',
styleUrl: './global-loading.component.scss',
changeDetection: ChangeDetectionStrategy.OnPush
})
export class GlobalLoadingComponent {
private readonly loadingService = inject(GlobalLoadingService);
protected readonly isLoading = this.loadingService.isLoading;
}

View File

@@ -51,7 +51,7 @@
(click)="togglePasswordVisibility()" (click)="togglePasswordVisibility()"
> >
<i <i
class="fa-solid" class="fa-regular"
[ngClass]="isPasswordVisible() ? 'fa-eye' : 'fa-eye-slash'" [ngClass]="isPasswordVisible() ? 'fa-eye' : 'fa-eye-slash'"
aria-hidden="true" aria-hidden="true"
></i> ></i>

View File

@@ -1,5 +1,5 @@
<!doctype html> <!doctype html>
<html lang="en"> <html lang="e">
<head> <head>
<meta charset="utf-8"> <meta charset="utf-8">
<title>ShopitFront</title> <title>ShopitFront</title>