refactor(checkout): remove unused completion request

src/app/core/layout/store-layout/store-layout.component.ts

@@ -290,7 +290,7 @@ export class StoreLayoutComponent implements OnInit {
       this.toastService.danger(message);
 
       if (error instanceof HttpErrorResponse && isExpiredStockReservationResponse(error.error)) {
-        this.cartService.loadCart().subscribe({
+        this.cartService.loadCart(true).subscribe({
           error: (refreshError) => console.error('Error refreshing expired cart', refreshError),
         });
       }

src/app/core/services/cart/cart.service.spec.ts

@@ -83,6 +83,20 @@ describe('CartService', () => {
     req.flush({ data: mockCart });
   });
 
+  it('refreshes catalog availability only after the expired cart has been reloaded', () => {
+    const availabilityChanged = vi.fn();
+    catalogAvailabilityService.availabilityChanged$.subscribe(availabilityChanged);
+
+    service.loadCart(true).subscribe();
+
+    expect(availabilityChanged).not.toHaveBeenCalled();
+    const req = httpMock.expectOne('http://api.test/tenants/acme/cart');
+    req.flush({ data: mockCart });
+
+    expect(service.cart()).toEqual(mockCart);
+    expect(availabilityChanged).toHaveBeenCalledOnce();
+  });
+
   it('propagates a custom loading mode to the request context', () => {
     service.withCustomLoading().loadCart().subscribe();
 

src/app/core/services/cart/cart.service.ts

@@ -34,14 +34,19 @@ export class CartService extends BaseApiService {
     });
   }
 
-  loadCart(): Observable<Cart> {
+  loadCart(refreshCatalogAvailability = false): Observable<Cart> {
     return this.http
       .get<ApiResponse<Cart>>(`${this.tenantApiUrl}/cart`, {
         withCredentials: true,
       })
       .pipe(
         map((response) => response.data),
-        tap((cart) => this.cartState.set(cart)),
+        tap((cart) => {
+          this.cartState.set(cart);
+          if (refreshCatalogAvailability) {
+            this.catalogAvailabilityService.notifyAvailabilityChanged();
+          }
+        }),
       );
   }
 

src/app/core/services/catalog/catalog.service.ts

@@ -14,7 +14,6 @@ import {
   CatalogItemDetail,
   CatalogVariantOptionsResponse,
   CategoryItemsResponse,
-  Product,
 } from './catalog.interface';
 
 type HttpParamValue = string | number | boolean | readonly (string | number | boolean)[];
@@ -33,12 +32,6 @@ export class CatalogService extends BaseApiService {
     return this.tenantService.getTenantApiUrl();
   }
 
-  getProductos(params?: ApiPaginationQueryParams): Observable<ApiPaginatedResponse<Product[]>> {
-    return this.http.get<ApiPaginatedResponse<Product[]>>(`${this.tenantApiUrl}/productos`, {
-      params: this.buildHttpParams(params),
-    });
-  }
-
   getCatalog(): Observable<CatalogFeaturedGroup[]> {
     return this.http.get<CatalogFeaturedGroup[]>(`${this.tenantApiUrl}/catalog`);
   }

src/app/core/services/checkout.service.spec.ts

@@ -1,9 +1,10 @@
 import { provideHttpClient } from '@angular/common/http';
 import { HttpTestingController, provideHttpClientTesting } from '@angular/common/http/testing';
 import { TestBed } from '@angular/core/testing';
-import { afterEach, beforeEach, describe, expect, it } from 'vitest';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 
 import { environment } from '../../../environments/environment';
+import { CatalogAvailabilityService } from './catalog/catalog-availability.service';
 import { CheckoutService } from './checkout.service';
 
 describe('CheckoutService', () => {
@@ -39,6 +40,45 @@ describe('CheckoutService', () => {
     await expect(purchasePromise).resolves.toMatchObject({ id: 55 });
   });
 
+  it('refreshes catalog availability when starting checkout fails', async () => {
+    const catalogAvailabilityService = TestBed.inject(CatalogAvailabilityService);
+    const notifyAvailabilityChanged = vi.spyOn(
+      catalogAvailabilityService,
+      'notifyAvailabilityChanged',
+    );
+    const purchasePromise = service.startCheckout('desfile', { cart_id: 12 });
+    const request = httpMock.expectOne(`${environment.url}tenants/desfile/compras/start-checkout`);
+
+    request.flush(
+      { message: 'No hay stock disponible.' },
+      { status: 422, statusText: 'Unprocessable Entity' },
+    );
+
+    await expect(purchasePromise).rejects.toBeTruthy();
+    expect(notifyAvailabilityChanged).toHaveBeenCalledOnce();
+  });
+
+  it('waits for the expired cart refresh before refreshing catalog availability', async () => {
+    const catalogAvailabilityService = TestBed.inject(CatalogAvailabilityService);
+    const notifyAvailabilityChanged = vi.spyOn(
+      catalogAvailabilityService,
+      'notifyAvailabilityChanged',
+    );
+    const purchasePromise = service.startCheckout('desfile', { cart_id: 12 });
+    const request = httpMock.expectOne(`${environment.url}tenants/desfile/compras/start-checkout`);
+
+    request.flush(
+      {
+        code: 'stock_reservation.expired',
+        message: 'La reserva de stock venció.',
+      },
+      { status: 422, statusText: 'Unprocessable Entity' },
+    );
+
+    await expect(purchasePromise).rejects.toBeTruthy();
+    expect(notifyAvailabilityChanged).not.toHaveBeenCalled();
+  });
+
   it('preserves checkout timing fields when completing a purchase', async () => {
     const purchasePromise = service.completePurchase('desfile', 55);
     const request = httpMock.expectOne(`${environment.url}tenants/desfile/compras/55/complete`);

src/app/core/services/checkout.service.ts

@@ -1,10 +1,11 @@
-import { Injectable } from '@angular/core';
+import { inject, Injectable } from '@angular/core';
 import { firstValueFrom } from 'rxjs';
 
 import { environment } from '../../../environments/environment';
 import { ApiPaginatedResponse } from './api-paginated-response.interface';
 import { ApiPaginationQueryParams } from './api-pagination-query-params.interface';
 import { BaseApiService } from './base-api.service';
+import { CatalogAvailabilityService } from './catalog/catalog-availability.service';
 
 export interface UpdatePurchaseCustomerPayload {
   dni: string;
@@ -126,10 +127,13 @@ export interface PurchaseDetailResponse extends PurchaseStatusResponse {
   providedIn: 'root',
 })
 export class CheckoutService extends BaseApiService {
+  private readonly catalogAvailabilityService = inject(CatalogAvailabilityService);
+
   async startCheckout(
     tenantCode: string,
     payload: StartCheckoutPayload,
   ): Promise<PurchaseDetailResponse> {
+    try {
       const response = await firstValueFrom(
         this.http.post<{ data?: PurchaseDetailResponse } | PurchaseDetailResponse>(
           `${environment.url}tenants/${tenantCode}/compras/start-checkout`,
@@ -144,6 +148,13 @@ export class CheckoutService extends BaseApiService {
       }
 
       return purchase;
+    } catch (error) {
+      const responseBody = (error as { error?: unknown } | null)?.error;
+      if (!isExpiredStockReservationResponse(responseBody)) {
+        this.catalogAvailabilityService.notifyAvailabilityChanged();
+      }
+      throw error;
+    }
   }
 
   async generatePaymentIntent(
@@ -188,23 +199,6 @@ export class CheckoutService extends BaseApiService {
     return purchase;
   }
 
-  async completePurchase(tenantCode: string, purchaseId: number): Promise<PurchaseStatusResponse> {
-    const response = await firstValueFrom(
-      this.http.post<{ data?: PurchaseStatusResponse } | PurchaseStatusResponse>(
-        `${environment.url}tenants/${tenantCode}/compras/${purchaseId}/complete`,
-        {},
-      ),
-    );
-
-    const purchase = this.extractResponseData<PurchaseStatusResponse>(response);
-
-    if (!purchase) {
-      throw new Error('Error al finalizar la compra.');
-    }
-
-    return purchase;
-  }
-
   async submitPurchaseForReview(
     tenantCode: string,
     purchaseId: number,

src/app/features/store/pages/category-items-page/category-items-page.component.ts

@@ -180,7 +180,7 @@ export class CategoryItemsPageComponent {
       this.toastService.danger(message);
 
       if (error instanceof HttpErrorResponse && isExpiredStockReservationResponse(error.error)) {
-        this.cartService.loadCart().subscribe({
+        this.cartService.loadCart(true).subscribe({
           error: (refreshError) => console.error('Error refreshing expired cart', refreshError),
         });
       }

src/app/features/store/pages/checkout-page/checkout-page.component.ts

@@ -326,7 +326,7 @@ export class CheckoutPageComponent implements OnInit, OnDestroy {
 
       if (this.isStockReservationExpiredError(error)) {
         this.showRequestError(error, 'La reserva de stock venció.');
-        this.cartService.loadCart().subscribe({
+        this.cartService.loadCart(true).subscribe({
           error: (refreshError) => console.error('Error refreshing expired cart', refreshError),
         });
         this.createdPurchaseId.set(null);

src/app/features/store/pages/search-page/search-page.component.ts

@@ -212,7 +212,7 @@ export class SearchPageComponent {
       this.toastService.danger(message);
 
       if (error instanceof HttpErrorResponse && isExpiredStockReservationResponse(error.error)) {
-        this.cartService.loadCart().subscribe({
+        this.cartService.loadCart(true).subscribe({
           error: (refreshError) => console.error('Error refreshing expired cart', refreshError),
         });
       }

src/app/features/store/pages/store-home-page/store-home-page.component.ts

@@ -224,7 +224,7 @@ export class StoreHomePageComponent implements OnInit, OnDestroy {
 
       if (error instanceof HttpErrorResponse && isExpiredStockReservationResponse(error.error)) {
         this.toastService.danger(error.error.message);
-        this.cartService.loadCart().subscribe({
+        this.cartService.loadCart(true).subscribe({
           error: (refreshError) => console.error('Error refreshing expired cart', refreshError),
         });
         return;

src/app/shared/components/cart/cart.component.ts

@@ -330,7 +330,7 @@ export class CartComponent {
       return;
     }
 
-    this.cartService.loadCart().subscribe({
+    this.cartService.loadCart(true).subscribe({
       error: (refreshError) => console.error('Error refreshing expired cart', refreshError),
     });
   }