From 9ba2041f7b83dcd8621d1de7b90aa8e02a922d78 Mon Sep 17 00:00:00 2001
From: ncoronel <ncoronel@quo.ar>
Date: Tue, 18 Aug 2026 14:18:20 -0300
Subject: [PATCH] feat(hero-banner): update image handling to support
 responsive images and refactor template feat(cart): enhance editing logic and
 add tests for editable state feat(tenant): modify HeroConfig to include
 responsive image type

---
 src/app/core/services/tenant.interface.ts     |  7 ++-
 .../store-home-page.component.spec.ts         |  3 +-
 .../components/cart/cart.component.html       |  4 +-
 .../components/cart/cart.component.spec.ts    | 48 +++++++++++++++++++
 .../shared/components/cart/cart.component.ts  |  7 ++-
 .../hero-banner/hero-banner.component.html    | 17 ++++---
 .../hero-banner/hero-banner.component.scss    |  9 ++++
 .../hero-banner/hero-banner.component.spec.ts | 22 +++++++++
 .../hero-banner/hero-banner.component.ts      | 12 +++++
 9 files changed, 115 insertions(+), 14 deletions(-)

diff --git a/src/app/core/services/tenant.interface.ts b/src/app/core/services/tenant.interface.ts
index 3874649..34c6f33 100644
--- a/src/app/core/services/tenant.interface.ts
+++ b/src/app/core/services/tenant.interface.ts
@@ -20,13 +20,18 @@ export interface WebsiteType {
 }
 
 export interface HeroConfig {
-  background_image_id?: string | null;
+  background_image_id?: string | ResponsiveImage | null;
   title_html?: string | null;
   description_html?: string | null;
   button_text?: string | null;
   button_href?: string | null;
 }
 
+export interface ResponsiveImage {
+  desktop: string;
+  mobile: string;
+}
+
 export interface AdditionalInfoConfig {
   description?: string | null;
 }
diff --git a/src/app/features/store/pages/store-home-page/store-home-page.component.spec.ts b/src/app/features/store/pages/store-home-page/store-home-page.component.spec.ts
index 4f1cad2..70ddd41 100644
--- a/src/app/features/store/pages/store-home-page/store-home-page.component.spec.ts
+++ b/src/app/features/store/pages/store-home-page/store-home-page.component.spec.ts
@@ -254,9 +254,10 @@ describe('StoreHomePageComponent', () => {
     const hero = (fixture.nativeElement as HTMLElement).querySelector(
       'app-hero-banner .hero-banner',
     ) as HTMLElement;
+    const heroImage = hero.querySelector('img');
 
     expect(hero).not.toBeNull();
-    expect(hero.style.backgroundImage).toContain('https://example.com/hero.jpg');
+    expect(heroImage?.getAttribute('src')).toBe('https://example.com/hero.jpg');
     expect(hero.textContent).toContain('Fiesta Fútbol Infantil');
     expect(hero.textContent).toContain('Viví una jornada inolvidable de fútbol infantil.');
     expect(hero.textContent).toContain('Rosario, Santa Fe');
diff --git a/src/app/shared/components/cart/cart.component.html b/src/app/shared/components/cart/cart.component.html
index 469dd86..6249c7a 100644
--- a/src/app/shared/components/cart/cart.component.html
+++ b/src/app/shared/components/cart/cart.component.html
@@ -6,7 +6,7 @@
     <h2 class="m-0 text-uppercase fw-bold cart-title">{{ title() }}</h2>
 
     <div class="d-flex align-items-center cart-header-actions">
-      @if (!readonly() && allowEditing() && items().length > 0) {
+      @if (!readonly() && editable() && allowEditing() && items().length > 0) {
         <button
           class="btn btn-link p-0 border-0 cart-edit-btn"
           type="button"
@@ -48,7 +48,7 @@
         [selectedVariant]="getItemVariant(item)"
         [quantity]="getItemQuantity(item)"
         [readonly]="readonly()"
-        [quantityDisabled]="editingDisabled() || (allowEditing() && !editing())"
+        [quantityDisabled]="!editable() || editingDisabled() || (allowEditing() && !editing())"
         [showRemove]="allowRemove()"
         (quantityChange)="onItemQuantityChange(idx, $event)"
         (variantChange)="onItemVariantChange(idx, $event)"
diff --git a/src/app/shared/components/cart/cart.component.spec.ts b/src/app/shared/components/cart/cart.component.spec.ts
index 091c8b5..918f730 100644
--- a/src/app/shared/components/cart/cart.component.spec.ts
+++ b/src/app/shared/components/cart/cart.component.spec.ts
@@ -408,6 +408,54 @@ describe('CartComponent', () => {
     ).toBe(false);
   });
 
+  it('hides the edit toggle and disables quantity changes when editable is false', async () => {
+    await TestBed.configureTestingModule({
+      imports: [CartComponent],
+      providers: [
+        {
+          provide: CartService,
+          useValue: {
+            cart: signal(null).asReadonly(),
+            updateItemQuantity: vi.fn(),
+            removeItem: vi.fn(),
+          },
+        },
+        { provide: ModalService, useValue: {} },
+        {
+          provide: ToastService,
+          useValue: { success: vi.fn(), info: vi.fn(), danger: vi.fn() },
+        },
+      ],
+    }).compileComponents();
+
+    const fixture = TestBed.createComponent(CartComponent);
+    fixture.componentRef.setInput('items', [
+      {
+        cartItemId: 10,
+        imageUrl: null,
+        product: 'Producto de prueba',
+        originalPrice: null,
+        discountedPrice: 1000,
+        discountPercentage: null,
+        attributes: [],
+        quantity: 1,
+      },
+    ]);
+    fixture.componentRef.setInput('allowEditing', true);
+    fixture.componentRef.setInput('editable', false);
+    const quantityChange = vi.fn();
+    fixture.componentInstance.itemQuantityChange.subscribe(quantityChange);
+    fixture.detectChanges();
+
+    expect(fixture.debugElement.query(By.css('.cart-edit-btn'))).toBeNull();
+    const cartItem = fixture.debugElement.query(By.css('app-cart-item'));
+    expect(cartItem.componentInstance.quantityDisabled()).toBe(true);
+
+    cartItem.triggerEventHandler('quantityChange', 2);
+
+    expect(quantityChange).not.toHaveBeenCalled();
+  });
+
   it('persists a variant selected from a cart row', async () => {
     const updateItemVariant = vi.fn().mockReturnValue(
       of({
diff --git a/src/app/shared/components/cart/cart.component.ts b/src/app/shared/components/cart/cart.component.ts
index 15768bd..a4c1b7c 100644
--- a/src/app/shared/components/cart/cart.component.ts
+++ b/src/app/shared/components/cart/cart.component.ts
@@ -53,6 +53,7 @@ export class CartComponent {
   readonly total = input<number>(0);
   readonly backgroundColor = input<string>('#ffffff');
   readonly readonly = input<boolean>(false);
+  readonly editable = input<boolean>(true);
   readonly allowEditing = input<boolean>(false);
   readonly allowRemove = input<boolean>(true);
   readonly persistQuantityChanges = input<boolean>(true);
@@ -124,6 +125,10 @@ export class CartComponent {
   }
 
   protected onItemQuantityChange(index: number, newQuantity: number): void {
+    if (!this.editable()) {
+      return;
+    }
+
     const mockItem = this.items()[index];
     if (!mockItem) {
       return;
@@ -220,7 +225,7 @@ export class CartComponent {
   protected readonly formattedTotal = computed(() => this.formatCurrency(this.total()));
 
   protected toggleEditing(): void {
-    if (this.editingDisabled()) {
+    if (!this.editable() || this.editingDisabled()) {
       return;
     }
 
diff --git a/src/app/shared/components/hero-banner/hero-banner.component.html b/src/app/shared/components/hero-banner/hero-banner.component.html
index e3a20bd..be58165 100644
--- a/src/app/shared/components/hero-banner/hero-banner.component.html
+++ b/src/app/shared/components/hero-banner/hero-banner.component.html
@@ -1,14 +1,13 @@
 <div class="hero-banner-container">
   <div class="hero-banner position-relative rounded">
-    <div
-      class="hero-media"
-      aria-hidden="true"
-      [ngStyle]="{
-        'background-image': heroConfig?.background_image_id
-          ? 'url(' + heroConfig.background_image_id + ')'
-          : 'none',
-      }"
-    ></div>
+    @if (desktopImageUrl) {
+      <picture class="hero-media" aria-hidden="true">
+        @if (mobileImageUrl) {
+          <source media="(max-width: 767.98px)" [srcset]="mobileImageUrl" />
+        }
+        <img [src]="desktopImageUrl" alt="" />
+      </picture>
+    }
 
     @if (heroConfig) {
       <div
diff --git a/src/app/shared/components/hero-banner/hero-banner.component.scss b/src/app/shared/components/hero-banner/hero-banner.component.scss
index 227274e..baf1e1b 100644
--- a/src/app/shared/components/hero-banner/hero-banner.component.scss
+++ b/src/app/shared/components/hero-banner/hero-banner.component.scss
@@ -12,11 +12,20 @@
 .hero-media {
   position: absolute;
   inset: 0;
+  display: block;
+  overflow: hidden;
   background-position: center;
   background-repeat: no-repeat;
   background-size: cover;
   border-radius: inherit;
 
+  img {
+    display: block;
+    width: 100%;
+    height: 100%;
+    object-fit: cover;
+  }
+
   &::after {
     content: '';
     position: absolute;
diff --git a/src/app/shared/components/hero-banner/hero-banner.component.spec.ts b/src/app/shared/components/hero-banner/hero-banner.component.spec.ts
index 235e236..2f25ef8 100644
--- a/src/app/shared/components/hero-banner/hero-banner.component.spec.ts
+++ b/src/app/shared/components/hero-banner/hero-banner.component.spec.ts
@@ -2,6 +2,28 @@ import { TestBed } from '@angular/core/testing';
 import { HeroBannerComponent } from './hero-banner.component';
 
 describe('HeroBannerComponent', () => {
+  it('renders desktop and mobile crop variants', async () => {
+    await TestBed.configureTestingModule({ imports: [HeroBannerComponent] }).compileComponents();
+
+    const fixture = TestBed.createComponent(HeroBannerComponent);
+    fixture.componentRef.setInput('heroConfig', {
+      background_image_id: {
+        desktop: 'https://example.com/desktop.jpg',
+        mobile: 'https://example.com/mobile.jpg',
+      },
+    });
+    fixture.detectChanges();
+
+    const element = fixture.nativeElement as HTMLElement;
+
+    expect(element.querySelector('source')?.getAttribute('srcset')).toBe(
+      'https://example.com/mobile.jpg',
+    );
+    expect(element.querySelector('img')?.getAttribute('src')).toBe(
+      'https://example.com/desktop.jpg',
+    );
+  });
+
   it('expands and collapses the event schedules', async () => {
     await TestBed.configureTestingModule({ imports: [HeroBannerComponent] }).compileComponents();
 
diff --git a/src/app/shared/components/hero-banner/hero-banner.component.ts b/src/app/shared/components/hero-banner/hero-banner.component.ts
index e3385c6..4859c54 100644
--- a/src/app/shared/components/hero-banner/hero-banner.component.ts
+++ b/src/app/shared/components/hero-banner/hero-banner.component.ts
@@ -18,6 +18,18 @@ export class HeroBannerComponent {
 
   protected schedulesExpanded = false;
 
+  protected get desktopImageUrl(): string | null {
+    const image = this.heroConfig?.background_image_id;
+
+    return typeof image === 'string' ? image : (image?.desktop ?? null);
+  }
+
+  protected get mobileImageUrl(): string | null {
+    const image = this.heroConfig?.background_image_id;
+
+    return typeof image === 'string' ? image : (image?.mobile ?? image?.desktop ?? null);
+  }
+
   get formattedDates(): string {
     if (this.eventConfig?.dates_text) {
       return this.eventConfig.dates_text;