tbianchini/shopit-front
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(modal): replace 'content' with 'description' and update related tests

Browse Source
This commit is contained in:
ncoronel
2026-09-09 08:50:05 -03:00
parent f859eba8a8
commit 8c15ad7cc1
17 changed files with 59 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/shared/components/cart/cart.component.spec.ts
View File

@@ -115,7 +115,7 @@ describe('CartComponent', () => {
expect(openConfirmDelete).toHaveBeenCalledWith({
title: 'Eliminar producto',
content: 'Se eliminará “Producto de prueba” del carrito. Esta acción no se puede deshacer.',
description: 'Se eliminará “Producto de prueba” del carrito. Esta acción no se puede deshacer.',
confirmLabel: 'Eliminar',
cancelLabel: 'Cancelar',
});

2
src/app/shared/components/cart/cart.component.ts
View File

@@ -236,7 +236,7 @@ export class CartComponent {
this.modalService
.openConfirmDelete({
title: 'Eliminar producto',
content: `Se eliminará “${target.productName}” del carrito. Esta acción no se puede deshacer.`,
description: `Se eliminará “${target.productName}” del carrito. Esta acción no se puede deshacer.`,
confirmLabel: 'Eliminar',
cancelLabel: 'Cancelar',
})

5
src/app/shared/components/confirm-delete-modal/confirm-delete-modal.component.html
View File

@@ -1,5 +1,8 @@
<div class="confirm-modal">
<p class="confirm-modal__content">{{ data.content }}</p>
<h2 class="confirm-modal__content">{{ data.title }}</h2>
@if (data.description) {
<p class="confirm-modal__content">{{ data.description }}</p>
}
<div class="confirm-modal__actions">
<app-button variant="danger-secondary" (click)="cancel()">

4
src/app/shared/components/confirm-delete-modal/confirm-delete-modal.component.spec.ts
View File

@@ -15,7 +15,7 @@ import { ConfirmDeleteModalComponent } from './confirm-delete-modal.component';
describe('ConfirmDeleteModalComponent', () => {
const data: ConfirmModalData = {
content: 'Se eliminara el elemento seleccionado.',
title: 'Se eliminara el elemento seleccionado.',
confirmLabel: 'Eliminar',
cancelLabel: 'Cancelar'
};
@@ -58,7 +58,7 @@ describe('ConfirmDeleteModalComponent', () => {
const element = fixture.nativeElement as HTMLElement;
const buttons = element.querySelectorAll('button');
expect(element.textContent).toContain(data.content);
expect(element.textContent).toContain(data.title);
expect(element.textContent).toContain(data.confirmLabel);
expect(buttons[1].className).toContain('btn-danger');
});

5
src/app/shared/components/confirm-modal/confirm-modal.component.html
View File

@@ -1,5 +1,8 @@
<div class="confirm-modal">
<p class="confirm-modal__content">{{ data.content }}</p>
<h2 class="confirm-modal__content">{{ data.title }}</h2>
@if (data.description) {
<p class="confirm-modal__content">{{ data.description }}</p>
}
<div class="confirm-modal__actions">
<app-button variant="secondary" (click)="cancel()">

4
src/app/shared/components/confirm-modal/confirm-modal.component.spec.ts
View File

@@ -15,7 +15,7 @@ import { ConfirmModalComponent } from './confirm-modal.component';
describe('ConfirmModalComponent', () => {
const data: ConfirmModalData = {
content: 'Se confirmara la operacion seleccionada.',
title: 'Se confirmara la operacion seleccionada.',
confirmLabel: 'Aceptar',
cancelLabel: 'Volver'
};
@@ -57,7 +57,7 @@ describe('ConfirmModalComponent', () => {
const element = fixture.nativeElement as HTMLElement;
expect(element.textContent).toContain(data.content);
expect(element.textContent).toContain(data.title);
expect(element.textContent).toContain(data.confirmLabel);
expect(element.textContent).toContain(data.cancelLabel);
});

2
src/app/shared/components/product-ticket-selector/product-ticket-selector.component.ts
View File

@@ -176,7 +176,7 @@ export class ProductTicketSelectorComponent {
this.modalService
.openConfirmDelete({
title: 'Eliminar entrada',
content: `Se eliminará esta entrada de “${this.title()}”. Si ya estaba reservada, se liberará del carrito.`,
description: `Se eliminará esta entrada de “${this.title()}”. Si ya estaba reservada, se liberará del carrito.`,
confirmLabel: 'Sí, eliminar',
cancelLabel: 'Cancelar',
size: 'md',

5
src/app/shared/components/simple-modal/simple-modal.component.html
View File

@@ -1,5 +1,8 @@
<div class="simple-modal">
<p class="simple-modal__content">{{ data.content }}</p>
<h2 class="simple-modal__content">{{ data.title }}</h2>
@if (data.description) {
<p class="simple-modal__content">{{ data.description }}</p>
}
<div class="simple-modal__actions">
<app-button (click)="close()">

4
src/app/shared/components/simple-modal/simple-modal.component.spec.ts
View File

@@ -15,7 +15,7 @@ import { SimpleModalComponent } from './simple-modal.component';
describe('SimpleModalComponent', () => {
const data: SimpleModalData = {
content: 'Este es un mensaje simple.',
title: 'Este es un mensaje simple.',
buttonLabel: 'Entendido'
};
@@ -56,7 +56,7 @@ describe('SimpleModalComponent', () => {
const element = fixture.nativeElement as HTMLElement;
expect(element.textContent).toContain(data.content);
expect(element.textContent).toContain(data.title);
expect(element.textContent).toContain(data.buttonLabel);
});