tbianchini/shopit-front
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(carousel): update test description and improve item selection logic in carousel component

Browse Source
This commit is contained in:
ncoronel
2026-07-23 12:09:28 -03:00
parent a1d5ecb6fa
commit 8963bd5460
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/app/shared/components/carousel/carousel.component.spec.ts
View File

@@ -120,10 +120,9 @@ describe('CarouselComponent', () => {
expect(frame.style.width).toBe('632px'); expect(frame.style.width).toBe('632px');
}); });
it('vuelve al extremo opuesto cuando circular está habilitado', () => { it('mantiene preparadas las páginas adyacentes y rota al terminar la transición', () => {
fixture.componentInstance.circular.set(true); fixture.componentInstance.circular.set(true);
fixture.detectChanges(); fixture.detectChanges();
expect(fixture.componentInstance.carousel().circular()).toBe(true);
const host = fixture.nativeElement.querySelector('app-carousel') as HTMLElement; const host = fixture.nativeElement.querySelector('app-carousel') as HTMLElement;
const firstItem = fixture.nativeElement.querySelector('.carousel__item') as HTMLElement; const firstItem = fixture.nativeElement.querySelector('.carousel__item') as HTMLElement;

4
src/app/shared/components/carousel/carousel.component.ts
View File

@@ -137,7 +137,9 @@ export class CarouselComponent<T> implements AfterViewInit {
return; return;
} }
const item = this.viewport().nativeElement.children.item(index) as HTMLElement | null; const item = this.viewport()
.nativeElement.querySelectorAll<HTMLElement>('.carousel__item')
.item(index);
item?.scrollIntoView({ item?.scrollIntoView({
behavior: 'smooth', behavior: 'smooth',