commitcd99a6489bMerge:ebcbbb1e63a036Author: ncoronel <ncoronel@quo.ar> Date: Wed Aug 26 10:12:44 2026 -0300 Merge branch 'fix/simplify_stock_reservations' of https://gitea.quo.ar/tbianchini/shopit-back into fix/simplify_stock_reservations commitebcbbb1774Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:33:39 2026 -0300 fix(cart): reconcile expired cart mutations commit3dd378ed06Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:15 2026 -0300 docs(stock): describe associated entity expiration commit4f705175bdAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:14 2026 -0300 test(stock): cover propagated reservation expiration commit82570fe941Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:09:52 2026 -0300 refactor(stock): propagate reservation expiration commitd2a2b323e0Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 docs(stock): document terminal reservation recovery commitec67623b7bAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 test(stock): cover terminal reservation lifecycle commitf6f138e180Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:41 2026 -0300 refactor(stock): make expired reservations terminal commitd612b7a118Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:30 2026 -0300 docs(stock): describe unified expiration ownership commit49f42d4507Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:23 2026 -0300 test(stock): cover authoritative reservation expiration commit1881cc1d4bAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:17 2026 -0300 refactor(stock): make reservation expiration authoritative commit00ec37d8a0Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:34 2026 -0300 docs(stock): document centralized reservation flow commitd9f374c718Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:29 2026 -0300 test(stock): cover aggregate reservation lifecycle commitbbfdf8f342Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:23 2026 -0300 refactor(stock): centralize reservation aggregate commit8a0f29bdaeAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:33:39 2026 -0300 fix(cart): reconcile expired cart mutations commit198ed400a9Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:15 2026 -0300 docs(stock): describe associated entity expiration commit23d83166e6Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:14 2026 -0300 test(stock): cover propagated reservation expiration commitcb090402d0Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:09:52 2026 -0300 refactor(stock): propagate reservation expiration commitc120b6f7c0Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 docs(stock): document terminal reservation recovery commit1106fa28b4Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 test(stock): cover terminal reservation lifecycle commit896fb81bcfAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:41 2026 -0300 refactor(stock): make expired reservations terminal commit8545fbc645Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:30 2026 -0300 docs(stock): describe unified expiration ownership commitdd6dcb708aAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:23 2026 -0300 test(stock): cover authoritative reservation expiration commit624b246ff5Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:17 2026 -0300 refactor(stock): make reservation expiration authoritative commit007b95b904Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:34 2026 -0300 docs(stock): document centralized reservation flow commit0b3c8c93beAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:29 2026 -0300 test(stock): cover aggregate reservation lifecycle commitede718e448Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:23 2026 -0300 refactor(stock): centralize reservation aggregate commite63a03601aAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:33:39 2026 -0300 fix(cart): reconcile expired cart mutations commit389373ad8cAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:15 2026 -0300 docs(stock): describe associated entity expiration commitace02a3133Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:14 2026 -0300 test(stock): cover propagated reservation expiration commitd69a6210f6Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:09:52 2026 -0300 refactor(stock): propagate reservation expiration commit3c0b43fea3Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 docs(stock): document terminal reservation recovery commit9b0008626bAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 test(stock): cover terminal reservation lifecycle commit61861e331aAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:41 2026 -0300 refactor(stock): make expired reservations terminal commit2cc9d7dd97Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:30 2026 -0300 docs(stock): describe unified expiration ownership commitf982bcead1Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:23 2026 -0300 test(stock): cover authoritative reservation expiration commit7a85e1731dAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:17 2026 -0300 refactor(stock): make reservation expiration authoritative commit6db99e775aAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:34 2026 -0300 docs(stock): document centralized reservation flow commite5f7ba3615Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:29 2026 -0300 test(stock): cover aggregate reservation lifecycle commit24bfef431bAuthor: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:23 2026 -0300 refactor(stock): centralize reservation aggregate
104 lines
3.5 KiB
PHP
104 lines
3.5 KiB
PHP
<?php
|
|
|
|
namespace Tests\Unit\Catalog;
|
|
|
|
use App\Domains\Catalog\Models\Inventory;
|
|
use App\Domains\Catalog\Models\StockReservation;
|
|
use App\Domains\Catalog\Models\StockReservationLine;
|
|
use App\Domains\Catalog\Services\ExpireStockReservationsService;
|
|
use App\Domains\Catalog\Services\StockReservationService;
|
|
use App\Domains\Purchase\Services\Checkout\ReleaseCheckoutService;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use RuntimeException;
|
|
use Tests\TestCase;
|
|
|
|
class ExpireStockReservationsServiceTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_it_expires_an_orphan_reservation_and_releases_its_inventory(): void
|
|
{
|
|
$inventory = Inventory::query()->create([
|
|
'real_stock' => 10,
|
|
'reserved_stock' => 2,
|
|
]);
|
|
$reservation = StockReservation::query()->create([
|
|
'status' => StockReservation::STATUS_ACTIVE,
|
|
'expires_at' => now()->subMinute(),
|
|
]);
|
|
StockReservationLine::query()->create([
|
|
'stock_reservation_id' => $reservation->id,
|
|
'inventory_id' => $inventory->id,
|
|
'quantity' => 2,
|
|
'tracks_inventory' => true,
|
|
]);
|
|
|
|
$result = app(ExpireStockReservationsService::class)->expireOverdue();
|
|
|
|
$this->assertSame([
|
|
'purchases' => 0,
|
|
'cart_reservations' => 0,
|
|
'orphan_reservations' => 1,
|
|
'failed' => 0,
|
|
], $result);
|
|
$this->assertDatabaseHas('stock_reservations', [
|
|
'id' => $reservation->id,
|
|
'status' => StockReservation::STATUS_EXPIRED,
|
|
'expires_at' => null,
|
|
]);
|
|
$this->assertDatabaseHas('inventories', [
|
|
'id' => $inventory->id,
|
|
'reserved_stock' => 0,
|
|
]);
|
|
}
|
|
|
|
public function test_one_failed_reservation_does_not_stop_the_remaining_batch(): void
|
|
{
|
|
$first = StockReservation::query()->create([
|
|
'status' => StockReservation::STATUS_ACTIVE,
|
|
'expires_at' => now()->subMinutes(2),
|
|
]);
|
|
$second = StockReservation::query()->create([
|
|
'status' => StockReservation::STATUS_ACTIVE,
|
|
'expires_at' => now()->subMinute(),
|
|
]);
|
|
|
|
$reservations = \Mockery::mock(StockReservationService::class);
|
|
$reservations->shouldReceive('expire')
|
|
->twice()
|
|
->andReturnUsing(function (StockReservation $reservation) use ($first): void {
|
|
if ($reservation->is($first)) {
|
|
throw new RuntimeException('Broken reservation.');
|
|
}
|
|
|
|
$reservation->update([
|
|
'status' => StockReservation::STATUS_EXPIRED,
|
|
'expires_at' => null,
|
|
'expired_at' => now(),
|
|
]);
|
|
});
|
|
|
|
$service = new ExpireStockReservationsService(
|
|
\Mockery::mock(ReleaseCheckoutService::class),
|
|
$reservations,
|
|
);
|
|
|
|
$result = $service->expireOverdue();
|
|
|
|
$this->assertSame([
|
|
'purchases' => 0,
|
|
'cart_reservations' => 0,
|
|
'orphan_reservations' => 1,
|
|
'failed' => 1,
|
|
], $result);
|
|
$this->assertDatabaseHas('stock_reservations', [
|
|
'id' => $first->id,
|
|
'status' => StockReservation::STATUS_ACTIVE,
|
|
]);
|
|
$this->assertDatabaseHas('stock_reservations', [
|
|
'id' => $second->id,
|
|
'status' => StockReservation::STATUS_EXPIRED,
|
|
]);
|
|
}
|
|
}
|