Merge branch 'fix/expiration_purchase_messages' of https://gitea.quo.ar/tbianchini/shopit-back into fix/expiration_purchase_messages

app/Domains/Sale/Services/AdminAppSaleService.php

@@ -53,6 +53,7 @@ class AdminAppSaleService
             ->where('tenant_codigo', $tenant->codigo)
             ->with([
                 'items',
+                'cart' => fn ($query) => $query->withTrashed(),
                 'cart.items.catalogItem',
                 'cart.items.variant.catalogItem',
                 'cart.items.variant.eventDates',
@@ -188,8 +189,28 @@ class AdminAppSaleService
 
     protected function saleForResponse(Purchase $sale): Purchase
     {
-        return $sale->refresh()
-            ->loadSum('items as quantity', 'cantidad')
-            ->loadCount('tickets');
+        /** @var Purchase */
+        return Purchase::query()
+            ->select('compras.*')
+            ->selectRaw($this->quantityExpression())
+            ->withCount('tickets')
+            ->findOrFail($sale->getKey());
+    }
+
+    protected function quantityExpression(): string
+    {
+        // El fallback se resuelve en SQL para poder ordenar por cantidad antes de paginar;
+        // los ítems consolidados de la compra tienen prioridad sobre los del carrito de origen.
+        return <<<'SQL'
+            COALESCE(
+                (SELECT SUM(compra_items.cantidad)
+                 FROM compra_items
+                 WHERE compra_items.compra_id = compras.id),
+                (SELECT SUM(carrito_items.cantidad)
+                 FROM carrito_items
+                 WHERE carrito_items.cart_id = compras.cart_id),
+                0
+            ) AS quantity
+            SQL;
     }
 }

tests/Feature/Sale/AdminAppSaleControllerTest.php

@@ -187,6 +187,54 @@ class AdminAppSaleControllerTest extends TestCase
             ->assertJsonPath('data.items.0.total', '25000.00');
     }
 
+    public function test_sales_list_uses_cart_quantity_until_purchase_items_exist(): void
+    {
+        $tenant = $this->createTenant('acme');
+        Sanctum::actingAs($this->createAdminAppUser($tenant));
+
+        $catalogItem = CatalogItem::query()->create([
+            'tenant_code' => $tenant->codigo,
+            'slug' => 'entrada-general',
+            'nombre' => 'Entrada general',
+            'descripcion' => 'Acceso general',
+            'precio' => '12500.00',
+        ]);
+        $cart = Cart::query()->create([
+            'tenant_codigo' => $tenant->codigo,
+            'status' => 'checkout',
+        ]);
+        CartItem::query()->create([
+            'cart_id' => $cart->id,
+            'catalog_item_id' => $catalogItem->id,
+            'cantidad' => 3,
+        ]);
+        $purchase = Purchase::query()->create([
+            'cart_id' => $cart->id,
+            'tenant_codigo' => $tenant->codigo,
+            'status' => Purchase::STATUS_PENDING_PAYMENT,
+            'total' => '37500.00',
+        ]);
+
+        $this->getJson('/api/v1/adminapp/tenant/sales')
+            ->assertOk()
+            ->assertJsonPath('data.0.id', $purchase->id)
+            ->assertJsonPath('data.0.quantity', 3);
+
+        PurchaseItem::query()->create([
+            'compra_id' => $purchase->id,
+            'source_catalog_item_id' => $catalogItem->id,
+            'nombre' => 'Entrada general',
+            'item_nombre' => 'Entrada general',
+            'cantidad' => 2,
+            'precio_unitario' => '12500.00',
+            'total' => '25000.00',
+        ]);
+
+        $this->getJson('/api/v1/adminapp/tenant/sales')
+            ->assertOk()
+            ->assertJsonPath('data.0.quantity', 2);
+    }
+
     public function test_an_adminapp_user_cannot_read_a_sale_from_another_tenant(): void
     {
         $tenant = $this->createTenant('acme');
@@ -318,6 +366,18 @@ class AdminAppSaleControllerTest extends TestCase
             'user_id' => $admin->id,
             'status' => 'converted',
         ]);
+        $catalogItem = CatalogItem::query()->create([
+            'tenant_code' => $tenant->codigo,
+            'slug' => 'entrada-general',
+            'nombre' => 'Entrada general',
+            'descripcion' => 'Acceso general',
+            'precio' => '10000.00',
+        ]);
+        CartItem::query()->create([
+            'cart_id' => $cart->id,
+            'catalog_item_id' => $catalogItem->id,
+            'cantidad' => 2,
+        ]);
         $cart->delete();
         $purchase = Purchase::query()->create([
             'cart_id' => $cart->id,
@@ -328,11 +388,17 @@ class AdminAppSaleControllerTest extends TestCase
 
         $this->postJson("/api/v1/adminapp/tenant/sales/{$purchase->id}/cancel")
             ->assertOk()
-            ->assertJsonPath('data.status', Purchase::STATUS_CANCELLED);
+            ->assertJsonPath('data.status', Purchase::STATUS_CANCELLED)
+            ->assertJsonPath('data.quantity', 2);
 
         $this->assertSame(Purchase::STATUS_CANCELLED, $purchase->fresh()->status);
         $this->assertSoftDeleted('carritos', ['id' => $cart->id]);
         $this->assertSame('converted', Cart::withTrashed()->findOrFail($cart->id)->status);
+
+        $this->getJson("/api/v1/adminapp/tenant/sales/{$purchase->id}")
+            ->assertOk()
+            ->assertJsonPath('data.items.0.product', 'Entrada general')
+            ->assertJsonPath('data.items.0.quantity', 2);
     }
 
     public function test_an_adminapp_user_cannot_change_a_sale_from_another_tenant(): void