fix(cart): reconcile expired cart mutations

app/Domains/Cart/Models/Cart.php

@@ -38,6 +38,16 @@ class Cart extends Model
 
     protected $table = 'carritos';
 
+    public const STATUS_ACTIVE = 'active';
+
+    public const STATUS_CHECKOUT = 'checkout';
+
+    public const STATUS_CONVERTED = 'converted';
+
+    public const STATUS_EXPIRED = 'expired';
+
+    public const STATUS_ABANDONED = 'abandoned';
+
     public const ORIGIN_USER = 'user';
 
     public const ORIGIN_DIRECT_CHECKOUT = 'direct_checkout';
@@ -119,6 +129,7 @@ class Cart extends Model
 
         return DB::transaction(function () use ($catalogItemId, $variantId, $quantity): CartItem {
             $this->invalidateCurrentCheckout();
+            app(StockReservationService::class)->assertCartReservationUsable($this);
             $selectedItem = $this->resolveScopedItem($catalogItemId, $variantId, true);
             $cartQuantity = (int) $this->items()
                 ->where('catalog_item_id', $catalogItemId)
@@ -183,6 +194,7 @@ class Cart extends Model
             $excludedPurchaseId,
         ): CartItem {
             $this->invalidateCurrentCheckout();
+            app(StockReservationService::class)->assertCartReservationUsable($this);
 
             /** @var CartItem $item */
             $item = $this->items()
@@ -284,6 +296,7 @@ class Cart extends Model
     {
         DB::transaction(function () use ($cartItemId): void {
             $this->invalidateCurrentCheckout();
+            app(StockReservationService::class)->assertCartReservationUsable($this);
 
             /** @var CartItem $item */
             $item = $this->items()
@@ -334,10 +347,14 @@ class Cart extends Model
             Purchase::STATUS_CREATED,
             Purchase::STATUS_PENDING_PAYMENT,
         ], true)) {
+            app(StockReservationService::class)->returnToCart($currentPurchase, $cart);
             $currentPurchase->update([
                 'status' => Purchase::STATUS_SUPERSEDED,
-                'expires_at' => null,
             ]);
+
+            $this->current_purchase_id = null;
+
+            return;
         }
 
         app(StockReservationService::class)->releaseForPurchase(

app/Domains/Cart/Services/CartService.php

@@ -4,9 +4,12 @@ namespace App\Domains\Cart\Services;
 
 use App\Domains\Auth\Models\User;
 use App\Domains\Cart\Models\Cart;
+use App\Domains\Catalog\Exceptions\StockReservationExpiredException;
+use App\Domains\Catalog\Services\ExpireStockReservationsService;
 use App\Domains\Tenant\Models\Tenant;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
+use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Str;
 use Illuminate\Validation\ValidationException;
 use Symfony\Component\HttpFoundation\Cookie;
@@ -22,7 +25,7 @@ class CartService
             return $this->makeEmptyCart($tenant);
         }
 
-        $cart = $this->findCart($tenant, $resolvedIdentity['identity']);
+        $cart = $this->resolveCart($tenant, $resolvedIdentity['identity']);
 
         if ($cart === null) {
             return $this->makeEmptyCart($tenant);
@@ -119,7 +122,7 @@ class CartService
     {
         $cart = new Cart([
             'tenant_codigo' => $tenant->codigo,
-            'status' => 'active',
+            'status' => Cart::STATUS_ACTIVE,
         ]);
 
         $cart->setRelation('items', collect());
@@ -220,12 +223,14 @@ class CartService
     {
         return Cart::query()
             ->where('tenant_codigo', $tenant->codigo)
-            ->where('status', 'active')
+            ->where('origin', Cart::ORIGIN_USER)
+            ->whereIn('status', [Cart::STATUS_ACTIVE, Cart::STATUS_EXPIRED])
             ->when(
                 $identity['user_id'] !== null,
                 fn ($query) => $query->where('user_id', $identity['user_id']),
                 fn ($query) => $query->where('guest_token', $identity['guest_token']),
             )
+            ->orderByRaw('CASE WHEN status = ? THEN 0 ELSE 1 END', [Cart::STATUS_ACTIVE])
             ->first();
     }
 
@@ -234,7 +239,7 @@ class CartService
      */
     protected function findCartOrFail(Tenant $tenant, array $identity): Cart
     {
-        $cart = $this->findCart($tenant, $identity);
+        $cart = $this->resolveCart($tenant, $identity, replaceExpired: false);
 
         if ($cart === null) {
             throw new NotFoundHttpException('Cart not found.');
@@ -247,10 +252,73 @@ class CartService
      * @param  array{user_id: ?int, guest_token: ?string}  $identity
      */
     protected function findOrCreateCart(Tenant $tenant, array $identity): Cart
+    {
+        return $this->resolveCart($tenant, $identity)
+            ?? $this->createCart($tenant, $identity);
+    }
+
+    /**
+     * @param  array{user_id: ?int, guest_token: ?string}  $identity
+     */
+    protected function resolveCart(
+        Tenant $tenant,
+        array $identity,
+        bool $replaceExpired = true,
+    ): ?Cart {
+        $cart = $this->findCart($tenant, $identity);
+
+        if ($cart?->status === Cart::STATUS_ACTIVE
+            && $cart->current_stock_reservation_id !== null
+            && app(ExpireStockReservationsService::class)
+                ->expireIfOverdue($cart->current_stock_reservation_id)) {
+            $cart = $this->findCart($tenant, $identity);
+        }
+
+        if ($cart?->status === Cart::STATUS_EXPIRED) {
+            if (! $replaceExpired) {
+                throw new StockReservationExpiredException;
+            }
+
+            return $this->replaceExpiredCart($cart, $tenant, $identity);
+        }
+
+        if ($cart !== null) {
+            return $cart;
+        }
+
+        return null;
+    }
+
+    /**
+     * @param  array{user_id: ?int, guest_token: ?string}  $identity
+     */
+    protected function replaceExpiredCart(Cart $expiredCart, Tenant $tenant, array $identity): Cart
+    {
+        return DB::transaction(function () use ($expiredCart, $tenant, $identity): Cart {
+            /** @var Cart|null $lockedCart */
+            $lockedCart = Cart::query()->lockForUpdate()->find($expiredCart->getKey());
+
+            if ($lockedCart?->status === Cart::STATUS_EXPIRED) {
+                $lockedCart->update([
+                    'status' => Cart::STATUS_ABANDONED,
+                    'current_purchase_id' => null,
+                ]);
+            }
+
+            return $this->findCart($tenant, $identity)
+                ?? $this->createCart($tenant, $identity);
+        });
+    }
+
+    /**
+     * @param  array{user_id: ?int, guest_token: ?string}  $identity
+     */
+    protected function createCart(Tenant $tenant, array $identity): Cart
     {
         $attributes = [
             'tenant_codigo' => $tenant->codigo,
-            'status' => 'active',
+            'status' => Cart::STATUS_ACTIVE,
+            'origin' => Cart::ORIGIN_USER,
         ];
 
         if ($identity['user_id'] !== null) {

app/Domains/Cart/Services/ExpireCartReservationsService.php

@@ -1,86 +0,0 @@
-<?php
-
-namespace App\Domains\Cart\Services;
-
-use App\Domains\Cart\Models\Cart;
-use App\Domains\Catalog\Models\StockReservation;
-use App\Domains\Catalog\Services\StockReservationService;
-use App\Domains\Purchase\Models\Purchase;
-use Illuminate\Support\Facades\DB;
-
-class ExpireCartReservationsService
-{
-    public function __construct(
-        private readonly StockReservationService $reservations,
-    ) {}
-
-    public function expireOverdue(): int
-    {
-        $expired = 0;
-        $lastReservationId = 0;
-
-        do {
-            $reservationIds = StockReservation::query()
-                ->where('status', StockReservation::STATUS_ACTIVE)
-                ->whereNotNull('expires_at')
-                ->where('expires_at', '<=', now())
-                ->where('id', '>', $lastReservationId)
-                ->whereHas('currentCart', fn ($query) => $query->where('status', 'active'))
-                ->whereDoesntHave('purchase', fn ($query) => $query->whereIn('status', [
-                    Purchase::STATUS_CREATED,
-                    Purchase::STATUS_PENDING_PAYMENT,
-                    Purchase::STATUS_IN_REVIEW,
-                ]))
-                ->orderBy('id')
-                ->limit(500)
-                ->pluck('id');
-
-            foreach ($reservationIds as $reservationId) {
-                $lastReservationId = (int) $reservationId;
-
-                if ($this->expireReservation($lastReservationId)) {
-                    $expired++;
-                }
-            }
-        } while ($reservationIds->count() === 500);
-
-        return $expired;
-    }
-
-    private function expireReservation(int $reservationId): bool
-    {
-        $cartId = Cart::query()
-            ->where('current_stock_reservation_id', $reservationId)
-            ->where('status', 'active')
-            ->value('id');
-        if ($cartId === null) {
-            return false;
-        }
-
-        return DB::transaction(function () use ($cartId, $reservationId): bool {
-            /** @var Cart|null $cart */
-            $cart = Cart::query()
-                ->whereKey($cartId)
-                ->where('current_stock_reservation_id', $reservationId)
-                ->where('status', 'active')
-                ->lockForUpdate()
-                ->first();
-            if ($cart === null) {
-                return false;
-            }
-
-            /** @var StockReservation|null $reservation */
-            $reservation = StockReservation::query()->lockForUpdate()->find($reservationId);
-            if ($reservation === null
-                || $reservation->status !== StockReservation::STATUS_ACTIVE
-                || $reservation->expires_at === null
-                || $reservation->expires_at->isFuture()) {
-                return false;
-            }
-
-            $this->reservations->expire($reservation);
-
-            return true;
-        });
-    }
-}

app/Domains/Cart/documentacion/README.md

@@ -12,7 +12,6 @@ Gestiona el carrito activo de un tenant tanto para visitantes como para usuarios
 ## Servicios
 
 - `CartService`: obtiene el carrito, modifica ítems y administra la cookie del token invitado.
-- `ExpireCartReservationsService`: libera como conjunto las reservas vencidas de carritos activos sin eliminar el contenido del carrito.
 - `GuestCartMergeService`: incorpora el carrito invitado al usuario cuando este se autentica.
 
 ## Endpoints
@@ -34,6 +33,6 @@ Depende de `Catalog` para productos y variantes, de `Tenant` para aislar datos y
 
 Un carrito puede pasar a `checkout`. Las compras directas usan un carrito técnico con `origin=direct_checkout`; los carritos normales conservan `origin=user` y pueden restaurarse al cancelar o vencer la compra.
 
-Cada edición sincroniza una única reserva para el carrito completo. Si varios ítems o bundles consumen el mismo inventario, se persiste una sola línea con la cantidad agregada. Al editar durante checkout, la compra anterior queda `superseded`, su reserva se libera con el motivo correspondiente y se crea otra para el carrito actualizado.
+Cada edición sincroniza una única reserva para el carrito completo. Si varios ítems o bundles consumen el mismo inventario, se persiste una sola línea con la cantidad agregada. Al editar durante checkout, la compra anterior queda `superseded`, se desvincula y el carrito conserva la misma reserva activa con sus líneas actualizadas.
 
-El comando unificado `php artisan reservations:expire` procesa primero las compras vencidas y luego las reservas activas de carrito cuyo `expires_at` haya vencido. Se ejecuta cada minuto mediante el scheduler, conserva la reserva y sus líneas como historial, libera el stock como conjunto y deja intactos el carrito y sus ítems.
+El comando unificado `php artisan reservations:expire` recorre una sola vez las reservas activas cuyo `expires_at` haya vencido. Cuando pertenecen a un carrito, conserva la reserva y sus líneas como historial, libera el stock como conjunto y cambia el carrito asociado a `expired` sin eliminar sus ítems. Al volver a resolver ese carrito desde la API, el anterior pasa automáticamente a `abandoned` y se crea uno activo y vacío para la misma identidad. El cliente nunca necesita reiniciarlo explícitamente. La API también materializa este vencimiento al acceder al carrito aunque el comando programado todavía no haya corrido.

app/Domains/Catalog/Exceptions/StockReservationExpiredException.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace App\Domains\Catalog\Exceptions;
+
+use RuntimeException;
+
+class StockReservationExpiredException extends RuntimeException
+{
+    public function __construct()
+    {
+        parent::__construct(__('api.cart.reservation_expired'));
+    }
+}

app/Domains/Catalog/Services/ExpireStockReservationsService.php

@@ -2,50 +2,184 @@
 
 namespace App\Domains\Catalog\Services;
 
-use App\Domains\Cart\Services\ExpireCartReservationsService;
-use App\Domains\Purchase\Services\CheckoutService;
+use App\Domains\Cart\Models\Cart;
+use App\Domains\Catalog\Models\StockReservation;
+use App\Domains\Purchase\Models\Purchase;
+use App\Domains\Purchase\Services\Checkout\ReleaseCheckoutService;
+use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Log;
+use RuntimeException;
 use Throwable;
 
 class ExpireStockReservationsService
 {
+    private const BATCH_SIZE = 500;
+
     public function __construct(
-        private readonly CheckoutService $checkout,
-        private readonly ExpireCartReservationsService $carts,
+        private readonly ReleaseCheckoutService $purchases,
+        private readonly StockReservationService $reservations,
     ) {}
 
     /**
-     * @return array{purchases: int, cart_reservations: int}
+     * @return array{purchases: int, cart_reservations: int, orphan_reservations: int, failed: int}
      */
     public function expireOverdue(): array
     {
-        $expiredPurchases = null;
-        $expiredCartItems = null;
+        $summary = [
+            'purchases' => 0,
+            'cart_reservations' => 0,
+            'orphan_reservations' => 0,
+            'failed' => 0,
+        ];
+        $lastReservationId = 0;
+
+        do {
+            $reservationIds = StockReservation::query()
+                ->where('status', StockReservation::STATUS_ACTIVE)
+                ->whereNotNull('expires_at')
+                ->where('expires_at', '<=', now())
+                ->where('id', '>', $lastReservationId)
+                ->orderBy('id')
+                ->limit(self::BATCH_SIZE)
+                ->pluck('id');
+
+            foreach ($reservationIds as $reservationId) {
+                $lastReservationId = (int) $reservationId;
 
                 try {
-            $expiredPurchases = $this->checkout->expireOverduePurchases();
-            $expiredCartItems = $this->carts->expireOverdue();
+                    $owner = $this->expireReservation($lastReservationId);
+                    if ($owner !== null) {
+                        $summary[$owner]++;
+                    }
+                } catch (Throwable $exception) {
+                    $summary['failed']++;
+                    Log::channel('commands')->error('Failed to expire overdue stock reservation.', [
+                        'command' => 'reservations:expire',
+                        'stock_reservation_id' => $lastReservationId,
+                        'exception' => $exception,
+                    ]);
+                }
+            }
+        } while ($reservationIds->count() === self::BATCH_SIZE);
 
         Log::channel('commands')->info('Stock reservation cleanup completed.', [
             'command' => 'reservations:expire',
-                'expired_purchases' => $expiredPurchases,
-                'expired_cart_reservations' => $expiredCartItems,
-                'total_expired' => $expiredPurchases + $expiredCartItems,
+            'expired_purchases' => $summary['purchases'],
+            'expired_cart_reservations' => $summary['cart_reservations'],
+            'expired_orphan_reservations' => $summary['orphan_reservations'],
+            'failed_reservations' => $summary['failed'],
+            'total_expired' => $summary['purchases']
+                + $summary['cart_reservations']
+                + $summary['orphan_reservations'],
         ]);
 
-            return [
-                'purchases' => $expiredPurchases,
-                'cart_reservations' => $expiredCartItems,
-            ];
-        } catch (Throwable $exception) {
-            Log::channel('commands')->error('Stock reservation cleanup failed.', [
-                'command' => 'reservations:expire',
-                'expired_purchases' => $expiredPurchases,
-                'expired_cart_reservations' => $expiredCartItems,
-                'exception' => $exception,
-            ]);
+        return $summary;
+    }
 
-            throw $exception;
-        }
+    public function expireIfOverdue(int $reservationId): bool
+    {
+        /** @var StockReservation|null $reservation */
+        $reservation = StockReservation::query()->find($reservationId);
+        if ($reservation?->status === StockReservation::STATUS_EXPIRED) {
+            return true;
+        }
+        if (! $this->isOverdue($reservation)) {
+            return false;
+        }
+
+        return $this->expireReservation($reservationId) !== null;
+    }
+
+    /** @return 'purchases'|'cart_reservations'|'orphan_reservations'|null */
+    private function expireReservation(int $reservationId): ?string
+    {
+        $purchaseId = Purchase::query()
+            ->where('stock_reservation_id', $reservationId)
+            ->value('id');
+        if ($purchaseId !== null) {
+            return $this->expirePurchase((int) $purchaseId);
+        }
+
+        $cartId = Cart::query()
+            ->where('current_stock_reservation_id', $reservationId)
+            ->where('status', 'active')
+            ->value('id');
+        if ($cartId !== null) {
+            return $this->expireCart((int) $cartId, $reservationId);
+        }
+
+        return $this->expireOrphan($reservationId);
+    }
+
+    /** @return 'purchases'|null */
+    private function expirePurchase(int $purchaseId): ?string
+    {
+        /** @var Purchase|null $purchase */
+        $purchase = Purchase::query()->find($purchaseId);
+        if ($purchase === null) {
+            return null;
+        }
+
+        $purchase = $this->purchases->expire($purchase);
+        if ($purchase->status === Purchase::STATUS_EXPIRED) {
+            return 'purchases';
+        }
+
+        $reservation = $purchase->stockReservation;
+        if ($this->isOverdue($reservation)) {
+            throw new RuntimeException('An overdue active reservation belongs to a purchase that cannot expire.');
+        }
+
+        return null;
+    }
+
+    /** @return 'cart_reservations'|null */
+    private function expireCart(int $cartId, int $reservationId): ?string
+    {
+        return DB::transaction(function () use ($cartId, $reservationId): ?string {
+            /** @var Cart|null $cart */
+            $cart = Cart::query()
+                ->whereKey($cartId)
+                ->where('current_stock_reservation_id', $reservationId)
+                ->where('status', Cart::STATUS_ACTIVE)
+                ->lockForUpdate()
+                ->first();
+            if ($cart === null) {
+                return null;
+            }
+
+            /** @var StockReservation|null $reservation */
+            $reservation = StockReservation::query()->lockForUpdate()->find($reservationId);
+            if (! $this->isOverdue($reservation)) {
+                return null;
+            }
+
+            $this->reservations->expire($reservation);
+            $cart->update(['status' => Cart::STATUS_EXPIRED]);
+
+            return 'cart_reservations';
+        });
+    }
+
+    /** @return 'orphan_reservations'|null */
+    private function expireOrphan(int $reservationId): ?string
+    {
+        /** @var StockReservation|null $reservation */
+        $reservation = StockReservation::query()->find($reservationId);
+        if (! $this->isOverdue($reservation)) {
+            return null;
+        }
+
+        $this->reservations->expire($reservation);
+
+        return 'orphan_reservations';
+    }
+
+    private function isOverdue(?StockReservation $reservation): bool
+    {
+        return $reservation !== null
+            && $reservation->status === StockReservation::STATUS_ACTIVE
+            && $reservation->expires_at !== null
+            && ! $reservation->expires_at->isFuture();
     }
 }

app/Domains/Catalog/Services/StockReservationService.php

@@ -4,6 +4,7 @@ namespace App\Domains\Catalog\Services;
 
 use App\Domains\Cart\Models\Cart;
 use App\Domains\Cart\Models\CartItem;
+use App\Domains\Catalog\Exceptions\StockReservationExpiredException;
 use App\Domains\Catalog\Models\Inventory;
 use App\Domains\Catalog\Models\StockReservation;
 use App\Domains\Catalog\Models\StockReservationLine;
@@ -43,13 +44,8 @@ class StockReservationService
                 ? null
                 : StockReservation::query()->lockForUpdate()->find($lockedCart->current_stock_reservation_id);
 
-            if ($reservation !== null
-                && $reservation->status === StockReservation::STATUS_ACTIVE
-                && $reservation->expires_at !== null
-                && $reservation->expires_at->isPast()) {
-                $this->finalizeLocked($reservation, StockReservation::STATUS_EXPIRED, null);
-                $lockedCart->update(['current_stock_reservation_id' => null]);
-                $reservation = null;
+            if ($reservation !== null) {
+                $this->assertUsableCartReservation($reservation);
             }
 
             if ($requirements === []) {
@@ -67,7 +63,7 @@ class StockReservationService
                 return null;
             }
 
-            if ($reservation === null || $reservation->status !== StockReservation::STATUS_ACTIVE) {
+            if ($reservation === null) {
                 $reservation = StockReservation::query()->create([
                     'status' => StockReservation::STATUS_ACTIVE,
                     'expires_at' => $this->expiration(),
@@ -158,9 +154,12 @@ class StockReservationService
         });
     }
 
-    public function attachToPurchase(Cart $cart, Purchase $purchase): StockReservation
-    {
-        return DB::transaction(function () use ($cart, $purchase): StockReservation {
+    public function attachToPurchase(
+        Cart $cart,
+        Purchase $purchase,
+        Carbon $expiresAt,
+    ): StockReservation {
+        return DB::transaction(function () use ($cart, $purchase, $expiresAt): StockReservation {
             /** @var Cart $lockedCart */
             $lockedCart = Cart::query()->lockForUpdate()->findOrFail($cart->getKey());
             /** @var Purchase $lockedPurchase */
@@ -172,9 +171,7 @@ class StockReservationService
 
             /** @var StockReservation $reservation */
             $reservation = StockReservation::query()->lockForUpdate()->findOrFail($lockedCart->current_stock_reservation_id);
-            if ($reservation->status !== StockReservation::STATUS_ACTIVE) {
-                throw new \InvalidArgumentException('La reserva de stock no está activa.');
-            }
+            $this->assertUsableCartReservation($reservation);
 
             $linkedPurchase = Purchase::query()
                 ->where('stock_reservation_id', $reservation->getKey())
@@ -185,7 +182,7 @@ class StockReservationService
             }
 
             $lockedPurchase->update(['stock_reservation_id' => $reservation->getKey()]);
-            $reservation->update(['expires_at' => $lockedPurchase->expires_at]);
+            $reservation->update(['expires_at' => $expiresAt]);
             $purchase->stock_reservation_id = $reservation->getKey();
             $cart->current_stock_reservation_id = $reservation->getKey();
 
@@ -210,6 +207,9 @@ class StockReservationService
             if ($reservation->status !== StockReservation::STATUS_ACTIVE) {
                 throw new \InvalidArgumentException('La reserva de stock no está activa.');
             }
+            if ($reservation->expires_at !== null && ! $reservation->expires_at->isFuture()) {
+                throw new StockReservationExpiredException;
+            }
 
             $lines = $this->lockLines($reservation);
             if ($lines->isEmpty()) {
@@ -264,6 +264,50 @@ class StockReservationService
         });
     }
 
+    public function returnToCart(Purchase $purchase, Cart $cart): StockReservation
+    {
+        return DB::transaction(function () use ($purchase, $cart): StockReservation {
+            /** @var Purchase $purchase */
+            $purchase = Purchase::query()->lockForUpdate()->findOrFail($purchase->getKey());
+            /** @var Cart $cart */
+            $cart = Cart::query()->lockForUpdate()->findOrFail($cart->getKey());
+
+            if ($purchase->stock_reservation_id === null
+                || $cart->current_stock_reservation_id !== $purchase->stock_reservation_id) {
+                throw new \InvalidArgumentException('La compra y el carrito no comparten la reserva activa.');
+            }
+
+            /** @var StockReservation $reservation */
+            $reservation = StockReservation::query()
+                ->lockForUpdate()
+                ->findOrFail($purchase->stock_reservation_id);
+            $this->assertUsableCartReservation($reservation);
+
+            $purchase->update(['stock_reservation_id' => null]);
+            $cart->update(['current_purchase_id' => null]);
+            $reservation->update(['expires_at' => $this->expiration()]);
+
+            return $reservation->fresh('lines');
+        });
+    }
+
+    public function assertCartReservationUsable(Cart $cart): void
+    {
+        DB::transaction(function () use ($cart): void {
+            /** @var Cart $cart */
+            $cart = Cart::query()->lockForUpdate()->findOrFail($cart->getKey());
+            if ($cart->current_stock_reservation_id === null) {
+                return;
+            }
+
+            /** @var StockReservation $reservation */
+            $reservation = StockReservation::query()
+                ->lockForUpdate()
+                ->findOrFail($cart->current_stock_reservation_id);
+            $this->assertUsableCartReservation($reservation);
+        });
+    }
+
     public function releaseCurrentCartReservation(
         Cart $cart,
         string $reason = self::REASON_CART_CHANGED,
@@ -299,16 +343,28 @@ class StockReservationService
         });
     }
 
-    public function syncPurchaseExpiration(Purchase $purchase): void
+    public function refreshForPurchase(Purchase $purchase, ?Carbon $expiresAt): void
     {
+        DB::transaction(function () use ($purchase, $expiresAt): void {
+            /** @var Purchase $purchase */
+            $purchase = Purchase::query()->lockForUpdate()->findOrFail($purchase->getKey());
             if ($purchase->stock_reservation_id === null) {
-            return;
+                throw new \InvalidArgumentException('La compra no tiene una reserva de stock.');
             }
 
-        StockReservation::query()
-            ->whereKey($purchase->stock_reservation_id)
-            ->where('status', StockReservation::STATUS_ACTIVE)
-            ->update(['expires_at' => $purchase->expires_at]);
+            /** @var StockReservation $reservation */
+            $reservation = StockReservation::query()
+                ->lockForUpdate()
+                ->findOrFail($purchase->stock_reservation_id);
+            if ($reservation->status !== StockReservation::STATUS_ACTIVE) {
+                throw new \InvalidArgumentException('La reserva de stock no está activa.');
+            }
+            if ($reservation->expires_at !== null && ! $reservation->expires_at->isFuture()) {
+                throw new StockReservationExpiredException;
+            }
+
+            $reservation->update(['expires_at' => $expiresAt]);
+        });
     }
 
     /**
@@ -408,10 +464,25 @@ class StockReservationService
             'release_reason' => $status === StockReservation::STATUS_RELEASED ? $reason : null,
         ]);
 
+        if ($status === StockReservation::STATUS_RELEASED) {
             Cart::query()
                 ->where('current_stock_reservation_id', $reservation->getKey())
                 ->update(['current_stock_reservation_id' => null]);
         }
+    }
+
+    private function assertUsableCartReservation(StockReservation $reservation): void
+    {
+        if ($reservation->status === StockReservation::STATUS_EXPIRED
+            || ($reservation->expires_at !== null && ! $reservation->expires_at->isFuture())) {
+            throw new StockReservationExpiredException;
+        }
+
+        if ($reservation->status !== StockReservation::STATUS_ACTIVE
+            || $reservation->expires_at === null) {
+            throw new \InvalidArgumentException('La reserva de stock no está disponible para operar el carrito.');
+        }
+    }
 
     private function expiration(): Carbon
     {

app/Domains/Catalog/documentacion/README.md

@@ -9,7 +9,7 @@ Modela y publica la oferta comercial del tenant: productos, variantes, categorí
 - `CatalogItem` es la raíz del producto y se relaciona con tenant, categoría, marca, inventario, variantes, atributos, adjuntos y grupos destacados.
 - `Variant`, `ItemAttribute`, `Attribute`, `AttributeOption` y `VariantDefinition` describen opciones comercializables.
 - `Inventory` administra stock disponible, reservado y comprado.
-- `StockReservation` representa la reserva completa de un carrito o checkout, con estados `active`, `committed`, `released` y `expired`. Sus `StockReservationLine` agregan la cantidad requerida por inventario, incluso cuando varios ítems o bundles consumen el mismo stock.
+- `StockReservation` representa la reserva completa de un carrito o checkout, con estados `active`, `committed`, `released` y `expired`. Su `expires_at` es el único reloj del bloqueo. Al expirar, también pasan a `expired` la compra pagable y el carrito asociados dentro de la misma transacción. Sus estados terminales nunca se reactivan ni se reemplazan implícitamente. Sus `StockReservationLine` agregan la cantidad requerida por inventario, incluso cuando varios ítems o bundles consumen el mismo stock.
 - `Category` soporta jerarquía y categorías globales o propias del tenant.
 - `FeaturedGroup` y `FeaturedItem` organizan secciones destacadas.
 - `BundleComponent` representa los componentes de un paquete.
@@ -19,6 +19,7 @@ Modela y publica la oferta comercial del tenant: productos, variantes, categorí
 - `CatalogService`: alta, búsqueda, detalle, listado por categoría y eliminación.
 - `CatalogInventoryService`: consulta, reserva, libera y confirma inventario.
 - `StockReservationService`: sincroniza el carrito como conjunto, bloquea todos sus inventarios en orden estable y mantiene el ledger agregado consistente con `Inventory.reserved_stock`.
+- `ExpireStockReservationsService`: detecta en un único recorrido reservas vencidas de compras, carritos y huérfanas, y delega los efectos comerciales sin mezclar esas reglas con la liberación física del inventario.
 - `FeaturedGroupService`: pagina los ítems destacados para la tienda.
 - `OnTicketFeaturedGroupService`: administra grupos destacados del panel para sitios de tickets.
 

app/Domains/Desfile/Services/InvitationPurchaseProvisioner.php

@@ -144,7 +144,6 @@ class InvitationPurchaseProvisioner
         if ($purchaseId !== null) {
             DB::table('compras')->where('id', $purchaseId)->update([
                 'status' => 'paid',
-                'expires_at' => null,
                 'total' => 0,
                 'updated_at' => $now,
             ]);
@@ -158,7 +157,6 @@ class InvitationPurchaseProvisioner
             'cart_id' => null,
             'status' => 'paid',
             'payment_method' => self::PAYMENT_METHOD,
-            'expires_at' => null,
             'total' => 0,
             'dni' => null,
             'transfer_payer_dni' => null,
@@ -396,7 +394,6 @@ class InvitationPurchaseProvisioner
         if ($reservationId === null) {
             $reservationId = DB::table('stock_reservations')->insertGetId([
                 'status' => 'committed',
-                'expires_at' => null,
                 'committed_at' => $now,
                 'released_at' => null,
                 'expired_at' => null,

app/Domains/Purchase/Controllers/PurchaseController.php

@@ -36,6 +36,7 @@ class PurchaseController extends Controller
 
         return PurchaseResource::collection(
             Purchase::query()
+                ->with('stockReservation')
                 ->where('tenant_codigo', $tenant->codigo)
                 ->where('user_id', $request->user()->id)
                 ->when($statuses !== [], fn ($query) => $query->whereIn('status', $statuses))
@@ -101,7 +102,13 @@ class PurchaseController extends Controller
             ? preg_replace('/\D+/', '', (string) $request->validated('transfer_payer_dni'))
             : null;
 
-        $updated = DB::transaction(function () use ($compra, $method, $purchaseState, $transferPayerDni): bool {
+        $updated = DB::transaction(function () use (
+            $checkoutService,
+            $compra,
+            $method,
+            $purchaseState,
+            $transferPayerDni,
+        ): bool {
             /** @var Purchase|null $purchase */
             $purchase = Purchase::query()
                 ->whereKey($compra->getKey())
@@ -128,9 +135,6 @@ class PurchaseController extends Controller
             $purchaseUpdate = [
                 'payment_method' => $method,
                 'status' => Purchase::STATUS_PENDING_PAYMENT,
-                'expires_at' => now()->addMinutes(
-                    max(1, (int) config("purchase.payment_expiration_minutes.{$method}", 30))
-                ),
                 'total' => $purchase->calculateCurrentTotalAmount(),
             ];
 
@@ -138,6 +142,12 @@ class PurchaseController extends Controller
                 $purchaseUpdate['transfer_payer_dni'] = $transferPayerDni;
             }
             $purchase->update($purchaseUpdate);
+            $checkoutService->refreshReservationExpiration(
+                $purchase,
+                now()->addMinutes(
+                    max(1, (int) config("purchase.payment_expiration_minutes.{$method}", 30)),
+                ),
+            );
 
             return true;
         });
@@ -150,7 +160,6 @@ class PurchaseController extends Controller
 
         $compra->refresh();
         $totalAmount = (float) $compra->total;
-        $checkoutService->syncReservationExpiration($compra);
 
         if ($method === 'transfer') {
             $telepagosService = new TelepagosIntegrationService;

app/Domains/Purchase/Models/Purchase.php

@@ -24,7 +24,6 @@ use Illuminate\Support\Facades\DB;
     'user_id',
     'status',
     'payment_method',
-    'expires_at',
     'total',
     'dni',
     'transfer_payer_dni',
@@ -80,7 +79,6 @@ class Purchase extends Model
             'cart_id' => 'integer',
             'stock_reservation_id' => 'integer',
             'user_id' => 'integer',
-            'expires_at' => 'datetime',
             'total' => 'decimal:2',
         ];
     }

app/Domains/Purchase/Resources/PurchaseResource.php

@@ -48,7 +48,7 @@ class PurchaseResource extends JsonResource
             'created_at' => $this->created_at,
             'status' => $this->status,
             'payment_method' => $this->payment_method,
-            'expires_at' => $this->expires_at,
+            'expires_at' => $this->stockReservation?->expires_at,
             'dni' => $this->dni,
             'transfer_payer_dni' => $this->transfer_payer_dni,
             'telefono' => $this->telefono,

app/Domains/Purchase/Services/Checkout/CompleteCheckoutService.php

@@ -61,10 +61,7 @@ class CompleteCheckoutService
 
             $this->purchaseState->lockCurrentCart($purchase);
 
-            if (
-                $purchase->status !== Purchase::STATUS_PENDING_PAYMENT
-                || ($purchase->expires_at !== null && $purchase->expires_at->isPast())
-            ) {
+            if ($purchase->status !== Purchase::STATUS_PENDING_PAYMENT) {
                 throw ValidationException::withMessages([
                     'purchase' => __('api.purchase.not_available_for_review'),
                 ]);
@@ -72,9 +69,8 @@ class CompleteCheckoutService
 
             $purchase->update([
                 'status' => Purchase::STATUS_IN_REVIEW,
-                'expires_at' => null,
             ]);
-            $this->reservations->syncPurchaseExpiration($purchase);
+            $this->reservations->refreshForPurchase($purchase, null);
 
             return $this->loadPurchase($purchase);
         });
@@ -195,7 +191,7 @@ class CompleteCheckoutService
 
     private function loadPurchase(Purchase $purchase): Purchase
     {
-        return $purchase->load(['items.imageAttachment']);
+        return $purchase->load(['items.imageAttachment', 'stockReservation']);
     }
 
     private function itemKey(int $catalogItemId, ?int $variantId): string

app/Domains/Purchase/Services/Checkout/PurchaseResponseLoader.php

@@ -8,6 +8,6 @@ class PurchaseResponseLoader
 {
     public function load(Purchase $purchase): Purchase
     {
-        return $purchase->load(['tenant', 'items.imageAttachment']);
+        return $purchase->load(['tenant', 'items.imageAttachment', 'stockReservation']);
     }
 }

app/Domains/Purchase/Services/Checkout/ReleaseCheckoutService.php

@@ -5,11 +5,10 @@ namespace App\Domains\Purchase\Services\Checkout;
 use App\Domains\Cart\Models\Cart;
 use App\Domains\Catalog\Models\StockReservation;
 use App\Domains\Catalog\Services\StockReservationService;
+use App\Domains\Purchase\Exceptions\PurchaseExpiredException;
 use App\Domains\Purchase\Models\Purchase;
 use Illuminate\Support\Facades\DB;
-use Illuminate\Support\Facades\Log;
 use Illuminate\Validation\ValidationException;
-use Throwable;
 
 class ReleaseCheckoutService
 {
@@ -32,40 +31,6 @@ class ReleaseCheckoutService
         return $this->release($purchase, Purchase::STATUS_EXPIRED);
     }
 
-    public function expireOverdue(): int
-    {
-        $expiredCount = 0;
-
-        Purchase::query()
-            ->whereIn('status', [Purchase::STATUS_CREATED, Purchase::STATUS_PENDING_PAYMENT])
-            ->whereNotNull('expires_at')
-            ->where('expires_at', '<=', now())
-            ->orderBy('id')
-            ->eachById(function (Purchase $purchase) use (&$expiredCount): void {
-                try {
-                    $purchase = $this->expire($purchase);
-                } catch (Throwable $exception) {
-                    Log::channel('commands')->error('Failed to expire overdue purchase.', [
-                        'command' => 'reservations:expire',
-                        'purchase_id' => $purchase->getKey(),
-                        'tenant_codigo' => $purchase->tenant_codigo,
-                        'cart_id' => $purchase->cart_id,
-                        'status' => $purchase->status,
-                        'expires_at' => $purchase->expires_at,
-                        'exception' => $exception,
-                    ]);
-
-                    return;
-                }
-
-                if ($purchase->status === Purchase::STATUS_EXPIRED) {
-                    $expiredCount++;
-                }
-            });
-
-        return $expiredCount;
-    }
-
     private function release(
         Purchase $purchase,
         string $targetStatus,
@@ -78,6 +43,11 @@ class ReleaseCheckoutService
         ): Purchase {
             $purchase = $this->lockPurchase($purchase);
 
+            if ($purchase->status === Purchase::STATUS_EXPIRED
+                && $targetStatus !== Purchase::STATUS_EXPIRED) {
+                throw new PurchaseExpiredException;
+            }
+
             if ($purchase->status === Purchase::STATUS_PAID) {
                 if ($targetStatus === Purchase::STATUS_EXPIRED) {
                     return $this->loadPurchase($purchase);
@@ -100,14 +70,31 @@ class ReleaseCheckoutService
                 return $this->loadPurchase($purchase);
             }
 
+            $cart = $purchase->cart()->withTrashed()->lockForUpdate()->first();
+
+            if ($targetStatus === Purchase::STATUS_CANCELLED
+                && $cart?->status === 'active'
+                && in_array($purchase->status, [
+                    Purchase::STATUS_CREATED,
+                    Purchase::STATUS_PENDING_PAYMENT,
+                ], true)) {
+                $this->reservations->returnToCart($purchase, $cart);
+                $purchase->update(['status' => Purchase::STATUS_CANCELLED]);
+
+                return $this->loadPurchase($purchase);
+            }
+
             if (
                 $targetStatus === Purchase::STATUS_EXPIRED
-                && ($purchase->expires_at === null || $purchase->expires_at->isFuture())
+                && (! in_array($purchase->status, [
+                    Purchase::STATUS_CREATED,
+                    Purchase::STATUS_PENDING_PAYMENT,
+                ], true) || ! $this->hasOverdueActiveReservation($purchase))
             ) {
                 return $this->loadPurchase($purchase);
             }
 
-            $this->releasePurchaseReservations($purchase, $targetStatus);
+            $this->releasePurchaseReservations($purchase, $targetStatus, $cart);
 
             $purchase->update(['status' => $targetStatus]);
 
@@ -115,9 +102,11 @@ class ReleaseCheckoutService
         });
     }
 
-    private function releasePurchaseReservations(Purchase $purchase, string $targetStatus): void
-    {
-        $cart = $purchase->cart()->withTrashed()->lockForUpdate()->first();
+    private function releasePurchaseReservations(
+        Purchase $purchase,
+        string $targetStatus,
+        ?Cart $cart,
+    ): void {
         try {
             $this->reservations->releaseForPurchase(
                 $purchase,
@@ -140,28 +129,40 @@ class ReleaseCheckoutService
             return;
         }
 
-        if ($cart->status === 'active') {
+        if ($targetStatus === Purchase::STATUS_EXPIRED
+            && in_array($cart->status, [Cart::STATUS_ACTIVE, Cart::STATUS_CHECKOUT], true)) {
             Cart::query()
                 ->whereKey($cart->getKey())
                 ->where('current_purchase_id', $purchase->getKey())
+                ->where('current_stock_reservation_id', $purchase->stock_reservation_id)
                 ->update([
+                    'status' => Cart::STATUS_EXPIRED,
                     'current_purchase_id' => null,
-                    'current_stock_reservation_id' => null,
                 ]);
 
-            if ($targetStatus === Purchase::STATUS_CANCELLED) {
-                $this->reservations->syncCart($cart);
-            }
-
             return;
         }
 
-        if ($cart->status !== 'checkout') {
+        if ($cart->status === Cart::STATUS_ACTIVE) {
+            $cartUpdate = [
+                'current_purchase_id' => null,
+                'current_stock_reservation_id' => null,
+            ];
+
+            Cart::query()
+                ->whereKey($cart->getKey())
+                ->where('current_purchase_id', $purchase->getKey())
+                ->update($cartUpdate);
+
+            return;
+        }
+
+        if ($cart->status !== Cart::STATUS_CHECKOUT) {
             return;
         }
 
         if (! $cart->trashed()) {
-            $cart->update(['status' => 'converted']);
+            $cart->update(['status' => Cart::STATUS_CONVERTED]);
             $cart->delete();
         }
     }
@@ -211,6 +212,17 @@ class ReleaseCheckoutService
 
     private function loadPurchase(Purchase $purchase): Purchase
     {
-        return $purchase->load(['items.imageAttachment']);
+        return $purchase->load(['items.imageAttachment', 'stockReservation']);
+    }
+
+    private function hasOverdueActiveReservation(Purchase $purchase): bool
+    {
+        /** @var StockReservation|null $reservation */
+        $reservation = $purchase->stockReservation()->lockForUpdate()->first();
+
+        return $reservation !== null
+            && $reservation->status === StockReservation::STATUS_ACTIVE
+            && $reservation->expires_at !== null
+            && ! $reservation->expires_at->isFuture();
     }
 }

app/Domains/Purchase/Services/Checkout/StartCheckoutService.php

@@ -4,6 +4,7 @@ namespace App\Domains\Purchase\Services\Checkout;
 
 use App\Domains\Cart\Models\Cart;
 use App\Domains\Cart\Models\CartItem;
+use App\Domains\Catalog\Exceptions\StockReservationExpiredException;
 use App\Domains\Catalog\Models\CatalogItem;
 use App\Domains\Catalog\Models\Variant;
 use App\Domains\Catalog\Services\CatalogInventoryService;
@@ -12,6 +13,7 @@ use App\Domains\Purchase\Exceptions\InsufficientStockException;
 use App\Domains\Purchase\Models\Purchase;
 use App\Domains\Purchase\Services\UserPurchaseLimitService;
 use App\Domains\Tenant\Models\Tenant;
+use Illuminate\Support\Carbon;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Validation\ValidationException;
@@ -204,7 +206,7 @@ class StartCheckoutService
             $cart->getKey(),
         );
         $cart->update(['current_purchase_id' => $purchase->getKey()]);
-        $this->reservations->attachToPurchase($cart, $purchase);
+        $this->reservations->attachToPurchase($cart, $purchase, $this->checkoutExpiration());
 
         $cartItems = $cart->items()->orderBy('id')->lockForUpdate()->get();
         $this->loadCartItems($cartItems);
@@ -270,7 +272,7 @@ class StartCheckoutService
             $cart->getKey(),
         );
         $cart->update(['current_purchase_id' => $purchase->getKey()]);
-        $this->reservations->attachToPurchase($cart, $purchase);
+        $this->reservations->attachToPurchase($cart, $purchase, $this->checkoutExpiration());
         $purchase->items()->createMany($this->snapshots->fromCartItems($cartItems));
 
         return $this->loadPurchase($purchase);
@@ -313,17 +315,9 @@ class StartCheckoutService
             Purchase::STATUS_CREATED,
             Purchase::STATUS_PENDING_PAYMENT,
         ], true)) {
+            $this->reservations->returnToCart($currentPurchase, $cart);
             $currentPurchase->update([
                 'status' => Purchase::STATUS_SUPERSEDED,
-                'expires_at' => null,
-            ]);
-            $this->reservations->releaseForPurchase(
-                $currentPurchase,
-                reason: StockReservationService::REASON_PURCHASE_SUPERSEDED,
-            );
-            $cart->update([
-                'current_purchase_id' => null,
-                'current_stock_reservation_id' => null,
             ]);
         }
 
@@ -336,7 +330,11 @@ class StartCheckoutService
             throw new NotFoundHttpException('Cart not found for tenant.');
         }
 
-        if ($cart->status !== 'active') {
+        if ($cart->status === Cart::STATUS_EXPIRED) {
+            throw new StockReservationExpiredException;
+        }
+
+        if ($cart->status !== Cart::STATUS_ACTIVE) {
             throw ValidationException::withMessages([
                 'cart_id' => __('api.purchase.inactive_cart'),
             ]);
@@ -410,13 +408,17 @@ class StartCheckoutService
             'user_id' => $userId,
             'status' => Purchase::STATUS_CREATED,
             'payment_method' => null,
-            'expires_at' => now()->addMinutes(
-                max(1, (int) config('purchase.checkout_expiration_minutes', 30)),
-            ),
             'total' => $total,
         ]);
     }
 
+    private function checkoutExpiration(): Carbon
+    {
+        return now()->addMinutes(
+            max(1, (int) config('purchase.checkout_expiration_minutes', 30)),
+        );
+    }
+
     /** @param Collection<int, CartItem> $cartItems */
     private function loadCartItems(Collection $cartItems): void
     {

app/Domains/Purchase/Services/CheckoutService.php

@@ -9,6 +9,7 @@ use App\Domains\Purchase\Services\Checkout\EditCheckoutService;
 use App\Domains\Purchase\Services\Checkout\ReleaseCheckoutService;
 use App\Domains\Purchase\Services\Checkout\StartCheckoutService;
 use App\Domains\Tenant\Models\Tenant;
+use Illuminate\Support\Carbon;
 use Illuminate\Support\Facades\DB;
 
 /**
@@ -78,13 +79,8 @@ class CheckoutService
         return $this->releaser->expire($purchase);
     }
 
-    public function expireOverduePurchases(): int
+    public function refreshReservationExpiration(Purchase $purchase, ?Carbon $expiresAt): void
     {
-        return $this->releaser->expireOverdue();
-    }
-
-    public function syncReservationExpiration(Purchase $purchase): void
-    {
-        $this->reservations->syncPurchaseExpiration($purchase);
+        $this->reservations->refreshForPurchase($purchase, $expiresAt);
     }
 }

app/Domains/Purchase/Services/PurchaseStateGuard.php

@@ -3,6 +3,7 @@
 namespace App\Domains\Purchase\Services;
 
 use App\Domains\Cart\Models\Cart;
+use App\Domains\Catalog\Models\StockReservation;
 use App\Domains\Purchase\Exceptions\PurchaseExpiredException;
 use App\Domains\Purchase\Models\Purchase;
 use Illuminate\Validation\ValidationException;
@@ -11,15 +12,32 @@ class PurchaseStateGuard
 {
     public function assertNotExpired(Purchase $purchase): void
     {
-        $hasExpiredStatus = $purchase->status === Purchase::STATUS_EXPIRED;
-        $hasExpiredByTime = in_array($purchase->status, [
+        if ($purchase->status === Purchase::STATUS_EXPIRED) {
+            throw new PurchaseExpiredException;
+        }
+
+        if (! in_array($purchase->status, [
             Purchase::STATUS_CREATED,
             Purchase::STATUS_PENDING_PAYMENT,
-        ], true)
-            && $purchase->expires_at !== null
-            && $purchase->expires_at->isPast();
+        ], true)) {
+            return;
+        }
 
-        if ($hasExpiredStatus || $hasExpiredByTime) {
+        /** @var StockReservation|null $reservation */
+        $reservation = $purchase->relationLoaded('stockReservation')
+            ? $purchase->getRelation('stockReservation')
+            : ($purchase->exists
+                ? $purchase->stockReservation()->first()
+                : null);
+
+        if ($reservation !== null && (
+            $reservation->status === StockReservation::STATUS_EXPIRED
+            || (
+                $reservation->status === StockReservation::STATUS_ACTIVE
+                && $reservation->expires_at !== null
+                && ! $reservation->expires_at->isFuture()
+            )
+        )) {
             throw new PurchaseExpiredException;
         }
     }

app/Domains/Purchase/documentacion/README.md

@@ -6,7 +6,7 @@ Implementa el ciclo de compra y checkout: crea la cabecera de compra desde un ca
 
 ## Modelo
 
-- `Purchase`: raíz de la compra; estados `created`, `pending_payment`, `in_review`, `paid`, `cancelled`, `rejected` y `expired`, y referencia la reserva que respaldó ese intento de checkout.
+- `Purchase`: raíz de la compra; estados `created`, `pending_payment`, `in_review`, `paid`, `cancelled`, `rejected` y `expired`, y referencia la reserva que respaldó ese intento de checkout. No guarda un vencimiento propio: expira como consecuencia del vencimiento de su reserva.
 - `PurchaseItem`: snapshot definitivo del producto o variante, creado recién al confirmar la compra.
 - `TelepagosQr` y `TelepagosPayment`: datos del QR e intentos/resultados del proveedor.
 - `PurchasePaid`: evento emitido una sola vez al pasar a pagada bajo bloqueo transaccional.
@@ -18,13 +18,13 @@ Implementa el ciclo de compra y checkout: crea la cabecera de compra desde un ca
 - `StartCheckoutService`: inicia la compra desde el carrito o crea un carrito técnico para compra directa, refresca el vencimiento de la reserva agregada y crea los snapshots `PurchaseItem`.
 - `EditCheckoutService`: modifica los datos del comprador antes del cierre.
 - `CompleteCheckoutService`: completa, envía a revisión o materializa los `PurchaseItem` al confirmar el pago.
-- `ReleaseCheckoutService`: cancela, vence y procesa vencimientos pendientes.
+- `ReleaseCheckoutService`: cancela o vence una compra y aplica sus efectos comerciales; el scanner unificado del dominio Catalog detecta las reservas pendientes de vencimiento.
 - `SourceCartService`: sincroniza o finaliza el carrito de checkout asociado a la compra.
 - `CatalogSelectionResolver` y `PurchaseItemSnapshotFactory`: resuelven selecciones y generan snapshots.
 
-Al informar una transferencia, la compra pasa de `pending_payment` a `in_review` y deja de vencer. Si el comprador abandona el checkout durante la revisión, la compra y sus reservas permanecen intactas y se crea un carrito activo nuevo para que pueda seguir comprando. Adminapp puede confirmar o anular explícitamente la compra en revisión.
+Al iniciar checkout o elegir un medio de pago se refresca directamente `StockReservation.expires_at`, que es la única fuente de verdad y se expone como `expires_at` en la respuesta pública de la compra. El refresco sólo se permite mientras la reserva siga vigente; una fecha vencida bloquea todas las mutaciones aun antes de que corra el scheduler. Al materializar la expiración, la compra pagable, su carrito y la reserva pasan a `expired` dentro de la misma transacción. Al cancelar o reemplazar una compra recuperable, ésta se desvincula y el carrito conserva la misma reserva activa. Al informar una transferencia, la compra pasa de `pending_payment` a `in_review` y ese vencimiento se limpia. Si el comprador abandona el checkout durante la revisión, la compra y sus reservas permanecen intactas y se crea un carrito activo nuevo para que pueda seguir comprando. Adminapp puede confirmar o anular explícitamente la compra en revisión.
 
-Las cantidades y variantes se editan mediante el dominio Cart. El endpoint autenticado `PATCH /checkout-carts/{cart}/items/{cartItem}` valida que el carrito pertenezca al usuario y a una compra editable. Cuando existe un cambio real, invalida atómicamente el intento de pago anterior, libera su reserva completa y crea otra para el contenido actualizado; Purchase no expone operaciones sobre líneas antes de la confirmación.
+Las cantidades y variantes se editan mediante el dominio Cart. El endpoint autenticado `PATCH /checkout-carts/{cart}/items/{cartItem}` valida que el carrito pertenezca al usuario y a una compra editable. Cuando existe un cambio real, invalida atómicamente el intento de pago anterior, devuelve la misma reserva activa al carrito y sincroniza sus líneas con el contenido actualizado; Purchase no expone operaciones sobre líneas antes de la confirmación.
 
 `UserPurchaseLimitService` controla límites de compra y `CheckoutService` conserva el punto de entrada para controladores e integraciones.
 

bootstrap/app.php

@@ -1,6 +1,7 @@
 <?php
 
 use App\Domains\Auth\Exceptions\AccountLockedException;
+use App\Domains\Catalog\Exceptions\StockReservationExpiredException;
 use App\Domains\Purchase\Exceptions\InsufficientStockException;
 use App\Domains\Purchase\Exceptions\PurchaseExpiredException;
 use App\Domains\Purchase\Exceptions\PurchaseLimitExceededException;
@@ -113,6 +114,16 @@ return Application::configure(basePath: dirname(__DIR__))
                 'message' => $exception->getMessage(),
             ], 422);
         });
+        $exceptions->render(function (StockReservationExpiredException $exception, Request $request) {
+            if (! $request->is('api/*')) {
+                return null;
+            }
+
+            return response()->json([
+                'code' => 'stock_reservation.expired',
+                'message' => $exception->getMessage(),
+            ], 422);
+        });
         $exceptions->render(function (ModelNotFoundException $exception, Request $request) {
             if (! $request->is('api/*')) {
                 return null;

database/migrations/2026_08_25_160000_make_stock_reservation_expiration_authoritative.php

@@ -0,0 +1,51 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    public function up(): void
+    {
+        DB::table('compras')
+            ->whereNotNull('stock_reservation_id')
+            ->orderBy('id')
+            ->chunkById(500, function ($purchases): void {
+                foreach ($purchases as $purchase) {
+                    DB::table('stock_reservations')
+                        ->where('id', $purchase->stock_reservation_id)
+                        ->where('status', 'active')
+                        ->update(['expires_at' => $purchase->expires_at]);
+                }
+            });
+
+        Schema::table('compras', function (Blueprint $table): void {
+            $table->dropIndex(['expires_at']);
+            $table->dropColumn('expires_at');
+        });
+    }
+
+    public function down(): void
+    {
+        Schema::table('compras', function (Blueprint $table): void {
+            $table->timestamp('expires_at')->nullable()->index()->after('payment_method');
+        });
+
+        DB::table('compras')
+            ->whereNotNull('stock_reservation_id')
+            ->orderBy('id')
+            ->chunkById(500, function ($purchases): void {
+                foreach ($purchases as $purchase) {
+                    DB::table('compras')
+                        ->where('id', $purchase->id)
+                        ->update([
+                            'expires_at' => DB::table('stock_reservations')
+                                ->where('id', $purchase->stock_reservation_id)
+                                ->value('expires_at'),
+                        ]);
+                }
+            });
+    }
+};

database/migrations/2026_08_25_170000_propagate_expired_stock_reservations.php

@@ -0,0 +1,30 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Support\Facades\DB;
+
+return new class extends Migration
+{
+    public function up(): void
+    {
+        $expiredReservationIds = fn ($query) => $query
+            ->select('id')
+            ->from('stock_reservations')
+            ->where('status', 'expired');
+
+        DB::table('compras')
+            ->whereIn('status', ['created', 'pending_payment'])
+            ->whereIn('stock_reservation_id', $expiredReservationIds)
+            ->update(['status' => 'expired']);
+
+        DB::table('carritos')
+            ->whereIn('status', ['active', 'checkout'])
+            ->whereIn('current_stock_reservation_id', $expiredReservationIds)
+            ->update(['status' => 'expired']);
+    }
+
+    public function down(): void
+    {
+        // Terminal business states cannot be reversed without inventing their prior state.
+    }
+};

lang/en/api.php

@@ -34,6 +34,7 @@ return [
         'bundle_variant_forbidden' => 'A bundle cannot have a variant.',
         'empty_bundle' => 'The bundle has no components.',
         'variant_required' => 'You must select a variant for this item.',
+        'reservation_expired' => 'The stock reservation has expired. Use the active cart to continue.',
     ],
     'purchase' => [
         'expired' => 'The purchase has expired. Please start a new purchase.',

lang/es/api.php

@@ -34,6 +34,7 @@ return [
         'bundle_variant_forbidden' => 'Un bundle no admite una variante.',
         'empty_bundle' => 'El bundle no tiene componentes.',
         'variant_required' => 'Debe seleccionar una variante para este ítem.',
+        'reservation_expired' => 'La reserva de stock venció. Usá el carrito activo para continuar.',
     ],
     'purchase' => [
         'expired' => "La compra venci\u{00F3}. Inici\u{00E1} una nueva compra.",

routes/console.php

@@ -16,6 +16,8 @@ Artisan::command('reservations:expire', function (): void {
 
     $this->info("Expired purchases: {$expired['purchases']}");
     $this->info("Expired cart reservations: {$expired['cart_reservations']}");
+    $this->info("Expired orphan reservations: {$expired['orphan_reservations']}");
+    $this->info("Failed reservations: {$expired['failed']}");
 })->purpose('Release expired stock reservations from purchases and abandoned carts');
 
 Schedule::command('reservations:expire')

tests/Feature/Cart/CartControllerTest.php

@@ -47,6 +47,7 @@ class CartControllerTest extends TestCase
         ]));
         $this->assertTrue(Schema::hasColumn('carritos', 'current_stock_reservation_id'));
         $this->assertTrue(Schema::hasColumn('compras', 'stock_reservation_id'));
+        $this->assertFalse(Schema::hasColumn('compras', 'expires_at'));
     }
 
     public function test_it_aggregates_shared_inventory_into_one_cart_reservation_line(): void
@@ -185,18 +186,22 @@ class CartControllerTest extends TestCase
         $this->travelBack();
     }
 
-    public function test_it_expires_abandoned_cart_reservations_without_deleting_the_cart(): void
+    public function test_it_expires_a_cart_reservation_and_automatically_replaces_the_cart(): void
     {
         config()->set('catalog.stock_reservation_expiration_minutes', 30);
         $tenant = $this->createTenant('acme');
+        $user = User::factory()->create();
         $item = $this->createDirectItem($tenant, 10, '49.90');
 
-        $response = $this->postJson('/api/tenants/acme/cart/items', [
+        $response = $this->actingAs($user, 'sanctum')
+            ->postJson('/api/tenants/acme/cart/items', [
                 'catalog_item_id' => $item->id,
                 'cantidad' => 2,
             ])->assertOk();
         $cartId = $response->json('data.id');
         $cartItemId = $response->json('data.items.0.id');
+        $cart = Cart::query()->findOrFail($cartId);
+        $reservationId = $cart->current_stock_reservation_id;
 
         $this->artisan('reservations:expire')
             ->expectsOutput('Expired purchases: 0')
@@ -218,11 +223,12 @@ class CartControllerTest extends TestCase
         $this->assertDatabaseHas('carrito_items', ['id' => $cartItemId]);
         $this->assertDatabaseHas('carritos', [
             'id' => $cartId,
-            'status' => 'active',
-            'current_stock_reservation_id' => null,
+            'status' => Cart::STATUS_EXPIRED,
+            'current_stock_reservation_id' => $reservationId,
             'deleted_at' => null,
         ]);
         $this->assertDatabaseHas('stock_reservations', [
+            'id' => $reservationId,
             'status' => 'expired',
             'expires_at' => null,
         ]);
@@ -231,6 +237,34 @@ class CartControllerTest extends TestCase
             'quantity' => 2,
         ]);
 
+        $currentCart = $this->getJson('/api/tenants/acme/cart')
+            ->assertOk()
+            ->assertJsonPath('data.status', Cart::STATUS_ACTIVE)
+            ->assertJsonPath('data.items', [])
+            ->assertJsonMissingPath('data.stock_reservation')
+            ->assertJsonMissingPath('data.current_stock_reservation_id');
+        $newCartId = $currentCart->json('data.id');
+
+        $this->assertNotSame($cartId, $newCartId);
+        $this->assertDatabaseHas('carritos', [
+            'id' => $cartId,
+            'status' => Cart::STATUS_ABANDONED,
+            'current_stock_reservation_id' => $reservationId,
+        ]);
+        $this->assertDatabaseHas('carritos', [
+            'id' => $newCartId,
+            'status' => Cart::STATUS_ACTIVE,
+            'current_stock_reservation_id' => null,
+        ]);
+
+        $this->postJson('/api/tenants/acme/cart/items', [
+            'catalog_item_id' => $item->id,
+            'cantidad' => 1,
+        ])
+            ->assertOk()
+            ->assertJsonPath('data.id', $newCartId)
+            ->assertJsonPath('data.items.0.cantidad', 1);
+
         $this->artisan('reservations:expire')
             ->expectsOutput('Expired purchases: 0')
             ->expectsOutput('Expired cart reservations: 0')
@@ -239,6 +273,88 @@ class CartControllerTest extends TestCase
         $this->travelBack();
     }
 
+    public function test_it_replaces_an_overdue_cart_before_the_expiration_job_runs(): void
+    {
+        config()->set('catalog.stock_reservation_expiration_minutes', 30);
+        $tenant = $this->createTenant('acme');
+        $user = User::factory()->create();
+        $item = $this->createDirectItem($tenant, 10, '49.90');
+
+        $original = $this->actingAs($user, 'sanctum')
+            ->postJson('/api/tenants/acme/cart/items', [
+                'catalog_item_id' => $item->id,
+                'cantidad' => 2,
+            ])->assertOk();
+        $originalCartId = $original->json('data.id');
+
+        $this->travel(31)->minutes();
+
+        $replacement = $this->postJson('/api/tenants/acme/cart/items', [
+            'catalog_item_id' => $item->id,
+            'cantidad' => 1,
+        ])
+            ->assertOk()
+            ->assertJsonPath('data.status', Cart::STATUS_ACTIVE)
+            ->assertJsonPath('data.items.0.cantidad', 1);
+
+        $this->assertNotSame($originalCartId, $replacement->json('data.id'));
+        $this->assertDatabaseHas('carritos', [
+            'id' => $originalCartId,
+            'status' => Cart::STATUS_ABANDONED,
+        ]);
+        $this->assertDatabaseHas('inventories', [
+            'id' => $item->inventory_id,
+            'reserved_stock' => 1,
+        ]);
+
+        $this->travelBack();
+    }
+
+    public function test_expired_cart_mutations_return_the_expiration_error_instead_of_not_found(): void
+    {
+        config()->set('catalog.stock_reservation_expiration_minutes', 30);
+        $tenant = $this->createTenant('acme');
+        $user = User::factory()->create();
+        [$item, $firstVariant] = $this->createVariantItem($tenant, 10, '49.90');
+        $secondInventory = Inventory::query()->create(['real_stock' => 10]);
+        $secondVariant = $item->variants()->create(['inventory_id' => $secondInventory->id]);
+
+        $cartItemId = $this->actingAs($user, 'sanctum')
+            ->postJson('/api/tenants/acme/cart/items', [
+                'catalog_item_id' => $item->id,
+                'variant_id' => $firstVariant->id,
+                'cantidad' => 2,
+            ])
+            ->assertOk()
+            ->json('data.items.0.id');
+
+        $this->travel(31)->minutes();
+
+        $expectedError = [
+            'code' => 'stock_reservation.expired',
+            'message' => __('api.cart.reservation_expired'),
+        ];
+
+        $this->patchJson("/api/tenants/acme/cart/items/{$cartItemId}", [
+            'cantidad' => 3,
+        ])
+            ->assertUnprocessable()
+            ->assertExactJson($expectedError);
+
+        $this->patchJson("/api/tenants/acme/cart/items/{$cartItemId}", [
+            'cantidad' => 2,
+            'variant_id' => $secondVariant->id,
+        ])
+            ->assertUnprocessable()
+            ->assertExactJson($expectedError);
+
+        $this->deleteJson("/api/tenants/acme/cart/items/{$cartItemId}")
+            ->assertUnprocessable()
+            ->assertExactJson($expectedError);
+
+        $this->travelBack();
+    }
+
     public function test_it_filters_item_images_when_the_tenant_disables_them(): void
     {
         $tenant = $this->createTenant('acme');

tests/Feature/Integration/TelepagosWebhookTest.php

@@ -62,6 +62,10 @@ class TelepagosWebhookTest extends TestCase
 
     public function test_transfer_payment_intent_persists_transfer_payer_dni_without_replacing_customer_dni(): void
     {
+        config()->set('purchase.payment_expiration_minutes.transfer', 60);
+        $now = now()->startOfSecond();
+        $this->travelTo($now);
+
         $tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
         $this->configureTelepagosIntegration($tenant);
         $user = User::factory()->create();
@@ -99,6 +103,13 @@ class TelepagosWebhookTest extends TestCase
             'payment_method' => 'transfer',
             'status' => Purchase::STATUS_PENDING_PAYMENT,
         ]);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $purchase->stock_reservation_id,
+            'status' => 'active',
+            'expires_at' => $now->copy()->addMinutes(60)->toDateTimeString(),
+        ]);
+
+        $this->travelBack();
     }
 
     public function test_transfer_webhook_matches_pending_purchase_by_dni_and_total_amount(): void

tests/Feature/Purchase/StorePurchaseTest.php

@@ -71,6 +71,43 @@ class StorePurchaseTest extends TestCase
         $this->travelBack();
     }
 
+    public function test_checkout_cannot_replace_an_overdue_cart_reservation(): void
+    {
+        $tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
+        $user = User::factory()->create();
+        $variant = $this->createVariantForTenant('sonder', 10, '50.00');
+        $cart = Cart::query()->create([
+            'tenant_codigo' => $tenant->codigo,
+            'user_id' => $user->id,
+            'status' => 'active',
+        ]);
+        $cart->addItem($variant->catalog_item_id, $variant->id, 2);
+        $reservationId = $cart->fresh()->current_stock_reservation_id;
+        $expiredAt = now()->subMinute()->startOfSecond();
+        $cart->currentStockReservation()->update(['expires_at' => $expiredAt]);
+
+        $this->actingAs($user, 'sanctum')
+            ->postJson('/api/tenants/sonder/compras/start-checkout', [
+                'cart_id' => $cart->id,
+            ])
+            ->assertUnprocessable()
+            ->assertExactJson([
+                'code' => 'stock_reservation.expired',
+                'message' => __('api.cart.reservation_expired'),
+            ]);
+
+        $this->assertDatabaseCount('compras', 0);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $reservationId,
+            'status' => 'active',
+            'expires_at' => $expiredAt->toDateTimeString(),
+        ]);
+        $this->assertDatabaseHas('carritos', [
+            'id' => $cart->id,
+            'current_stock_reservation_id' => $reservationId,
+        ]);
+    }
+
     public function test_it_starts_checkout_from_cart_with_purchase_item_snapshots(): void
     {
         $tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
@@ -480,6 +517,7 @@ class StorePurchaseTest extends TestCase
         $user = User::factory()->create();
         $variant = $this->createVariantForTenant('sonder', 10, '50.00');
         $purchase = $this->createCheckoutPurchase($user, 'sonder', $variant, 3);
+        $reservationId = $purchase->stock_reservation_id;
         $activeCart = Cart::query()
             ->where('user_id', $user->id)
             ->where('status', 'active')
@@ -513,7 +551,11 @@ class StorePurchaseTest extends TestCase
             'reserved_stock' => 3,
         ]);
         $activeCart->refresh();
-        $this->assertNotNull($activeCart->current_stock_reservation_id);
+        $this->assertSame($reservationId, $activeCart->current_stock_reservation_id);
+        $this->assertDatabaseHas('compras', [
+            'id' => $purchase->id,
+            'stock_reservation_id' => null,
+        ]);
         $this->assertDatabaseHas('stock_reservations', [
             'id' => $activeCart->current_stock_reservation_id,
             'status' => 'active',
@@ -526,7 +568,7 @@ class StorePurchaseTest extends TestCase
         $this->assertSame(1, $activeCart->items()->count());
     }
 
-    public function test_it_reassigns_a_terminal_purchase_reservation_and_rejects_a_late_confirmation(): void
+    public function test_it_reuses_the_cart_reservation_for_a_new_checkout_and_rejects_a_late_confirmation(): void
     {
         $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
         $user = User::factory()->create();
@@ -538,7 +580,6 @@ class StorePurchaseTest extends TestCase
         $previousPurchase->update([
             'status' => Purchase::STATUS_PENDING_PAYMENT,
             'payment_method' => 'transfer',
-            'expires_at' => now()->addMinutes(30),
         ]);
 
         $currentPurchase = app(CheckoutService::class)->startCheckout(
@@ -550,17 +591,20 @@ class StorePurchaseTest extends TestCase
         $this->assertDatabaseHas('compras', [
             'id' => $previousPurchase->id,
             'status' => Purchase::STATUS_SUPERSEDED,
-            'expires_at' => null,
         ]);
         $this->assertDatabaseHas('carritos', [
             'id' => $cart->id,
             'current_purchase_id' => $currentPurchase->id,
         ]);
-        $this->assertNotSame($previousReservationId, $currentPurchase->stock_reservation_id);
+        $this->assertSame($previousReservationId, $currentPurchase->stock_reservation_id);
+        $this->assertDatabaseHas('compras', [
+            'id' => $previousPurchase->id,
+            'stock_reservation_id' => null,
+        ]);
         $this->assertDatabaseHas('stock_reservations', [
             'id' => $previousReservationId,
-            'status' => 'released',
-            'release_reason' => 'purchase_superseded',
+            'status' => 'active',
+            'release_reason' => null,
         ]);
         $this->assertPurchaseReservation($currentPurchase->id, $variant->inventory_id, 2, 'active');
 
@@ -606,7 +650,7 @@ class StorePurchaseTest extends TestCase
         ]);
         $this->assertDatabaseHas('stock_reservations', [
             'status' => 'released',
-            'release_reason' => 'purchase_superseded',
+            'release_reason' => 'cart_empty',
         ]);
         $this->assertDatabaseHas('stock_reservation_lines', [
             'inventory_id' => $variant->inventory_id,
@@ -624,7 +668,7 @@ class StorePurchaseTest extends TestCase
         $this->assertSame(3, $remaining);
     }
 
-    public function test_it_expires_the_purchase_without_mutating_the_active_cart(): void
+    public function test_it_expires_the_purchase_and_preserves_the_expired_cart_items(): void
     {
         $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
         $user = User::factory()->create();
@@ -635,7 +679,7 @@ class StorePurchaseTest extends TestCase
             ->where('status', 'active')
             ->firstOrFail();
         $cartItemId = $purchase->cart->items()->firstOrFail()->id;
-        $purchase->update(['expires_at' => now()->subMinute()]);
+        $purchase->stockReservation()->update(['expires_at' => now()->subMinute()]);
 
         $this->artisan('reservations:expire')->assertSuccessful();
 
@@ -650,12 +694,55 @@ class StorePurchaseTest extends TestCase
         $this->assertDatabaseHas('carritos', [
             'id' => $activeCart->id,
             'user_id' => $user->id,
-            'status' => 'active',
+            'status' => Cart::STATUS_EXPIRED,
             'current_purchase_id' => null,
+            'current_stock_reservation_id' => $purchase->stock_reservation_id,
             'deleted_at' => null,
         ]);
         $this->assertPurchaseReservation($purchase->id, $variant->inventory_id, 3, 'expired');
         $this->assertSame(1, $activeCart->items()->count());
+
+        $this->actingAs($user, 'sanctum')
+            ->postJson('/api/tenants/sonder/compras/start-checkout', [
+                'cart_id' => $activeCart->id,
+            ])
+            ->assertUnprocessable()
+            ->assertExactJson([
+                'code' => 'stock_reservation.expired',
+                'message' => __('api.cart.reservation_expired'),
+            ]);
+
+        $this->actingAs($user, 'sanctum')
+            ->postJson("/api/tenants/sonder/compras/{$purchase->id}/cancel")
+            ->assertUnprocessable()
+            ->assertJsonPath('code', 'purchase.expired');
+    }
+
+    public function test_an_overdue_purchase_cannot_be_cancelled_before_the_expiration_job_runs(): void
+    {
+        $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
+        $user = User::factory()->create();
+        $variant = $this->createVariantForTenant('sonder', 10, '50.00');
+        $purchase = $this->createCheckoutPurchase($user, 'sonder', $variant, 1);
+        $purchase->stockReservation()->update(['expires_at' => now()->subMinute()]);
+
+        $this->actingAs($user, 'sanctum')
+            ->postJson("/api/tenants/sonder/compras/{$purchase->id}/cancel")
+            ->assertUnprocessable()
+            ->assertExactJson([
+                'code' => 'stock_reservation.expired',
+                'message' => __('api.cart.reservation_expired'),
+            ]);
+
+        $this->assertDatabaseHas('compras', [
+            'id' => $purchase->id,
+            'status' => Purchase::STATUS_CREATED,
+            'stock_reservation_id' => $purchase->stock_reservation_id,
+        ]);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $purchase->stock_reservation_id,
+            'status' => 'active',
+        ]);
     }
 
     public function test_it_keeps_cart_items_during_checkout_and_updates_customer_data(): void
@@ -860,7 +947,6 @@ class StorePurchaseTest extends TestCase
         $purchase->update([
             'payment_method' => 'transfer',
             'status' => Purchase::STATUS_PENDING_PAYMENT,
-            'expires_at' => now()->addMinutes(30),
         ]);
 
         $url = "/api/tenants/sonder/compras/{$purchase->id}/review";
@@ -874,6 +960,10 @@ class StorePurchaseTest extends TestCase
         $this->assertDatabaseHas('compras', [
             'id' => $purchase->id,
             'status' => Purchase::STATUS_IN_REVIEW,
+        ]);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $purchase->stock_reservation_id,
+            'status' => 'active',
             'expires_at' => null,
         ]);
 
@@ -945,7 +1035,7 @@ class StorePurchaseTest extends TestCase
         ]);
     }
 
-    public function test_it_expires_an_abandoned_purchase_without_mutating_its_active_cart(): void
+    public function test_it_expires_a_purchase_and_its_associated_cart(): void
     {
         $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
         $user = User::factory()->create();
@@ -956,7 +1046,7 @@ class StorePurchaseTest extends TestCase
             ->where('status', 'active')
             ->firstOrFail();
 
-        $this->assertNotNull($purchase->expires_at);
+        $this->assertNotNull($purchase->stockReservation->expires_at);
         $this->assertDatabaseHas('inventories', [
             'id' => $variant->inventory_id,
             'reserved_stock' => 3,
@@ -987,7 +1077,9 @@ class StorePurchaseTest extends TestCase
         $this->assertDatabaseHas('carritos', [
             'id' => $activeCart->id,
             'user_id' => $user->id,
-            'status' => 'active',
+            'status' => Cart::STATUS_EXPIRED,
+            'current_purchase_id' => null,
+            'current_stock_reservation_id' => $purchase->stock_reservation_id,
             'deleted_at' => null,
         ]);
         $this->assertSame(1, $activeCart->items()->count());

tests/Unit/Catalog/ExpireStockReservationsServiceTest.php

@@ -2,77 +2,102 @@
 
 namespace Tests\Unit\Catalog;
 
-use App\Domains\Cart\Services\ExpireCartReservationsService;
+use App\Domains\Catalog\Models\Inventory;
+use App\Domains\Catalog\Models\StockReservation;
+use App\Domains\Catalog\Models\StockReservationLine;
 use App\Domains\Catalog\Services\ExpireStockReservationsService;
-use App\Domains\Purchase\Services\CheckoutService;
-use Illuminate\Support\Facades\Log;
-use Psr\Log\LoggerInterface;
+use App\Domains\Catalog\Services\StockReservationService;
+use App\Domains\Purchase\Services\Checkout\ReleaseCheckoutService;
+use Illuminate\Foundation\Testing\RefreshDatabase;
 use RuntimeException;
 use Tests\TestCase;
 
 class ExpireStockReservationsServiceTest extends TestCase
 {
-    public function test_it_expires_purchases_before_abandoned_cart_reservations(): void
+    use RefreshDatabase;
+
+    public function test_it_expires_an_orphan_reservation_and_releases_its_inventory(): void
     {
-        $checkout = \Mockery::mock(CheckoutService::class);
-        $checkout->shouldReceive('expireOverduePurchases')
-            ->once()
-            ->ordered()
-            ->andReturn(2);
-
-        $carts = \Mockery::mock(ExpireCartReservationsService::class);
-        $carts->shouldReceive('expireOverdue')
-            ->once()
-            ->ordered()
-            ->andReturn(3);
-
-        $logger = \Mockery::mock(LoggerInterface::class);
-        Log::shouldReceive('channel')
-            ->once()
-            ->with('commands')
-            ->andReturn($logger);
-        $logger->shouldReceive('info')
-            ->once()
-            ->with('Stock reservation cleanup completed.', [
-                'command' => 'reservations:expire',
-                'expired_purchases' => 2,
-                'expired_cart_reservations' => 3,
-                'total_expired' => 5,
+        $inventory = Inventory::query()->create([
+            'real_stock' => 10,
+            'reserved_stock' => 2,
+        ]);
+        $reservation = StockReservation::query()->create([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinute(),
+        ]);
+        StockReservationLine::query()->create([
+            'stock_reservation_id' => $reservation->id,
+            'inventory_id' => $inventory->id,
+            'quantity' => 2,
+            'tracks_inventory' => true,
         ]);
 
-        $result = (new ExpireStockReservationsService($checkout, $carts))->expireOverdue();
+        $result = app(ExpireStockReservationsService::class)->expireOverdue();
 
         $this->assertSame([
-            'purchases' => 2,
-            'cart_reservations' => 3,
+            'purchases' => 0,
+            'cart_reservations' => 0,
+            'orphan_reservations' => 1,
+            'failed' => 0,
         ], $result);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $reservation->id,
+            'status' => StockReservation::STATUS_EXPIRED,
+            'expires_at' => null,
+        ]);
+        $this->assertDatabaseHas('inventories', [
+            'id' => $inventory->id,
+            'reserved_stock' => 0,
+        ]);
     }
 
-    public function test_it_logs_failed_cleanup_attempts_and_rethrows_the_error(): void
+    public function test_one_failed_reservation_does_not_stop_the_remaining_batch(): void
     {
-        $exception = new RuntimeException('Unable to clean carts.');
-        $checkout = \Mockery::mock(CheckoutService::class);
-        $checkout->shouldReceive('expireOverduePurchases')->once()->andReturn(2);
-
-        $carts = \Mockery::mock(ExpireCartReservationsService::class);
-        $carts->shouldReceive('expireOverdue')->once()->andThrow($exception);
-
-        $logger = \Mockery::mock(LoggerInterface::class);
-        Log::shouldReceive('channel')
-            ->once()
-            ->with('commands')
-            ->andReturn($logger);
-        $logger->shouldReceive('error')
-            ->once()
-            ->with('Stock reservation cleanup failed.', [
-                'command' => 'reservations:expire',
-                'expired_purchases' => 2,
-                'expired_cart_reservations' => null,
-                'exception' => $exception,
+        $first = StockReservation::query()->create([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinutes(2),
+        ]);
+        $second = StockReservation::query()->create([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinute(),
         ]);
 
-        $this->expectExceptionObject($exception);
+        $reservations = \Mockery::mock(StockReservationService::class);
+        $reservations->shouldReceive('expire')
+            ->twice()
+            ->andReturnUsing(function (StockReservation $reservation) use ($first): void {
+                if ($reservation->is($first)) {
+                    throw new RuntimeException('Broken reservation.');
+                }
 
-        (new ExpireStockReservationsService($checkout, $carts))->expireOverdue();
+                $reservation->update([
+                    'status' => StockReservation::STATUS_EXPIRED,
+                    'expires_at' => null,
+                    'expired_at' => now(),
+                ]);
+            });
+
+        $service = new ExpireStockReservationsService(
+            \Mockery::mock(ReleaseCheckoutService::class),
+            $reservations,
+        );
+
+        $result = $service->expireOverdue();
+
+        $this->assertSame([
+            'purchases' => 0,
+            'cart_reservations' => 0,
+            'orphan_reservations' => 1,
+            'failed' => 1,
+        ], $result);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $first->id,
+            'status' => StockReservation::STATUS_ACTIVE,
+        ]);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $second->id,
+            'status' => StockReservation::STATUS_EXPIRED,
+        ]);
     }
 }

tests/Unit/Purchase/PurchaseStateGuardTest.php

@@ -2,6 +2,7 @@
 
 namespace Tests\Unit\Purchase;
 
+use App\Domains\Catalog\Models\StockReservation;
 use App\Domains\Purchase\Exceptions\PurchaseExpiredException;
 use App\Domains\Purchase\Models\Purchase;
 use App\Domains\Purchase\Services\PurchaseStateGuard;
@@ -22,7 +23,6 @@ class PurchaseStateGuardTest extends TestCase
     {
         $purchase = (new Purchase)->forceFill([
             'status' => Purchase::STATUS_EXPIRED,
-            'expires_at' => null,
         ]);
 
         $this->expectException(PurchaseExpiredException::class);
@@ -34,8 +34,11 @@ class PurchaseStateGuardTest extends TestCase
     {
         $purchase = (new Purchase)->forceFill([
             'status' => Purchase::STATUS_PENDING_PAYMENT,
-            'expires_at' => now()->subMinute(),
         ]);
+        $purchase->setRelation('stockReservation', (new StockReservation)->forceFill([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinute(),
+        ]));
 
         $this->expectException(PurchaseExpiredException::class);
 
@@ -46,8 +49,11 @@ class PurchaseStateGuardTest extends TestCase
     {
         $purchase = (new Purchase)->forceFill([
             'status' => Purchase::STATUS_PAID,
-            'expires_at' => now()->subMinute(),
         ]);
+        $purchase->setRelation('stockReservation', (new StockReservation)->forceFill([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinute(),
+        ]));
 
         $this->guard->assertNotExpired($purchase);