feat: enhance product detail retrieval to support variant selection and fallback image handling

app/Domains/Catalog/Controllers/ProductVariantController.php

@@ -41,7 +41,11 @@ class ProductVariantController extends Controller
         $producto = $this->resolveScopedProduct($tenant, $producto);
         $productVariant = $this->resolveScopedVariant($producto, $productVariant);
 
-        return ProductVariantResource::make($productVariant->load(['product', 'definitions.productAttribute.attribute.options', 'attachments']));
+        return ProductVariantResource::make($productVariant->load([
+            'attachments' => fn ($query) => $query->orderBy('attachments.id'),
+            'definitions.productAttribute.attribute.options',
+            'product.attachments' => fn ($query) => $query->orderBy('attachments.id'),
+        ]));
     }
 
     public function update(UpdateProductVariantRequest $request, Tenant $tenant, Product $producto, ProductVariant $productVariant, ProductService $productService): ProductVariantResource

app/Domains/Catalog/Resources/ProductResource.php

@@ -2,11 +2,12 @@
 
 namespace App\Domains\Catalog\Resources;
 
+use App\Domains\Catalog\Models\Product;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;
 
 /**
- * @mixin \App\Domains\Catalog\Models\Product
+ * @mixin Product
  */
 class ProductResource extends JsonResource
 {
@@ -23,15 +24,26 @@ class ProductResource extends JsonResource
             'nombre' => $this->nombre,
             'descripcion' => $this->descripcion,
             'precio' => $this->precio,
-            'category' => $this->whenLoaded('category', fn () =>  $this->category?->nombre),
+            'category' => $this->whenLoaded('category', fn () => $this->category?->nombre),
             'brand' => $this->whenLoaded('brand', fn () => $this->brand?->nombre),
-            'images' => $this->whenLoaded('attachments', fn () =>
-                $this->attachments
-                    ->map(fn ($attachment) => $attachment->getTemporaryUrl(1440))
-                    ->values()
+            'images' => $this->whenLoaded('attachments', fn () => $this->attachments
+                ->map(fn ($attachment) => $attachment->getTemporaryUrl(1440))
+                ->values()
             ),
             'attributes' => AttributeResource::collection($this->whenLoaded('attributes')),
-            'variants' => ProductVariantResource::collection($this->whenLoaded('variants')),
+            'variants_map' => $this->whenLoaded('variants', fn () => $this->variants
+                ->map(fn ($variant) => [
+                    'variant_id' => $variant->id,
+                    'stock' => $variant->stock,
+                    'attributes' => $variant->definitions
+                        ->mapWithKeys(fn ($definition) => [
+                            $definition->productAttribute?->attribute?->codigo => $definition->value,
+                        ])
+                        ->filter(fn ($value, $key) => $key !== null)
+                        ->toArray(),
+                ])
+                ->values()
+            ),
             'variant' => $this->when(
                 $this->getSelectedVariant() !== null,
                 fn () => ProductVariantResource::make($this->getSelectedVariant())

app/Domains/Catalog/Resources/ProductVariantResource.php

@@ -2,11 +2,12 @@
 
 namespace App\Domains\Catalog\Resources;
 
+use App\Domains\Catalog\Models\ProductVariant;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;
 
 /**
- * @mixin \App\Domains\Catalog\Models\ProductVariant
+ * @mixin ProductVariant
  */
 class ProductVariantResource extends JsonResource
 {
@@ -35,13 +36,19 @@ class ProductVariantResource extends JsonResource
                         ->values();
                 }
 
-                // Fallback: use product-level attachments when the variant has none
-                $this->loadMissing('product.attachments');
+                if ($this->relationLoaded('fallbackAttachments')) {
+                    return $this->fallbackAttachments
+                        ->map(fn ($attachment) => $attachment->getTemporaryUrl(1440))
+                        ->values();
+                }
 
-                return $this->product?->attachments
-                    ?->map(fn ($attachment) => $attachment->getTemporaryUrl(1440))
-                    ?->values()
-                    ?? collect();
+                if ($this->relationLoaded('product') && $this->product?->relationLoaded('attachments')) {
+                    return $this->product->attachments
+                        ->map(fn ($attachment) => $attachment->getTemporaryUrl(1440))
+                        ->values();
+                }
+
+                return collect();
             }),
         ];
     }

app/Domains/Catalog/Services/ProductService.php

@@ -7,16 +7,19 @@ use App\Domains\Catalog\Models\Attribute;
 use App\Domains\Catalog\Models\Product;
 use App\Domains\Catalog\Models\ProductVariant;
 use App\Domains\Tenant\Models\Tenant;
+use Illuminate\Contracts\Pagination\LengthAwarePaginator;
 use Illuminate\Http\UploadedFile;
 use Illuminate\Support\Facades\DB;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 class ProductService
 {
     public function __construct(protected AttachmentService $attachmentService) {}
+
     /**
      * Create a product.
      *
-     * @param array<string, mixed> $data
+     * @param  array<string, mixed>  $data
      */
     public function create(Tenant $tenant, array $data): Product
     {
@@ -44,7 +47,7 @@ class ProductService
     /**
      * Update a product.
      *
-     * @param array<string, mixed> $data
+     * @param  array<string, mixed>  $data
      */
     public function update(Product $product, array $data): Product
     {
@@ -98,7 +101,7 @@ class ProductService
     /**
      * Create a product variant.
      *
-     * @param array<string, mixed> $data
+     * @param  array<string, mixed>  $data
      */
     public function createVariant(Product $product, array $data): ProductVariant
     {
@@ -119,7 +122,7 @@ class ProductService
     /**
      * Update a product variant.
      *
-     * @param array<string, mixed> $data
+     * @param  array<string, mixed>  $data
      */
     public function updateVariant(ProductVariant $variant, array $data): ProductVariant
     {
@@ -156,7 +159,7 @@ class ProductService
     /**
      * Create an attribute.
      *
-     * @param array<string, mixed> $data
+     * @param  array<string, mixed>  $data
      */
     public static function createAttribute(Tenant $tenant, array $data): Attribute
     {
@@ -168,7 +171,7 @@ class ProductService
     /**
      * Update an attribute.
      *
-     * @param array<string, mixed> $data
+     * @param  array<string, mixed>  $data
      */
     public static function updateAttribute(Attribute $attribute, array $data): Attribute
     {
@@ -183,7 +186,7 @@ class ProductService
      * When called on update, the existing attachments are detached first so the
      * final set always matches exactly what was sent in the request.
      *
-     * @param array<int, UploadedFile|string> $images
+     * @param  array<int, UploadedFile|string>  $images
      */
     protected function syncVariantImages(ProductVariant $variant, array $images): void
     {
@@ -204,7 +207,7 @@ class ProductService
      *
      * Same logic as syncVariantImages but for products without variants.
      *
-     * @param array<int, UploadedFile|string> $images
+     * @param  array<int, UploadedFile|string>  $images
      */
     protected function syncProductImages(Product $product, array $images): void
     {
@@ -248,7 +251,7 @@ class ProductService
     /**
      * Get products for a tenant with resolved first image (with fallback to first variant's first image).
      */
-    public function getProductos(Tenant $tenant): \Illuminate\Contracts\Pagination\LengthAwarePaginator
+    public function getProductos(Tenant $tenant): LengthAwarePaginator
     {
         $products = Product::query()
             ->where('tenant_codigo', $tenant->codigo)
@@ -282,33 +285,29 @@ class ProductService
     public function getProductDetail(Tenant $tenant, Product $product, ?int $variantId = null): Product
     {
         $product->load([
-            'attachments',
+            'attachments' => fn ($query) => $query->orderBy('attachments.id'),
+            'attributes.options',
             'brand',
             'category',
-            'attributes.options',
+            'variants' => fn ($query) => $query->orderBy('id'),
             'variants.definitions.productAttribute.attribute.options',
         ]);
 
-        $selectedVariantQuery = $product->variants()
-            ->with([
-                'attachments',
-                'definitions.productAttribute.attribute.options',
-            ]);
-
         $selectedVariant = $variantId !== null
-            ? $selectedVariantQuery->whereKey($variantId)->first()
-            : null;
+            ? $product->variants->firstWhere('id', $variantId)
+            : $product->variants->first(fn (ProductVariant $variant) => $variant->stock > 0);
 
-        if ($selectedVariant === null) {
-            $selectedVariant = $product->variants()
-                ->with([
-                    'attachments',
-                    'definitions.productAttribute.attribute.options',
-                ])
-                ->first();
+        if ($variantId !== null && $selectedVariant === null) {
+            throw new NotFoundHttpException('Product variant not found for product.');
         }
 
-        if ($selectedVariant) {
+        $selectedVariant ??= $product->variants->first();
+
+        if ($selectedVariant !== null) {
+            $selectedVariant->load([
+                'attachments' => fn ($query) => $query->orderBy('attachments.id'),
+            ]);
+            $selectedVariant->setRelation('fallbackAttachments', $product->attachments);
             $product->setSelectedVariant($selectedVariant);
         }
 

database/migrations/2026_06_29_102114_refactor_product_attributes_table.php

@@ -38,6 +38,10 @@ return new class extends Migration
         });
 
         // 4. Point variant values to the product-attribute pivot instead of the base attribute
+        Schema::table('productos_variantes_values', function (Blueprint $table) {
+            $table->index('producto_variante_id', 'prod_var_values_variant_id_index');
+        });
+
         Schema::table('productos_variantes_values', function (Blueprint $table) {
             $table->dropForeign('productos_variantes_definiciones_attribute_id_foreign');
             $table->dropUnique('prod_var_def_variant_attr_unique');
@@ -85,6 +89,10 @@ return new class extends Migration
             $table->unique(['producto_variante_id', 'attribute_id'], 'prod_var_def_variant_attr_unique');
         });
 
+        Schema::table('productos_variantes_values', function (Blueprint $table) {
+            $table->dropIndex('prod_var_values_variant_id_index');
+        });
+
         Schema::dropIfExists('products_attributes');
         Schema::rename('productos_variantes_values', 'productos_variantes_definiciones');
         Schema::rename('attribute', 'productos_attributes');

tests/Feature/Catalog/ProductControllerTest.php

@@ -2,8 +2,11 @@
 
 namespace Tests\Feature\Catalog;
 
+use App\Domains\Attachable\Enums\AttachmentType;
+use App\Domains\Attachable\Models\Attachment;
 use App\Domains\Catalog\Models\Attribute;
 use App\Domains\Catalog\Models\Product;
+use App\Domains\Catalog\Models\ProductAttribute;
 use App\Domains\Catalog\Models\ProductVariant;
 use App\Domains\Tenant\Models\Tenant;
 use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -15,8 +18,11 @@ class ProductControllerTest extends TestCase
     use RefreshDatabase;
 
     private Tenant $tenant;
+
     private Attribute $sizeAttr;
+
     private Attribute $colorAttr;
+
     private Attribute $extraAttr;
 
     protected function setUp(): void
@@ -358,7 +364,7 @@ class ProductControllerTest extends TestCase
             'options' => [
                 ['value' => 'P', 'label' => 'Piqueno'],
                 ['value' => 'M', 'label' => 'Medio'],
-            ]
+            ],
         ]);
 
         // 2. Create product and associate attribute
@@ -384,14 +390,13 @@ class ProductControllerTest extends TestCase
                 [
                     'attribute_id' => $selectAttr->id,
                     'value' => 'G', // Invalid value
-                ]
-            ]
+                ],
+            ],
         ]);
     }
 
-    public function test_it_returns_product_detail_with_variants_and_selected_variant_resource(): void
+    public function test_it_returns_product_detail_with_variant_mapping_and_default_selected_variant(): void
     {
-        // 1. Create a product
         $product = Product::create([
             'tenant_codigo' => $this->tenant->codigo,
             'categoria_id' => 1,
@@ -399,73 +404,202 @@ class ProductControllerTest extends TestCase
             'nombre' => 'Test Product Show',
             'precio' => 100.00,
         ]);
+        $productAttributes = $this->syncVariantAttributes($product);
 
-        // Associate attributes to product
-        $product->attributes()->sync([$this->sizeAttr->id, $this->colorAttr->id]);
-
-        // 2. Create variant
         $variant = $product->createVariant([
-            'slug' => 'test-product-show-s-azul',
-            'nombre' => 'Test Product Show S Azul',
-            'stock' => 10,
-            'precio' => 105.00,
+            'stock' => 0,
             'definitions' => [
                 [
-                    'attribute_id' => $this->sizeAttr->id,
+                    'products_attribute_id' => $productAttributes['size']->id,
                     'value' => 'S',
                 ],
                 [
-                    'attribute_id' => $this->colorAttr->id,
+                    'products_attribute_id' => $productAttributes['color']->id,
                     'value' => 'Azul',
                 ],
             ],
         ]);
 
-        // Attach an image to the variant
-        $attachment = \App\Domains\Attachable\Models\Attachment::create([
-            'key' => (string) Str::uuid(),
-            'path' => 'attachments/variant-img.png',
-            'filename' => 'variant-img.png',
-            'type' => \App\Domains\Attachable\Enums\AttachmentType::Image,
-            'mime_type' => 'image/png',
+        $secondVariant = $product->createVariant([
+            'stock' => 4,
+            'definitions' => [
+                [
+                    'products_attribute_id' => $productAttributes['size']->id,
+                    'value' => '38',
+                ],
+                [
+                    'products_attribute_id' => $productAttributes['color']->id,
+                    'value' => 'Rojo',
+                ],
+            ],
         ]);
-        $variant->attachments()->attach($attachment->id);
+        $variantAttachment = $this->createAttachment('attachments/selected-variant.png');
+        $secondVariant->attachments()->attach($variantAttachment->id);
 
-        // 3. Request product show detail
         $response = $this->getJson("/api/tenants/{$this->tenant->codigo}/productos/{$product->id}");
 
         $response->assertOk();
-
-        // 4. Assert selected variant resource structure and data
         $response->assertJsonStructure([
             'data' => [
                 'id',
                 'nombre',
-                'variant' => [
-                    'id',
-                    'producto_id',
-                    'stock',
-                    'images',
-                    'definitions' => [
-                        '*' => [
-                            'id',
-                            'producto_variante_id',
-                            'products_attribute_id',
-                            'attribute_id',
-                            'value',
-                            'attribute',
-                            'metadata',
+                'attributes',
+                'variants_map' => [
+                    '*' => [
+                        'variant_id',
+                        'stock',
+                        'attributes' => [
+                            'talle',
+                            'color',
                         ],
                     ],
                 ],
+                'variant' => [
+                    'id',
+                    'stock',
+                    'definitions',
+                    'images',
+                ],
             ],
         ]);
 
-        $response->assertJsonPath('data.variant.id', $variant->id);
-        $response->assertJsonPath('data.variant.producto_id', $product->id);
-        $response->assertJsonPath('data.variant.stock', 10);
+        $response->assertJsonMissingPath('data.variants');
+        $response->assertJsonPath('data.variants_map.0.variant_id', $variant->id);
+        $response->assertJsonPath('data.variants_map.0.stock', 0);
+        $response->assertJsonPath('data.variants_map.0.attributes.talle', 'S');
+        $response->assertJsonPath('data.variants_map.0.attributes.color', 'Azul');
+        $response->assertJsonPath('data.variants_map.1.variant_id', $secondVariant->id);
+        $response->assertJsonPath('data.variants_map.1.stock', 4);
+        $response->assertJsonPath('data.variants_map.1.attributes.talle', '38');
+        $response->assertJsonPath('data.variants_map.1.attributes.color', 'Rojo');
+        $response->assertJsonCount(2, 'data.variants_map');
+        $response->assertJsonPath('data.variant.id', $secondVariant->id);
+        $response->assertJsonPath('data.variant.stock', 4);
+        $response->assertJsonPath('data.variant.definitions.talle', '38');
+        $response->assertJsonPath('data.variant.definitions.color', 'Rojo');
         $response->assertJsonCount(1, 'data.variant.images');
-        $response->assertJsonCount(2, 'data.variant.definitions');
+        $this->assertStringContainsString($variantAttachment->path, $response->json('data.variant.images.0'));
+    }
+
+    public function test_it_returns_requested_variant_in_product_detail(): void
+    {
+        $product = Product::create([
+            'tenant_codigo' => $this->tenant->codigo,
+            'categoria_id' => 1,
+            'slug' => 'test-product-requested-variant',
+            'nombre' => 'Test Product Requested Variant',
+            'precio' => 100.00,
+        ]);
+        $productAttributes = $this->syncVariantAttributes($product);
+
+        $firstVariant = $product->createVariant([
+            'stock' => 5,
+            'definitions' => [
+                [
+                    'products_attribute_id' => $productAttributes['size']->id,
+                    'value' => 'S',
+                ],
+            ],
+        ]);
+        $secondVariant = $product->createVariant([
+            'stock' => 7,
+            'definitions' => [
+                [
+                    'products_attribute_id' => $productAttributes['size']->id,
+                    'value' => '38',
+                ],
+            ],
+        ]);
+
+        $response = $this->getJson("/api/tenants/{$this->tenant->codigo}/productos/{$product->id}?variant_id={$firstVariant->id}");
+
+        $response->assertOk();
+        $response->assertJsonPath('data.variant.id', $firstVariant->id);
+        $response->assertJsonPath('data.variant.stock', 5);
+        $response->assertJsonPath('data.variants_map.1.variant_id', $secondVariant->id);
+    }
+
+    public function test_it_rejects_product_detail_variant_id_from_another_product(): void
+    {
+        $product = Product::create([
+            'tenant_codigo' => $this->tenant->codigo,
+            'categoria_id' => 1,
+            'slug' => 'test-product-invalid-variant',
+            'nombre' => 'Test Product Invalid Variant',
+            'precio' => 100.00,
+        ]);
+        $otherProduct = Product::create([
+            'tenant_codigo' => $this->tenant->codigo,
+            'categoria_id' => 1,
+            'slug' => 'test-product-other-variant',
+            'nombre' => 'Test Product Other Variant',
+            'precio' => 100.00,
+        ]);
+
+        $otherVariant = $otherProduct->variants()->create(['stock' => 3]);
+
+        $response = $this->getJson("/api/tenants/{$this->tenant->codigo}/productos/{$product->id}?variant_id={$otherVariant->id}");
+
+        $response->assertNotFound();
+    }
+
+    public function test_selected_variant_images_fall_back_to_product_images(): void
+    {
+        $product = Product::create([
+            'tenant_codigo' => $this->tenant->codigo,
+            'categoria_id' => 1,
+            'slug' => 'test-product-fallback-images',
+            'nombre' => 'Test Product Fallback Images',
+            'precio' => 100.00,
+        ]);
+        $productAttributes = $this->syncVariantAttributes($product);
+        $productAttachment = $this->createAttachment('attachments/product-fallback.png');
+        $product->attachments()->attach($productAttachment->id);
+
+        $variant = $product->createVariant([
+            'stock' => 6,
+            'definitions' => [
+                [
+                    'products_attribute_id' => $productAttributes['size']->id,
+                    'value' => 'S',
+                ],
+            ],
+        ]);
+
+        $response = $this->getJson("/api/tenants/{$this->tenant->codigo}/productos/{$product->id}");
+
+        $response->assertOk();
+        $response->assertJsonPath('data.variant.id', $variant->id);
+        $response->assertJsonCount(1, 'data.variant.images');
+        $this->assertStringContainsString($productAttachment->path, $response->json('data.variant.images.0'));
+    }
+
+    /**
+     * @return array{size: ProductAttribute, color: ProductAttribute}
+     */
+    private function syncVariantAttributes(Product $product): array
+    {
+        $product->attributes()->sync([$this->sizeAttr->id, $this->colorAttr->id]);
+
+        return [
+            'size' => $product->productAttributes()
+                ->where('attribute_id', $this->sizeAttr->id)
+                ->firstOrFail(),
+            'color' => $product->productAttributes()
+                ->where('attribute_id', $this->colorAttr->id)
+                ->firstOrFail(),
+        ];
+    }
+
+    private function createAttachment(string $path): Attachment
+    {
+        return Attachment::create([
+            'key' => (string) Str::uuid(),
+            'path' => $path,
+            'filename' => basename($path),
+            'type' => AttachmentType::Image,
+            'mime_type' => 'image/png',
+        ]);
     }
 
     protected function createTenant(string $codigo, string $nombre, string $dominio): Tenant
@@ -473,18 +607,18 @@ class ProductControllerTest extends TestCase
         $hdrKey = (string) Str::uuid();
         $ftrKey = (string) Str::uuid();
 
-        $headerAttachment = \App\Domains\Attachable\Models\Attachment::create([
+        $headerAttachment = Attachment::create([
             'key' => $hdrKey,
-            'path' => 'tenants/' . $hdrKey . '.png',
+            'path' => 'tenants/'.$hdrKey.'.png',
             'filename' => 'logo_header.png',
-            'type' => \App\Domains\Attachable\Enums\AttachmentType::Image,
+            'type' => AttachmentType::Image,
             'mime_type' => 'image/png',
         ]);
-        $footerAttachment = \App\Domains\Attachable\Models\Attachment::create([
+        $footerAttachment = Attachment::create([
             'key' => $ftrKey,
-            'path' => 'tenants/' . $ftrKey . '.png',
+            'path' => 'tenants/'.$ftrKey.'.png',
             'filename' => 'logo_footer.png',
-            'type' => \App\Domains\Attachable\Enums\AttachmentType::Image,
+            'type' => AttachmentType::Image,
             'mime_type' => 'image/png',
         ]);