Merge branch 'fix/simplify_stock_reservations' of https://gitea.quo.ar/tbianchini/shopit-back into fix/simplify_stock_reservations

.env.example

@@ -31,6 +31,7 @@ AUTH_LOGIN_ATTEMPT_WINDOW_MINUTES=30
 AUTH_LOGIN_LOCK_MINUTES=15
 AUTH_LOGIN_RATE_LIMIT_PER_MINUTE=10
 AUTH_LOGIN_IP_RATE_LIMIT_PER_MINUTE=30
+AUTH_PASSWORD_RESET_EXPIRATION_MINUTES=60
 
 LOG_CHANNEL=daily
 LOG_STACK=single

app/Domains/Auth/Controllers/ValidateResetPasswordAttemptController.php

@@ -22,10 +22,18 @@ class ValidateResetPasswordAttemptController extends Controller
     {
         $data = $request->validated();
 
-        if (! $this->resetPasswordAttemptService->validateCode(
+        $result = $this->resetPasswordAttemptService->validateCode(
             $data['email'],
             $data['codigo'],
-        )) {
+        );
+
+        if ($result === ResetPasswordAttemptService::CODE_EXPIRED) {
+            throw ValidationException::withMessages([
+                'codigo' => __('api.auth.reset_code_expired'),
+            ]);
+        }
+
+        if ($result !== ResetPasswordAttemptService::CODE_VALID) {
             throw ValidationException::withMessages([
                 'codigo' => __('api.auth.reset_code_invalid'),
             ]);

app/Domains/Auth/Models/ResetPasswordAttempt.php

@@ -7,7 +7,7 @@ use Illuminate\Database\Eloquent\Attributes\Hidden;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 
-#[Fillable(['user_id', 'codigo', 'reason', 'status'])]
+#[Fillable(['user_id', 'codigo', 'reason', 'status', 'expires_at'])]
 #[Hidden(['codigo'])]
 class ResetPasswordAttempt extends Model
 {
@@ -31,6 +31,7 @@ class ResetPasswordAttempt extends Model
     {
         return [
             'user_id' => 'integer',
+            'expires_at' => 'datetime',
         ];
     }
 

app/Domains/Auth/Services/ResetPasswordAttemptService.php

@@ -12,6 +12,12 @@ use Throwable;
 
 class ResetPasswordAttemptService
 {
+    public const CODE_VALID = 'valid';
+
+    public const CODE_INVALID = 'invalid';
+
+    public const CODE_EXPIRED = 'expired';
+
     public function createForEmail(
         string $email,
         string $tenantCode,
@@ -146,12 +152,12 @@ class ResetPasswordAttemptService
         );
     }
 
-    public function validateCode(string $email, string $code): bool
+    public function validateCode(string $email, string $code): string
     {
         $emailFingerprint = $this->emailFingerprint($email);
 
         try {
-            return DB::transaction(function () use ($email, $code, $emailFingerprint): bool {
+            return DB::transaction(function () use ($email, $code, $emailFingerprint): string {
                 $user = User::query()
                     ->where('email', $email)
                     ->lockForUpdate()
@@ -169,14 +175,27 @@ class ResetPasswordAttemptService
                         'email_fingerprint' => $emailFingerprint,
                     ]);
 
-                    return false;
+                    return self::CODE_INVALID;
+                }
+
+                if ($attempt->expires_at?->isPast()) {
+                    $attempt->update([
+                        'status' => ResetPasswordAttempt::STATUS_EXPIRED,
+                    ]);
+
+                    Log::info('Password reset code validation failed: attempt expired.', [
+                        'email_fingerprint' => $emailFingerprint,
+                        'attempt_id' => $attempt->getKey(),
+                    ]);
+
+                    return self::CODE_EXPIRED;
                 }
 
                 $attempt->update([
                     'status' => ResetPasswordAttempt::STATUS_VALIDATED,
                 ]);
 
-                return true;
+                return self::CODE_VALID;
             });
         } catch (Throwable $exception) {
             Log::error('Failed to validate password reset code.', [
@@ -214,6 +233,19 @@ class ResetPasswordAttemptService
                     return false;
                 }
 
+                if ($attempt->expires_at?->isPast()) {
+                    $attempt->update([
+                        'status' => ResetPasswordAttempt::STATUS_EXPIRED,
+                    ]);
+
+                    Log::info('Password reset failed: attempt expired.', [
+                        'email_fingerprint' => $emailFingerprint,
+                        'attempt_id' => $attempt->getKey(),
+                    ]);
+
+                    return false;
+                }
+
                 $user->password = $password;
                 $user->failed_login_attempts = 0;
                 $user->last_failed_login_at = null;
@@ -270,6 +302,7 @@ class ResetPasswordAttemptService
             'codigo' => $this->generateCode(),
             'reason' => $reason,
             'status' => ResetPasswordAttempt::STATUS_PENDING,
+            'expires_at' => now()->addMinutes((int) config('auth.passwords.users.expire')),
         ]);
 
         return $attempt->getKey();

app/Domains/Bootstrap/Resources/AdminAppBootstrapResource.php

@@ -30,6 +30,7 @@ class AdminAppBootstrapResource extends JsonResource
             'login_header_footer_color' => $websiteType->login_header_footer_color,
             'site_logo' => $websiteType->siteLogo?->getTemporaryUrl(1440),
             'footer_logo' => $websiteType->footerLogo?->getTemporaryUrl(1440),
+            'favicon' => $websiteType->favicon?->getTemporaryUrl(1440),
         ];
     }
 }

app/Domains/Bootstrap/Services/AdminAppBootstrapService.php

@@ -11,7 +11,7 @@ class AdminAppBootstrapService
     {
         return [
             'website_type' => WebsiteType::query()
-                ->with(['siteLogo', 'footerLogo'])
+                ->with(['siteLogo', 'footerLogo', 'favicon'])
                 ->where('dominio', $domain)
                 ->firstOrFail(),
         ];

app/Domains/Bootstrap/Services/ScannerBootstrapService.php

@@ -11,7 +11,7 @@ class ScannerBootstrapService
     {
         return [
             'website_type' => WebsiteType::query()
-                ->with(['siteLogo', 'footerLogo'])
+                ->with(['siteLogo', 'footerLogo', 'favicon'])
                 ->where('scanner_domain', $domain)
                 ->firstOrFail(),
         ];

app/Domains/Notification/Events/TicketsAvailable.php

@@ -1,19 +0,0 @@
-<?php
-
-namespace App\Domains\Notification\Events;
-
-use Illuminate\Foundation\Events\Dispatchable;
-use Illuminate\Queue\SerializesModels;
-
-class TicketsAvailable
-{
-    use Dispatchable, SerializesModels;
-
-    /**
-     * @param  array<int, int>  $ticketIds
-     */
-    public function __construct(
-        public readonly int $purchaseId,
-        public readonly array $ticketIds,
-    ) {}
-}

app/Domains/Notification/Listeners/SendPurchaseConfirmedEmail.php

@@ -7,7 +7,7 @@ use App\Domains\Purchase\Events\PurchasePaid;
 use Illuminate\Contracts\Queue\ShouldQueueAfterCommit;
 use Illuminate\Queue\InteractsWithQueue;
 
-class SendPurchasePaidEmail implements ShouldQueueAfterCommit
+class SendPurchaseConfirmedEmail implements ShouldQueueAfterCommit
 {
     use InteractsWithQueue;
 
@@ -20,6 +20,6 @@ class SendPurchasePaidEmail implements ShouldQueueAfterCommit
 
     public function handle(PurchasePaid $event): void
     {
-        app(NotificationMailService::class)->sendPurchasePaid($event->purchaseId);
+        app(NotificationMailService::class)->sendPurchaseConfirmed($event->purchaseId);
     }
 }

app/Domains/Notification/Listeners/SendTicketsAvailableEmail.php

@@ -1,25 +0,0 @@
-<?php
-
-namespace App\Domains\Notification\Listeners;
-
-use App\Domains\Notification\Events\TicketsAvailable;
-use App\Domains\Notification\Services\NotificationMailService;
-use Illuminate\Contracts\Queue\ShouldQueueAfterCommit;
-use Illuminate\Queue\InteractsWithQueue;
-
-class SendTicketsAvailableEmail implements ShouldQueueAfterCommit
-{
-    use InteractsWithQueue;
-
-    public string $queue = 'emails';
-
-    public int $tries = 3;
-
-    /** @var array<int, int> */
-    public array $backoff = [30, 120, 300];
-
-    public function handle(TicketsAvailable $event): void
-    {
-        app(NotificationMailService::class)->sendTicketsAvailable($event->purchaseId, $event->ticketIds);
-    }
-}

app/Domains/Notification/Services/NotificationMailService.php

@@ -119,55 +119,17 @@ class NotificationMailService
         });
     }
 
-    public function sendPurchasePaid(int $purchaseId): void
+    public function sendPurchaseConfirmed(int $purchaseId): void
     {
         $context = ['purchase_id' => $purchaseId];
 
-        $this->sendLogged('purchase_paid', $context, function () use ($purchaseId, $context): ?array {
+        $this->sendLogged('purchase_confirmed', $context, function () use ($purchaseId, $context): ?array {
             $purchase = Purchase::query()
                 ->with(['tenant', 'user', 'items'])
                 ->find($purchaseId);
 
             if ($purchase === null) {
-                $this->logSkipped('purchase_paid', array_merge($context, [
+                $this->logSkipped('purchase_confirmed', array_merge($context, [
-                    'reason' => 'purchase_not_found',
-                    'missing_model' => Purchase::class,
-                ]));
-
-                return null;
-            }
-
-            $this->mailService
-                ->forTenant($purchase->tenant_codigo)
-                ->send(
-                    $this->recipientFor($purchase),
-                    "Pago confirmado - Compra #{$purchase->getKey()}",
-                    view('mail.notifications.purchase-paid', compact('purchase'))->render(),
-                );
-
-            return [
-                'tenant_code' => $purchase->tenant_codigo,
-                'user_id' => $purchase->user_id,
-                'purchase_status' => $purchase->status,
-                'purchase_item_count' => $purchase->items->count(),
-            ];
-        });
-    }
-
-    /** @param array<int, int> $ticketIds */
-    public function sendTicketsAvailable(int $purchaseId, array $ticketIds): void
-    {
-        $context = [
-            'purchase_id' => $purchaseId,
-            'requested_ticket_count' => count($ticketIds),
-            'requested_ticket_ids' => $ticketIds,
-        ];
-
-        $this->sendLogged('tickets_available', $context, function () use ($purchaseId, $ticketIds, $context): ?array {
-            $purchase = Purchase::query()->with(['tenant', 'user'])->find($purchaseId);
-
-            if ($purchase === null) {
-                $this->logSkipped('tickets_available', array_merge($context, [
                     'reason' => 'purchase_not_found',
                     'missing_model' => Purchase::class,
                 ]));
@@ -177,41 +139,34 @@ class NotificationMailService
 
             /** @var Collection<int, Ticket> $tickets */
             $tickets = Ticket::query()
+                ->where('source_purchase_id', $purchase->getKey())
                 ->where('tenant_code', $purchase->tenant_codigo)
-                ->where('user_id', $purchase->user_id)
-                ->whereKey($ticketIds)
                 ->with(TicketPresentationResolver::RELATIONS)
                 ->get();
-
+            $attachments = $tickets->isEmpty()
-            if ($tickets->isEmpty()) {
+                ? []
-                $this->logSkipped('tickets_available', array_merge($context, [
+                : [[
-                    'reason' => 'tickets_not_found',
+                    'data' => $this->ticketPdfService->contents($purchase->tenant, $tickets),
-                    'missing_model' => Ticket::class,
+                    'name' => $this->ticketPdfService->filename($tickets),
-                    'tenant_code' => $purchase->tenant_codigo,
+                    'mime' => 'application/pdf',
-                    'user_id' => $purchase->user_id,
+                ]];
-                ]));
-
-                return null;
-            }
 
             $this->mailService
                 ->forTenant($purchase->tenant_codigo)
                 ->send(
                     $this->recipientFor($purchase),
-                    'Tus tickets ya están disponibles',
+                    "Compra confirmada - Compra #{$purchase->getKey()}",
-                    view('mail.notifications.tickets-available', compact('purchase', 'tickets'))->render(),
+                    view('mail.notifications.purchase-confirmed', compact('purchase', 'tickets'))->render(),
-                    attachments: [[
+                    attachments: $attachments,
-                        'data' => $this->ticketPdfService->contents($purchase->tenant, $tickets),
-                        'name' => $this->ticketPdfService->filename($tickets),
-                        'mime' => 'application/pdf',
-                    ]],
                 );
 
             return [
                 'tenant_code' => $purchase->tenant_codigo,
                 'user_id' => $purchase->user_id,
-                'sent_ticket_count' => $tickets->count(),
+                'purchase_status' => $purchase->status,
-                'sent_ticket_ids' => $tickets->modelKeys(),
+                'purchase_item_count' => $purchase->items->count(),
+                'ticket_count' => $tickets->count(),
+                'ticket_ids' => $tickets->modelKeys(),
             ];
         });
     }

app/Domains/Notification/documentacion/README.md

@@ -8,12 +8,11 @@ Orquesta notificaciones de negocio por correo a partir de eventos de otros domin
 
 - `UserRegistered`: dispara el correo de bienvenida.
 - `PasswordResetRequested`: envía el código de recuperación si el intento sigue pendiente.
-- `PurchasePaid`: envía la confirmación de pago.
+- `PurchasePaid`: envía la confirmación de compra y adjunta los tickets generados, cuando corresponde.
-- `TicketsAvailable`: informa y entrega la disponibilidad de tickets.
 
 ## Componentes
 
-Los listeners `SendWelcomeEmail`, `SendPasswordResetEmail`, `SendPurchasePaidEmail` y `SendTicketsAvailableEmail` delegan en `NotificationMailService`. Este servicio carga el contexto necesario, renderiza las vistas y envía mediante `Integration/MailService`.
+Los listeners `SendWelcomeEmail`, `SendPasswordResetEmail` y `SendPurchaseConfirmedEmail` delegan en `NotificationMailService`. Este servicio carga el contexto necesario, renderiza las vistas y envía mediante `Integration/MailService`.
 
 ## API y dependencias
 
@@ -24,5 +23,5 @@ No expone rutas HTTP. Consume datos de `Auth`, `Tenant`, `Purchase` y `Ticket`,
 - Los listeners reciben identificadores y vuelven a cargar los modelos, evitando transportar entidades obsoletas.
 - La recuperación no se envía si el intento dejó de estar pendiente.
 - Los correos de cuenta (bienvenida y recuperación de contraseña) usan la identidad visual del `WebsiteType` asociado al tenant, con fallback al tenant si no tiene uno configurado.
-- Los correos transaccionales (pago confirmado y tickets disponibles) usan la identidad visual del tenant/evento de la compra.
+- El correo transaccional de compra confirmada usa la identidad visual del tenant y adjunta un único PDF cuando la compra generó tickets.
 - Los handlers deben permanecer idempotentes o tolerantes a reintentos de cola.

app/Domains/Tenant/Services/WebsiteTypeService.php

@@ -82,6 +82,7 @@ class WebsiteTypeService
                     && $previousLogo->id !== $websiteType->site_logo
                     && $previousLogo->id !== $websiteType->footer_logo
                     && $previousLogo->id !== $websiteType->favicon_id
+                    && ! $this->isReferencedByWebsiteType($previousLogo)
                 ) {
                     $this->attachmentService->delete($previousLogo);
                 }
@@ -90,4 +91,16 @@ class WebsiteTypeService
             return $websiteType;
         });
     }
+
+    private function isReferencedByWebsiteType(Attachment $attachment): bool
+    {
+        return WebsiteType::query()
+            ->where(function ($query) use ($attachment): void {
+                $query
+                    ->where('site_logo', $attachment->id)
+                    ->orWhere('footer_logo', $attachment->id)
+                    ->orWhere('favicon_id', $attachment->id);
+            })
+            ->exists();
+    }
 }

app/Domains/Ticket/Listeners/GenerateTicketsForPaidPurchase.php

@@ -3,7 +3,6 @@
 namespace App\Domains\Ticket\Listeners;
 
 use App\Domains\Catalog\Models\CatalogItem;
-use App\Domains\Notification\Events\TicketsAvailable;
 use App\Domains\Purchase\Events\PurchasePaid;
 use App\Domains\Purchase\Models\Purchase;
 use App\Domains\Ticket\Exceptions\TicketGenerationException;
@@ -21,8 +20,6 @@ class GenerateTicketsForPaidPurchase
             ->with(['user', 'items'])
             ->findOrFail($event->purchaseId);
         $user = $purchase->user;
-        $ticketIds = [];
-
         foreach ($purchase->items as $purchaseItem) {
             $catalogItem = CatalogItem::query()
                 ->where('tenant_code', $purchase->tenant_codigo)
@@ -40,19 +37,13 @@ class GenerateTicketsForPaidPurchase
                 throw TicketGenerationException::purchaseWithoutUser($purchase);
             }
 
-            $generatedTickets = $this->ticketGenerator->generate(
+            $this->ticketGenerator->generate(
                 $catalogItem,
                 $user,
                 $purchaseItem->cantidad,
                 $purchaseItem->source_variant_id,
                 $purchase->getKey(),
             );
-
-            array_push($ticketIds, ...$generatedTickets->pluck('id')->all());
-        }
-
-        if ($ticketIds !== []) {
-            TicketsAvailable::dispatch($purchase->getKey(), $ticketIds);
         }
     }
 

app/Domains/Ticket/documentacion/README.md

@@ -21,7 +21,7 @@ vigente, vencido o usado, y resuelve sus fechas efectivas de inicio y fin sin pe
 1. `Purchase` emite `PurchasePaid` al confirmarse el pago.
 2. `GenerateTicketsForPaidPurchase` atiende el evento.
 3. `TicketGeneratorService` crea los tickets requeridos según ítems, cantidades y vigencia.
-4. El flujo puede emitir disponibilidad para que `Notification` informe al comprador.
+4. `Notification` envía la confirmación de compra después de la generación y adjunta los tickets cuando existen.
 
 ## Endpoints
 

app/Providers/AppServiceProvider.php

@@ -3,11 +3,9 @@
 namespace App\Providers;
 
 use App\Domains\Notification\Events\PasswordResetRequested;
-use App\Domains\Notification\Events\TicketsAvailable;
 use App\Domains\Notification\Events\UserRegistered;
 use App\Domains\Notification\Listeners\SendPasswordResetEmail;
-use App\Domains\Notification\Listeners\SendPurchasePaidEmail;
+use App\Domains\Notification\Listeners\SendPurchaseConfirmedEmail;
-use App\Domains\Notification\Listeners\SendTicketsAvailableEmail;
 use App\Domains\Notification\Listeners\SendWelcomeEmail;
 use App\Domains\Purchase\Events\PurchasePaid;
 use App\Domains\Ticket\Listeners\GenerateTicketsForPaidPurchase;
@@ -33,9 +31,8 @@ class AppServiceProvider extends ServiceProvider
      */
     public function boot(): void
     {
-        Event::listen(PurchasePaid::class, SendPurchasePaidEmail::class);
         Event::listen(PurchasePaid::class, GenerateTicketsForPaidPurchase::class);
-        Event::listen(TicketsAvailable::class, SendTicketsAvailableEmail::class);
+        Event::listen(PurchasePaid::class, SendPurchaseConfirmedEmail::class);
         Event::listen(UserRegistered::class, SendWelcomeEmail::class);
         Event::listen(PasswordResetRequested::class, SendPasswordResetEmail::class);
 

config/auth.php

@@ -96,7 +96,7 @@ return [
         'users' => [
             'provider' => 'users',
             'table' => env('AUTH_PASSWORD_RESET_TOKEN_TABLE', 'password_reset_tokens'),
-            'expire' => 60,
+            'expire' => (int) env('AUTH_PASSWORD_RESET_EXPIRATION_MINUTES', 60),
             'throttle' => 60,
         ],
     ],

database/migrations/2026_08_25_010000_add_expires_at_to_reset_password_attempts_table.php

@@ -0,0 +1,32 @@
+<?php
+
+use App\Domains\Auth\Models\ResetPasswordAttempt;
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    public function up(): void
+    {
+        Schema::table('reset_password_attempts', function (Blueprint $table): void {
+            $table->timestamp('expires_at')->nullable()->after('status');
+        });
+
+        // Attempts created before this migration did not have an expiration instant.
+        DB::table('reset_password_attempts')
+            ->whereIn('status', [
+                ResetPasswordAttempt::STATUS_PENDING,
+                ResetPasswordAttempt::STATUS_VALIDATED,
+            ])
+            ->update(['status' => ResetPasswordAttempt::STATUS_EXPIRED]);
+    }
+
+    public function down(): void
+    {
+        Schema::table('reset_password_attempts', function (Blueprint $table): void {
+            $table->dropColumn('expires_at');
+        });
+    }
+};

database/migrations/2026_08_26_000000_set_website_type_favicon.php

@@ -0,0 +1,96 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Storage;
+use Illuminate\Support\Str;
+
+return new class extends Migration
+{
+    private const FILENAME = 'onticket_favicon.svg';
+
+    /** @var list<string> */
+    private const WEBSITE_TYPE_CODES = ['shopit', 'onticket'];
+
+    public function up(): void
+    {
+        $websiteTypes = DB::table('website_type')
+            ->whereIn('codigo', self::WEBSITE_TYPE_CODES)
+            ->get(['codigo', 'favicon_id']);
+
+        if ($websiteTypes->isEmpty()) {
+            return;
+        }
+
+        $faviconIds = $websiteTypes
+            ->pluck('favicon_id')
+            ->filter()
+            ->unique()
+            ->values();
+
+        if (
+            $faviconIds->count() === 1
+            && DB::table('attachments')
+                ->where('id', $faviconIds->first())
+                ->where('filename', self::FILENAME)
+                ->exists()
+            && $websiteTypes->every(
+                fn (object $websiteType): bool => $websiteType->favicon_id === $faviconIds->first()
+            )
+        ) {
+            return;
+        }
+
+        $sourcePath = public_path('images/website_types/'.self::FILENAME);
+
+        if (! is_file($sourcePath)) {
+            throw new RuntimeException("Favicon not found at path: {$sourcePath}");
+        }
+
+        $contents = file_get_contents($sourcePath);
+
+        if ($contents === false) {
+            throw new RuntimeException("Could not read favicon at path: {$sourcePath}");
+        }
+
+        $key = (string) Str::uuid();
+        $storedPath = "website-types/{$key}.svg";
+
+        if (! Storage::disk('s3')->put($storedPath, $contents)) {
+            throw new RuntimeException("Could not store favicon at path: {$storedPath}");
+        }
+
+        try {
+            DB::transaction(function () use ($contents, $key, $storedPath): void {
+                $attachmentId = DB::table('attachments')->insertGetId([
+                    'key' => $key,
+                    'path' => $storedPath,
+                    'filename' => self::FILENAME,
+                    'type' => 'image',
+                    'mime_type' => 'image/svg+xml',
+                    'extension' => 'svg',
+                    'size' => strlen($contents),
+                    'created_at' => now(),
+                    'updated_at' => now(),
+                ]);
+
+                DB::table('website_type')
+                    ->whereIn('codigo', self::WEBSITE_TYPE_CODES)
+                    ->update([
+                        'favicon_id' => $attachmentId,
+                        'updated_at' => now(),
+                    ]);
+            });
+        } catch (Throwable $throwable) {
+            Storage::disk('s3')->delete($storedPath);
+
+            throw $throwable;
+        }
+    }
+
+    public function down(): void
+    {
+        // The shared attachment may be in use outside these website types.
+        // Keep this data migration irreversible to avoid deleting an active asset.
+    }
+};

database/seeders/DesfilePuraTendenciaSeeder.php

@@ -191,6 +191,7 @@ class DesfilePuraTendenciaSeeder extends Seeder
 
         FeaturedGroup::query()->create([
             'tenant_code' => self::TENANT_CODE,
+            'code' => 'entradas',
             'source_type' => FeaturedGroupSource::All,
             'category_id' => null,
             'product_layout' => ProductLayout::TicketSelector,

database/seeders/FiestaFutbolInfantilProductSeeder.php

@@ -144,6 +144,7 @@ class FiestaFutbolInfantilProductSeeder extends Seeder
 
         FeaturedGroup::query()->create([
             'tenant_code' => $tenant->codigo,
+            'code' => 'productos',
             'source_type' => FeaturedGroupSource::All,
             'category_id' => null,
             'product_layout' => ProductLayout::Row,

database/seeders/ProductCatalogFromImagesSeeder.php

@@ -171,6 +171,7 @@ class ProductCatalogFromImagesSeeder extends Seeder
 
         FeaturedGroup::query()->create([
             'tenant_code' => $tenant->codigo,
+            'code' => 'productos',
             'source_type' => FeaturedGroupSource::All,
             'product_layout' => ProductLayout::ColumnWithImage,
             'group_layout' => GroupLayout::Paginated,
@@ -180,6 +181,7 @@ class ProductCatalogFromImagesSeeder extends Seeder
 
         $carouselGroup = FeaturedGroup::query()->create([
             'tenant_code' => $tenant->codigo,
+            'code' => 'productos-destacados',
             'source_type' => FeaturedGroupSource::Manual,
             'product_layout' => ProductLayout::ColumnWithImage,
             'group_layout' => GroupLayout::Carousel,

database/seeders/WebsiteTypeSeeder.php

@@ -36,6 +36,7 @@ class WebsiteTypeSeeder extends Seeder
                 ...self::PRESENTATION,
                 'site_logo' => $this->onTicketLogo(),
                 'footer_logo' => $this->onTicketFooterLogo(),
+                'favicon' => $this->onTicketFavicon(),
             ],
         );
 
@@ -70,6 +71,7 @@ class WebsiteTypeSeeder extends Seeder
                 ...self::PRESENTATION,
                 'site_logo' => $this->onTicketLogo(),
                 'footer_logo' => $this->onTicketFooterLogo(),
+                'favicon' => $shopIt->favicon()->firstOrFail()->key,
             ],
         );
 
@@ -175,4 +177,21 @@ class WebsiteTypeSeeder extends Seeder
             true,
         );
     }
+
+    private function onTicketFavicon(): UploadedFile
+    {
+        $path = public_path('images/website_types/onticket_favicon.svg');
+
+        if (! file_exists($path)) {
+            throw new RuntimeException("OnTicket favicon not found at path: {$path}");
+        }
+
+        return new UploadedFile(
+            $path,
+            'onticket_favicon.svg',
+            'image/svg+xml',
+            null,
+            true,
+        );
+    }
 }

lang/en/api.php

@@ -12,6 +12,7 @@ return [
         'password_reset_invalid' => 'The password recovery request is invalid or has already been used.',
         'password_updated' => 'Password updated successfully.',
         'reset_code_invalid' => 'The code you entered is invalid.',
+        'reset_code_expired' => 'The password recovery code expired. Request a new one.',
         'reset_code_valid' => 'Code validated successfully.',
         'invalid_tenant_or_return_url' => 'The tenant or return URL is invalid.',
         'request_expired' => 'The authentication request expired. Please try again.',

lang/es/api.php

@@ -12,6 +12,7 @@ return [
         'password_reset_invalid' => 'La solicitud de recuperación es inválida o ya fue utilizada.',
         'password_updated' => 'Contraseña modificada correctamente.',
         'reset_code_invalid' => 'El código ingresado es inválido.',
+        'reset_code_expired' => 'El código de recuperación expiró. Solicitá uno nuevo.',
         'reset_code_valid' => 'Código validado correctamente.',
         'invalid_tenant_or_return_url' => 'El tenant o la URL de retorno no son válidos.',
         'request_expired' => 'La solicitud de autenticación expiró. Intenta nuevamente.',

public/images/website_types/onticket_favicon.svg

@@ -0,0 +1,3 @@
+<svg width="63" height="36" viewBox="0 0 63 36" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path d="M44.64 0H17.94C8.05 0 0 8.05 0 17.94C0 27.83 8.05 35.88 17.94 35.88H44.64C54.53 35.88 62.58 27.83 62.58 17.94C62.58 8.05 54.53 0 44.64 0ZM44.62 31.78C36.98 31.78 30.79 25.59 30.79 17.95C30.79 10.31 36.98 4.12 44.62 4.12C52.26 4.12 58.45 10.31 58.45 17.95C58.45 25.59 52.26 31.78 44.62 31.78Z" fill="#FF7006"/>
+</svg>

resources/views/mail/notifications/purchase-confirmed.blade.php

@@ -1,4 +1,4 @@
-<h1 style="margin: 0 0 20px;">¡Recibimos tu pago!</h1>
+<h1 style="margin: 0 0 20px;">¡Compra realizada con éxito!</h1>
 <p>La compra <strong>#{{ $purchase->id }}</strong> fue confirmada correctamente.</p>
 <table role="presentation" style="width: 100%; border-collapse: collapse; margin: 20px 0;">
     @foreach ($purchase->items as $item)
@@ -10,3 +10,6 @@
     @endforeach
 </table>
 <p style="font-size: 18px;"><strong>Total pagado: ${{ number_format((float) $purchase->total, 2, ',', '.') }}</strong></p>
+@if ($tickets->isNotEmpty())
+    <p><strong>Tus tickets ya están disponibles</strong></p>
+@endif

resources/views/mail/notifications/tickets-available.blade.php

@@ -1,8 +0,0 @@
-<h1 style="margin: 0 0 20px;">Tus tickets ya están disponibles</h1>
-<p>Generamos {{ $tickets->count() }} {{ $tickets->count() === 1 ? 'ticket' : 'tickets' }} para la compra <strong>#{{ $purchase->id }}</strong>.</p>
-<p>{{ $tickets->count() === 1 ? 'El ticket está adjunto' : 'Los tickets están adjuntos' }} a este correo en formato PDF.</p>
-<ul style="padding-left: 20px;">
-    @foreach ($tickets as $ticket)
-        <li style="margin-bottom: 8px;">{{ $ticket->name }}</li>
-    @endforeach
-</ul>

tests/Feature/Auth/CreateResetPasswordAttemptControllerTest.php

@@ -69,6 +69,10 @@ class CreateResetPasswordAttemptControllerTest extends TestCase
         $this->assertTrue($attempt->user->is($user));
         $this->assertMatchesRegularExpression('/^\d{4}$/', $attempt->codigo);
         $this->assertSame(ResetPasswordAttempt::STATUS_PENDING, $attempt->status);
+        $this->assertTrue($attempt->expires_at->between(
+            now()->addMinutes(59),
+            now()->addMinutes(60),
+        ));
         Event::assertDispatched(
             PasswordResetRequested::class,
             fn (PasswordResetRequested $event): bool => $event->attemptId === $attempt->id

tests/Feature/Auth/ResetPasswordAttemptTest.php

@@ -18,7 +18,9 @@ class ResetPasswordAttemptTest extends TestCase
             'id',
             'user_id',
             'codigo',
+            'reason',
             'status',
+            'expires_at',
         ], Schema::getColumnListing('reset_password_attempts'));
     }
 
@@ -28,12 +30,14 @@ class ResetPasswordAttemptTest extends TestCase
 
         $attempt = $user->resetPasswordAttempts()->create([
             'codigo' => '123456',
+            'expires_at' => now()->addHour(),
         ]);
 
         $this->assertSame(ResetPasswordAttempt::STATUS_PENDING, $attempt->status);
         $this->assertTrue($attempt->user->is($user));
         $this->assertTrue($user->resetPasswordAttempts->contains($attempt));
         $this->assertFalse($attempt->usesTimestamps());
+        $this->assertTrue($attempt->expires_at->isFuture());
         $this->assertArrayNotHasKey('codigo', $attempt->toArray());
     }
 

tests/Feature/Auth/ResetPasswordControllerTest.php

@@ -99,6 +99,30 @@ class ResetPasswordControllerTest extends TestCase
         $this->assertSame(ResetPasswordAttempt::STATUS_USED, $attempt->fresh()->status);
     }
 
+    public function test_an_expired_validated_attempt_cannot_reset_the_password(): void
+    {
+        $user = User::factory()->create([
+            'email' => 'ada@example.com',
+            'password' => 'OldSecret!123',
+        ]);
+        $attempt = $user->resetPasswordAttempts()->create([
+            'codigo' => '1234',
+            'status' => ResetPasswordAttempt::STATUS_VALIDATED,
+            'expires_at' => now()->subSecond(),
+        ]);
+
+        $this->postJson('/api/password/reset', [
+            'email' => 'ada@example.com',
+            'codigo' => '1234',
+            'password' => 'NewSecret!456',
+            'password_confirmation' => 'NewSecret!456',
+        ])->assertUnprocessable()
+            ->assertJsonValidationErrors('codigo');
+
+        $this->assertTrue(Hash::check('OldSecret!123', $user->fresh()->password));
+        $this->assertSame(ResetPasswordAttempt::STATUS_EXPIRED, $attempt->fresh()->status);
+    }
+
     public function test_it_validates_password_confirmation_and_strength(): void
     {
         $this->postJson('/api/password/reset', [

tests/Feature/Auth/ValidateResetPasswordAttemptControllerTest.php

@@ -49,6 +49,27 @@ class ValidateResetPasswordAttemptControllerTest extends TestCase
         );
     }
 
+    public function test_it_expires_an_attempt_and_returns_the_expired_code_message(): void
+    {
+        $user = User::factory()->create(['email' => 'ada@example.com']);
+        $attempt = $user->resetPasswordAttempts()->create([
+            'codigo' => '1234',
+            'expires_at' => now()->subSecond(),
+        ]);
+
+        $this->postJson('/api/password/reset-attempts/validate', [
+            'email' => 'ada@example.com',
+            'codigo' => '1234',
+        ])->assertUnprocessable()
+            ->assertJsonValidationErrors('codigo')
+            ->assertJsonPath('errors.codigo.0', __('api.auth.reset_code_expired'));
+
+        $this->assertSame(
+            ResetPasswordAttempt::STATUS_EXPIRED,
+            $attempt->fresh()->status,
+        );
+    }
+
     public function test_it_rejects_an_expired_or_already_validated_attempt(): void
     {
         $user = User::factory()->create(['email' => 'ada@example.com']);

tests/Feature/Catalog/CatalogSchemaTest.php

@@ -96,6 +96,7 @@ class CatalogSchemaTest extends TestCase
         $this->assertEqualsCanonicalizing([
             'id',
             'tenant_code',
+            'code',
             'source_type',
             'category_id',
             'product_layout',

tests/Feature/Migrations/SetWebsiteTypeFaviconTest.php

@@ -0,0 +1,61 @@
+<?php
+
+namespace Tests\Feature\Migrations;
+
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Storage;
+use Tests\TestCase;
+
+class SetWebsiteTypeFaviconTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_it_uploads_one_favicon_and_shares_the_attachment_between_website_types(): void
+    {
+        Storage::fake('s3');
+
+        DB::table('website_type')->insert([
+            [
+                'codigo' => 'shopit',
+                'nombre' => 'ShopIt',
+                'created_at' => now(),
+                'updated_at' => now(),
+            ],
+            [
+                'codigo' => 'onticket',
+                'nombre' => 'OnTicket',
+                'created_at' => now(),
+                'updated_at' => now(),
+            ],
+        ]);
+
+        $migration = require database_path(
+            'migrations/2026_08_26_000000_set_website_type_favicon.php'
+        );
+
+        $migration->up();
+        $migration->up();
+
+        $faviconIds = DB::table('website_type')
+            ->whereIn('codigo', ['shopit', 'onticket'])
+            ->pluck('favicon_id');
+
+        $this->assertCount(2, $faviconIds);
+        $this->assertNotNull($faviconIds->first());
+        $this->assertSame(1, $faviconIds->unique()->count());
+
+        $attachment = DB::table('attachments')->where('id', $faviconIds->first())->first();
+
+        $this->assertNotNull($attachment);
+        $this->assertSame('onticket_favicon.svg', $attachment->filename);
+        $this->assertSame('image/svg+xml', $attachment->mime_type);
+        $this->assertSame('svg', $attachment->extension);
+        $this->assertSame(1, DB::table('attachments')->where('filename', 'onticket_favicon.svg')->count());
+        Storage::disk('s3')->assertExists($attachment->path);
+        $this->assertSame(
+            file_get_contents(public_path('images/website_types/onticket_favicon.svg')),
+            Storage::disk('s3')->get($attachment->path),
+        );
+    }
+}

tests/Feature/Notification/NotificationMailServiceTest.php

@@ -142,7 +142,7 @@ class NotificationMailServiceTest extends TestCase
         });
     }
 
-    public function test_it_sends_purchase_and_ticket_emails_to_the_purchase_recipient(): void
+    public function test_it_sends_one_purchase_confirmation_with_generated_tickets_attached(): void
     {
         $this->useWebsiteTypeBranding();
         $purchase = Purchase::query()->create([
@@ -175,30 +175,23 @@ class NotificationMailServiceTest extends TestCase
         $ticket = Ticket::query()->create([
             'tenant_code' => $this->tenant->codigo,
             'ticket' => fake()->uuid(),
+            'source_purchase_id' => $purchase->id,
             'source_catalog_item_id' => $catalogItem->id,
             'user_id' => $this->user->id,
         ]);
         $service = app(NotificationMailService::class);
 
-        $service->sendPurchasePaid($purchase->id);
+        $service->sendPurchaseConfirmed($purchase->id);
-        $service->sendTicketsAvailable($purchase->id, [$ticket->id]);
 
-        Mail::assertSent(Mailable::class, 2);
+        Mail::assertSent(Mailable::class, 1);
-        Mail::assertSent(Mailable::class, function (Mailable $mail) use ($purchase): bool {
+        Mail::assertSent(Mailable::class, function (Mailable $mail) use ($purchase, $ticket): bool {
-            $mail->assertTo('checkout@example.com');
-
-            return $mail->subject === "Pago confirmado - Compra #{$purchase->id}"
-                && str_contains($mail->render(), 'Total pagado')
-                && str_contains($mail->render(), 'border-top: 4px solid #112233')
-                && ! str_contains($mail->render(), 'border-top: 4px solid #ff7006');
-        });
-        Mail::assertSent(Mailable::class, function (Mailable $mail) use ($ticket): bool {
             $mail->assertTo('checkout@example.com');
             $attachment = collect($mail->rawAttachments)->firstWhere('name', "tickets_{$ticket->id}.pdf");
 
-            return $mail->subject === 'Tus tickets ya están disponibles'
+            return $mail->subject === "Compra confirmada - Compra #{$purchase->id}"
-                && str_contains($mail->render(), 'Entrada general')
+                && str_contains($mail->render(), '¡Compra realizada con éxito!')
-                && str_contains($mail->render(), 'El ticket está adjunto')
+                && str_contains($mail->render(), 'Total pagado')
+                && str_contains($mail->render(), 'Tus tickets ya están disponibles')
                 && $attachment !== null
                 && $attachment['options'] === ['mime' => 'application/pdf']
                 && str_starts_with($attachment['data'], '%PDF-')
@@ -207,6 +200,26 @@ class NotificationMailServiceTest extends TestCase
         });
     }
 
+    public function test_purchase_confirmation_omits_ticket_content_and_attachment_without_tickets(): void
+    {
+        $purchase = Purchase::query()->create([
+            'tenant_codigo' => $this->tenant->codigo,
+            'user_id' => $this->user->id,
+            'status' => Purchase::STATUS_PAID,
+            'payment_method' => 'transfer',
+            'total' => 25,
+        ]);
+
+        app(NotificationMailService::class)->sendPurchaseConfirmed($purchase->id);
+
+        Mail::assertSent(Mailable::class, function (Mailable $mail) use ($purchase): bool {
+            return $mail->subject === "Compra confirmada - Compra #{$purchase->id}"
+                && str_contains($mail->render(), '¡Compra realizada con éxito!')
+                && ! str_contains($mail->render(), 'Tus tickets ya están disponibles')
+                && $mail->rawAttachments === [];
+        });
+    }
+
     private function useWebsiteTypeBranding(): void
     {
         $websiteType = WebsiteType::query()->create([

tests/Feature/Notification/QueuedNotificationListenerTest.php

@@ -2,9 +2,7 @@
 
 namespace Tests\Feature\Notification;
 
-use App\Domains\Notification\Events\TicketsAvailable;
+use App\Domains\Notification\Listeners\SendPurchaseConfirmedEmail;
-use App\Domains\Notification\Listeners\SendPurchasePaidEmail;
-use App\Domains\Notification\Listeners\SendTicketsAvailableEmail;
 use App\Domains\Notification\Services\NotificationMailService;
 use App\Domains\Purchase\Events\PurchasePaid;
 use Mockery;
@@ -12,35 +10,21 @@ use Tests\TestCase;
 
 class QueuedNotificationListenerTest extends TestCase
 {
-    public function test_purchase_paid_email_delegates_with_the_purchase_id(): void
+    public function test_purchase_confirmed_email_delegates_with_the_purchase_id(): void
     {
         $mailService = Mockery::mock(NotificationMailService::class);
-        $mailService->shouldReceive('sendPurchasePaid')
+        $mailService->shouldReceive('sendPurchaseConfirmed')
             ->once()
             ->with(123);
         $this->app->instance(NotificationMailService::class, $mailService);
 
-        (new SendPurchasePaidEmail)->handle(new PurchasePaid(123));
+        (new SendPurchaseConfirmedEmail)->handle(new PurchasePaid(123));
     }
 
-    public function test_tickets_available_email_delegates_with_scalar_identifiers(): void
+    public function test_purchase_paid_event_only_serializes_the_purchase_id(): void
-    {
-        $mailService = Mockery::mock(NotificationMailService::class);
-        $mailService->shouldReceive('sendTicketsAvailable')
-            ->once()
-            ->with(123, [10, 11]);
-        $this->app->instance(NotificationMailService::class, $mailService);
-
-        (new SendTicketsAvailableEmail)->handle(new TicketsAvailable(123, [10, 11]));
-    }
-
-    public function test_email_events_only_serialize_scalar_identifiers(): void
     {
         $purchasePaid = unserialize(serialize(new PurchasePaid(123)));
-        $ticketsAvailable = unserialize(serialize(new TicketsAvailable(123, [10, 11])));
 
         $this->assertSame(123, $purchasePaid->purchaseId);
-        $this->assertSame(123, $ticketsAvailable->purchaseId);
-        $this->assertSame([10, 11], $ticketsAvailable->ticketIds);
     }
 }

tests/Feature/Seeders/DesfilePuraTendenciaSeederTest.php

@@ -161,6 +161,7 @@ class DesfilePuraTendenciaSeederTest extends TestCase
         ]);
         $this->assertDatabaseHas('featured_groups', [
             'tenant_code' => 'desfile_pura_tendencia',
+            'code' => 'entradas',
             'source_type' => 'all',
             'product_layout' => 'ticket_selector',
             'group_layout' => 'single',

tests/Feature/Seeders/FiestaFutbolInfantilProductSeederTest.php

@@ -151,6 +151,7 @@ class FiestaFutbolInfantilProductSeederTest extends TestCase
         ));
 
         $featuredGroup = FeaturedGroup::query()->where('tenant_code', $tenant->codigo)->sole();
+        $this->assertSame('productos', $featuredGroup->code);
         $this->assertSame(FeaturedGroupSource::All, $featuredGroup->source_type);
         $this->assertSame(ProductLayout::Row, $featuredGroup->product_layout);
         $this->assertSame(GroupLayout::SimpleVertical, $featuredGroup->group_layout);

tests/Feature/Seeders/ProductCatalogFromImagesSeederTest.php

@@ -69,6 +69,7 @@ class ProductCatalogFromImagesSeederTest extends TestCase
             ->pluck('id');
 
         $this->assertNotNull($paginatedGroup);
+        $this->assertSame('productos', $paginatedGroup->code);
         $this->assertSame(ProductLayout::ColumnWithImage, $paginatedGroup->product_layout);
         $this->assertSame(GroupLayout::Paginated, $paginatedGroup->group_layout);
         $this->assertSame(FeaturedGroupSource::All, $paginatedGroup->source_type);
@@ -76,6 +77,7 @@ class ProductCatalogFromImagesSeederTest extends TestCase
         $this->assertCount(0, $paginatedGroup->featuredItems);
 
         $this->assertNotNull($carouselGroup);
+        $this->assertSame('productos-destacados', $carouselGroup->code);
         $this->assertSame(ProductLayout::ColumnWithImage, $carouselGroup->product_layout);
         $this->assertSame(GroupLayout::Carousel, $carouselGroup->group_layout);
         $this->assertSame(FeaturedGroupSource::Manual, $carouselGroup->source_type);

tests/Feature/Seeders/WebsiteTypeSeederTest.php

@@ -21,7 +21,7 @@ class WebsiteTypeSeederTest extends TestCase
         $this->seed(WebsiteTypeSeeder::class);
 
         $this->assertSame(2, WebsiteType::query()->count());
-        $this->assertSame(4, Attachment::query()->count());
+        $this->assertSame(5, Attachment::query()->count());
 
         $expectedPresentation = [
             'primary_color' => '#FF7006',
@@ -49,6 +49,8 @@ class WebsiteTypeSeederTest extends TestCase
         Storage::disk('s3')->assertExists($shopIt->siteLogo->path);
         $this->assertSame('onticket_footer_logo.png', $shopIt->footerLogo->filename);
         Storage::disk('s3')->assertExists($shopIt->footerLogo->path);
+        $this->assertSame('onticket_favicon.svg', $shopIt->favicon->filename);
+        Storage::disk('s3')->assertExists($shopIt->favicon->path);
         $this->assertSame(['carousel'], $shopIt->extras->pluck('codigo')->all());
         $this->assertSame('Carrusel principal', $shopIt->extras->sole()->nombre);
         $this->assertSame([
@@ -79,6 +81,8 @@ class WebsiteTypeSeederTest extends TestCase
         Storage::disk('s3')->assertExists($onTicket->footerLogo->path);
         $this->assertNotSame($shopIt->site_logo, $onTicket->site_logo);
         $this->assertNotSame($shopIt->footer_logo, $onTicket->footer_logo);
+        $this->assertSame($shopIt->favicon_id, $onTicket->favicon_id);
+        $this->assertSame('onticket_favicon.svg', $onTicket->favicon->filename);
         $this->assertEqualsCanonicalizing(
             ['heroConfig', 'eventConfig', 'additionalInfoConfig'],
             $onTicket->extras->pluck('codigo')->all(),

tests/Feature/Tenant/BootstrapAdminAppControllerTest.php

@@ -14,6 +14,7 @@ class BootstrapAdminAppControllerTest extends TestCase
     public function test_it_publicly_bootstraps_the_admin_app_by_domain(): void
     {
         $footerLogo = Attachment::factory()->create();
+        $favicon = Attachment::factory()->create();
 
         WebsiteType::query()->create([
             'codigo' => 'shopit',
@@ -31,6 +32,7 @@ class BootstrapAdminAppControllerTest extends TestCase
             'border_color' => '#eaeaea',
             'login_header_footer_color' => '#313131',
             'footer_logo' => $footerLogo->id,
+            'favicon_id' => $favicon->id,
         ]);
 
         $this->getJson('/api/v1/adminapp/bootstrap/ADMIN.SHOPIT.TEST')
@@ -41,6 +43,7 @@ class BootstrapAdminAppControllerTest extends TestCase
             ->assertJsonPath('data.login_header_footer_color', '#313131')
             ->assertJsonPath('data.site_logo', null)
             ->assertJsonPath('data.footer_logo', $footerLogo->getTemporaryUrl(1440))
+            ->assertJsonPath('data.favicon', $favicon->getTemporaryUrl(1440))
             ->assertJsonMissingPath('data.forms')
             ->assertJsonMissingPath('data.codigo')
             ->assertJsonMissingPath('data.nombre')

tests/Feature/Tenant/BootstrapScannerControllerTest.php

@@ -14,6 +14,7 @@ class BootstrapScannerControllerTest extends TestCase
     public function test_it_publicly_bootstraps_the_scanner_by_scanner_domain(): void
     {
         $siteLogo = Attachment::factory()->create();
+        $favicon = Attachment::factory()->create();
 
         WebsiteType::query()->create([
             'codigo' => 'shopit',
@@ -32,6 +33,7 @@ class BootstrapScannerControllerTest extends TestCase
             'border_color' => '#eaeaea',
             'login_header_footer_color' => '#313131',
             'site_logo' => $siteLogo->id,
+            'favicon_id' => $favicon->id,
         ]);
 
         $this->getJson('/api/v1/scanner/bootstrap/SCANNER.SHOPIT.TEST')
@@ -40,6 +42,7 @@ class BootstrapScannerControllerTest extends TestCase
             ->assertJsonPath('data.primary_color', '#112233')
             ->assertJsonPath('data.site_logo', $siteLogo->getTemporaryUrl(1440))
             ->assertJsonPath('data.footer_logo', null)
+            ->assertJsonPath('data.favicon', $favicon->getTemporaryUrl(1440))
             ->assertJsonMissingPath('data.codigo')
             ->assertJsonMissingPath('data.nombre')
             ->assertJsonMissingPath('data.dominio')

tests/Feature/Tenant/WebsiteTypeServiceTest.php

@@ -69,4 +69,31 @@ class WebsiteTypeServiceTest extends TestCase
             'favicon_id' => $favicon->id,
         ]);
     }
+
+    public function test_it_keeps_a_shared_favicon_when_one_website_type_replaces_it(): void
+    {
+        Storage::fake('s3');
+
+        $service = app(WebsiteTypeService::class);
+        $shopIt = $service->create([
+            'codigo' => 'shopit',
+            'nombre' => 'ShopIt',
+            'favicon' => UploadedFile::fake()->image('shared-favicon.png', 32, 32),
+        ]);
+        $sharedFavicon = $shopIt->favicon()->firstOrFail();
+        $onTicket = $service->create([
+            'codigo' => 'onticket',
+            'nombre' => 'OnTicket',
+            'favicon' => $sharedFavicon->key,
+        ]);
+
+        $service->updateOrCreate(
+            ['codigo' => 'shopit'],
+            ['favicon' => UploadedFile::fake()->image('shopit-favicon.png', 32, 32)],
+        );
+
+        $this->assertSame($sharedFavicon->id, $onTicket->fresh()->favicon_id);
+        $this->assertDatabaseHas('attachments', ['id' => $sharedFavicon->id]);
+        Storage::disk('s3')->assertExists($sharedFavicon->path);
+    }
 }

tests/Feature/Ticket/TicketGeneratorServiceTest.php

@@ -11,7 +11,6 @@ use App\Domains\Catalog\Models\CatalogItem;
 use App\Domains\Catalog\Models\Inventory;
 use App\Domains\Catalog\Services\CatalogService;
 use App\Domains\Event\Models\EventDate;
-use App\Domains\Notification\Events\TicketsAvailable;
 use App\Domains\Purchase\Models\Purchase;
 use App\Domains\Shared\Enums\FieldType;
 use App\Domains\Tenant\Models\Tenant;
@@ -22,7 +21,6 @@ use App\Domains\Ticket\Services\TicketGeneratorService;
 use Illuminate\Database\Eloquent\Collection as EloquentCollection;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Carbon;
-use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\Queue;
 use Illuminate\Support\Str;
 use Tests\TestCase;
@@ -220,7 +218,6 @@ class TicketGeneratorServiceTest extends TestCase
 
     public function test_marking_a_purchase_as_paid_generates_its_tickets_once(): void
     {
-        Event::fake([TicketsAvailable::class]);
         $item = $this->createTicketableItem('paid-ticket');
         $purchase = $this->createPurchase($item, 2);
         $purchase->setRelation('items', new EloquentCollection);
@@ -229,7 +226,6 @@ class TicketGeneratorServiceTest extends TestCase
 
         $this->assertSame(Purchase::STATUS_PAID, $purchase->status);
         $this->assertDatabaseCount('tickets', 2);
-        Event::assertDispatchedTimes(TicketsAvailable::class, 1);
 
         $this->actingAs($this->user, 'sanctum')
             ->getJson("/api/tenants/{$this->tenant->codigo}/compras/{$purchase->id}")
@@ -240,7 +236,6 @@ class TicketGeneratorServiceTest extends TestCase
         $purchase->markAsPaid();
 
         $this->assertDatabaseCount('tickets', 2);
-        Event::assertDispatchedTimes(TicketsAvailable::class, 1);
     }
 
     public function test_a_ticket_generated_from_a_purchase_keeps_its_source_ids(): void
@@ -453,7 +448,6 @@ class TicketGeneratorServiceTest extends TestCase
 
     public function test_marking_a_purchase_as_paid_ignores_items_without_tickets(): void
     {
-        Event::fake([TicketsAvailable::class]);
         $item = $this->createTicketableItem('regular-product');
         $item->update(['has_tickets' => false]);
         $purchase = $this->createPurchase($item->fresh(), 1);
@@ -462,7 +456,6 @@ class TicketGeneratorServiceTest extends TestCase
 
         $this->assertSame(Purchase::STATUS_PAID, $purchase->status);
         $this->assertDatabaseCount('tickets', 0);
-        Event::assertNotDispatched(TicketsAvailable::class);
 
         $this->actingAs($this->user, 'sanctum')
             ->getJson("/api/tenants/{$this->tenant->codigo}/compras/{$purchase->id}")

tests/Unit/Bootstrap/AdminAppBootstrapResourceTest.php

@@ -17,11 +17,13 @@ class AdminAppBootstrapResourceTest extends TestCase
         ]);
         $websiteType->setRelation('siteLogo', null);
         $websiteType->setRelation('footerLogo', null);
+        $websiteType->setRelation('favicon', null);
         $data = AdminAppBootstrapResource::make([
             'website_type' => $websiteType,
         ])->resolve(request());
 
         $this->assertSame('shopit', $data['website_type_code']);
+        $this->assertNull($data['favicon']);
         $this->assertArrayNotHasKey('forms', $data);
     }
 }

tests/Unit/Notification/NotificationMailServiceLoggingTest.php

@@ -42,31 +42,11 @@ class NotificationMailServiceLoggingTest extends TestCase
                 'purchase_id' => 123,
                 'reason' => 'purchase_not_found',
                 'missing_model' => Purchase::class,
-                'email_type' => 'purchase_paid',
+                'email_type' => 'purchase_confirmed',
             ],
         );
 
-        $this->service->sendPurchasePaid(123);
+        $this->service->sendPurchaseConfirmed(123);
-    }
-
-    public function test_missing_purchase_log_includes_the_requested_ticket_ids(): void
-    {
-        $this->createEmptyPurchasesTable();
-
-        Log::shouldReceive('channel')->once()->with('emails')->andReturnSelf();
-        Log::shouldReceive('warning')->once()->with(
-            'Notification email skipped.',
-            [
-                'purchase_id' => 123,
-                'requested_ticket_count' => 2,
-                'requested_ticket_ids' => [10, 11],
-                'reason' => 'purchase_not_found',
-                'missing_model' => Purchase::class,
-                'email_type' => 'tickets_available',
-            ],
-        );
-
-        $this->service->sendTicketsAvailable(123, [10, 11]);
     }
 
     public function test_it_logs_successful_delivery_with_the_mailer(): void
@@ -97,13 +77,13 @@ class NotificationMailServiceLoggingTest extends TestCase
         Log::shouldReceive('error')->once()->with(
             'Notification email delivery failed.',
             Mockery::on(fn (array $context): bool => $context['purchase_id'] === 123
-                && $context['email_type'] === 'purchase_paid'
+                && $context['email_type'] === 'purchase_confirmed'
                 && $context['exception'] === $exception),
         );
 
         $this->expectExceptionObject($exception);
 
-        $this->sendLogged('purchase_paid', ['purchase_id' => 123], function () use ($exception): array {
+        $this->sendLogged('purchase_confirmed', ['purchase_id' => 123], function () use ($exception): array {
             throw $exception;
         });
     }