Merge branch 'fix/expiration_purchase_messages' of https://gitea.quo.ar/tbianchini/shopit-back into fix/expiration_purchase_messages

app/Domains/Purchase/Resources/PurchaseResource.php

@@ -21,15 +21,18 @@ class PurchaseResource extends JsonResource
         $purchaseItems = $this->resource->relationLoaded('items')
             ? $this->resource->getRelation('items')
             : collect();
-        $cartItems = $purchaseItems->isEmpty()
+        $cartItems = $this->resource->relationLoaded('cart')
-            && $this->resource->relationLoaded('cart')
             && $this->resource->getRelation('cart')?->relationLoaded('items')
                 ? $this->resource->getRelation('cart')->getRelation('items')
-                : collect();
+                : null;
-        $items = $purchaseItems->isNotEmpty() ? $purchaseItems : $cartItems;
+        $usesCartItems = in_array($this->status, [
-        $itemsSource = $purchaseItems->isNotEmpty()
+            Purchase::STATUS_CREATED,
-            ? 'purchase'
+            Purchase::STATUS_PENDING_PAYMENT,
-            : ($cartItems->isNotEmpty() ? 'cart' : null);
+        ], true) && $cartItems !== null;
+        $items = $usesCartItems ? $cartItems : $purchaseItems;
+        $itemsSource = $usesCartItems
+            ? 'cart'
+            : ($purchaseItems->isNotEmpty() ? 'purchase' : null);
         $ticketsCount = array_key_exists('tickets_count', $this->resource->getAttributes())
             ? (int) $this->resource->getAttribute('tickets_count')
             : null;

app/Domains/Purchase/Services/Checkout/PurchaseResponseLoader.php

@@ -10,7 +10,16 @@ class PurchaseResponseLoader
     {
         $purchase->load(['tenant', 'items.imageAttachment']);
 
-        if ($purchase->items->isEmpty() && $purchase->cart_id !== null) {
+        if (
+            $purchase->cart_id !== null
+            && (
+                in_array($purchase->status, [
+                    Purchase::STATUS_CREATED,
+                    Purchase::STATUS_PENDING_PAYMENT,
+                ], true)
+                || $purchase->items->isEmpty()
+            )
+        ) {
             $purchase->load([
                 'cart.items.catalogItem.inventory',
                 'cart.items.catalogItem.attachments',

app/Domains/Sale/Services/AdminAppSaleService.php

@@ -53,6 +53,7 @@ class AdminAppSaleService
             ->where('tenant_codigo', $tenant->codigo)
             ->with([
                 'items',
+                'cart' => fn ($query) => $query->withTrashed(),
                 'cart.items.catalogItem',
                 'cart.items.variant.catalogItem',
                 'cart.items.variant.eventDates',
@@ -151,7 +152,18 @@ class AdminAppSaleService
                 $filters['status'] ?? null,
                 fn (Builder $query, string $status): Builder => $query->where('status', $status)
             )
-            ->withSum('items as quantity', 'cantidad')
+            ->select('compras.*')
+            ->selectRaw(
+                'CASE WHEN compras.status IN (?, ?) '
+                .'THEN (SELECT COALESCE(SUM(cart_items.cantidad), 0) FROM carrito_items AS cart_items '
+                .'WHERE cart_items.cart_id = compras.cart_id) '
+                .'ELSE (SELECT COALESCE(SUM(purchase_items.cantidad), 0) FROM compra_items AS purchase_items '
+                .'WHERE purchase_items.compra_id = compras.id) END AS quantity',
+                [
+                    Purchase::STATUS_CREATED,
+                    Purchase::STATUS_PENDING_PAYMENT,
+                ],
+            )
             ->withCount('tickets')
             ->orderBy($sortColumns[$sortBy], $sortDirection)
             ->when($sortBy !== 'id', fn (Builder $query): Builder => $query->orderByDesc('id'));
@@ -177,8 +189,28 @@ class AdminAppSaleService
 
     protected function saleForResponse(Purchase $sale): Purchase
     {
-        return $sale->refresh()
+        /** @var Purchase */
-            ->loadSum('items as quantity', 'cantidad')
+        return Purchase::query()
-            ->loadCount('tickets');
+            ->select('compras.*')
+            ->selectRaw($this->quantityExpression())
+            ->withCount('tickets')
+            ->findOrFail($sale->getKey());
+    }
+
+    protected function quantityExpression(): string
+    {
+        // El fallback se resuelve en SQL para poder ordenar por cantidad antes de paginar;
+        // los ítems consolidados de la compra tienen prioridad sobre los del carrito de origen.
+        return <<<'SQL'
+            COALESCE(
+                (SELECT SUM(compra_items.cantidad)
+                 FROM compra_items
+                 WHERE compra_items.compra_id = compras.id),
+                (SELECT SUM(carrito_items.cantidad)
+                 FROM carrito_items
+                 WHERE carrito_items.cart_id = compras.cart_id),
+                0
+            ) AS quantity
+            SQL;
     }
 }

tests/Feature/Purchase/StorePurchaseTest.php

@@ -1244,6 +1244,42 @@ class StorePurchaseTest extends TestCase
             ->assertJsonPath('data.total', '100.00');
     }
 
+    public function test_created_and_pending_payment_purchase_details_use_the_current_cart_quantity(): void
+    {
+        $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
+        $user = User::factory()->create([
+            'email' => 'buyer@example.com',
+        ]);
+        $variant = $this->createVariantForTenant('sonder', 10, '50.00');
+
+        foreach ([Purchase::STATUS_CREATED, Purchase::STATUS_PENDING_PAYMENT] as $status) {
+            $purchase = $this->createCheckoutPurchase($user, 'sonder', $variant, 2);
+            $purchase->items()->create([
+                'source_catalog_item_id' => $variant->catalog_item_id,
+                'source_variant_id' => $variant->id,
+                'item_nombre' => $variant->catalogItem->nombre,
+                'descripcion' => $variant->catalogItem->descripcion,
+                'slug' => $variant->catalogItem->slug,
+                'variant_attributes' => [],
+                'cantidad' => 1,
+                'precio_unitario' => '50.00',
+                'total' => '50.00',
+            ]);
+            $purchase->cart->items()->update(['cantidad' => 3]);
+            $purchase->update(['status' => $status]);
+
+            $this->actingAs($user, 'sanctum')
+                ->getJson("/api/tenants/sonder/compras/{$purchase->id}")
+                ->assertOk()
+                ->assertJsonPath('data.status', $status)
+                ->assertJsonPath('data.items_source', 'cart')
+                ->assertJsonPath('data.items.0.quantity', 3)
+                ->assertJsonPath('data.items.0.line_total', '150.00')
+                ->assertJsonPath('data.subtotal', '150.00')
+                ->assertJsonPath('data.total', '150.00');
+        }
+    }
+
     public function test_purchase_detail_uses_purchase_items_for_paid_purchase_even_without_cart(): void
     {
         $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');

tests/Feature/Sale/AdminAppSaleControllerTest.php

@@ -31,6 +31,83 @@ class AdminAppSaleControllerTest extends TestCase
         WebsiteType::query()->create(['codigo' => 'onticket', 'nombre' => 'OnTicket']);
     }
 
+    public function test_sales_list_uses_cart_quantity_for_created_and_pending_payment_sales(): void
+    {
+        $tenant = $this->createTenant('acme');
+        Sanctum::actingAs($this->createAdminAppUser($tenant));
+
+        $catalogItem = CatalogItem::query()->create([
+            'tenant_code' => $tenant->codigo,
+            'slug' => 'entrada-general',
+            'nombre' => 'Entrada general',
+            'precio' => '10000.00',
+        ]);
+
+        $createdCart = Cart::query()->create([
+            'tenant_codigo' => $tenant->codigo,
+            'status' => 'checkout',
+        ]);
+        CartItem::query()->create([
+            'cart_id' => $createdCart->id,
+            'catalog_item_id' => $catalogItem->id,
+            'cantidad' => 3,
+        ]);
+        $createdPurchase = Purchase::query()->create([
+            'cart_id' => $createdCart->id,
+            'tenant_codigo' => $tenant->codigo,
+            'status' => Purchase::STATUS_CREATED,
+            'total' => '30000.00',
+        ]);
+        PurchaseItem::query()->create([
+            'compra_id' => $createdPurchase->id,
+            'source_catalog_item_id' => $catalogItem->id,
+            'item_nombre' => $catalogItem->nombre,
+            'cantidad' => 1,
+            'precio_unitario' => '10000.00',
+            'total' => '10000.00',
+        ]);
+
+        $pendingCart = Cart::query()->create([
+            'tenant_codigo' => $tenant->codigo,
+            'status' => 'checkout',
+        ]);
+        CartItem::query()->create([
+            'cart_id' => $pendingCart->id,
+            'catalog_item_id' => $catalogItem->id,
+            'cantidad' => 4,
+        ]);
+        $pendingPurchase = Purchase::query()->create([
+            'cart_id' => $pendingCart->id,
+            'tenant_codigo' => $tenant->codigo,
+            'status' => Purchase::STATUS_PENDING_PAYMENT,
+            'total' => '40000.00',
+        ]);
+
+        $paidPurchase = Purchase::query()->create([
+            'tenant_codigo' => $tenant->codigo,
+            'status' => Purchase::STATUS_PAID,
+            'total' => '20000.00',
+        ]);
+        PurchaseItem::query()->create([
+            'compra_id' => $paidPurchase->id,
+            'source_catalog_item_id' => $catalogItem->id,
+            'item_nombre' => $catalogItem->nombre,
+            'cantidad' => 2,
+            'precio_unitario' => '10000.00',
+            'total' => '20000.00',
+        ]);
+
+        $this->getJson('/api/v1/adminapp/tenant/sales?sort_by=id&sort_direction=asc')
+            ->assertOk()
+            ->assertJsonCount(3, 'data')
+            ->assertJsonPath('data.0.id', $createdPurchase->id)
+            ->assertJsonPath('data.0.quantity', 3)
+            ->assertJsonPath('data.1.id', $pendingPurchase->id)
+            ->assertJsonPath('data.1.quantity', 4)
+            ->assertJsonPath('data.2.id', $paidPurchase->id)
+            ->assertJsonPath('data.2.quantity', 2);
+    }
+
     public function test_authentication_is_required_to_read_a_sale_detail(): void
     {
         $this->getJson('/api/v1/adminapp/tenant/sales/1')->assertUnauthorized();
@@ -110,6 +187,54 @@ class AdminAppSaleControllerTest extends TestCase
             ->assertJsonPath('data.items.0.total', '25000.00');
     }
 
+    public function test_sales_list_uses_cart_quantity_until_purchase_items_exist(): void
+    {
+        $tenant = $this->createTenant('acme');
+        Sanctum::actingAs($this->createAdminAppUser($tenant));
+
+        $catalogItem = CatalogItem::query()->create([
+            'tenant_code' => $tenant->codigo,
+            'slug' => 'entrada-general',
+            'nombre' => 'Entrada general',
+            'descripcion' => 'Acceso general',
+            'precio' => '12500.00',
+        ]);
+        $cart = Cart::query()->create([
+            'tenant_codigo' => $tenant->codigo,
+            'status' => 'checkout',
+        ]);
+        CartItem::query()->create([
+            'cart_id' => $cart->id,
+            'catalog_item_id' => $catalogItem->id,
+            'cantidad' => 3,
+        ]);
+        $purchase = Purchase::query()->create([
+            'cart_id' => $cart->id,
+            'tenant_codigo' => $tenant->codigo,
+            'status' => Purchase::STATUS_PENDING_PAYMENT,
+            'total' => '37500.00',
+        ]);
+
+        $this->getJson('/api/v1/adminapp/tenant/sales')
+            ->assertOk()
+            ->assertJsonPath('data.0.id', $purchase->id)
+            ->assertJsonPath('data.0.quantity', 3);
+
+        PurchaseItem::query()->create([
+            'compra_id' => $purchase->id,
+            'source_catalog_item_id' => $catalogItem->id,
+            'nombre' => 'Entrada general',
+            'item_nombre' => 'Entrada general',
+            'cantidad' => 2,
+            'precio_unitario' => '12500.00',
+            'total' => '25000.00',
+        ]);
+
+        $this->getJson('/api/v1/adminapp/tenant/sales')
+            ->assertOk()
+            ->assertJsonPath('data.0.quantity', 2);
+    }
+
     public function test_an_adminapp_user_cannot_read_a_sale_from_another_tenant(): void
     {
         $tenant = $this->createTenant('acme');
@@ -241,6 +366,18 @@ class AdminAppSaleControllerTest extends TestCase
             'user_id' => $admin->id,
             'status' => 'converted',
         ]);
+        $catalogItem = CatalogItem::query()->create([
+            'tenant_code' => $tenant->codigo,
+            'slug' => 'entrada-general',
+            'nombre' => 'Entrada general',
+            'descripcion' => 'Acceso general',
+            'precio' => '10000.00',
+        ]);
+        CartItem::query()->create([
+            'cart_id' => $cart->id,
+            'catalog_item_id' => $catalogItem->id,
+            'cantidad' => 2,
+        ]);
         $cart->delete();
         $purchase = Purchase::query()->create([
             'cart_id' => $cart->id,
@@ -251,11 +388,17 @@ class AdminAppSaleControllerTest extends TestCase
 
         $this->postJson("/api/v1/adminapp/tenant/sales/{$purchase->id}/cancel")
             ->assertOk()
-            ->assertJsonPath('data.status', Purchase::STATUS_CANCELLED);
+            ->assertJsonPath('data.status', Purchase::STATUS_CANCELLED)
+            ->assertJsonPath('data.quantity', 2);
 
         $this->assertSame(Purchase::STATUS_CANCELLED, $purchase->fresh()->status);
         $this->assertSoftDeleted('carritos', ['id' => $cart->id]);
         $this->assertSame('converted', Cart::withTrashed()->findOrFail($cart->id)->status);
+
+        $this->getJson("/api/v1/adminapp/tenant/sales/{$purchase->id}")
+            ->assertOk()
+            ->assertJsonPath('data.items.0.product', 'Entrada general')
+            ->assertJsonPath('data.items.0.quantity', 2);
     }
 
     public function test_an_adminapp_user_cannot_change_a_sale_from_another_tenant(): void