tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: rename finalize methods to complete for consistency in purchase processing

Browse Source
This commit is contained in:
ncoronel
2026-07-07 15:36:07 -03:00
parent c276ccd311
commit f18fbc8147
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Domains/Purchase/Controllers/PurchaseController.php
View File

@@ -120,12 +120,12 @@ class PurchaseController extends Controller
], 400); ], 400);
} }
public function finalize(Request $request, Tenant $tenant, Purchase $compra, CheckoutService $checkoutService): PurchaseResource public function complete(Request $request, Tenant $tenant, Purchase $compra, CheckoutService $checkoutService): PurchaseResource
{ {
$compra = $this->resolveScopedPurchase($tenant, $request->user()->id, $compra); $compra = $this->resolveScopedPurchase($tenant, $request->user()->id, $compra);
return PurchaseResource::make( return PurchaseResource::make(
$checkoutService->finalizePurchase($compra) $checkoutService->completePurchase($compra)
); );
} }

2
app/Domains/Purchase/Services/CheckoutService.php
View File

@@ -67,7 +67,7 @@ class CheckoutService
}); });
} }
public function finalizePurchase(Purchase $purchase): Purchase public function completePurchase(Purchase $purchase): Purchase
{ {
return DB::transaction(function () use ($purchase): Purchase { return DB::transaction(function () use ($purchase): Purchase {
/** @var Purchase $purchase */ /** @var Purchase $purchase */

2
app/Domains/Purchase/routes/api.php
View File

@@ -6,5 +6,5 @@ use Illuminate\Support\Facades\Route;
Route::prefix('tenants/{tenant:codigo}')->middleware(['auth:sanctum', \App\Domains\Cart\Middleware\MergeGuestCartMiddleware::class])->group(function (): void { Route::prefix('tenants/{tenant:codigo}')->middleware(['auth:sanctum', \App\Domains\Cart\Middleware\MergeGuestCartMiddleware::class])->group(function (): void {
Route::apiResource('compras', PurchaseController::class)->only(['index', 'store', 'show']); Route::apiResource('compras', PurchaseController::class)->only(['index', 'store', 'show']);
Route::post('compras/{compra}/payment-intent', [PurchaseController::class, 'paymentIntent']); Route::post('compras/{compra}/payment-intent', [PurchaseController::class, 'paymentIntent']);
Route::post('compras/{compra}/finalize', [PurchaseController::class, 'finalize']); Route::post('compras/{compra}/complete', [PurchaseController::class, 'complete']);
}); });

2
tests/Feature/Integration/TelepagosWebhookTest.php
View File

@@ -152,7 +152,7 @@ class TelepagosWebhookTest extends TestCase
'payment_method' => 'transfer', 'payment_method' => 'transfer',
]); ]);
$checkoutService->finalizePurchase($purchase); $checkoutService->completePurchase($purchase);
return $purchase->fresh(); return $purchase->fresh();
} }

2
tests/Feature/Purchase/StorePurchaseTest.php
View File

@@ -148,7 +148,7 @@ class StorePurchaseTest extends TestCase
]); ]);
$this->actingAs($user, 'sanctum') $this->actingAs($user, 'sanctum')
->postJson("/api/tenants/sonder/compras/{$purchaseId}/finalize") ->postJson("/api/tenants/sonder/compras/{$purchaseId}/complete")
->assertOk() ->assertOk()
->assertJsonPath('data.status', Purchase::STATUS_PENDING_PAYMENT); ->assertJsonPath('data.status', Purchase::STATUS_PENDING_PAYMENT);