From efa499d993503689dcb206142896c00a8bf8833c Mon Sep 17 00:00:00 2001 From: ncoronel Date: Thu, 2 Jul 2026 09:37:43 -0300 Subject: [PATCH] feat: rename stock fields to cantidad_maxima in ProductResource and ProductVariantResource --- app/Domains/Catalog/Resources/ProductResource.php | 5 +---- .../Catalog/Resources/ProductVariantResource.php | 5 +---- tests/Feature/Catalog/ProductControllerTest.php | 12 ++++++------ 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/app/Domains/Catalog/Resources/ProductResource.php b/app/Domains/Catalog/Resources/ProductResource.php index 7f6f541..dc8f222 100644 --- a/app/Domains/Catalog/Resources/ProductResource.php +++ b/app/Domains/Catalog/Resources/ProductResource.php @@ -34,10 +34,7 @@ class ProductResource extends JsonResource 'variants_map' => $this->whenLoaded('variants', fn () => $this->variants ->map(fn ($variant) => [ 'variant_id' => $variant->id, - 'stock' => $variant->stock_tecnico, - 'stock_real' => $variant->stock_real, - 'stock_reservado' => $variant->stock_reservado, - 'stock_tecnico' => $variant->stock_tecnico, + 'cantidad_maxima' => $variant->stock_tecnico, 'attributes' => $variant->definitions ->mapWithKeys(fn ($definition) => [ $definition->productAttribute?->attribute?->codigo => $definition->value, diff --git a/app/Domains/Catalog/Resources/ProductVariantResource.php b/app/Domains/Catalog/Resources/ProductVariantResource.php index dc0b2d7..7ff817a 100644 --- a/app/Domains/Catalog/Resources/ProductVariantResource.php +++ b/app/Domains/Catalog/Resources/ProductVariantResource.php @@ -18,10 +18,7 @@ class ProductVariantResource extends JsonResource { return [ 'id' => $this->id, - 'stock' => $this->stock_tecnico, - 'stock_real' => $this->stock_real, - 'stock_reservado' => $this->stock_reservado, - 'stock_tecnico' => $this->stock_tecnico, + 'cantidad_maxima' => $this->stock_tecnico, 'product' => ProductResource::make($this->whenLoaded('product')), 'definitions' => $this->whenLoaded( 'definitions', diff --git a/tests/Feature/Catalog/ProductControllerTest.php b/tests/Feature/Catalog/ProductControllerTest.php index 62ad9cb..1d32724 100644 --- a/tests/Feature/Catalog/ProductControllerTest.php +++ b/tests/Feature/Catalog/ProductControllerTest.php @@ -449,7 +449,7 @@ class ProductControllerTest extends TestCase 'variants_map' => [ '*' => [ 'variant_id', - 'stock', + 'cantidad_maxima', 'attributes' => [ 'talle', 'color', @@ -458,7 +458,7 @@ class ProductControllerTest extends TestCase ], 'variant' => [ 'id', - 'stock', + 'cantidad_maxima', 'definitions', 'images', ], @@ -467,16 +467,16 @@ class ProductControllerTest extends TestCase $response->assertJsonMissingPath('data.variants'); $response->assertJsonPath('data.variants_map.0.variant_id', $variant->id); - $response->assertJsonPath('data.variants_map.0.stock', 0); + $response->assertJsonPath('data.variants_map.0.cantidad_maxima', 0); $response->assertJsonPath('data.variants_map.0.attributes.talle', 'S'); $response->assertJsonPath('data.variants_map.0.attributes.color', 'Azul'); $response->assertJsonPath('data.variants_map.1.variant_id', $secondVariant->id); - $response->assertJsonPath('data.variants_map.1.stock', 4); + $response->assertJsonPath('data.variants_map.1.cantidad_maxima', 4); $response->assertJsonPath('data.variants_map.1.attributes.talle', '38'); $response->assertJsonPath('data.variants_map.1.attributes.color', 'Rojo'); $response->assertJsonCount(2, 'data.variants_map'); $response->assertJsonPath('data.variant.id', $secondVariant->id); - $response->assertJsonPath('data.variant.stock', 4); + $response->assertJsonPath('data.variant.cantidad_maxima', 4); $response->assertJsonPath('data.variant.definitions.talle', '38'); $response->assertJsonPath('data.variant.definitions.color', 'Rojo'); $response->assertJsonCount(1, 'data.variant.images'); @@ -535,7 +535,7 @@ class ProductControllerTest extends TestCase $response->assertOk(); $response->assertJsonPath('data.variant.id', $firstVariant->id); - $response->assertJsonPath('data.variant.stock', 5); + $response->assertJsonPath('data.variant.cantidad_maxima', 5); $response->assertJsonPath('data.variants_map.1.variant_id', $secondVariant->id); }