fix(variant): simplify getName method and add test for variant without catalog attributes

This commit is contained in:
2026-08-05 09:18:12 -03:00
parent 7c9ebc6d4d
commit ee911171be
2 changed files with 23 additions and 14 deletions

View File

@@ -79,20 +79,7 @@ class Variant extends Model
public function getName(): string
{
$name = $this->catalogItem->nombre;
$this->loadMissing('definitions.itemAttribute.attribute');
$definitions = $this->definitions
->map(function (VariantDefinition $definition): ?string {
$attributeName = $definition->itemAttribute?->attribute?->nombre;
return $attributeName
? "{$attributeName}: {$definition->value}"
: $definition->value;
})
->filter()
->implode(', ');
return $definitions === '' ? $name : "{$name} ({$definitions})";
return $this->catalogItem->nombre;
}
public function getMinimumUseDate(): ?CarbonInterface