tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: refactor ProductVariantController and requests to use scoped product handling and update route parameters

Browse Source
This commit is contained in:
ncoronel
2026-06-29 14:51:36 -03:00
parent a7372f9d08
commit edcb73f748
4 changed files with 41 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
app/Domains/Catalog/Controllers/ProductVariantController.php
View File

@@ -12,80 +12,72 @@ use App\Domains\Tenant\Models\Tenant;
use App\Http\Controllers\Controller; use App\Http\Controllers\Controller;
use Illuminate\Http\JsonResponse; use Illuminate\Http\JsonResponse;
use Illuminate\Http\Response; use Illuminate\Http\Response;
use Illuminate\Support\Facades\DB;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
class ProductVariantController extends Controller class ProductVariantController extends Controller
{ {
public function index(Tenant $tenant): JsonResponse public function index(Tenant $tenant, Product $producto): JsonResponse
{ {
$query = ProductVariant::query() $query = ProductVariant::query()
->whereHas('product', fn ($query) => $query->where('tenant_codigo', $tenant->codigo)) ->where('producto_id', $producto->id)
->with(['product', 'definitions.attribute.options', 'attachments']) ->with(['product', 'definitions.attribute.options', 'attachments'])
->latest(); ->latest();
return ProductVariantResource::collection($query->paginateFromRequest())->response(); return ProductVariantResource::collection($query->paginateFromRequest())->response();
} }
public function store(StoreProductVariantRequest $request, Tenant $tenant, ProductService $productService): JsonResponse public function store(StoreProductVariantRequest $request, Tenant $tenant, Product $producto, ProductService $productService): JsonResponse
{ {
$validated = $request->validated(); $producto = $this->resolveScopedProduct($tenant, $producto);
$product = $this->resolveTenantProduct($tenant, (int) $validated['producto_id']);
$variant = $productService->createVariant($product, $validated); $variant = $productService->createVariant($producto, $request->validated());
return ProductVariantResource::make($variant)->response()->setStatusCode(201); return ProductVariantResource::make($variant)->response()->setStatusCode(201);
} }
public function show(Tenant $tenant, ProductVariant $productVariant): ProductVariantResource public function show(Tenant $tenant, Product $producto, ProductVariant $productVariant): ProductVariantResource
{ {
$productVariant = $this->resolveScopedVariant($tenant, $productVariant); $producto = $this->resolveScopedProduct($tenant, $producto);
$productVariant = $this->resolveScopedVariant($producto, $productVariant);
return ProductVariantResource::make($productVariant->load(['product', 'definitions.attribute.options', 'attachments'])); return ProductVariantResource::make($productVariant->load(['product', 'definitions.attribute.options', 'attachments']));
} }
public function update(UpdateProductVariantRequest $request, Tenant $tenant, ProductVariant $productVariant, ProductService $productService): ProductVariantResource public function update(UpdateProductVariantRequest $request, Tenant $tenant, Product $producto, ProductVariant $productVariant, ProductService $productService): ProductVariantResource
{ {
$productVariant = $this->resolveScopedVariant($tenant, $productVariant); $producto = $this->resolveScopedProduct($tenant, $producto);
$validated = $request->validated(); $productVariant = $this->resolveScopedVariant($producto, $productVariant);
$this->resolveTenantProduct($tenant, (int) $validated['producto_id']); $productVariant = $productService->updateVariant($productVariant, $request->validated());
$productVariant = $productService->updateVariant($productVariant, $validated);
return ProductVariantResource::make($productVariant); return ProductVariantResource::make($productVariant);
} }
public function destroy(Tenant $tenant, ProductVariant $productVariant, ProductService $productService): Response public function destroy(Tenant $tenant, Product $producto, ProductVariant $productVariant, ProductService $productService): Response
{ {
$productVariant = $this->resolveScopedVariant($tenant, $productVariant); $producto = $this->resolveScopedProduct($tenant, $producto);
$productVariant = $this->resolveScopedVariant($producto, $productVariant);
$productService->deleteVariant($productVariant); $productService->deleteVariant($productVariant);
return response()->noContent(); return response()->noContent();
} }
protected function resolveScopedVariant(Tenant $tenant, ProductVariant $variant): ProductVariant protected function resolveScopedProduct(Tenant $tenant, Product $product): Product
{ {
$variant->loadMissing('product'); if ($product->tenant_codigo !== $tenant->codigo) {
if ($variant->product === null || $variant->product->tenant_codigo !== $tenant->codigo) {
throw new NotFoundHttpException('Product variant not found for tenant.');
}
return $variant;
}
protected function resolveTenantProduct(Tenant $tenant, int $productId): Product
{
$product = Product::query()
->whereKey($productId)
->where('tenant_codigo', $tenant->codigo)
->first();
if ($product === null) {
throw new NotFoundHttpException('Product not found for tenant.'); throw new NotFoundHttpException('Product not found for tenant.');
} }
return $product; return $product;
} }
protected function resolveScopedVariant(Product $product, ProductVariant $variant): ProductVariant
{
if ($variant->producto_id !== $product->id) {
throw new NotFoundHttpException('Product variant not found for product.');
}
return $variant;
}
} }

14
app/Domains/Catalog/Requests/StoreProductVariantRequest.php
View File

@@ -18,20 +18,16 @@ class StoreProductVariantRequest extends FormRequest
*/ */
public function rules(): array public function rules(): array
{ {
/** @var \App\Domains\Catalog\Models\Product|null $product */
$product = $this->route('producto');
return [ return [
'producto_id' => [
'required',
'integer',
Rule::exists('productos', 'id')->where(
fn ($query) => $query->where('tenant_codigo', $this->route('tenant')?->codigo)
),
],
'slug' => [ 'slug' => [
'nullable', 'nullable',
'string', 'string',
'max:255', 'max:255',
Rule::unique('productos_variantes', 'slug')->where( Rule::unique('productos_variantes', 'slug')->where(
fn ($query) => $query->where('producto_id', $this->input('producto_id')) fn ($query) => $query->where('producto_id', $product?->id)
), ),
], ],
'nombre' => ['nullable', 'string', 'max:255'], 'nombre' => ['nullable', 'string', 'max:255'],
@@ -47,7 +43,7 @@ class StoreProductVariantRequest extends FormRequest
fn ($query) => $query->where('tenant_codigo', $this->route('tenant')?->codigo) fn ($query) => $query->where('tenant_codigo', $this->route('tenant')?->codigo)
), ),
function ($attribute, $value, $fail) { function ($attribute, $value, $fail) {
$productId = $this->input('producto_id'); $productId = $this->route('producto')?->id;
if ($productId) { if ($productId) {
$exists = \Illuminate\Support\Facades\DB::table('products_attributes') $exists = \Illuminate\Support\Facades\DB::table('products_attributes')
->where('product_id', $productId) ->where('product_id', $productId)

13
app/Domains/Catalog/Requests/UpdateProductVariantRequest.php
View File

@@ -21,22 +21,17 @@ class UpdateProductVariantRequest extends FormRequest
{ {
/** @var ProductVariant|null $productVariant */ /** @var ProductVariant|null $productVariant */
$productVariant = $this->route('productVariant'); $productVariant = $this->route('productVariant');
/** @var \App\Domains\Catalog\Models\Product|null $product */
$product = $this->route('producto');
return [ return [
'producto_id' => [
'required',
'integer',
Rule::exists('productos', 'id')->where(
fn ($query) => $query->where('tenant_codigo', $this->route('tenant')?->codigo)
),
],
'slug' => [ 'slug' => [
'nullable', 'nullable',
'string', 'string',
'max:255', 'max:255',
Rule::unique('productos_variantes', 'slug') Rule::unique('productos_variantes', 'slug')
->ignore($productVariant?->id) ->ignore($productVariant?->id)
->where(fn ($query) => $query->where('producto_id', $this->input('producto_id'))), ->where(fn ($query) => $query->where('producto_id', $product?->id)),
], ],
'nombre' => ['nullable', 'string', 'max:255'], 'nombre' => ['nullable', 'string', 'max:255'],
'stock' => ['sometimes', 'integer', 'min:0'], 'stock' => ['sometimes', 'integer', 'min:0'],
@@ -51,7 +46,7 @@ class UpdateProductVariantRequest extends FormRequest
fn ($query) => $query->where('tenant_codigo', $this->route('tenant')?->codigo) fn ($query) => $query->where('tenant_codigo', $this->route('tenant')?->codigo)
), ),
function ($attribute, $value, $fail) { function ($attribute, $value, $fail) {
$productId = $this->input('producto_id'); $productId = $this->route('producto')?->id;
if ($productId) { if ($productId) {
$exists = \Illuminate\Support\Facades\DB::table('products_attributes') $exists = \Illuminate\Support\Facades\DB::table('products_attributes')
->where('product_id', $productId) ->where('product_id', $productId)

7
app/Domains/Catalog/routes/api.php
View File

@@ -12,6 +12,9 @@ Route::prefix('tenants/{tenant:codigo}')->group(function (): void {
Route::apiResource('categorias', CategoryController::class)->parameters(['categorias' => 'categoria']); Route::apiResource('categorias', CategoryController::class)->parameters(['categorias' => 'categoria']);
Route::apiResource('productos', ProductController::class); Route::apiResource('productos', ProductController::class);
Route::apiResource('attributes', AttributeController::class); Route::apiResource('attributes', AttributeController::class);
Route::apiResource('product-variants', ProductVariantController::class) Route::apiResource('productos.variants', ProductVariantController::class)
->parameters(['product-variants' => 'productVariant']); ->parameters([
'productos' => 'producto',
'variants' => 'productVariant',
]);
}); });