tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: enhance sale detail retrieval by including trashed cart items and update related tests

Browse Source
This commit is contained in:
ncoronel
2026-08-21 08:58:18 -03:00
parent 8c09ca1204
commit dd81e3b3f7
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/Domains/Sale/Services/AdminAppSaleService.php
View File

@@ -53,6 +53,7 @@ class AdminAppSaleService
->where('tenant_codigo', $tenant->codigo) ->where('tenant_codigo', $tenant->codigo)
->with([ ->with([
'items', 'items',
'cart' => fn ($query) => $query->withTrashed(),
'cart.items.catalogItem', 'cart.items.catalogItem',
'cart.items.variant.catalogItem', 'cart.items.variant.catalogItem',
'cart.items.variant.eventDates', 'cart.items.variant.eventDates',
@@ -188,6 +189,8 @@ class AdminAppSaleService
protected function quantityExpression(): string protected function quantityExpression(): string
{ {
// El fallback se resuelve en SQL para poder ordenar por cantidad antes de paginar;
// los ítems consolidados de la compra tienen prioridad sobre los del carrito de origen.
return <<<'SQL' return <<<'SQL'
COALESCE( COALESCE(
(SELECT SUM(compra_items.cantidad) (SELECT SUM(compra_items.cantidad)

5
tests/Feature/Sale/AdminAppSaleControllerTest.php
View File

@@ -317,6 +317,11 @@ class AdminAppSaleControllerTest extends TestCase
$this->assertSame(Purchase::STATUS_CANCELLED, $purchase->fresh()->status); $this->assertSame(Purchase::STATUS_CANCELLED, $purchase->fresh()->status);
$this->assertSoftDeleted('carritos', ['id' => $cart->id]); $this->assertSoftDeleted('carritos', ['id' => $cart->id]);
$this->assertSame('converted', Cart::withTrashed()->findOrFail($cart->id)->status); $this->assertSame('converted', Cart::withTrashed()->findOrFail($cart->id)->status);
$this->getJson("/api/v1/adminapp/tenant/sales/{$purchase->id}")
->assertOk()
->assertJsonPath('data.items.0.product', 'Entrada general')
->assertJsonPath('data.items.0.quantity', 2);
} }
public function test_an_adminapp_user_cannot_change_a_sale_from_another_tenant(): void public function test_an_adminapp_user_cannot_change_a_sale_from_another_tenant(): void