test(stock): cover authoritative reservation expiration

tests/Unit/Catalog/ExpireStockReservationsServiceTest.php

@@ -2,77 +2,102 @@
 
 namespace Tests\Unit\Catalog;
 
-use App\Domains\Cart\Services\ExpireCartReservationsService;
+use App\Domains\Catalog\Models\Inventory;
+use App\Domains\Catalog\Models\StockReservation;
+use App\Domains\Catalog\Models\StockReservationLine;
 use App\Domains\Catalog\Services\ExpireStockReservationsService;
-use App\Domains\Purchase\Services\CheckoutService;
-use Illuminate\Support\Facades\Log;
-use Psr\Log\LoggerInterface;
+use App\Domains\Catalog\Services\StockReservationService;
+use App\Domains\Purchase\Services\Checkout\ReleaseCheckoutService;
+use Illuminate\Foundation\Testing\RefreshDatabase;
 use RuntimeException;
 use Tests\TestCase;
 
 class ExpireStockReservationsServiceTest extends TestCase
 {
-    public function test_it_expires_purchases_before_abandoned_cart_reservations(): void
+    use RefreshDatabase;
+
+    public function test_it_expires_an_orphan_reservation_and_releases_its_inventory(): void
     {
-        $checkout = \Mockery::mock(CheckoutService::class);
-        $checkout->shouldReceive('expireOverduePurchases')
-            ->once()
-            ->ordered()
-            ->andReturn(2);
+        $inventory = Inventory::query()->create([
+            'real_stock' => 10,
+            'reserved_stock' => 2,
+        ]);
+        $reservation = StockReservation::query()->create([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinute(),
+        ]);
+        StockReservationLine::query()->create([
+            'stock_reservation_id' => $reservation->id,
+            'inventory_id' => $inventory->id,
+            'quantity' => 2,
+            'tracks_inventory' => true,
+        ]);
 
-        $carts = \Mockery::mock(ExpireCartReservationsService::class);
-        $carts->shouldReceive('expireOverdue')
-            ->once()
-            ->ordered()
-            ->andReturn(3);
-
-        $logger = \Mockery::mock(LoggerInterface::class);
-        Log::shouldReceive('channel')
-            ->once()
-            ->with('commands')
-            ->andReturn($logger);
-        $logger->shouldReceive('info')
-            ->once()
-            ->with('Stock reservation cleanup completed.', [
-                'command' => 'reservations:expire',
-                'expired_purchases' => 2,
-                'expired_cart_reservations' => 3,
-                'total_expired' => 5,
-            ]);
-
-        $result = (new ExpireStockReservationsService($checkout, $carts))->expireOverdue();
+        $result = app(ExpireStockReservationsService::class)->expireOverdue();
 
         $this->assertSame([
-            'purchases' => 2,
-            'cart_reservations' => 3,
+            'purchases' => 0,
+            'cart_reservations' => 0,
+            'orphan_reservations' => 1,
+            'failed' => 0,
         ], $result);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $reservation->id,
+            'status' => StockReservation::STATUS_EXPIRED,
+            'expires_at' => null,
+        ]);
+        $this->assertDatabaseHas('inventories', [
+            'id' => $inventory->id,
+            'reserved_stock' => 0,
+        ]);
     }
 
-    public function test_it_logs_failed_cleanup_attempts_and_rethrows_the_error(): void
+    public function test_one_failed_reservation_does_not_stop_the_remaining_batch(): void
     {
-        $exception = new RuntimeException('Unable to clean carts.');
-        $checkout = \Mockery::mock(CheckoutService::class);
-        $checkout->shouldReceive('expireOverduePurchases')->once()->andReturn(2);
+        $first = StockReservation::query()->create([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinutes(2),
+        ]);
+        $second = StockReservation::query()->create([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinute(),
+        ]);
 
-        $carts = \Mockery::mock(ExpireCartReservationsService::class);
-        $carts->shouldReceive('expireOverdue')->once()->andThrow($exception);
+        $reservations = \Mockery::mock(StockReservationService::class);
+        $reservations->shouldReceive('expire')
+            ->twice()
+            ->andReturnUsing(function (StockReservation $reservation) use ($first): void {
+                if ($reservation->is($first)) {
+                    throw new RuntimeException('Broken reservation.');
+                }
 
-        $logger = \Mockery::mock(LoggerInterface::class);
-        Log::shouldReceive('channel')
-            ->once()
-            ->with('commands')
-            ->andReturn($logger);
-        $logger->shouldReceive('error')
-            ->once()
-            ->with('Stock reservation cleanup failed.', [
-                'command' => 'reservations:expire',
-                'expired_purchases' => 2,
-                'expired_cart_reservations' => null,
-                'exception' => $exception,
-            ]);
+                $reservation->update([
+                    'status' => StockReservation::STATUS_EXPIRED,
+                    'expires_at' => null,
+                    'expired_at' => now(),
+                ]);
+            });
 
-        $this->expectExceptionObject($exception);
+        $service = new ExpireStockReservationsService(
+            \Mockery::mock(ReleaseCheckoutService::class),
+            $reservations,
+        );
 
-        (new ExpireStockReservationsService($checkout, $carts))->expireOverdue();
+        $result = $service->expireOverdue();
+
+        $this->assertSame([
+            'purchases' => 0,
+            'cart_reservations' => 0,
+            'orphan_reservations' => 1,
+            'failed' => 1,
+        ], $result);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $first->id,
+            'status' => StockReservation::STATUS_ACTIVE,
+        ]);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $second->id,
+            'status' => StockReservation::STATUS_EXPIRED,
+        ]);
     }
 }