test(stock): cover authoritative reservation expiration

tests/Feature/Cart/CartControllerTest.php

@@ -47,6 +47,7 @@ class CartControllerTest extends TestCase
         ]));
         $this->assertTrue(Schema::hasColumn('carritos', 'current_stock_reservation_id'));
         $this->assertTrue(Schema::hasColumn('compras', 'stock_reservation_id'));
+        $this->assertFalse(Schema::hasColumn('compras', 'expires_at'));
     }
 
     public function test_it_aggregates_shared_inventory_into_one_cart_reservation_line(): void

tests/Feature/Integration/TelepagosWebhookTest.php

@@ -62,6 +62,10 @@ class TelepagosWebhookTest extends TestCase
 
     public function test_transfer_payment_intent_persists_transfer_payer_dni_without_replacing_customer_dni(): void
     {
+        config()->set('purchase.payment_expiration_minutes.transfer', 60);
+        $now = now()->startOfSecond();
+        $this->travelTo($now);
+
         $tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
         $this->configureTelepagosIntegration($tenant);
         $user = User::factory()->create();
@@ -99,6 +103,13 @@ class TelepagosWebhookTest extends TestCase
             'payment_method' => 'transfer',
             'status' => Purchase::STATUS_PENDING_PAYMENT,
         ]);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $purchase->stock_reservation_id,
+            'status' => 'active',
+            'expires_at' => $now->copy()->addMinutes(60)->toDateTimeString(),
+        ]);
+
+        $this->travelBack();
     }
 
     public function test_transfer_webhook_matches_pending_purchase_by_dni_and_total_amount(): void

tests/Feature/Purchase/StorePurchaseTest.php

@@ -538,7 +538,6 @@ class StorePurchaseTest extends TestCase
         $previousPurchase->update([
             'status' => Purchase::STATUS_PENDING_PAYMENT,
             'payment_method' => 'transfer',
-            'expires_at' => now()->addMinutes(30),
         ]);
 
         $currentPurchase = app(CheckoutService::class)->startCheckout(
@@ -550,7 +549,6 @@ class StorePurchaseTest extends TestCase
         $this->assertDatabaseHas('compras', [
             'id' => $previousPurchase->id,
             'status' => Purchase::STATUS_SUPERSEDED,
-            'expires_at' => null,
         ]);
         $this->assertDatabaseHas('carritos', [
             'id' => $cart->id,
@@ -635,7 +633,7 @@ class StorePurchaseTest extends TestCase
             ->where('status', 'active')
             ->firstOrFail();
         $cartItemId = $purchase->cart->items()->firstOrFail()->id;
-        $purchase->update(['expires_at' => now()->subMinute()]);
+        $purchase->stockReservation()->update(['expires_at' => now()->subMinute()]);
 
         $this->artisan('reservations:expire')->assertSuccessful();
 
@@ -860,7 +858,6 @@ class StorePurchaseTest extends TestCase
         $purchase->update([
             'payment_method' => 'transfer',
             'status' => Purchase::STATUS_PENDING_PAYMENT,
-            'expires_at' => now()->addMinutes(30),
         ]);
 
         $url = "/api/tenants/sonder/compras/{$purchase->id}/review";
@@ -874,6 +871,10 @@ class StorePurchaseTest extends TestCase
         $this->assertDatabaseHas('compras', [
             'id' => $purchase->id,
             'status' => Purchase::STATUS_IN_REVIEW,
+        ]);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $purchase->stock_reservation_id,
+            'status' => 'active',
             'expires_at' => null,
         ]);
 
@@ -956,7 +957,7 @@ class StorePurchaseTest extends TestCase
             ->where('status', 'active')
             ->firstOrFail();
 
-        $this->assertNotNull($purchase->expires_at);
+        $this->assertNotNull($purchase->stockReservation->expires_at);
         $this->assertDatabaseHas('inventories', [
             'id' => $variant->inventory_id,
             'reserved_stock' => 3,