test(stock): cover aggregate reservation lifecycle

tests/Feature/Cart/CartControllerTest.php

@@ -47,7 +47,6 @@ class CartControllerTest extends TestCase
         ]));
         $this->assertTrue(Schema::hasColumn('carritos', 'current_stock_reservation_id'));
         $this->assertTrue(Schema::hasColumn('compras', 'stock_reservation_id'));
-        $this->assertFalse(Schema::hasColumn('compras', 'expires_at'));
     }
 
     public function test_it_aggregates_shared_inventory_into_one_cart_reservation_line(): void
@@ -186,7 +185,7 @@ class CartControllerTest extends TestCase
         $this->travelBack();
     }
 
-    public function test_it_expires_a_cart_reservation_and_automatically_replaces_the_cart(): void
+    public function test_it_expires_abandoned_cart_reservations_without_deleting_the_cart(): void
     {
         config()->set('catalog.stock_reservation_expiration_minutes', 30);
         $tenant = $this->createTenant('acme');
@@ -223,12 +222,11 @@ class CartControllerTest extends TestCase
         $this->assertDatabaseHas('carrito_items', ['id' => $cartItemId]);
         $this->assertDatabaseHas('carritos', [
             'id' => $cartId,
-            'status' => Cart::STATUS_EXPIRED,
-            'current_stock_reservation_id' => $reservationId,
+            'status' => 'active',
+            'current_stock_reservation_id' => null,
             'deleted_at' => null,
         ]);
         $this->assertDatabaseHas('stock_reservations', [
-            'id' => $reservationId,
             'status' => 'expired',
             'expires_at' => null,
         ]);
@@ -237,34 +235,6 @@ class CartControllerTest extends TestCase
             'quantity' => 2,
         ]);
 
-        $currentCart = $this->getJson('/api/tenants/acme/cart')
-            ->assertOk()
-            ->assertJsonPath('data.status', Cart::STATUS_ACTIVE)
-            ->assertJsonPath('data.items', [])
-            ->assertJsonMissingPath('data.stock_reservation')
-            ->assertJsonMissingPath('data.current_stock_reservation_id');
-        $newCartId = $currentCart->json('data.id');
-
-        $this->assertNotSame($cartId, $newCartId);
-        $this->assertDatabaseHas('carritos', [
-            'id' => $cartId,
-            'status' => Cart::STATUS_ABANDONED,
-            'current_stock_reservation_id' => $reservationId,
-        ]);
-        $this->assertDatabaseHas('carritos', [
-            'id' => $newCartId,
-            'status' => Cart::STATUS_ACTIVE,
-            'current_stock_reservation_id' => null,
-        ]);
-
-        $this->postJson('/api/tenants/acme/cart/items', [
-            'catalog_item_id' => $item->id,
-            'cantidad' => 1,
-        ])
-            ->assertOk()
-            ->assertJsonPath('data.id', $newCartId)
-            ->assertJsonPath('data.items.0.cantidad', 1);
-
         $this->artisan('reservations:expire')
             ->expectsOutput('Expired purchases: 0')
             ->expectsOutput('Expired cart reservations: 0')