tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(menus): separate shopit and onticket admin menus

Browse Source
This commit is contained in:
ncoronel
2026-09-29 09:04:50 -03:00
parent 0fe38df019
commit d42896e956
19 changed files with 657 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Feature/Auth/ScannerMeControllerTest.php
View File

@@ -43,7 +43,7 @@ class ScannerMeControllerTest extends TestCase
'route' => '/scanner/scan',
]);
$foreign = Menu::query()->create([
'code' => 'adminapp.inicio',
'code' => 'onticket.adminapp.inicio',
'label' => 'Administración',
'route' => '/admin/inicio',
]);

2
tests/Feature/Desfile/EntryControllerTest.php
View File

@@ -186,7 +186,7 @@ class EntryControllerTest extends TestCase
'admin_website_type_code' => 'onticket',
]);
$menu = Menu::query()->firstOrCreate(
['code' => 'adminapp.desfile.entradas'],
['code' => 'onticket.adminapp.desfile.entradas'],
['label' => 'Entradas', 'route' => '/admin/desfile/entradas'],
);
$tenant->menues()->attach($menu->code);

2
tests/Feature/FiestaFutbolInfantil/AccommodationControllerTest.php
View File

@@ -236,7 +236,7 @@ class AccommodationControllerTest extends TestCase
if ($withMenu) {
$menu = Menu::query()->firstOrCreate(
['code' => 'adminapp.fiesta-futbol-infantil.alojamientos'],
['code' => 'onticket.adminapp.fiesta-futbol-infantil.alojamientos'],
['label' => 'Alojamientos', 'route' => '/admin/alojamientos'],
);
$tenant->menues()->syncWithoutDetaching([$menu->code]);

10
tests/Feature/FiestaFutbolInfantil/EntryControllerTest.php
View File

@@ -43,10 +43,10 @@ class EntryControllerTest extends TestCase
{
$tenant = $this->createFiestaTenant();
$categories = [
'entries' => ['Entradas', 'adminapp.fiesta-futbol-infantil.entradas'],
'foods' => ['Comidas', 'adminapp.fiesta-futbol-infantil.comida'],
'accommodations' => ['Alojamientos', 'adminapp.fiesta-futbol-infantil.alojamientos'],
'merchandise' => ['Merchandising', 'adminapp.fiesta-futbol-infantil.merchandising'],
'entries' => ['Entradas', 'onticket.adminapp.fiesta-futbol-infantil.entradas'],
'foods' => ['Comidas', 'onticket.adminapp.fiesta-futbol-infantil.comida'],
'accommodations' => ['Alojamientos', 'onticket.adminapp.fiesta-futbol-infantil.alojamientos'],
'merchandise' => ['Merchandising', 'onticket.adminapp.fiesta-futbol-infantil.merchandising'],
];
foreach ($categories as [$label, $menuCode]) {
@@ -405,7 +405,7 @@ class EntryControllerTest extends TestCase
{
$tenant = $this->createTenant('fiesta_futbol_infantil');
$menu = Menu::query()->create([
'code' => 'adminapp.fiesta-futbol-infantil.entradas',
'code' => 'onticket.adminapp.fiesta-futbol-infantil.entradas',
'label' => 'Entradas',
'route' => '/admin/entradas',
]);

2
tests/Feature/FiestaFutbolInfantil/FoodControllerTest.php
View File

@@ -367,7 +367,7 @@ class FoodControllerTest extends TestCase
'time_end' => '23:59',
]);
$menu = Menu::query()->create([
'code' => 'adminapp.fiesta-futbol-infantil.comida',
'code' => 'onticket.adminapp.fiesta-futbol-infantil.comida',
'label' => 'Comida',
'route' => '/admin/comidas',
]);

2
tests/Feature/FiestaFutbolInfantil/MerchandiseControllerTest.php
View File

@@ -293,7 +293,7 @@ class MerchandiseControllerTest extends TestCase
['value' => 'XL', 'label' => 'XL', 'sort_order' => 4],
]);
$menu = Menu::query()->create([
'code' => 'adminapp.fiesta-futbol-infantil.merchandising',
'code' => 'onticket.adminapp.fiesta-futbol-infantil.merchandising',
'label' => 'Merchandising',
'route' => '/admin/merchandising',
]);

2
tests/Feature/Forms/AdminAppDesfileEntryReservationFormControllerTest.php
View File

@@ -135,7 +135,7 @@ class AdminAppDesfileEntryReservationFormControllerTest extends TestCase
private function grantReservationsMenu(Tenant $tenant): void
{
$menu = Menu::query()->create([
'code' => 'adminapp.desfile.reservas',
'code' => 'onticket.adminapp.desfile.reservas',
'label' => 'Reserva de Tickets',
'route' => '/admin/desfile/reservas',
]);

2
tests/Feature/Forms/AdminAppTicketFilterFormControllerTest.php
View File

@@ -349,7 +349,7 @@ class AdminAppTicketFilterFormControllerTest extends TestCase
private function grantTicketsMenu(Tenant $tenant): void
{
$menu = Menu::query()->create([
'code' => 'adminapp.tickets',
'code' => 'onticket.adminapp.tickets',
'label' => 'Tickets',
'route' => '/admin/tickets',
]);

201
tests/Feature/Migrations/SeparateAdminAppMenusByWebsiteTypeTest.php Normal file
View File

@@ -0,0 +1,201 @@
<?php
namespace Tests\Feature\Migrations;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Schema;
use Tests\TestCase;
class SeparateAdminAppMenusByWebsiteTypeTest extends TestCase
{
private const SHOPIT_MENU_CODES = [
'shopit.adminapp.marca',
'shopit.adminapp.contacto',
'shopit.adminapp.productos',
'shopit.adminapp.categorias',
'shopit.adminapp.transacciones',
'shopit.adminapp.reportes',
'shopit.adminapp.usuarios_roles',
];
protected function setUp(): void
{
parent::setUp();
Schema::create('menues', function (Blueprint $table): void {
$table->id();
$table->string('code')->unique();
$table->string('label');
$table->string('parent_menu_code')->nullable();
$table->string('content_type')->default('dynamic');
$table->json('static_content_schema')->nullable();
$table->string('route');
$table->timestamps();
});
Schema::create('tenants', function (Blueprint $table): void {
$table->string('codigo')->primary();
$table->string('admin_website_type_code')->nullable();
});
Schema::create('roles', function (Blueprint $table): void {
$table->string('codigo')->primary();
});
Schema::create('tenants_menues', function (Blueprint $table): void {
$table->id();
$table->string('tenant_code');
$table->string('menu_code');
$table->json('static_content')->nullable();
$table->timestamps();
$table->unique(['tenant_code', 'menu_code']);
});
Schema::create('roles_menues', function (Blueprint $table): void {
$table->id();
$table->string('rol_codigo');
$table->string('menu_codigo');
$table->unique(['rol_codigo', 'menu_codigo']);
});
$now = now();
DB::table('menues')->insert([
[
'code' => 'main.adminapp',
'label' => 'Administración',
'parent_menu_code' => null,
'route' => '/',
'created_at' => $now,
'updated_at' => $now,
],
[
'code' => 'adminapp.inicio',
'label' => 'Inicio',
'parent_menu_code' => 'main.adminapp',
'route' => '/admin/inicio',
'created_at' => $now,
'updated_at' => $now,
],
[
'code' => 'adminapp.tickets',
'label' => 'Tickets',
'parent_menu_code' => 'main.adminapp',
'route' => '/admin/tickets',
'created_at' => $now,
'updated_at' => $now,
],
[
'code' => 'account',
'label' => 'Mi cuenta',
'parent_menu_code' => null,
'route' => '/mi-cuenta',
'created_at' => $now,
'updated_at' => $now,
],
]);
DB::table('tenants')->insert([
['codigo' => 'sonder', 'admin_website_type_code' => 'shopit'],
['codigo' => 'mutual_smep', 'admin_website_type_code' => 'shopit'],
['codigo' => 'fiesta_futbol_infantil', 'admin_website_type_code' => 'onticket'],
]);
DB::table('roles')->insert([
['codigo' => 'admin'],
['codigo' => 'adminapp'],
['codigo' => 'user'],
]);
foreach (['sonder', 'mutual_smep', 'fiesta_futbol_infantil'] as $tenantCode) {
foreach (['main.adminapp', 'adminapp.inicio', 'account'] as $menuCode) {
DB::table('tenants_menues')->insert([
'tenant_code' => $tenantCode,
'menu_code' => $menuCode,
'created_at' => $now,
'updated_at' => $now,
]);
}
}
DB::table('tenants_menues')->insert([
'tenant_code' => 'fiesta_futbol_infantil',
'menu_code' => 'adminapp.tickets',
'created_at' => $now,
'updated_at' => $now,
]);
DB::table('roles_menues')->insert([
['rol_codigo' => 'admin', 'menu_codigo' => 'adminapp.inicio'],
['rol_codigo' => 'adminapp', 'menu_codigo' => 'adminapp.inicio'],
['rol_codigo' => 'adminapp', 'menu_codigo' => 'adminapp.tickets'],
]);
}
protected function tearDown(): void
{
Schema::dropIfExists('roles_menues');
Schema::dropIfExists('tenants_menues');
Schema::dropIfExists('roles');
Schema::dropIfExists('tenants');
Schema::dropIfExists('menues');
parent::tearDown();
}
public function test_it_separates_admin_menus_by_admin_website_type_and_rolls_back(): void
{
$migration = require database_path(
'migrations/2026_09_29_000000_separate_adminapp_menus_by_website_type.php'
);
$migration->up();
$migration->up();
$this->assertDatabaseMissing('menues', ['code' => 'adminapp.inicio']);
$this->assertDatabaseHas('menues', ['code' => 'onticket.adminapp.inicio']);
$this->assertDatabaseHas('tenants_menues', [
'tenant_code' => 'fiesta_futbol_infantil',
'menu_code' => 'onticket.adminapp.tickets',
]);
$this->assertDatabaseHas('tenants_menues', [
'tenant_code' => 'fiesta_futbol_infantil',
'menu_code' => 'onticket.adminapp.inicio',
]);
foreach (['sonder', 'mutual_smep'] as $tenantCode) {
$adminMenuCodes = DB::table('tenants_menues')
->join('menues', 'menues.code', '=', 'tenants_menues.menu_code')
->where('tenants_menues.tenant_code', $tenantCode)
->where(fn ($query) => $query
->where('menues.code', 'main.adminapp')
->orWhere('menues.parent_menu_code', 'main.adminapp'))
->orderBy('menues.code')
->pluck('menues.code')
->all();
$this->assertSame(
collect(['main.adminapp', ...self::SHOPIT_MENU_CODES])->sort()->values()->all(),
$adminMenuCodes,
);
$this->assertDatabaseHas('tenants_menues', [
'tenant_code' => $tenantCode,
'menu_code' => 'account',
]);
}
foreach (self::SHOPIT_MENU_CODES as $menuCode) {
$this->assertDatabaseHas('roles_menues', [
'rol_codigo' => 'adminapp',
'menu_codigo' => $menuCode,
]);
}
$migration->down();
$this->assertDatabaseHas('menues', ['code' => 'adminapp.inicio']);
$this->assertDatabaseMissing('menues', ['code' => 'onticket.adminapp.inicio']);
$this->assertDatabaseMissing('menues', ['code' => 'shopit.adminapp.marca']);
$this->assertDatabaseHas('tenants_menues', [
'tenant_code' => 'sonder',
'menu_code' => 'adminapp.inicio',
]);
$this->assertDatabaseHas('tenants_menues', [
'tenant_code' => 'fiesta_futbol_infantil',
'menu_code' => 'adminapp.tickets',
]);
}
}

6
tests/Feature/Seeders/DesfilePuraTendenciaSeederTest.php
View File

@@ -135,7 +135,7 @@ class DesfilePuraTendenciaSeederTest extends TestCase
$expectedMenus = DB::table('tenants_menues')
->where('tenant_code', 'fiesta_futbol_infantil')
->where('menu_code', 'not like', 'adminapp.fiesta-futbol-infantil.%')
->where('menu_code', 'not like', 'onticket.adminapp.fiesta-futbol-infantil.%')
->orderBy('menu_code')
->pluck('menu_code')
->all();
@@ -147,9 +147,9 @@ class DesfilePuraTendenciaSeederTest extends TestCase
$this->assertSame($expectedMenus, $actualMenus);
$this->assertContains('main.adminapp', $actualMenus);
$this->assertContains('adminapp.event', $actualMenus);
$this->assertContains('onticket.adminapp.event', $actualMenus);
$this->assertContains('scanner.scan', $actualMenus);
$this->assertNotContains('adminapp.fiesta-futbol-infantil.entradas', $actualMenus);
$this->assertNotContains('onticket.adminapp.fiesta-futbol-infantil.entradas', $actualMenus);
$catalogItem = DB::table('catalog_items')
->where('tenant_code', 'desfile_pura_tendencia')

104
tests/Feature/Seeders/MenuSeederTest.php
View File

@@ -5,6 +5,7 @@ namespace Tests\Feature\Seeders;
use App\Domains\Core\Authorization\Enums\RoleCode;
use App\Domains\Core\Authorization\Models\Role;
use App\Domains\Core\Menu\Models\Menu;
use App\Domains\Core\Tenant\Models\AdminWebsiteType;
use App\Domains\Core\Tenant\Models\Tenant;
use App\Shared\Attachable\Enums\AttachmentType;
use App\Shared\Attachable\Models\Attachment;
@@ -25,21 +26,26 @@ class MenuSeederTest extends TestCase
$this->seed(MenuSeeder::class);
$expectedMenus = [
'adminapp.inicio' => ['Inicio', '/admin/inicio'],
'adminapp.catalog' => ['Catálogo', '/admin/catalog'],
'adminapp.categories' => ['Categorías', '/admin/categories'],
'adminapp.combos' => ['Combos', '/admin/combos'],
'adminapp.event' => ['Eventos', '/admin/event'],
'adminapp.staff' => ['Staff', '/admin/staff'],
'adminapp.ventas' => ['Ventas', '/admin/ventas'],
'onticket.adminapp.inicio' => ['Inicio', '/admin/inicio'],
'onticket.adminapp.catalog' => ['Catálogo', '/admin/catalog'],
'onticket.adminapp.categories' => ['Categorías', '/admin/categories'],
'onticket.adminapp.combos' => ['Combos', '/admin/combos'],
'onticket.adminapp.event' => ['Eventos', '/admin/event'],
'onticket.adminapp.staff' => ['Usuarios', '/admin/staff'],
'onticket.adminapp.ventas' => ['Ventas', '/admin/ventas'],
];
$fiestaCategoryMenus = [
'adminapp.tickets' => ['Tickets', '/admin/tickets'],
'adminapp.fiesta-futbol-infantil.entradas' => ['Entradas', '/admin/entradas'],
'adminapp.fiesta-futbol-infantil.alojamientos' => ['Alojamientos', '/admin/alojamientos'],
'adminapp.fiesta-futbol-infantil.merchandising' => ['Merchandising', '/admin/merchandising'],
'adminapp.fiesta-futbol-infantil.comida' => ['Comida', '/admin/comidas'],
'onticket.adminapp.tickets' => ['Tickets', '/admin/tickets'],
'onticket.adminapp.fiesta-futbol-infantil.entradas' => ['Entradas', '/admin/entradas'],
'onticket.adminapp.fiesta-futbol-infantil.alojamientos' => ['Alojamientos', '/admin/alojamientos'],
'onticket.adminapp.fiesta-futbol-infantil.merchandising' => ['Merchandising', '/admin/merchandising'],
'onticket.adminapp.fiesta-futbol-infantil.comida' => ['Comida', '/admin/comidas'],
];
$desfileMenus = [
'onticket.adminapp.desfile.entradas' => ['Entradas', '/admin/desfile/entradas'],
'onticket.adminapp.desfile.reservas' => ['Reserva de Tickets', '/admin/desfile/reservas'],
];
$shopItMenus = $this->shopItAdminMenus();
$adminApp = Menu::query()
->with('children')
@@ -53,7 +59,8 @@ class MenuSeederTest extends TestCase
collect(array_keys([
...$expectedMenus,
...$fiestaCategoryMenus,
'adminapp.desfile.entradas' => ['Entradas', '/admin/desfile/entradas'],
...$desfileMenus,
...$shopItMenus,
]))->sort()->values()->all(),
$adminApp->children->pluck('code')->sort()->values()->all()
);
@@ -88,10 +95,10 @@ class MenuSeederTest extends TestCase
}
foreach ([
'adminapp.inicio',
'adminapp.catalog',
'adminapp.categories',
'adminapp.combos',
'onticket.adminapp.inicio',
'onticket.adminapp.catalog',
'onticket.adminapp.categories',
'onticket.adminapp.combos',
] as $code) {
$this->assertFalse(
$fiestaTenant->menues()->where('menues.code', $code)->exists()
@@ -116,6 +123,50 @@ class MenuSeederTest extends TestCase
);
}
public function test_it_assigns_only_shopit_admin_menus_to_shopit_admin_tenants(): void
{
AdminWebsiteType::query()->create([
'codigo' => 'shopit',
'nombre' => 'ShopIt',
]);
$sonder = $this->createTenant('sonder', 'shopit');
$mutualSmep = $this->createTenant('mutual_smep', 'shopit');
$onTicket = $this->createTenant('onticket');
$this->seed(MenuSeeder::class);
$shopItMenuCodes = array_keys($this->shopItAdminMenus());
foreach ([$sonder, $mutualSmep] as $tenant) {
$adminMenuCodes = $tenant->menues()
->where(fn ($query) => $query
->where('menues.code', 'main.adminapp')
->orWhere('menues.parent_menu_code', 'main.adminapp'))
->orderBy('menues.code')
->pluck('menues.code')
->all();
$this->assertSame(
collect(['main.adminapp', ...$shopItMenuCodes])->sort()->values()->all(),
$adminMenuCodes,
);
}
foreach ($this->shopItAdminMenus() as $code => [$label, $route]) {
$menu = Menu::query()->where('code', $code)->firstOrFail();
$this->assertSame($label, $menu->label);
$this->assertSame($route, $menu->route);
$this->assertSame('main.adminapp', $menu->parent_menu_code);
$this->assertFalse($onTicket->menues()->where('menues.code', $code)->exists());
}
$this->assertFalse(
Menu::query()->where('code', 'like', 'adminapp.%')->exists()
);
}
public function test_it_assigns_menus_to_the_expected_roles(): void
{
$this->seed(AuthorizationSeeder::class);
@@ -162,7 +213,7 @@ class MenuSeederTest extends TestCase
$this->assertSame($userMenuCodes, $userRoleMenuCodes);
$this->assertNotContains('main.adminapp', $userRoleMenuCodes);
$this->assertNotContains('adminapp.catalog', $userRoleMenuCodes);
$this->assertNotContains('onticket.adminapp.catalog', $userRoleMenuCodes);
$scannerRoleMenuCodes = Role::query()
->where('codigo', RoleCode::Scanner->value)
@@ -382,7 +433,7 @@ class MenuSeederTest extends TestCase
);
}
private function createTenant(string $code): Tenant
private function createTenant(string $code, ?string $adminWebsiteTypeCode = null): Tenant
{
$headerLogo = $this->createAttachment("{$code}-header.png");
$footerLogo = $this->createAttachment("{$code}-footer.png");
@@ -391,6 +442,7 @@ class MenuSeederTest extends TestCase
'codigo' => $code,
'nombre' => $code,
'dominio' => "{$code}.example.com",
'admin_website_type_code' => $adminWebsiteTypeCode,
'primary_color' => '#111111',
'secondary_color' => '#222222',
'danger_color' => '#333333',
@@ -402,6 +454,20 @@ class MenuSeederTest extends TestCase
]);
}
/** @return array<string, array{string, string}> */
private function shopItAdminMenus(): array
{
return [
'shopit.adminapp.marca' => ['Marca', '/admin/marca'],
'shopit.adminapp.contacto' => ['Contacto', '/admin/contacto'],
'shopit.adminapp.productos' => ['Productos', '/admin/productos'],
'shopit.adminapp.categorias' => ['Categorías', '/admin/categorias'],
'shopit.adminapp.transacciones' => ['Transacciones', '/admin/transacciones'],
'shopit.adminapp.reportes' => ['Reportes', '/admin/reportes'],
'shopit.adminapp.usuarios_roles' => ['Usuarios y roles', '/admin/usuarios-roles'],
];
}
private function createAttachment(string $filename): Attachment
{
return Attachment::query()->create([

2
tests/Feature/Ticket/AdminAppTicketControllerTest.php
View File

@@ -1359,7 +1359,7 @@ class AdminAppTicketControllerTest extends TestCase
private function grantTicketsMenu(Tenant $tenant): void
{
$menu = Menu::query()->create([
'code' => 'adminapp.tickets',
'code' => 'onticket.adminapp.tickets',
'label' => 'Tickets',
'route' => '/admin/tickets',
]);