tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(ticket): add command to convert fixed_window validity times between local timezone and UTC

Browse Source
This commit is contained in:
ncoronel
2026-09-21 16:22:48 -03:00
parent 969e99b3ae
commit d33b435ba5
4 changed files with 82 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
tests/Feature/Ticket/ConvertValidityTimesToUtcTest.php
View File

@@ -27,48 +27,49 @@ class ConvertValidityTimesToUtcTest extends TestCase
DB::table('validity_times')->insert(['id' => 3, 'type' => 'time_window', 'start_time' => '07:00:00', 'end_time' => '10:00:00']);
}
public function test_preview_does_not_modify_data(): void
{
$this->artisan('tickets:convert-validity-times-to-utc', ['--all' => true])->assertSuccessful();
$this->assertDatabaseHas('validity_times', ['id' => 1, 'fixed_starts_at' => '2026-09-21 07:00:00']);
}
public function test_explicit_conversion_preserves_multiple_days_nulls_and_time_windows(): void
{
$this->artisan('tickets:convert-validity-times-to-utc', ['--ids' => '1,2', '--apply' => true])->assertSuccessful();
$this->assertDatabaseHas('validity_times', [
'id' => 1, 'fixed_starts_at' => '2026-09-21 10:00:00', 'fixed_expires_at' => '2026-09-24 02:59:00',
]);
$this->assertDatabaseHas('validity_times', ['id' => 2, 'fixed_starts_at' => null, 'fixed_expires_at' => '2026-09-25 02:59:00']);
$this->assertDatabaseHas('validity_times', ['id' => 3, 'start_time' => '07:00:00', 'end_time' => '10:00:00']);
}
public function test_all_converts_every_fixed_window_without_a_migration(): void
public function test_all_round_trip_restores_exact_values_across_dates_and_nulls(): void
{
$before = DB::table('validity_times')->orderBy('id')->get()->toJson();
$this->artisan('tickets:convert-validity-times-to-utc', ['--all' => true, '--apply' => true])->assertSuccessful();
$this->assertDatabaseHas('validity_times', ['id' => 1, 'fixed_starts_at' => '2026-09-21 10:00:00', 'fixed_expires_at' => '2026-09-24 02:59:00']);
$this->assertDatabaseHas('validity_times', ['id' => 2, 'fixed_starts_at' => null, 'fixed_expires_at' => '2026-09-25 02:59:00']);
$this->assertDatabaseHas('validity_times', ['id' => 3, 'start_time' => '07:00:00', 'end_time' => '10:00:00']);
$this->artisan('tickets:convert-validity-times-to-utc', ['--all' => true, '--reverse' => true, '--apply' => true])->assertSuccessful();
$this->assertSame($before, DB::table('validity_times')->orderBy('id')->get()->toJson());
}
public function test_ids_leave_unselected_fixed_windows_unchanged(): void
public function test_reverse_preview_shows_local_result_without_writing(): void
{
$this->artisan('tickets:convert-validity-times-to-utc', ['--ids' => '1', '--apply' => true])->assertSuccessful();
$before = DB::table('validity_times')->orderBy('id')->get()->toJson();
$this->artisan('tickets:convert-validity-times-to-utc', ['--all' => true, '--reverse' => true])
->expectsOutputToContain('UTC -> America/Argentina/Buenos_Aires')
->expectsTable(['ID', 'Inicio original', 'Fin original', 'Inicio resultante', 'Fin resultante'], [
[1, '2026-09-21 07:00:00', '2026-09-23 23:59:00', '2026-09-21 04:00:00', '2026-09-23 20:59:00'],
[2, null, '2026-09-24 23:59:00', null, '2026-09-24 20:59:00'],
])->assertSuccessful();
$this->assertSame($before, DB::table('validity_times')->orderBy('id')->get()->toJson());
}
public function test_reverse_by_ids_uses_selected_timezone_and_preserves_other_rows(): void
{
$this->artisan('tickets:convert-validity-times-to-utc', ['--ids' => '1', '--reverse' => true, '--source-timezone' => 'Asia/Tokyo', '--apply' => true])->assertSuccessful();
$this->assertDatabaseHas('validity_times', ['id' => 1, 'fixed_starts_at' => '2026-09-21 16:00:00', 'fixed_expires_at' => '2026-09-24 08:59:00']);
$this->assertDatabaseHas('validity_times', ['id' => 2, 'fixed_expires_at' => '2026-09-24 23:59:00']);
$this->assertDatabaseHas('validity_times', ['id' => 3, 'start_time' => '07:00:00']);
}
public function test_invalid_scope_is_rejected_before_any_write(): void
public function test_invalid_scope_fails_without_changes(): void
{
foreach ([[], ['--all' => true, '--ids' => '1'], ['--ids' => '1,999'], ['--ids' => '1,3'], ['--ids' => 'bad'], ['--ids' => '1', '--source-timezone' => 'bad']] as $options) {
$this->artisan('tickets:convert-validity-times-to-utc', $options + ['--apply' => true])->assertFailed();
$before = DB::table('validity_times')->orderBy('id')->get()->toJson();
foreach ([[], ['--ids' => '1', '--all' => true], ['--ids' => '1,999'], ['--ids' => '1,3'], ['--ids' => 'bad'], ['--all' => true, '--source-timezone' => 'bad']] as $options) {
$this->artisan('tickets:convert-validity-times-to-utc', $options + ['--reverse' => true, '--apply' => true])->assertFailed();
}
$this->assertDatabaseHas('validity_times', ['id' => 1, 'fixed_starts_at' => '2026-09-21 07:00:00']);
$this->assertSame($before, DB::table('validity_times')->orderBy('id')->get()->toJson());
}
public function test_failure_rolls_back_all_updates(): void
public function test_reverse_failure_rolls_back_entire_operation(): void
{
DB::statement("CREATE TRIGGER prevent_second_update BEFORE UPDATE ON validity_times WHEN OLD.id = 2 BEGIN SELECT RAISE(ABORT, 'test failure'); END");
$this->artisan('tickets:convert-validity-times-to-utc', ['--ids' => '1,2', '--apply' => true])->assertFailed();
$this->assertDatabaseHas('validity_times', ['id' => 1, 'fixed_starts_at' => '2026-09-21 07:00:00']);
DB::statement("CREATE TRIGGER fail_second BEFORE UPDATE ON validity_times WHEN OLD.id = 2 BEGIN SELECT RAISE(ABORT, 'test failure'); END");
$before = DB::table('validity_times')->orderBy('id')->get()->toJson();
$this->artisan('tickets:convert-validity-times-to-utc', ['--all' => true, '--reverse' => true, '--apply' => true])->assertFailed();
$this->assertSame($before, DB::table('validity_times')->orderBy('id')->get()->toJson());
}
}