tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: refactor cart item handling to use mapped buyable types and improve method signatures

Browse Source
This commit is contained in:
ncoronel
2026-07-14 16:43:00 -03:00
parent 480ee70393
commit c05206cc51
7 changed files with 50 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/Domains/Cart/Resources/CartItemResource.php
View File

@@ -22,7 +22,7 @@ class CartItemResource extends JsonResource
$precio = $buyable?->getPrice();
$imageUrl = null;
if ($this->buyable_type === 'variant' && $buyable && $buyable->relationLoaded('attachments')) {
if ($this->buyable_type === \App\Domains\Catalog\Models\ProductVariant::class && $buyable && $buyable->relationLoaded('attachments')) {
$firstAttachment = $buyable->attachments->first();
if ($firstAttachment) {
$imageUrl = $firstAttachment->getTemporaryUrl(1440);
@@ -33,7 +33,7 @@ class CartItemResource extends JsonResource
'id' => $this->id,
'cantidad' => $this->cantidad,
'precio_unitario' => $this->formatMoney($precio),
'buyable_type' => $this->buyable_type,
'buyable_type' => $this->mapBuyableTypeToAlias($this->buyable_type),
'buyable_id' => $this->buyable_id,
'product' => $buyable === null ? null : [
'nombre' => $productName,
@@ -42,6 +42,15 @@ class CartItemResource extends JsonResource
];
}
protected function mapBuyableTypeToAlias(?string $type): string
{
return match ($type) {
\App\Domains\Catalog\Models\ProductVariant::class => 'variant',
\App\Domains\Bundle\Models\Bundle::class => 'bundle',
default => 'unknown',
};
}
protected function formatMoney(float|int|string|null $amount): string
{
return number_format((float) ($amount ?? 0), 2, '.', '');