feat(authorization): refactor role management to use RoleCode enum, update migrations, seeders, and tests

tests/Feature/Auth/UserAuthorizationRelationsTest.php

@@ -2,14 +2,10 @@
 
 namespace Tests\Feature\Auth;
 
-use App\Domains\Attachable\Enums\AttachmentType;
-use App\Domains\Attachable\Models\Attachment;
 use App\Domains\Auth\Models\User;
-use App\Domains\Authorization\Models\Role;
-use App\Domains\Tenant\Models\Tenant;
+use App\Domains\Authorization\Enums\RoleCode;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Schema;
-use LogicException;
 use Tests\TestCase;
 
 class UserAuthorizationRelationsTest extends TestCase
@@ -28,79 +24,9 @@ class UserAuthorizationRelationsTest extends TestCase
     {
         $user = User::factory()->create();
 
-        $this->assertSame('user', $user->rol_codigo);
+        $this->assertSame(RoleCode::User->value, $user->rol_codigo);
         $this->assertNull($user->tenant_codigo);
-        $this->assertSame('user', $user->role->codigo);
+        $this->assertSame(RoleCode::User->value, $user->role->codigo);
         $this->assertNull($user->tenant);
     }
-
-    public function test_a_tenant_admin_belongs_to_its_role_and_tenant(): void
-    {
-        $tenant = $this->createTenant();
-        $user = User::factory()->create([
-            'rol_codigo' => 'tenant_admin',
-            'tenant_codigo' => $tenant->codigo,
-        ]);
-
-        $this->assertSame('tenant_admin', $user->role->codigo);
-        $this->assertTrue($user->tenant->is($tenant));
-        $this->assertTrue(
-            Role::query()
-                ->where('codigo', 'tenant_admin')
-                ->firstOrFail()
-                ->users
-                ->contains($user)
-        );
-    }
-
-    public function test_only_a_tenant_admin_can_have_a_tenant_code(): void
-    {
-        $tenant = $this->createTenant();
-
-        $this->expectException(LogicException::class);
-
-        User::factory()->create([
-            'rol_codigo' => 'user',
-            'tenant_codigo' => $tenant->codigo,
-        ]);
-    }
-
-    public function test_a_tenant_admin_must_have_a_tenant_code(): void
-    {
-        $this->expectException(LogicException::class);
-
-        User::factory()->create([
-            'rol_codigo' => 'tenant_admin',
-        ]);
-    }
-
-    private function createTenant(): Tenant
-    {
-        $headerLogo = $this->createAttachment('header.png');
-        $footerLogo = $this->createAttachment('footer.png');
-
-        return Tenant::query()->create([
-            'codigo' => 'acme',
-            'nombre' => 'Acme',
-            'dominio' => 'acme.test',
-            'primary_color' => '#111111',
-            'secondary_color' => '#222222',
-            'danger_color' => '#333333',
-            'success_color' => '#444444',
-            'header_bg_color' => '#ffffff',
-            'footer_bg_color' => '#ffffff',
-            'header_logo_id' => $headerLogo->id,
-            'footer_logo_id' => $footerLogo->id,
-        ]);
-    }
-
-    private function createAttachment(string $filename): Attachment
-    {
-        return Attachment::query()->create([
-            'path' => "test/{$filename}",
-            'filename' => $filename,
-            'type' => AttachmentType::Image,
-            'mime_type' => 'image/png',
-        ]);
-    }
 }

tests/Feature/Seeders/AuthorizationSeederTest.php

@@ -2,6 +2,7 @@
 
 namespace Tests\Feature\Seeders;
 
+use App\Domains\Authorization\Enums\RoleCode;
 use App\Domains\Authorization\Models\Permission;
 use App\Domains\Authorization\Models\Role;
 use Database\Seeders\AuthorizationSeeder;
@@ -17,7 +18,11 @@ class AuthorizationSeederTest extends TestCase
         $this->seed(AuthorizationSeeder::class);
 
         $this->assertSame(
-            ['admin', 'adminapp', 'tenant_admin', 'user'],
+            [
+                RoleCode::Admin->value,
+                RoleCode::AdminApp->value,
+                RoleCode::User->value,
+            ],
             Role::query()->orderBy('codigo')->pluck('codigo')->all()
         );
         $this->assertCount(22, Permission::query()->get());
@@ -27,15 +32,12 @@ class AuthorizationSeederTest extends TestCase
     {
         $this->seed(AuthorizationSeeder::class);
 
-        $admin = Role::query()->where('codigo', 'admin')->firstOrFail();
-        $appAdmin = Role::query()->where('codigo', 'adminapp')->firstOrFail();
-        $tenantAdmin = Role::query()->where('codigo', 'tenant_admin')->firstOrFail();
-        $user = Role::query()->where('codigo', 'user')->firstOrFail();
+        $admin = Role::query()->where('codigo', RoleCode::Admin->value)->firstOrFail();
+        $appAdmin = Role::query()->where('codigo', RoleCode::AdminApp->value)->firstOrFail();
+        $user = Role::query()->where('codigo', RoleCode::User->value)->firstOrFail();
 
         $this->assertCount(22, $admin->permissions);
         $this->assertCount(0, $appAdmin->permissions);
-        $this->assertCount(21, $tenantAdmin->permissions);
-        $this->assertFalse($tenantAdmin->permissions->contains('codigo', 'roles.gestionar'));
         $this->assertCount(0, $user->permissions);
     }
 
@@ -44,8 +46,8 @@ class AuthorizationSeederTest extends TestCase
         $this->seed(AuthorizationSeeder::class);
         $this->seed(AuthorizationSeeder::class);
 
-        $this->assertCount(4, Role::query()->get());
+        $this->assertCount(3, Role::query()->get());
         $this->assertCount(22, Permission::query()->get());
-        $this->assertDatabaseCount('roles_permisos', 43);
+        $this->assertDatabaseCount('roles_permisos', 22);
     }
 }

tests/Feature/Seeders/MenuSeederTest.php

@@ -4,6 +4,7 @@ namespace Tests\Feature\Seeders;
 
 use App\Domains\Attachable\Enums\AttachmentType;
 use App\Domains\Attachable\Models\Attachment;
+use App\Domains\Authorization\Enums\RoleCode;
 use App\Domains\Authorization\Models\Role;
 use App\Domains\Menu\Models\Menu;
 use App\Domains\Tenant\Models\Tenant;
@@ -62,7 +63,7 @@ class MenuSeederTest extends TestCase
             ->pluck('code')
             ->all();
 
-        foreach (['admin', 'adminapp'] as $roleCode) {
+        foreach ([RoleCode::Admin->value, RoleCode::AdminApp->value] as $roleCode) {
             $roleMenuCodes = Role::query()
                 ->where('codigo', $roleCode)
                 ->firstOrFail()
@@ -75,7 +76,7 @@ class MenuSeederTest extends TestCase
         }
 
         $userRoleMenuCodes = Role::query()
-            ->where('codigo', 'user')
+            ->where('codigo', RoleCode::User->value)
             ->firstOrFail()
             ->menus()
             ->orderBy('menues.code')

tests/Feature/Tenant/BootstrapTenantControllerTest.php

@@ -4,6 +4,7 @@ namespace Tests\Feature\Tenant;
 
 use App\Domains\Attachable\Enums\AttachmentType;
 use App\Domains\Attachable\Models\Attachment;
+use App\Domains\Authorization\Enums\RoleCode;
 use App\Domains\Authorization\Models\Role;
 use App\Domains\Catalog\Models\Category;
 use App\Domains\Menu\Models\Menu;
@@ -147,7 +148,7 @@ class BootstrapTenantControllerTest extends TestCase
     {
         $tenant = $this->createTenant();
         $userRole = Role::query()->create([
-            'codigo' => 'user',
+            'codigo' => RoleCode::User->value,
             'nombre' => 'Usuario',
         ]);
         $parent = Menu::query()->create([
@@ -228,11 +229,11 @@ class BootstrapTenantControllerTest extends TestCase
     {
         $tenant = $this->createTenant();
         $userRole = Role::query()->create([
-            'codigo' => 'user',
+            'codigo' => RoleCode::User->value,
             'nombre' => 'Usuario',
         ]);
         $adminRole = Role::query()->create([
-            'codigo' => 'admin',
+            'codigo' => RoleCode::Admin->value,
             'nombre' => 'Administrador',
         ]);
         $userMenu = Menu::query()->create([