feat: implement BankAccount management with CRUD operations and selection for tenants

This commit is contained in:
2026-07-03 13:43:32 -03:00
parent b94efea4e0
commit b1e40b3430
13 changed files with 497 additions and 2 deletions

View File

@@ -0,0 +1,67 @@
<?php
namespace App\Domains\Tenant\Controllers;
use App\Domains\Tenant\Models\BankAccount;
use App\Domains\Tenant\Models\Tenant;
use App\Domains\Tenant\Requests\StoreBankAccountRequest;
use App\Domains\Tenant\Requests\UpdateBankAccountRequest;
use App\Domains\Tenant\Resources\BankAccountResource;
use App\Domains\Tenant\Resources\TenantResource;
use App\Http\Controllers\Controller;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Response;
class BankAccountController extends Controller
{
public function index(Tenant $tenant): JsonResponse
{
$accounts = $tenant->bankAccounts()->latest()->get();
return BankAccountResource::collection($accounts)->response();
}
public function store(StoreBankAccountRequest $request, Tenant $tenant): JsonResponse
{
$data = $request->validated();
$data['tenant_code'] = $tenant->codigo;
$account = BankAccount::query()->create($data);
return BankAccountResource::make($account)->response()->setStatusCode(201);
}
public function show(Tenant $tenant, BankAccount $bankAccount): BankAccountResource
{
abort_if($bankAccount->tenant_code !== $tenant->codigo, 404);
return BankAccountResource::make($bankAccount);
}
public function update(UpdateBankAccountRequest $request, Tenant $tenant, BankAccount $bankAccount): BankAccountResource
{
abort_if($bankAccount->tenant_code !== $tenant->codigo, 404);
$bankAccount->update($request->validated());
return BankAccountResource::make($bankAccount);
}
public function destroy(Tenant $tenant, BankAccount $bankAccount): Response
{
abort_if($bankAccount->tenant_code !== $tenant->codigo, 404);
$bankAccount->delete();
return response()->noContent();
}
public function select(Tenant $tenant, BankAccount $bankAccount): TenantResource
{
abort_if($bankAccount->tenant_code !== $tenant->codigo, 400, 'Bank account does not belong to this tenant.');
$tenant->selected_bank_account_id = $bankAccount->id;
$tenant->save();
return TenantResource::make($tenant->loadMissing(['headerLogo', 'footerLogo', 'selectedBankAccount']));
}
}

View File

@@ -15,7 +15,7 @@ class BootstrapTenantController extends Controller
$dominio = $request->validated('dominio'); $dominio = $request->validated('dominio');
return TenantResource::make( return TenantResource::make(
Tenant::query()->with(['headerLogo', 'footerLogo'])->where('dominio', $dominio)->firstOrFail() Tenant::query()->with(['headerLogo', 'footerLogo', 'selectedBankAccount'])->where('dominio', $dominio)->firstOrFail()
); );
} }
} }

View File

@@ -0,0 +1,28 @@
<?php
namespace App\Domains\Tenant\Models;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
class BankAccount extends Model
{
use HasFactory;
protected $fillable = [
'tenant_code',
'titular',
'entidad',
'alias',
'cvu',
];
/**
* @return BelongsTo<Tenant, $this>
*/
public function tenant(): BelongsTo
{
return $this->belongsTo(Tenant::class, 'tenant_code', 'codigo');
}
}

View File

@@ -55,5 +55,21 @@ class Tenant extends Model
{ {
return $this->hasMany(Product::class, 'tenant_codigo', 'codigo'); return $this->hasMany(Product::class, 'tenant_codigo', 'codigo');
} }
/**
* @return HasMany<BankAccount, $this>
*/
public function bankAccounts(): HasMany
{
return $this->hasMany(BankAccount::class, 'tenant_code', 'codigo');
}
/**
* @return BelongsTo<BankAccount, $this>
*/
public function selectedBankAccount(): BelongsTo
{
return $this->belongsTo(BankAccount::class, 'selected_bank_account_id');
}
} }

View File

@@ -0,0 +1,26 @@
<?php
namespace App\Domains\Tenant\Requests;
use Illuminate\Foundation\Http\FormRequest;
class StoreBankAccountRequest extends FormRequest
{
public function authorize(): bool
{
return true;
}
/**
* @return array<string, mixed>
*/
public function rules(): array
{
return [
'titular' => ['required', 'string', 'max:255'],
'entidad' => ['required', 'string', 'max:255'],
'alias' => ['required', 'string', 'max:255'],
'cvu' => ['required', 'string', 'max:255'],
];
}
}

View File

@@ -0,0 +1,26 @@
<?php
namespace App\Domains\Tenant\Requests;
use Illuminate\Foundation\Http\FormRequest;
class UpdateBankAccountRequest extends FormRequest
{
public function authorize(): bool
{
return true;
}
/**
* @return array<string, mixed>
*/
public function rules(): array
{
return [
'titular' => ['sometimes', 'string', 'max:255'],
'entidad' => ['sometimes', 'string', 'max:255'],
'alias' => ['sometimes', 'string', 'max:255'],
'cvu' => ['sometimes', 'string', 'max:255'],
];
}
}

View File

@@ -0,0 +1,27 @@
<?php
namespace App\Domains\Tenant\Resources;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\JsonResource;
/**
* @mixin \App\Domains\Tenant\Models\BankAccount
*/
class BankAccountResource extends JsonResource
{
/**
* @return array<string, mixed>
*/
public function toArray(Request $request): array
{
return [
'id' => $this->id,
'tenant_code' => $this->tenant_code,
'titular' => $this->titular,
'entidad' => $this->entidad,
'alias' => $this->alias,
'cvu' => $this->cvu,
];
}
}

View File

@@ -29,6 +29,8 @@ class TenantResource extends JsonResource
// 1 day // 1 day
'header_logo' => $this->headerLogo?->getTemporaryUrl(1440), 'header_logo' => $this->headerLogo?->getTemporaryUrl(1440),
'footer_logo' => $this->footerLogo?->getTemporaryUrl(1440 ), 'footer_logo' => $this->footerLogo?->getTemporaryUrl(1440 ),
'selected_bank_account_id' => $this->selected_bank_account_id,
'selected_bank_account' => BankAccountResource::make($this->whenLoaded('selectedBankAccount')),
]; ];
} }
} }

View File

@@ -8,3 +8,9 @@ Route::get('tenants/bootstrap/{dominio}', BootstrapTenantController::class)
->where('dominio', '.*'); ->where('dominio', '.*');
Route::apiResource('tenants', TenantController::class); Route::apiResource('tenants', TenantController::class);
Route::prefix('tenants/{tenant:codigo}')->group(function (): void {
Route::post('bank-accounts/{bank_account}/select', [\App\Domains\Tenant\Controllers\BankAccountController::class, 'select']);
Route::apiResource('bank-accounts', \App\Domains\Tenant\Controllers\BankAccountController::class)
->parameters(['bank-accounts' => 'bank_account']);
});

View File

@@ -0,0 +1,38 @@
<?php
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;
return new class extends Migration
{
/**
* Run the migrations.
*/
public function up(): void
{
Schema::create('bank_accounts', function (Blueprint $table) {
$table->id();
$table->string('tenant_code');
$table->string('titular');
$table->string('entidad');
$table->string('alias');
$table->string('cvu');
$table->timestamps();
$table->foreign('tenant_code')
->references('codigo')
->on('tenants')
->cascadeOnUpdate()
->cascadeOnDelete();
});
}
/**
* Reverse the migrations.
*/
public function down(): void
{
Schema::dropIfExists('bank_accounts');
}
};

View File

@@ -0,0 +1,34 @@
<?php
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;
return new class extends Migration
{
/**
* Run the migrations.
*/
public function up(): void
{
Schema::table('tenants', function (Blueprint $table) {
$table->unsignedBigInteger('selected_bank_account_id')->nullable()->after('footer_logo_id');
$table->foreign('selected_bank_account_id')
->references('id')
->on('bank_accounts')
->nullOnDelete();
});
}
/**
* Reverse the migrations.
*/
public function down(): void
{
Schema::table('tenants', function (Blueprint $table) {
$table->dropForeign(['selected_bank_account_id']);
$table->dropColumn('selected_bank_account_id');
});
}
};

View File

@@ -72,7 +72,7 @@ class TenantSeeder extends Seeder
true true
); );
$this->tenantService->create([ $tenant = $this->tenantService->create([
'codigo' => 'sonder', 'codigo' => 'sonder',
'nombre' => 'Sonder', 'nombre' => 'Sonder',
'dominio' => 'localhost', 'dominio' => 'localhost',
@@ -85,5 +85,32 @@ class TenantSeeder extends Seeder
'header_logo' => $headerLogo, 'header_logo' => $headerLogo,
'footer_logo' => $footerLogo, 'footer_logo' => $footerLogo,
]); ]);
$bankAccount1 = \App\Domains\Tenant\Models\BankAccount::query()->create([
'tenant_code' => $tenant->codigo,
'titular' => 'Sonder S.A. (Principal)',
'entidad' => 'Banco de la Nación Argentina',
'alias' => 'sonder.indumentaria',
'cvu' => '0110065420006540987654',
]);
\App\Domains\Tenant\Models\BankAccount::query()->create([
'tenant_code' => $tenant->codigo,
'titular' => 'Sonder S.A. (Secundaria)',
'entidad' => 'Banco de Galicia y Buenos Aires',
'alias' => 'sonder.indumentaria.galicia',
'cvu' => '0070012345678901234567',
]);
\App\Domains\Tenant\Models\BankAccount::query()->create([
'tenant_code' => $tenant->codigo,
'titular' => 'Sonder S.A. (Mercado Pago)',
'entidad' => 'Mercado Pago',
'alias' => 'sonder.indumentaria.mp',
'cvu' => '0000003100012345678901',
]);
$tenant->selected_bank_account_id = $bankAccount1->id;
$tenant->save();
} }
} }

View File

@@ -0,0 +1,198 @@
<?php
namespace Tests\Feature\Tenant;
use App\Domains\Tenant\Models\BankAccount;
use App\Domains\Tenant\Models\Tenant;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
class BankAccountControllerTest extends TestCase
{
use RefreshDatabase;
private Tenant $tenant;
protected function setUp(): void
{
parent::setUp();
$hdrKey = (string) \Illuminate\Support\Str::uuid();
$ftrKey = (string) \Illuminate\Support\Str::uuid();
$headerAttachment = \App\Domains\Attachable\Models\Attachment::create([
'key' => $hdrKey,
'path' => 'tenants/' . $hdrKey . '.png',
'filename' => 'logo_header.png',
'type' => \App\Domains\Attachable\Enums\AttachmentType::Image,
'mime_type' => 'image/png',
]);
$footerAttachment = \App\Domains\Attachable\Models\Attachment::create([
'key' => $ftrKey,
'path' => 'tenants/' . $ftrKey . '.png',
'filename' => 'logo_footer.png',
'type' => \App\Domains\Attachable\Enums\AttachmentType::Image,
'mime_type' => 'image/png',
]);
$this->tenant = Tenant::create([
'codigo' => 'acme',
'nombre' => 'Acme',
'dominio' => 'acme.com',
'primary_color' => '#ff0000',
'secondary_color' => '#00ff00',
'danger_color' => '#0000ff',
'success_color' => '#00ff00',
'header_bg_color' => '#ffffff',
'footer_bg_color' => '#ffffff',
'header_logo_id' => $headerAttachment->id,
'footer_logo_id' => $footerAttachment->id,
]);
}
public function test_it_lists_bank_accounts_for_a_tenant(): void
{
BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->getJson("/api/tenants/acme/bank-accounts");
$response->assertOk()
->assertJsonCount(1, 'data')
->assertJsonPath('data.0.titular', 'John Doe');
}
public function test_it_creates_a_bank_account_for_a_tenant(): void
{
$response = $this->postJson("/api/tenants/acme/bank-accounts", [
'titular' => 'Jane Doe',
'entidad' => 'Banco Nación',
'alias' => 'jane.doe.nacion',
'cvu' => '9876543210987654321098',
]);
$response->assertCreated()
->assertJsonPath('data.titular', 'Jane Doe');
$this->assertDatabaseHas('bank_accounts', [
'tenant_code' => 'acme',
'titular' => 'Jane Doe',
]);
}
public function test_it_shows_a_bank_account(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->getJson("/api/tenants/acme/bank-accounts/{$account->id}");
$response->assertOk()
->assertJsonPath('data.titular', 'John Doe');
}
public function test_it_updates_a_bank_account(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->putJson("/api/tenants/acme/bank-accounts/{$account->id}", [
'titular' => 'John Doe Updated',
]);
$response->assertOk()
->assertJsonPath('data.titular', 'John Doe Updated');
$this->assertDatabaseHas('bank_accounts', [
'id' => $account->id,
'titular' => 'John Doe Updated',
]);
}
public function test_it_deletes_a_bank_account(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->deleteJson("/api/tenants/acme/bank-accounts/{$account->id}");
$response->assertNoContent();
$this->assertDatabaseMissing('bank_accounts', ['id' => $account->id]);
}
public function test_it_selects_a_bank_account_for_a_tenant(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$response = $this->postJson("/api/tenants/acme/bank-accounts/{$account->id}/select");
$response->assertOk()
->assertJsonPath('data.selected_bank_account_id', $account->id);
$this->tenant->refresh();
$this->assertEquals($account->id, $this->tenant->selected_bank_account_id);
}
public function test_it_deletes_related_bank_accounts_when_tenant_is_deleted(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$this->assertDatabaseHas('bank_accounts', ['id' => $account->id]);
$this->tenant->delete();
$this->assertDatabaseMissing('bank_accounts', ['id' => $account->id]);
}
public function test_it_sets_selected_bank_account_id_to_null_when_selected_bank_account_is_deleted(): void
{
$account = BankAccount::query()->create([
'tenant_code' => 'acme',
'titular' => 'John Doe',
'entidad' => 'Banco Galicia',
'alias' => 'john.doe.galicia',
'cvu' => '1234567890123456789012',
]);
$this->tenant->selected_bank_account_id = $account->id;
$this->tenant->save();
$account->delete();
$this->tenant->refresh();
$this->assertNull($this->tenant->selected_bank_account_id);
}
}