feat(authorization): establish many-to-many relationship between roles and menus, add migration and seeder updates
This commit is contained in:
@@ -3,6 +3,8 @@
|
|||||||
namespace App\Domains\Authorization\Models;
|
namespace App\Domains\Authorization\Models;
|
||||||
|
|
||||||
use App\Domains\Auth\Models\User;
|
use App\Domains\Auth\Models\User;
|
||||||
|
use App\Domains\Menu\Models\Menu;
|
||||||
|
use App\Domains\Menu\Models\MenuRole;
|
||||||
use Illuminate\Database\Eloquent\Model;
|
use Illuminate\Database\Eloquent\Model;
|
||||||
use Illuminate\Database\Eloquent\Relations\BelongsToMany;
|
use Illuminate\Database\Eloquent\Relations\BelongsToMany;
|
||||||
use Illuminate\Database\Eloquent\Relations\HasMany;
|
use Illuminate\Database\Eloquent\Relations\HasMany;
|
||||||
@@ -39,4 +41,19 @@ class Role extends Model
|
|||||||
{
|
{
|
||||||
return $this->hasMany(User::class, 'rol_codigo', 'codigo');
|
return $this->hasMany(User::class, 'rol_codigo', 'codigo');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return BelongsToMany<Menu, $this>
|
||||||
|
*/
|
||||||
|
public function menus(): BelongsToMany
|
||||||
|
{
|
||||||
|
return $this->belongsToMany(
|
||||||
|
Menu::class,
|
||||||
|
'menues_roles',
|
||||||
|
'rol_codigo',
|
||||||
|
'menu_codigo',
|
||||||
|
'codigo',
|
||||||
|
'code'
|
||||||
|
)->using(MenuRole::class);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -2,6 +2,7 @@
|
|||||||
|
|
||||||
namespace App\Domains\Menu\Models;
|
namespace App\Domains\Menu\Models;
|
||||||
|
|
||||||
|
use App\Domains\Authorization\Models\Role;
|
||||||
use App\Domains\Tenant\Models\Tenant;
|
use App\Domains\Tenant\Models\Tenant;
|
||||||
use Illuminate\Database\Eloquent\Factories\HasFactory;
|
use Illuminate\Database\Eloquent\Factories\HasFactory;
|
||||||
use Illuminate\Database\Eloquent\Model;
|
use Illuminate\Database\Eloquent\Model;
|
||||||
@@ -78,4 +79,16 @@ class Menu extends Model
|
|||||||
->withPivot('static_content')
|
->withPivot('static_content')
|
||||||
->withTimestamps();
|
->withTimestamps();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function roles(): BelongsToMany
|
||||||
|
{
|
||||||
|
return $this->belongsToMany(
|
||||||
|
Role::class,
|
||||||
|
'menues_roles',
|
||||||
|
'menu_codigo',
|
||||||
|
'rol_codigo',
|
||||||
|
'code',
|
||||||
|
'codigo'
|
||||||
|
)->using(MenuRole::class);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
31
app/Domains/Menu/Models/MenuRole.php
Normal file
31
app/Domains/Menu/Models/MenuRole.php
Normal file
@@ -0,0 +1,31 @@
|
|||||||
|
<?php
|
||||||
|
|
||||||
|
namespace App\Domains\Menu\Models;
|
||||||
|
|
||||||
|
use App\Domains\Authorization\Models\Role;
|
||||||
|
use Illuminate\Database\Eloquent\Relations\BelongsTo;
|
||||||
|
use Illuminate\Database\Eloquent\Relations\Pivot;
|
||||||
|
|
||||||
|
class MenuRole extends Pivot
|
||||||
|
{
|
||||||
|
protected $table = 'menues_roles';
|
||||||
|
|
||||||
|
public $incrementing = true;
|
||||||
|
|
||||||
|
public $timestamps = false;
|
||||||
|
|
||||||
|
protected $fillable = [
|
||||||
|
'rol_codigo',
|
||||||
|
'menu_codigo',
|
||||||
|
];
|
||||||
|
|
||||||
|
public function role(): BelongsTo
|
||||||
|
{
|
||||||
|
return $this->belongsTo(Role::class, 'rol_codigo', 'codigo');
|
||||||
|
}
|
||||||
|
|
||||||
|
public function menu(): BelongsTo
|
||||||
|
{
|
||||||
|
return $this->belongsTo(Menu::class, 'menu_codigo', 'code');
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,35 @@
|
|||||||
|
<?php
|
||||||
|
|
||||||
|
use Illuminate\Database\Migrations\Migration;
|
||||||
|
use Illuminate\Database\Schema\Blueprint;
|
||||||
|
use Illuminate\Support\Facades\Schema;
|
||||||
|
|
||||||
|
return new class extends Migration
|
||||||
|
{
|
||||||
|
public function up(): void
|
||||||
|
{
|
||||||
|
Schema::create('menues_roles', function (Blueprint $table): void {
|
||||||
|
$table->id();
|
||||||
|
$table->string('rol_codigo');
|
||||||
|
$table->string('menu_codigo');
|
||||||
|
|
||||||
|
$table->foreign('rol_codigo')
|
||||||
|
->references('codigo')
|
||||||
|
->on('roles')
|
||||||
|
->cascadeOnUpdate()
|
||||||
|
->cascadeOnDelete();
|
||||||
|
$table->foreign('menu_codigo')
|
||||||
|
->references('code')
|
||||||
|
->on('menues')
|
||||||
|
->cascadeOnUpdate()
|
||||||
|
->cascadeOnDelete();
|
||||||
|
|
||||||
|
$table->unique(['rol_codigo', 'menu_codigo']);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
public function down(): void
|
||||||
|
{
|
||||||
|
Schema::dropIfExists('menues_roles');
|
||||||
|
}
|
||||||
|
};
|
||||||
@@ -111,6 +111,11 @@ class AuthorizationSeeder extends Seeder
|
|||||||
'descripcion' => 'Administra la plataforma y todos sus tenants.',
|
'descripcion' => 'Administra la plataforma y todos sus tenants.',
|
||||||
'permisos' => [],
|
'permisos' => [],
|
||||||
],
|
],
|
||||||
|
'adminapp' => [
|
||||||
|
'nombre' => 'Administrador de la aplicación',
|
||||||
|
'descripcion' => 'Accede a los menús administrativos de la aplicación.',
|
||||||
|
'permisos' => [],
|
||||||
|
],
|
||||||
'tenant_admin' => [
|
'tenant_admin' => [
|
||||||
'nombre' => 'Administrador del tenant',
|
'nombre' => 'Administrador del tenant',
|
||||||
'descripcion' => 'Administra la operación de su propio tenant.',
|
'descripcion' => 'Administra la operación de su propio tenant.',
|
||||||
|
|||||||
@@ -2,6 +2,7 @@
|
|||||||
|
|
||||||
namespace Database\Seeders;
|
namespace Database\Seeders;
|
||||||
|
|
||||||
|
use App\Domains\Authorization\Models\Role;
|
||||||
use App\Domains\Menu\Models\Menu;
|
use App\Domains\Menu\Models\Menu;
|
||||||
use App\Domains\Tenant\Models\Tenant;
|
use App\Domains\Tenant\Models\Tenant;
|
||||||
use Illuminate\Database\Seeder;
|
use Illuminate\Database\Seeder;
|
||||||
@@ -133,6 +134,19 @@ class MenuSeeder extends Seeder
|
|||||||
->whereIn('code', ['profile', 'purchases', 'tickets'])
|
->whereIn('code', ['profile', 'purchases', 'tickets'])
|
||||||
->delete();
|
->delete();
|
||||||
|
|
||||||
|
$allRoleMenuCodes = Menu::query()->pluck('code');
|
||||||
|
$userMenuCodes = Menu::query()
|
||||||
|
->where('code', 'not like', 'admin.%')
|
||||||
|
->pluck('code');
|
||||||
|
|
||||||
|
Role::query()
|
||||||
|
->whereIn('codigo', ['admin', 'adminapp'])
|
||||||
|
->each(fn (Role $role) => $role->menus()->sync($allRoleMenuCodes));
|
||||||
|
|
||||||
|
Role::query()
|
||||||
|
->where('codigo', 'user')
|
||||||
|
->each(fn (Role $role) => $role->menus()->sync($userMenuCodes));
|
||||||
|
|
||||||
$tenants = Tenant::all();
|
$tenants = Tenant::all();
|
||||||
|
|
||||||
$allMenus = Menu::pluck('code')->toArray();
|
$allMenus = Menu::pluck('code')->toArray();
|
||||||
|
|||||||
@@ -17,7 +17,7 @@ class AuthorizationSeederTest extends TestCase
|
|||||||
$this->seed(AuthorizationSeeder::class);
|
$this->seed(AuthorizationSeeder::class);
|
||||||
|
|
||||||
$this->assertSame(
|
$this->assertSame(
|
||||||
['admin', 'tenant_admin', 'user'],
|
['admin', 'adminapp', 'tenant_admin', 'user'],
|
||||||
Role::query()->orderBy('codigo')->pluck('codigo')->all()
|
Role::query()->orderBy('codigo')->pluck('codigo')->all()
|
||||||
);
|
);
|
||||||
$this->assertCount(22, Permission::query()->get());
|
$this->assertCount(22, Permission::query()->get());
|
||||||
@@ -28,10 +28,12 @@ class AuthorizationSeederTest extends TestCase
|
|||||||
$this->seed(AuthorizationSeeder::class);
|
$this->seed(AuthorizationSeeder::class);
|
||||||
|
|
||||||
$admin = Role::query()->where('codigo', 'admin')->firstOrFail();
|
$admin = Role::query()->where('codigo', 'admin')->firstOrFail();
|
||||||
|
$appAdmin = Role::query()->where('codigo', 'adminapp')->firstOrFail();
|
||||||
$tenantAdmin = Role::query()->where('codigo', 'tenant_admin')->firstOrFail();
|
$tenantAdmin = Role::query()->where('codigo', 'tenant_admin')->firstOrFail();
|
||||||
$user = Role::query()->where('codigo', 'user')->firstOrFail();
|
$user = Role::query()->where('codigo', 'user')->firstOrFail();
|
||||||
|
|
||||||
$this->assertCount(22, $admin->permissions);
|
$this->assertCount(22, $admin->permissions);
|
||||||
|
$this->assertCount(0, $appAdmin->permissions);
|
||||||
$this->assertCount(21, $tenantAdmin->permissions);
|
$this->assertCount(21, $tenantAdmin->permissions);
|
||||||
$this->assertFalse($tenantAdmin->permissions->contains('codigo', 'roles.gestionar'));
|
$this->assertFalse($tenantAdmin->permissions->contains('codigo', 'roles.gestionar'));
|
||||||
$this->assertCount(0, $user->permissions);
|
$this->assertCount(0, $user->permissions);
|
||||||
@@ -42,7 +44,7 @@ class AuthorizationSeederTest extends TestCase
|
|||||||
$this->seed(AuthorizationSeeder::class);
|
$this->seed(AuthorizationSeeder::class);
|
||||||
$this->seed(AuthorizationSeeder::class);
|
$this->seed(AuthorizationSeeder::class);
|
||||||
|
|
||||||
$this->assertCount(3, Role::query()->get());
|
$this->assertCount(4, Role::query()->get());
|
||||||
$this->assertCount(22, Permission::query()->get());
|
$this->assertCount(22, Permission::query()->get());
|
||||||
$this->assertDatabaseCount('roles_permisos', 43);
|
$this->assertDatabaseCount('roles_permisos', 43);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -4,8 +4,10 @@ namespace Tests\Feature\Seeders;
|
|||||||
|
|
||||||
use App\Domains\Attachable\Enums\AttachmentType;
|
use App\Domains\Attachable\Enums\AttachmentType;
|
||||||
use App\Domains\Attachable\Models\Attachment;
|
use App\Domains\Attachable\Models\Attachment;
|
||||||
|
use App\Domains\Authorization\Models\Role;
|
||||||
use App\Domains\Menu\Models\Menu;
|
use App\Domains\Menu\Models\Menu;
|
||||||
use App\Domains\Tenant\Models\Tenant;
|
use App\Domains\Tenant\Models\Tenant;
|
||||||
|
use Database\Seeders\AuthorizationSeeder;
|
||||||
use Database\Seeders\MenuSeeder;
|
use Database\Seeders\MenuSeeder;
|
||||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||||
use Tests\TestCase;
|
use Tests\TestCase;
|
||||||
@@ -45,6 +47,48 @@ class MenuSeederTest extends TestCase
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function test_it_assigns_menus_to_the_expected_roles(): void
|
||||||
|
{
|
||||||
|
$this->seed(AuthorizationSeeder::class);
|
||||||
|
$this->seed(MenuSeeder::class);
|
||||||
|
|
||||||
|
$allMenuCodes = Menu::query()
|
||||||
|
->orderBy('code')
|
||||||
|
->pluck('code')
|
||||||
|
->all();
|
||||||
|
$userMenuCodes = Menu::query()
|
||||||
|
->where('code', 'not like', 'admin.%')
|
||||||
|
->orderBy('code')
|
||||||
|
->pluck('code')
|
||||||
|
->all();
|
||||||
|
|
||||||
|
foreach (['admin', 'adminapp'] as $roleCode) {
|
||||||
|
$roleMenuCodes = Role::query()
|
||||||
|
->where('codigo', $roleCode)
|
||||||
|
->firstOrFail()
|
||||||
|
->menus()
|
||||||
|
->orderBy('menues.code')
|
||||||
|
->pluck('menues.code')
|
||||||
|
->all();
|
||||||
|
|
||||||
|
$this->assertSame($allMenuCodes, $roleMenuCodes);
|
||||||
|
}
|
||||||
|
|
||||||
|
$userRoleMenuCodes = Role::query()
|
||||||
|
->where('codigo', 'user')
|
||||||
|
->firstOrFail()
|
||||||
|
->menus()
|
||||||
|
->orderBy('menues.code')
|
||||||
|
->pluck('menues.code')
|
||||||
|
->all();
|
||||||
|
|
||||||
|
$this->assertSame($userMenuCodes, $userRoleMenuCodes);
|
||||||
|
$this->assertDatabaseCount(
|
||||||
|
'menues_roles',
|
||||||
|
(count($allMenuCodes) * 2) + count($userMenuCodes)
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
public function test_it_seeds_the_account_menu_hierarchy(): void
|
public function test_it_seeds_the_account_menu_hierarchy(): void
|
||||||
{
|
{
|
||||||
$tenant = $this->createTenant('account_tenant');
|
$tenant = $this->createTenant('account_tenant');
|
||||||
|
|||||||
Reference in New Issue
Block a user