refactor(cart): invalidate payment on actual changes

app/Domains/Cart/Services/CartService.php

@@ -4,6 +4,7 @@ namespace App\Domains\Cart\Services;
 
 use App\Domains\Auth\Models\User;
 use App\Domains\Cart\Models\Cart;
+use App\Domains\Cart\Models\CartItem;
 use App\Domains\Catalog\Services\StockReservationService;
 use App\Domains\Purchase\Models\Purchase;
 use App\Domains\Tenant\Models\Tenant;
@@ -98,64 +99,6 @@ class CartService
             $variantId,
             $updateVariant,
         ): Cart {
-            /** @var Purchase|null $purchase */
-            $purchase = Purchase::query()
-                ->where('cart_id', $cart->getKey())
-                ->where('tenant_codigo', $tenant->codigo)
-                ->where('user_id', $user->getKey())
-                ->where('status', Purchase::STATUS_CREATED)
-                ->whereDoesntHave('items')
-                ->lockForUpdate()
-                ->first();
-
-            if ($purchase === null) {
-                throw new NotFoundHttpException('Checkout cart not found.');
-            }
-
-            if ($purchase->expires_at !== null && $purchase->expires_at->isPast()) {
-                throw ValidationException::withMessages([
-                    'cart' => __('api.purchase.not_editable'),
-                ]);
-            }
-
-            /** @var Cart|null $checkoutCart */
-            $checkoutCart = Cart::query()
-                ->whereKey($cart->getKey())
-                ->where('tenant_codigo', $tenant->codigo)
-                ->where('user_id', $user->getKey())
-                ->where('status', 'checkout')
-                ->lockForUpdate()
-                ->first();
-
-            if ($checkoutCart === null) {
-                throw new NotFoundHttpException('Checkout cart not found.');
-            }
-
-            $checkoutCart->updateItem(
-                $cartItemId,
-                $quantity,
-                $variantId,
-                $updateVariant,
-                $purchase->getKey(),
-            );
-            $purchase->update(['total' => $checkoutCart->getTotalAmount()]);
-
-            return $this->loadCart($checkoutCart);
-        });
-    }
-
-    public function prepareCheckoutEditing(
-        Tenant $tenant,
-        Request $request,
-        Cart $cart,
-    ): Cart {
-        $user = $request->user() ?? Auth::guard('sanctum')->user();
-
-        if (! $user instanceof User) {
-            throw new NotFoundHttpException('Checkout cart not found.');
-        }
-
-        return DB::transaction(function () use ($tenant, $user, $cart): Cart {
             /** @var Purchase|null $purchase */
             $purchase = Purchase::query()
                 ->where('cart_id', $cart->getKey())
@@ -192,11 +135,37 @@ class CartService
                 throw new NotFoundHttpException('Checkout cart not found.');
             }
 
+            /** @var CartItem|null $cartItem */
+            $cartItem = $checkoutCart->items()
+                ->whereKey($cartItemId)
+                ->lockForUpdate()
+                ->first();
+
+            if ($cartItem === null) {
+                throw new NotFoundHttpException('Checkout item not found.');
+            }
+
+            $hasChanges = (int) $cartItem->cantidad !== $quantity
+                || ($updateVariant && $cartItem->variant_id !== $variantId);
+
+            if (! $hasChanges) {
+                return $this->loadCart($checkoutCart);
+            }
+
+            $checkoutCart->updateItem(
+                $cartItemId,
+                $quantity,
+                $variantId,
+                $updateVariant,
+                $purchase->getKey(),
+            );
+
             $purchase->telepagosQr()->delete();
             $purchase->update([
                 'status' => Purchase::STATUS_CREATED,
                 'payment_method' => null,
                 'transfer_payer_dni' => null,
+                'total' => $checkoutCart->getTotalAmount(),
                 'expires_at' => now()->addMinutes(
                     max(1, (int) config('purchase.checkout_expiration_minutes', 30)),
                 ),