tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor menu codes to remove 'onticket' prefix

Browse Source 
- Updated route middleware and menu codes across various files to replace 'onticket.adminapp' with 'adminapp'.
- Adjusted API routes for Ticketing, FiestaFutbolInfantil, and Desfile to reflect the new menu structure.
- Modified database migrations to remove the 'onticket' prefix from existing menu codes.
- Updated tests to align with the new menu code structure, ensuring compatibility and correctness.
This commit is contained in:
ncoronel
2026-10-02 10:04:55 -03:00
parent 57ea0024dd
commit 8d2bcba1bf
20 changed files with 270 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Feature/Auth/ScannerMeControllerTest.php
View File

@@ -43,7 +43,7 @@ class ScannerMeControllerTest extends TestCase
'route' => '/scanner/scan',
]);
$foreign = Menu::query()->create([
'code' => 'onticket.adminapp.inicio',
'code' => 'adminapp.inicio',
'label' => 'Administración',
'route' => '/admin/inicio',
]);

2
tests/Feature/Desfile/EntryControllerTest.php
View File

@@ -186,7 +186,7 @@ class EntryControllerTest extends TestCase
'admin_website_type_code' => 'onticket',
]);
$menu = Menu::query()->firstOrCreate(
['code' => 'onticket.adminapp.desfile.entradas'],
['code' => 'adminapp.desfile.entradas'],
['label' => 'Entradas', 'route' => '/admin/desfile/entradas'],
);
$tenant->menues()->attach($menu->code);

2
tests/Feature/FiestaFutbolInfantil/AccommodationControllerTest.php
View File

@@ -236,7 +236,7 @@ class AccommodationControllerTest extends TestCase
if ($withMenu) {
$menu = Menu::query()->firstOrCreate(
['code' => 'onticket.adminapp.fiesta-futbol-infantil.alojamientos'],
['code' => 'adminapp.fiesta-futbol-infantil.alojamientos'],
['label' => 'Alojamientos', 'route' => '/admin/alojamientos'],
);
$tenant->menues()->syncWithoutDetaching([$menu->code]);

10
tests/Feature/FiestaFutbolInfantil/EntryControllerTest.php
View File

@@ -43,10 +43,10 @@ class EntryControllerTest extends TestCase
{
$tenant = $this->createFiestaTenant();
$categories = [
'entries' => ['Entradas', 'onticket.adminapp.fiesta-futbol-infantil.entradas'],
'foods' => ['Comidas', 'onticket.adminapp.fiesta-futbol-infantil.comida'],
'accommodations' => ['Alojamientos', 'onticket.adminapp.fiesta-futbol-infantil.alojamientos'],
'merchandise' => ['Merchandising', 'onticket.adminapp.fiesta-futbol-infantil.merchandising'],
'entries' => ['Entradas', 'adminapp.fiesta-futbol-infantil.entradas'],
'foods' => ['Comidas', 'adminapp.fiesta-futbol-infantil.comida'],
'accommodations' => ['Alojamientos', 'adminapp.fiesta-futbol-infantil.alojamientos'],
'merchandise' => ['Merchandising', 'adminapp.fiesta-futbol-infantil.merchandising'],
];
foreach ($categories as [$label, $menuCode]) {
@@ -405,7 +405,7 @@ class EntryControllerTest extends TestCase
{
$tenant = $this->createTenant('fiesta_futbol_infantil');
$menu = Menu::query()->create([
'code' => 'onticket.adminapp.fiesta-futbol-infantil.entradas',
'code' => 'adminapp.fiesta-futbol-infantil.entradas',
'label' => 'Entradas',
'route' => '/admin/entradas',
]);

2
tests/Feature/FiestaFutbolInfantil/FoodControllerTest.php
View File

@@ -367,7 +367,7 @@ class FoodControllerTest extends TestCase
'time_end' => '23:59',
]);
$menu = Menu::query()->create([
'code' => 'onticket.adminapp.fiesta-futbol-infantil.comida',
'code' => 'adminapp.fiesta-futbol-infantil.comida',
'label' => 'Comida',
'route' => '/admin/comidas',
]);

2
tests/Feature/FiestaFutbolInfantil/MerchandiseControllerTest.php
View File

@@ -293,7 +293,7 @@ class MerchandiseControllerTest extends TestCase
['value' => 'XL', 'label' => 'XL', 'sort_order' => 4],
]);
$menu = Menu::query()->create([
'code' => 'onticket.adminapp.fiesta-futbol-infantil.merchandising',
'code' => 'adminapp.fiesta-futbol-infantil.merchandising',
'label' => 'Merchandising',
'route' => '/admin/merchandising',
]);

2
tests/Feature/Forms/AdminAppDesfileEntryReservationFormControllerTest.php
View File

@@ -135,7 +135,7 @@ class AdminAppDesfileEntryReservationFormControllerTest extends TestCase
private function grantReservationsMenu(Tenant $tenant): void
{
$menu = Menu::query()->create([
'code' => 'onticket.adminapp.desfile.reservas',
'code' => 'adminapp.desfile.reservas',
'label' => 'Reserva de Tickets',
'route' => '/admin/desfile/reservas',
]);

2
tests/Feature/Forms/AdminAppTicketFilterFormControllerTest.php
View File

@@ -349,7 +349,7 @@ class AdminAppTicketFilterFormControllerTest extends TestCase
private function grantTicketsMenu(Tenant $tenant): void
{
$menu = Menu::query()->create([
'code' => 'onticket.adminapp.tickets',
'code' => 'adminapp.tickets',
'label' => 'Tickets',
'route' => '/admin/tickets',
]);

5
tests/Feature/Menu/TicketMenuAccessTest.php
View File

@@ -18,8 +18,8 @@ class TicketMenuAccessTest extends TestCase
public static function menuAssignments(): array
{
return [
'new code' => ['onticket.adminapp.tickets', 'current', false],
'old code' => ['adminapp.tickets', 'current', true],
'compatible code' => ['adminapp.tickets', 'current', true],
'prefixed code' => ['onticket.adminapp.tickets', 'current', false],
'another tenant' => ['adminapp.tickets', 'other', false],
'unrelated menu' => ['adminapp.ventas', 'current', false],
];
@@ -39,6 +39,7 @@ class TicketMenuAccessTest extends TestCase
Schema::create('tenants_menues', function (Blueprint $table): void {
$table->string('tenant_code');
$table->string('menu_code');
$table->boolean('is_enabled')->default(true);
});
DB::table('tenants')->insert(['codigo' => 'current']);
DB::table('menues')->insert(['code' => $menuCode]);

108
tests/Feature/Migrations/RemoveOnticketMenuCodePrefixTest.php Normal file
View File

@@ -0,0 +1,108 @@
<?php
namespace Tests\Feature\Migrations;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Schema;
use Tests\TestCase;
class RemoveOnticketMenuCodePrefixTest extends TestCase
{
protected function setUp(): void
{
parent::setUp();
Schema::create('menues', function (Blueprint $table): void {
$table->id();
$table->string('code')->unique();
$table->string('label');
$table->string('parent_menu_code')->nullable();
$table->foreign('parent_menu_code')->references('code')->on('menues')->nullOnDelete();
});
Schema::create('tenants_menues', function (Blueprint $table): void {
$table->id();
$table->string('tenant_code');
$table->string('menu_code');
$table->json('static_content')->nullable();
$table->boolean('is_enabled')->default(true);
$table->timestamps();
$table->foreign('menu_code')->references('code')->on('menues')->cascadeOnDelete();
$table->unique(['tenant_code', 'menu_code']);
});
Schema::create('roles_menues', function (Blueprint $table): void {
$table->id();
$table->string('rol_codigo');
$table->string('menu_codigo');
$table->string('access_level')->default('none');
$table->foreign('menu_codigo')->references('code')->on('menues')->cascadeOnDelete();
$table->unique(['rol_codigo', 'menu_codigo']);
});
}
public function test_it_preserves_hierarchy_assignments_content_and_access_and_can_run_twice(): void
{
DB::table('menues')->insert(['code' => 'onticket.custom', 'label' => 'Custom']);
DB::table('menues')->insert([
['code' => 'onticket.custom.child', 'label' => 'Child', 'parent_menu_code' => 'onticket.custom'],
['code' => 'unrelated', 'label' => 'Unrelated', 'parent_menu_code' => 'onticket.custom'],
['code' => 'shopit.adminapp.marca', 'label' => 'Marca', 'parent_menu_code' => null],
]);
$createdAt = '2026-09-01 12:00:00';
DB::table('tenants_menues')->insert([
'tenant_code' => 'tenant', 'menu_code' => 'onticket.custom.child',
'static_content' => '{"title":"Content"}', 'is_enabled' => false,
'created_at' => $createdAt, 'updated_at' => $createdAt,
]);
DB::table('roles_menues')->insert([
'rol_codigo' => 'adminapp', 'menu_codigo' => 'onticket.custom.child', 'access_level' => 'edit',
]);
$migration = require database_path('migrations/2026_10_02_000000_remove_onticket_menu_code_prefix.php');
$migration->up();
$migration->up();
$this->assertFalse(DB::table('menues')->where('code', 'like', 'onticket.%')->exists());
$this->assertDatabaseHas('menues', ['code' => 'custom.child', 'label' => 'Child', 'parent_menu_code' => 'custom']);
$this->assertDatabaseHas('menues', ['code' => 'unrelated', 'parent_menu_code' => 'custom']);
$this->assertDatabaseHas('menues', ['code' => 'shopit.adminapp.marca']);
$this->assertDatabaseHas('tenants_menues', [
'tenant_code' => 'tenant', 'menu_code' => 'custom.child',
'static_content' => '{"title":"Content"}', 'is_enabled' => false, 'created_at' => $createdAt,
]);
$this->assertDatabaseHas('roles_menues', [
'rol_codigo' => 'adminapp', 'menu_codigo' => 'custom.child', 'access_level' => 'edit',
]);
$this->assertDatabaseCount('tenants_menues', 1);
$this->assertDatabaseCount('roles_menues', 1);
}
public function test_it_merges_existing_codes_without_losing_the_active_assignment_settings(): void
{
DB::table('menues')->insert([
['code' => 'adminapp.tickets', 'label' => 'Tickets'],
['code' => 'onticket.adminapp.tickets', 'label' => 'Tickets prefixed'],
]);
DB::table('tenants_menues')->insert([
['tenant_code' => 'tenant', 'menu_code' => 'adminapp.tickets', 'is_enabled' => true],
['tenant_code' => 'tenant', 'menu_code' => 'onticket.adminapp.tickets', 'is_enabled' => false],
['tenant_code' => 'other', 'menu_code' => 'adminapp.tickets', 'is_enabled' => true],
]);
DB::table('roles_menues')->insert([
['rol_codigo' => 'adminapp', 'menu_codigo' => 'adminapp.tickets', 'access_level' => 'edit'],
['rol_codigo' => 'adminapp', 'menu_codigo' => 'onticket.adminapp.tickets', 'access_level' => 'none'],
['rol_codigo' => 'other', 'menu_codigo' => 'adminapp.tickets', 'access_level' => 'view'],
]);
$migration = require database_path('migrations/2026_10_02_000000_remove_onticket_menu_code_prefix.php');
$migration->up();
$this->assertDatabaseCount('menues', 1);
$this->assertDatabaseCount('tenants_menues', 2);
$this->assertDatabaseCount('roles_menues', 2);
$this->assertDatabaseHas('tenants_menues', ['tenant_code' => 'tenant', 'menu_code' => 'adminapp.tickets', 'is_enabled' => false]);
$this->assertDatabaseHas('tenants_menues', ['tenant_code' => 'other', 'menu_code' => 'adminapp.tickets', 'is_enabled' => true]);
$this->assertDatabaseHas('roles_menues', ['rol_codigo' => 'adminapp', 'menu_codigo' => 'adminapp.tickets', 'access_level' => 'none']);
$this->assertDatabaseHas('roles_menues', ['rol_codigo' => 'other', 'menu_codigo' => 'adminapp.tickets', 'access_level' => 'view']);
}
}

6
tests/Feature/Seeders/DesfilePuraTendenciaSeederTest.php
View File

@@ -135,7 +135,7 @@ class DesfilePuraTendenciaSeederTest extends TestCase
$expectedMenus = DB::table('tenants_menues')
->where('tenant_code', 'fiesta_futbol_infantil')
->where('menu_code', 'not like', 'onticket.adminapp.fiesta-futbol-infantil.%')
->where('menu_code', 'not like', 'adminapp.fiesta-futbol-infantil.%')
->orderBy('menu_code')
->pluck('menu_code')
->all();
@@ -147,9 +147,9 @@ class DesfilePuraTendenciaSeederTest extends TestCase
$this->assertSame($expectedMenus, $actualMenus);
$this->assertContains('main.adminapp', $actualMenus);
$this->assertContains('onticket.adminapp.event', $actualMenus);
$this->assertContains('adminapp.event', $actualMenus);
$this->assertContains('scanner.scan', $actualMenus);
$this->assertNotContains('onticket.adminapp.fiesta-futbol-infantil.entradas', $actualMenus);
$this->assertNotContains('adminapp.fiesta-futbol-infantil.entradas', $actualMenus);
$catalogItem = DB::table('catalog_items')
->where('tenant_code', 'desfile_pura_tendencia')

40
tests/Feature/Seeders/MenuSeederTest.php
View File

@@ -26,24 +26,24 @@ class MenuSeederTest extends TestCase
$this->seed(MenuSeeder::class);
$expectedMenus = [
'onticket.adminapp.inicio' => ['Inicio', '/admin/inicio'],
'onticket.adminapp.catalog' => ['Catálogo', '/admin/catalog'],
'onticket.adminapp.categories' => ['Categorías', '/admin/categories'],
'onticket.adminapp.combos' => ['Combos', '/admin/combos'],
'onticket.adminapp.event' => ['Eventos', '/admin/event'],
'onticket.adminapp.staff' => ['Usuarios', '/admin/staff'],
'onticket.adminapp.ventas' => ['Ventas', '/admin/ventas'],
'adminapp.inicio' => ['Inicio', '/admin/inicio'],
'adminapp.catalog' => ['Catálogo', '/admin/catalog'],
'adminapp.categories' => ['Categorías', '/admin/categories'],
'adminapp.combos' => ['Combos', '/admin/combos'],
'adminapp.event' => ['Eventos', '/admin/event'],
'adminapp.staff' => ['Usuarios', '/admin/staff'],
'adminapp.ventas' => ['Ventas', '/admin/ventas'],
];
$fiestaCategoryMenus = [
'onticket.adminapp.tickets' => ['Tickets', '/admin/tickets'],
'onticket.adminapp.fiesta-futbol-infantil.entradas' => ['Entradas', '/admin/entradas'],
'onticket.adminapp.fiesta-futbol-infantil.alojamientos' => ['Alojamientos', '/admin/alojamientos'],
'onticket.adminapp.fiesta-futbol-infantil.merchandising' => ['Merchandising', '/admin/merchandising'],
'onticket.adminapp.fiesta-futbol-infantil.comida' => ['Comida', '/admin/comidas'],
'adminapp.tickets' => ['Tickets', '/admin/tickets'],
'adminapp.fiesta-futbol-infantil.entradas' => ['Entradas', '/admin/entradas'],
'adminapp.fiesta-futbol-infantil.alojamientos' => ['Alojamientos', '/admin/alojamientos'],
'adminapp.fiesta-futbol-infantil.merchandising' => ['Merchandising', '/admin/merchandising'],
'adminapp.fiesta-futbol-infantil.comida' => ['Comida', '/admin/comidas'],
];
$desfileMenus = [
'onticket.adminapp.desfile.entradas' => ['Entradas', '/admin/desfile/entradas'],
'onticket.adminapp.desfile.reservas' => ['Reserva de Tickets', '/admin/desfile/reservas'],
'adminapp.desfile.entradas' => ['Entradas', '/admin/desfile/entradas'],
'adminapp.desfile.reservas' => ['Reserva de Tickets', '/admin/desfile/reservas'],
];
$shopItMenus = $this->shopItAdminMenus();
@@ -96,10 +96,10 @@ class MenuSeederTest extends TestCase
}
foreach ([
'onticket.adminapp.inicio',
'onticket.adminapp.catalog',
'onticket.adminapp.categories',
'onticket.adminapp.combos',
'adminapp.inicio',
'adminapp.catalog',
'adminapp.categories',
'adminapp.combos',
] as $code) {
$this->assertFalse(
$fiestaTenant->menues()->where('menues.code', $code)->exists()
@@ -164,7 +164,7 @@ class MenuSeederTest extends TestCase
}
$this->assertFalse(
Menu::query()->where('code', 'like', 'adminapp.%')->exists()
Menu::query()->where('code', 'like', 'onticket.%')->exists()
);
}
@@ -214,7 +214,7 @@ class MenuSeederTest extends TestCase
$this->assertSame($userMenuCodes, $userRoleMenuCodes);
$this->assertNotContains('main.adminapp', $userRoleMenuCodes);
$this->assertNotContains('onticket.adminapp.catalog', $userRoleMenuCodes);
$this->assertNotContains('adminapp.catalog', $userRoleMenuCodes);
$scannerRoleMenuCodes = Role::query()
->where('codigo', RoleCode::Scanner->value)

2
tests/Feature/Ticket/AdminAppTicketControllerTest.php
View File

@@ -1359,7 +1359,7 @@ class AdminAppTicketControllerTest extends TestCase
private function grantTicketsMenu(Tenant $tenant): void
{
$menu = Menu::query()->create([
'code' => 'onticket.adminapp.tickets',
'code' => 'adminapp.tickets',
'label' => 'Tickets',
'route' => '/admin/tickets',
]);