tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(purchase): add checkout expiration settings and reservation status to purchase items

Browse Source 
- Introduced a new configuration file for purchase settings, including checkout and payment expiration times.
- Added a migration to include a `reservation_status` column in the `compra_items` table, defaulting to 'active' and updating existing records based on purchase status.
- Created a migration to add an `expires_at` timestamp to the `compras` table, updating it for existing records based on their status.
- Scoped unique indexes in the `carritos` table to only active carts, adding virtual columns for active user and guest tokens.
- Implemented a console command to expire overdue purchases and release stock reservations, scheduled to run every minute.
- Added tests for Google token exchange and login functionality, ensuring proper cart handling and user authentication.
- Updated purchase-related tests to reflect changes in item handling and customer data validation.
This commit is contained in:
ncoronel
2026-07-27 12:49:27 -03:00
parent c37b8894e4
commit 8b26a2b63e
30 changed files with 1738 additions and 396 deletions
Download Patch File Download Diff File Expand all files Collapse all files

440
tests/Feature/Purchase/StorePurchaseTest.php
View File

@@ -30,7 +30,7 @@ class StorePurchaseTest extends TestCase
Queue::fake();
}
public function test_it_creates_a_purchase_from_cart_id_without_persisting_items_yet(): void
public function test_it_creates_an_independent_purchase_snapshot_from_cart(): void
{
$tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create([
@@ -74,24 +74,20 @@ class StorePurchaseTest extends TestCase
]);
$response = $this->actingAs($user, 'sanctum')
->postJson('/api/tenants/sonder/compras', [
->postJson('/api/tenants/sonder/compras/start-checkout', [
'cart_id' => $cartId,
'dni' => '987654321',
'telefono' => '+54 9 341 555-4321',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
]);
$response->assertCreated();
$response->assertJsonPath('data.cart_id', $cartId);
$response->assertJsonPath('data.dni', '987654321');
$response->assertJsonPath('data.telefono', '+54 9 341 555-4321');
$response->assertJsonPath('data.nombre_apellido', 'Juan Perez');
$response->assertJsonPath('data.email', 'juan.perez@example.com');
$response->assertJsonPath('data.dni', null);
$response->assertJsonPath('data.telefono', null);
$response->assertJsonPath('data.nombre_apellido', null);
$response->assertJsonPath('data.email', null);
$response->assertJsonPath('data.tenant_codigo', 'sonder');
$response->assertJsonPath('data.status', Purchase::STATUS_CREATED);
$response->assertJsonPath('data.items_source', null);
$response->assertJsonPath('data.items', []);
$response->assertJsonPath('data.items_source', 'purchase');
$response->assertJsonCount(1, 'data.items');
$response->assertJsonPath('data.subtotal', '100.00');
$response->assertJsonPath('data.total', '100.00');
@@ -102,20 +98,25 @@ class StorePurchaseTest extends TestCase
'cart_id' => $cartId,
'tenant_codigo' => 'sonder',
'user_id' => $user->id,
'dni' => '987654321',
'telefono' => '+54 9 341 555-4321',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
'dni' => null,
'telefono' => null,
'nombre_apellido' => null,
'email' => null,
'status' => Purchase::STATUS_CREATED,
'total' => 100,
]);
$this->assertDatabaseMissing('compra_items', [
$this->assertDatabaseHas('compra_items', [
'compra_id' => $purchaseId,
'source_catalog_item_id' => $catalogItem->id,
'source_variant_id' => $variant->id,
'cantidad' => 2,
'reservation_status' => 'active',
]);
$this->assertDatabaseHas('carritos', [
'id' => $cartId,
'status' => 'active',
'user_id' => $user->id,
'status' => 'checkout',
'deleted_at' => null,
]);
$this->assertDatabaseHas('carrito_items', [
'cart_id' => $cartId,
@@ -130,6 +131,281 @@ class StorePurchaseTest extends TestCase
]);
}
public function test_it_creates_a_direct_purchase_without_creating_or_changing_a_cart(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create();
$variant = $this->createVariantForTenant('sonder', 10, '50.00');
$response = $this->actingAs($user, 'sanctum')
->postJson('/api/tenants/sonder/compras/start-checkout', [
'direct_item' => [
'catalog_item_id' => $variant->catalog_item_id,
'variant_id' => $variant->id,
'cantidad' => 3,
],
])
->assertCreated()
->assertJsonPath('data.cart_id', null)
->assertJsonPath('data.items_source', 'purchase')
->assertJsonPath('data.items.0.quantity', 3)
->assertJsonPath('data.total', '150.00');
$this->assertDatabaseCount('carritos', 0);
$this->assertDatabaseHas('compra_items', [
'compra_id' => $response->json('data.id'),
'source_catalog_item_id' => $variant->catalog_item_id,
'source_variant_id' => $variant->id,
'cantidad' => 3,
'reservation_status' => 'active',
]);
$this->assertDatabaseHas('inventories', [
'id' => $variant->inventory_id,
'real_stock' => 10,
'reserved_stock' => 3,
]);
$this->actingAs($user, 'sanctum')
->postJson("/api/tenants/sonder/compras/{$response->json('data.id')}/cancel")
->assertOk()
->assertJsonPath('data.status', Purchase::STATUS_CANCELLED);
$this->assertDatabaseHas('compra_items', [
'compra_id' => $response->json('data.id'),
'reservation_status' => 'released',
]);
$this->assertDatabaseHas('inventories', [
'id' => $variant->inventory_id,
'real_stock' => 10,
'reserved_stock' => 0,
]);
}
public function test_it_restores_the_source_cart_when_checkout_is_cancelled(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create();
$variant = $this->createVariantForTenant('sonder', 10, '50.00');
$purchase = $this->createCheckoutPurchase($user, 'sonder', $variant, 3);
$this->assertDatabaseHas('carritos', [
'id' => $purchase->cart_id,
'status' => 'checkout',
'deleted_at' => null,
]);
$this->actingAs($user, 'sanctum')
->postJson("/api/tenants/sonder/compras/{$purchase->id}/cancel")
->assertOk()
->assertJsonPath('data.status', Purchase::STATUS_CANCELLED);
$this->assertDatabaseHas('carritos', [
'id' => $purchase->cart_id,
'user_id' => $user->id,
'status' => 'active',
'deleted_at' => null,
]);
$this->assertDatabaseHas('carrito_items', [
'cart_id' => $purchase->cart_id,
'catalog_item_id' => $variant->catalog_item_id,
'variant_id' => $variant->id,
'cantidad' => 3,
]);
$this->assertDatabaseHas('inventories', [
'id' => $variant->inventory_id,
'reserved_stock' => 3,
]);
}
public function test_it_merges_the_checkout_cart_when_the_user_created_another_active_cart(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create();
$variant = $this->createVariantForTenant('sonder', 10, '50.00');
$purchase = $this->createCheckoutPurchase($user, 'sonder', $variant, 2);
$activeCartId = $this->actingAs($user, 'sanctum')
->postJson('/api/tenants/sonder/cart/items', [
'catalog_item_id' => $variant->catalog_item_id,
'variant_id' => $variant->id,
'cantidad' => 1,
])
->assertOk()
->json('data.id');
$this->assertNotSame($purchase->cart_id, $activeCartId);
$this->actingAs($user, 'sanctum')
->postJson("/api/tenants/sonder/compras/{$purchase->id}/cancel")
->assertOk();
$this->assertDatabaseHas('carritos', [
'id' => $activeCartId,
'user_id' => $user->id,
'status' => 'active',
'deleted_at' => null,
]);
$this->assertDatabaseHas('carrito_items', [
'cart_id' => $activeCartId,
'catalog_item_id' => $variant->catalog_item_id,
'variant_id' => $variant->id,
'cantidad' => 3,
]);
$this->assertDatabaseHas('inventories', [
'id' => $variant->inventory_id,
'reserved_stock' => 3,
]);
}
public function test_it_creates_purchase_items_before_checkout_and_updates_customer_data(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create();
$variant = $this->createVariantForTenant('sonder', 10, '50.00');
$purchaseResponse = $this->actingAs($user, 'sanctum')
->postJson('/api/tenants/sonder/compras/start-checkout', [
'direct_item' => [
'catalog_item_id' => $variant->catalog_item_id,
'variant_id' => $variant->id,
'cantidad' => 2,
],
])
->assertCreated()
->assertJsonPath('data.items_source', 'purchase')
->assertJsonCount(1, 'data.items')
->assertJsonPath('data.items.0.quantity', 2)
->assertJsonPath('data.dni', null)
->assertJsonPath('data.telefono', null);
$purchaseId = $purchaseResponse->json('data.id');
$this->actingAs($user, 'sanctum')
->patchJson("/api/tenants/sonder/compras/{$purchaseId}/customer-data", [
'dni' => '987654321',
'telefono' => '+54 9 341 555-4321',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
])
->assertOk()
->assertJsonPath('data.id', $purchaseId)
->assertJsonPath('data.dni', '987654321')
->assertJsonPath('data.telefono', '+54 9 341 555-4321')
->assertJsonPath('data.nombre_apellido', 'Juan Perez')
->assertJsonPath('data.email', 'juan.perez@example.com')
->assertJsonCount(1, 'data.items');
$this->assertDatabaseHas('compras', [
'id' => $purchaseId,
'dni' => '987654321',
'telefono' => '+54 9 341 555-4321',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
]);
}
public function test_it_updates_a_created_purchase_item_quantity_and_its_stock_reservation(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create();
$variant = $this->createVariantForTenant('sonder', 10, '50.00');
$purchase = $this->createCheckoutPurchase($user, 'sonder', $variant, 2);
$itemId = $purchase->items->firstOrFail()->id;
$this->actingAs($user, 'sanctum')
->patchJson("/api/tenants/sonder/compras/{$purchase->id}/items/{$itemId}", [
'quantity' => 4,
])
->assertOk()
->assertJsonPath('data.items.0.quantity', 4)
->assertJsonPath('data.items.0.line_total', '200.00')
->assertJsonPath('data.subtotal', '200.00')
->assertJsonPath('data.total', '200.00');
$this->assertDatabaseHas('inventories', [
'id' => $variant->inventory_id,
'reserved_stock' => 4,
]);
$this->assertDatabaseHas('carrito_items', [
'cart_id' => $purchase->cart_id,
'catalog_item_id' => $variant->catalog_item_id,
'variant_id' => $variant->id,
'cantidad' => 4,
]);
$this->actingAs($user, 'sanctum')
->patchJson("/api/tenants/sonder/compras/{$purchase->id}/items/{$itemId}", [
'quantity' => 1,
])
->assertOk()
->assertJsonPath('data.items.0.quantity', 1)
->assertJsonPath('data.total', '50.00');
$this->assertDatabaseHas('inventories', [
'id' => $variant->inventory_id,
'reserved_stock' => 1,
]);
}
public function test_it_reopens_a_pending_purchase_before_editing_items(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create();
$variant = $this->createVariantForTenant('sonder', 10, '50.00');
$purchase = $this->createCheckoutPurchase($user, 'sonder', $variant, 2);
$purchase->update([
'status' => Purchase::STATUS_PENDING_PAYMENT,
'payment_method' => 'qr',
]);
$purchase->telepagosQr()->create([
'qr_order_id' => 'stale-order',
'qr_code' => 'stale-qr',
]);
$this->actingAs($user, 'sanctum')
->postJson("/api/tenants/sonder/compras/{$purchase->id}/edit-items")
->assertOk()
->assertJsonPath('data.status', Purchase::STATUS_CREATED)
->assertJsonPath('data.payment_method', null);
$this->assertDatabaseHas('compras', [
'id' => $purchase->id,
'status' => Purchase::STATUS_CREATED,
'payment_method' => null,
]);
$this->assertDatabaseMissing('telepagos_qr', [
'compra_id' => $purchase->id,
'qr_order_id' => 'stale-order',
]);
}
public function test_start_checkout_rejects_customer_data(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create();
$variant = $this->createVariantForTenant('sonder', 10, '50.00');
$this->actingAs($user, 'sanctum')
->postJson('/api/tenants/sonder/compras/start-checkout', [
'direct_item' => [
'catalog_item_id' => $variant->catalog_item_id,
'variant_id' => $variant->id,
'cantidad' => 1,
],
'dni' => '987654321',
'telefono' => '+54 9 341 555-4321',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
])
->assertUnprocessable()
->assertJsonValidationErrors([
'dni',
'telefono',
'nombre_apellido',
'email',
]);
}
public function test_it_moves_a_created_purchase_to_pending_payment_when_finalized(): void
{
$tenant = $this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
@@ -148,12 +424,8 @@ class StorePurchaseTest extends TestCase
->json('data.id');
$purchaseId = $this->actingAs($user, 'sanctum')
->postJson('/api/tenants/sonder/compras', [
->postJson('/api/tenants/sonder/compras/start-checkout', [
'cart_id' => $cartId,
'dni' => '987654321',
'telefono' => '+54 9 341 555-4321',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
])
->assertCreated()
->json('data.id');
@@ -176,7 +448,52 @@ class StorePurchaseTest extends TestCase
]);
}
public function test_purchase_detail_uses_cart_items_for_created_purchase(): void
public function test_it_expires_an_abandoned_purchase_and_restores_its_cart(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create();
$variant = $this->createVariantForTenant('sonder', 10, '50.00');
$purchase = $this->createCheckoutPurchase($user, 'sonder', $variant, 3);
$this->assertNotNull($purchase->expires_at);
$this->assertDatabaseHas('inventories', [
'id' => $variant->inventory_id,
'reserved_stock' => 3,
]);
$this->travel(31)->minutes();
$this->artisan('purchases:expire')
->expectsOutput('Expired purchases: 1')
->assertSuccessful();
$this->assertDatabaseHas('compras', [
'id' => $purchase->id,
'status' => Purchase::STATUS_EXPIRED,
]);
$this->assertDatabaseHas('compra_items', [
'compra_id' => $purchase->id,
'reservation_status' => 'released',
]);
$this->assertDatabaseHas('inventories', [
'id' => $variant->inventory_id,
'real_stock' => 10,
'reserved_stock' => 3,
'sold_units' => 0,
]);
$this->assertDatabaseHas('carritos', [
'id' => $purchase->cart_id,
'user_id' => $user->id,
'status' => 'active',
'deleted_at' => null,
]);
$this->artisan('purchases:expire')
->expectsOutput('Expired purchases: 0')
->assertSuccessful();
}
public function test_purchase_detail_uses_purchase_items_for_created_purchase(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create([
@@ -189,22 +506,22 @@ class StorePurchaseTest extends TestCase
->getJson("/api/tenants/sonder/compras/{$purchase->id}")
->assertOk()
->assertJsonPath('data.status', Purchase::STATUS_CREATED)
->assertJsonPath('data.items_source', 'cart')
->assertJsonPath('data.items_source', 'purchase')
->assertJsonCount(1, 'data.items')
->assertJsonPath('data.items.0.quantity', 2)
->assertJsonPath('data.items.0.unit_price', '50.00')
->assertJsonPath('data.items.0.line_total', '100.00')
->assertJsonPath('data.items.0.product.id', $variant->catalogItem->id)
->assertJsonPath('data.items.0.product.nombre', $variant->catalogItem->nombre)
->assertJsonPath('data.items.0.product.slug', $variant->catalogItem->slug)
->assertJsonPath('data.items.0.product.imagen', null)
->assertJsonPath('data.items.0.variant.id', $variant->id)
->assertJsonPath('data.items.0.variant.attributes', [])
->assertJsonPath('data.items.0.source_catalog_item_id', $variant->catalogItem->id)
->assertJsonPath('data.items.0.source_variant_id', $variant->id)
->assertJsonPath('data.items.0.item_details.nombre', $variant->catalogItem->nombre)
->assertJsonPath('data.items.0.item_details.slug', $variant->catalogItem->slug)
->assertJsonPath('data.items.0.item_details.imagen', null)
->assertJsonPath('data.items.0.item_details.attributes', [])
->assertJsonPath('data.subtotal', '100.00')
->assertJsonPath('data.total', '100.00');
}
public function test_purchase_detail_uses_cart_items_for_pending_payment_purchase(): void
public function test_purchase_detail_uses_purchase_items_for_pending_payment_purchase(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create([
@@ -223,13 +540,13 @@ class StorePurchaseTest extends TestCase
->getJson("/api/tenants/sonder/compras/{$purchase->id}")
->assertOk()
->assertJsonPath('data.status', Purchase::STATUS_PENDING_PAYMENT)
->assertJsonPath('data.items_source', 'cart')
->assertJsonPath('data.items_source', 'purchase')
->assertJsonCount(1, 'data.items')
->assertJsonPath('data.items.0.quantity', 2)
->assertJsonPath('data.items.0.unit_price', '50.00')
->assertJsonPath('data.items.0.line_total', '100.00')
->assertJsonPath('data.items.0.product.imagen', null)
->assertJsonPath('data.items.0.variant.attributes', [])
->assertJsonPath('data.items.0.item_details.imagen', null)
->assertJsonPath('data.items.0.item_details.attributes', [])
->assertJsonPath('data.subtotal', '100.00')
->assertJsonPath('data.total', '100.00');
}
@@ -280,7 +597,7 @@ class StorePurchaseTest extends TestCase
->assertJsonPath('data.total', '100.00');
}
public function test_purchase_detail_prefers_purchase_items_when_both_sources_exist(): void
public function test_purchase_detail_does_not_require_its_source_cart(): void
{
$this->createTenant('sonder', 'Sonder', 'sonder.com.ar');
$user = User::factory()->create([
@@ -289,30 +606,17 @@ class StorePurchaseTest extends TestCase
$variant = $this->createVariantForTenant('sonder', 10, '50.00');
$purchase = $this->createCheckoutPurchase($user, 'sonder', $variant, 2);
$purchase->items()->create([
'source_catalog_item_id' => $variant->catalog_item_id,
'source_variant_id' => $variant->id,
'nombre' => $variant->catalogItem->nombre,
'descripcion' => $variant->catalogItem->descripcion,
'slug' => $variant->catalogItem->slug,
'item_nombre' => $variant->getName(),
'variant_attributes' => [],
'cantidad' => 1,
'precio_unitario' => '50.00',
'discount_total' => null,
'tax_total' => null,
'total' => '50.00',
]);
$purchase->update(['cart_id' => null]);
$this->actingAs($user, 'sanctum')
->getJson("/api/tenants/sonder/compras/{$purchase->id}")
->assertOk()
->assertJsonPath('data.items_source', 'purchase')
->assertJsonCount(1, 'data.items')
->assertJsonPath('data.items.0.quantity', 1)
->assertJsonPath('data.items.0.line_total', '50.00')
->assertJsonPath('data.subtotal', '50.00')
->assertJsonPath('data.total', '50.00');
->assertJsonPath('data.items.0.quantity', 2)
->assertJsonPath('data.items.0.line_total', '100.00')
->assertJsonPath('data.subtotal', '100.00')
->assertJsonPath('data.total', '100.00');
}
public function test_purchase_index_returns_empty_items_without_loaded_relations(): void
@@ -350,12 +654,8 @@ class StorePurchaseTest extends TestCase
->json('data.id');
$this->actingAs($attacker, 'sanctum')
->postJson('/api/tenants/sonder/compras', [
->postJson('/api/tenants/sonder/compras/start-checkout', [
'cart_id' => $cartId,
'dni' => '12345678',
'telefono' => '+54 9 341 555-1111',
'nombre_apellido' => 'Intruso',
'email' => 'intruso@example.com',
])
->assertNotFound();
}
@@ -377,12 +677,8 @@ class StorePurchaseTest extends TestCase
->json('data.id');
$this->actingAs($user, 'sanctum')
->postJson('/api/tenants/sonder/compras', [
->postJson('/api/tenants/sonder/compras/start-checkout', [
'cart_id' => $cartId,
'dni' => '12345678',
'telefono' => '+54 9 341 555-1111',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
])
->assertNotFound();
}
@@ -398,12 +694,8 @@ class StorePurchaseTest extends TestCase
]);
$this->actingAs($user, 'sanctum')
->postJson('/api/tenants/sonder/compras', [
->postJson('/api/tenants/sonder/compras/start-checkout', [
'cart_id' => $cart->id,
'dni' => '12345678',
'telefono' => '+54 9 341 555-1111',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
])
->assertUnprocessable()
->assertJsonValidationErrors(['cart_id']);
@@ -420,12 +712,8 @@ class StorePurchaseTest extends TestCase
]);
$this->actingAs($user, 'sanctum')
->postJson('/api/tenants/sonder/compras', [
->postJson('/api/tenants/sonder/compras/start-checkout', [
'cart_id' => $cart->id,
'dni' => '12345678',
'telefono' => '+54 9 341 555-1111',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
])
->assertUnprocessable()
->assertJsonValidationErrors(['cart_id']);
@@ -510,10 +798,6 @@ class StorePurchaseTest extends TestCase
return app(CheckoutService::class)->startCheckout($tenant, $user->id, [
'cart_id' => $cart->id,
'dni' => '987654321',
'telefono' => '+54 9 341 555-4321',
'nombre_apellido' => 'Juan Perez',
'email' => 'juan.perez@example.com',
]);
}