feat: refactor cart and purchase handling to support polymorphic buyable types and improve code readability

2026-07-16 09:55:38 -03:00
parent c05206cc51
commit 6fc6ed1fac
14 changed files with 196 additions and 79 deletions
--- a/app/Domains/Purchase/Controllers/PurchaseController.php
+++ b/app/Domains/Purchase/Controllers/PurchaseController.php
@@ -2,14 +2,20 @@

 namespace App\Domains\Purchase\Controllers;

+use App\Domains\Bundle\Models\Bundle;
+use App\Domains\Catalog\Models\ProductVariant;
+use App\Domains\Integration\Services\TelepagosIntegrationService;
 use App\Domains\Purchase\Models\Purchase;
+use App\Domains\Purchase\Requests\PaymentIntentRequest;
 use App\Domains\Purchase\Requests\StorePurchaseRequest;
 use App\Domains\Purchase\Resources\PurchaseResource;
 use App\Domains\Purchase\Services\CheckoutService;
 use App\Domains\Tenant\Models\Tenant;
 use App\Http\Controllers\Controller;
+use Illuminate\Database\Eloquent\Relations\MorphTo;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
+use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Log;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

@@ -46,12 +52,17 @@ class PurchaseController extends Controller
    {
        $compra = $this->resolveScopedPurchase($tenant, $request->user()->id, $compra);

-        return PurchaseResource::make(
-            $compra->loadMissing($this->purchaseDetailRelations())
-        );
+        $compra->loadMissing(['items', 'cart.items']);
+        $this->loadBuyables($compra->items);
+
+        if ($compra->cart !== null) {
+            $this->loadBuyables($compra->cart->items);
+        }
+
+        return PurchaseResource::make($compra);
    }

-    public function paymentIntent(\App\Domains\Purchase\Requests\PaymentIntentRequest $request, Tenant $tenant, Purchase $compra): JsonResponse
+    public function paymentIntent(PaymentIntentRequest $request, Tenant $tenant, Purchase $compra): JsonResponse
    {
        $compra = $this->resolveScopedPurchase($tenant, $request->user()->id, $compra);
        $method = $request->validated('method');
@@ -63,7 +74,7 @@ class PurchaseController extends Controller
        ]);

        if ($method === 'transfer') {
-            $telepagosService = new \App\Domains\Integration\Services\TelepagosIntegrationService();
+            $telepagosService = new TelepagosIntegrationService;
            $telepagosService->forTenant($tenant->codigo);

            try {
@@ -81,13 +92,13 @@ class PurchaseController extends Controller
                ]);
            } catch (\Exception $e) {
                return response()->json([
-                    'message' => 'Error getting account info: ' . $e->getMessage()
+                    'message' => 'Error getting account info: '.$e->getMessage(),
                ], 500);
            }
        }

        if ($method === 'qr') {
-            $telepagosService = new \App\Domains\Integration\Services\TelepagosIntegrationService();
+            $telepagosService = new TelepagosIntegrationService;
            $telepagosService->forTenant($tenant->codigo);

            try {
@@ -100,11 +111,11 @@ class PurchaseController extends Controller

                $telepagosQr = $compra->telepagosQr()->create([
                    'qr_order_id' => (string) ($qrResponse['qr_order_id'] ?? ''),
-                    'qr_code' =>  $qrResponse['qr_code'] ?? '',
+                    'qr_code' => $qrResponse['qr_code'] ?? '',
                ]);
            } catch (\Exception $e) {
                return response()->json([
-                    'message' => 'Error generating QR: ' . $e->getMessage()
+                    'message' => 'Error generating QR: '.$e->getMessage(),
                ], 500);
            }

@@ -143,15 +154,19 @@ class PurchaseController extends Controller
    /**
     * @return list<string>
     */
-    protected function purchaseDetailRelations(): array
+    protected function loadBuyables(Collection $items): void
    {
-        return [
-            'items.variant.product',
-            'items.variant.definitions.productAttribute.attribute',
-            'items.variant.attachments',
-            'cart.items.variant.product',
-            'cart.items.variant.definitions.productAttribute.attribute',
-            'cart.items.variant.attachments',
-        ];
+        $items->load([
+            'buyable' => function (MorphTo $morphTo): void {
+                $morphTo->morphWith([
+                    ProductVariant::class => [
+                        'product',
+                        'definitions.productAttribute.attribute',
+                        'attachments',
+                    ],
+                    Bundle::class => ['items.variant'],
+                ]);
+            },
+        ]);
    }
 }
--- a/app/Domains/Purchase/Models/Purchase.php
+++ b/app/Domains/Purchase/Models/Purchase.php
@@ -10,6 +10,7 @@ use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Database\Eloquent\Relations\HasMany;
+use Illuminate\Database\Eloquent\Relations\HasOne;

 #[Fillable([
    'cart_id',
@@ -28,9 +29,13 @@ class Purchase extends Model
    use HasFactory;

    public const STATUS_CREATED = 'created';
+
    public const STATUS_PENDING_PAYMENT = 'pending_payment';
+
    public const STATUS_PAID = 'paid';
+
    public const STATUS_CANCELLED = 'cancelled';
+
    public const STATUS_REJECTED = 'rejected';

    protected $table = 'compras';
@@ -77,7 +82,7 @@ class Purchase extends Model
    }

    /**
-     * @return \Illuminate\Database\Eloquent\Relations\HasOne<TelepagosQr, $this>
+     * @return HasOne<TelepagosQr, $this>
     */
    public function telepagosQr()
    {
@@ -113,7 +118,7 @@ class Purchase extends Model

        $cart = $this->relationLoaded('cart')
            ? $this->getRelation('cart')
-            : $this->cart()->with('items.variant.product')->first();
+            : $this->cart()->with('items.buyable')->first();

        if (! $cart) {
            return 0.0;
--- a/app/Domains/Purchase/Resources/PurchaseItemResource.php
+++ b/app/Domains/Purchase/Resources/PurchaseItemResource.php
@@ -2,13 +2,16 @@

 namespace App\Domains\Purchase\Resources;

+use App\Domains\Bundle\Models\Bundle;
 use App\Domains\Cart\Models\CartItem;
+use App\Domains\Catalog\Models\ProductVariant;
 use App\Domains\Purchase\Models\PurchaseItem;
+use App\Domains\Shared\Contracts\Buyable;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;

 /**
- * @mixin \App\Domains\Purchase\Models\PurchaseItem|\App\Domains\Cart\Models\CartItem
+ * @mixin PurchaseItem|CartItem
 */
 class PurchaseItemResource extends JsonResource
 {
@@ -17,15 +20,16 @@ class PurchaseItemResource extends JsonResource
     */
    public function toArray(Request $request): array
    {
-        /** @var \App\Domains\Shared\Contracts\Buyable|null $buyable */
+        /** @var Buyable|null $buyable */
        $buyable = $this->buyable;
        $quantity = (int) ($this->cantidad ?? 0);
        $unitPrice = $this->resolveUnitPrice();
        $lineTotal = $this->resolveLineTotal($unitPrice, $quantity);
+        $variant = $buyable instanceof ProductVariant ? $buyable : null;

        $imageUrl = null;
        $attributes = [];
-        if ($this->buyable_type === \App\Domains\Catalog\Models\ProductVariant::class && $buyable) {
+        if ($this->buyable_type === ProductVariant::class && $buyable) {
            $imageUrl = $this->resolveImageUrl($buyable);
            $attributes = $this->resolveAttributes($buyable);
        }
@@ -37,6 +41,16 @@ class PurchaseItemResource extends JsonResource
            'line_total' => $this->formatMoney($lineTotal),
            'buyable_type' => $this->mapBuyableTypeToAlias($this->buyable_type),
            'buyable_id' => $this->buyable_id,
+            'product' => $variant === null ? null : [
+                'id' => $variant->product?->id,
+                'nombre' => $variant->product?->nombre,
+                'slug' => $variant->product?->slug,
+                'imagen' => $imageUrl,
+            ],
+            'variant' => $variant === null ? null : [
+                'id' => $variant->id,
+                'attributes' => $attributes,
+            ],
            'item_details' => $buyable === null ? null : [
                'nombre' => $buyable->getName(),
                'imagen' => $imageUrl,
@@ -48,8 +62,8 @@ class PurchaseItemResource extends JsonResource
    protected function mapBuyableTypeToAlias(?string $type): string
    {
        return match ($type) {
-            \App\Domains\Catalog\Models\ProductVariant::class => 'variant',
-            \App\Domains\Bundle\Models\Bundle::class => 'bundle',
+            ProductVariant::class => 'variant',
+            Bundle::class => 'bundle',
            default => 'unknown',
        };
    }
--- a/app/Domains/Purchase/Resources/PurchaseResource.php
+++ b/app/Domains/Purchase/Resources/PurchaseResource.php
@@ -3,13 +3,14 @@
 namespace App\Domains\Purchase\Resources;

 use App\Domains\Cart\Models\CartItem;
+use App\Domains\Purchase\Models\Purchase;
 use App\Domains\Purchase\Models\PurchaseItem;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;
 use Illuminate\Support\Collection;

 /**
- * @mixin \App\Domains\Purchase\Models\Purchase
+ * @mixin Purchase
 */
 class PurchaseResource extends JsonResource
 {
@@ -87,7 +88,7 @@ class PurchaseResource extends JsonResource
            return (float) $item->precio_unitario * $item->cantidad;
        }

-        return (float) ($item->variant?->product?->precio ?? 0) * $item->cantidad;
+        return (float) ($item->buyable?->getPrice() ?? 0) * $item->cantidad;
    }

    protected function resolveItemTotal(PurchaseItem|CartItem $item): float