From 856b9a670632963fc32c868ac0a7cdd48978d9c7 Mon Sep 17 00:00:00 2001 From: ncoronel Date: Thu, 1 Oct 2026 10:29:06 -0300 Subject: [PATCH] refactor: update menu code references from 'onticket.adminapp.tickets' to 'adminapp.tickets' --- app/Domains/Ticketing/Ticket/documentacion/README.md | 2 +- app/Domains/Ticketing/Ticket/routes/adminapp.php | 12 ++++++------ app/Shared/Forms/routes/adminapp.php | 2 +- tests/Feature/Menu/TicketMenuAccessTest.php | 10 +++++----- .../Feature/Ticket/AdminAppTicketEventScopeTest.php | 4 ++-- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/app/Domains/Ticketing/Ticket/documentacion/README.md b/app/Domains/Ticketing/Ticket/documentacion/README.md index 66b5df4c..1b3bf0eb 100644 --- a/app/Domains/Ticketing/Ticket/documentacion/README.md +++ b/app/Domains/Ticketing/Ticket/documentacion/README.md @@ -82,7 +82,7 @@ Bajo `/tenants/{tenant:codigo}`, protegidos por `auth:sanctum`: - `POST /tickets/pdf`. Bajo `/v1/adminapp/tenant`, protegido por `auth:sanctum`, `adminapp.tenant` y el menú -`onticket.adminapp.tickets`: +`adminapp.tickets`: - `GET /tickets`, paginado y con búsqueda opcional mediante `q`. La respuesta incluye `scanned_tickets` y `total_tickets` para el tenant autenticado. diff --git a/app/Domains/Ticketing/Ticket/routes/adminapp.php b/app/Domains/Ticketing/Ticket/routes/adminapp.php index 17e0329a..b785612a 100644 --- a/app/Domains/Ticketing/Ticket/routes/adminapp.php +++ b/app/Domains/Ticketing/Ticket/routes/adminapp.php @@ -7,24 +7,24 @@ Route::prefix('v1/adminapp/tenant') ->middleware(['auth:sanctum', 'adminapp.tenant']) ->group(function (): void { Route::get('tickets', [TicketController::class, 'index']) - ->middleware('tenant.menu:onticket.adminapp.tickets') + ->middleware('tenant.menu:adminapp.tickets') ->name('adminapp.tickets.index'); Route::post('tickets/{ticket}/cancel', [TicketController::class, 'cancel']) ->whereNumber('ticket') - ->middleware('tenant.menu:onticket.adminapp.tickets') + ->middleware('tenant.menu:adminapp.tickets') ->name('adminapp.tickets.cancel'); Route::get('tickets/{ticket}/refund', [TicketController::class, 'calculateRefund']) ->whereNumber('ticket') - ->middleware('tenant.menu:onticket.adminapp.tickets') + ->middleware('tenant.menu:adminapp.tickets') ->name('adminapp.tickets.calculate-refund'); Route::post('tickets/{ticket}/refund', [TicketController::class, 'refund']) ->whereNumber('ticket') - ->middleware('tenant.menu:onticket.adminapp.tickets') + ->middleware('tenant.menu:adminapp.tickets') ->name('adminapp.tickets.refund'); Route::get('tickets/pdf', [TicketController::class, 'downloadPdf']) - ->middleware('tenant.menu:onticket.adminapp.tickets') + ->middleware('tenant.menu:adminapp.tickets') ->name('adminapp.tickets.pdf'); Route::get('tickets/excel', [TicketController::class, 'downloadExcel']) - ->middleware('tenant.menu:onticket.adminapp.tickets') + ->middleware('tenant.menu:adminapp.tickets') ->name('adminapp.tickets.excel'); }); diff --git a/app/Shared/Forms/routes/adminapp.php b/app/Shared/Forms/routes/adminapp.php index e77dcc63..6517d639 100644 --- a/app/Shared/Forms/routes/adminapp.php +++ b/app/Shared/Forms/routes/adminapp.php @@ -23,7 +23,7 @@ Route::prefix('v1/adminapp/forms') Route::get('sale', SaleFormController::class); Route::get('staff', StaffFormController::class); Route::get('tickets-filter', TicketFilterFormController::class) - ->middleware('tenant.menu:onticket.adminapp.tickets') + ->middleware('tenant.menu:adminapp.tickets') ->name('adminapp.forms.tickets-filter'); Route::get( 'fiesta-futbol-infantil/ticket', diff --git a/tests/Feature/Menu/TicketMenuAccessTest.php b/tests/Feature/Menu/TicketMenuAccessTest.php index a9dae0a2..48c7549a 100644 --- a/tests/Feature/Menu/TicketMenuAccessTest.php +++ b/tests/Feature/Menu/TicketMenuAccessTest.php @@ -18,9 +18,9 @@ class TicketMenuAccessTest extends TestCase public static function menuAssignments(): array { return [ - 'OnTicket' => ['onticket.adminapp.tickets', 'current', true], - 'old code' => ['adminapp.tickets', 'current', false], - 'another tenant' => ['onticket.adminapp.tickets', 'other', false], + 'new code' => ['onticket.adminapp.tickets', 'current', false], + 'old code' => ['adminapp.tickets', 'current', true], + 'another tenant' => ['adminapp.tickets', 'other', false], 'unrelated menu' => ['adminapp.ventas', 'current', false], ]; } @@ -53,7 +53,7 @@ class TicketMenuAccessTest extends TestCase } try { - $response = (new EnsureTenantHasMenu)->handle($request, fn () => response('allowed'), 'onticket.adminapp.tickets'); + $response = (new EnsureTenantHasMenu)->handle($request, fn () => response('allowed'), 'adminapp.tickets'); $this->assertSame('allowed', $response->getContent()); } catch (HttpException $exception) { $this->assertSame(404, $exception->getStatusCode()); @@ -70,7 +70,7 @@ class TicketMenuAccessTest extends TestCase ] as $name) { $route = Route::getRoutes()->getByName($name); $this->assertNotNull($route); - $this->assertContains('tenant.menu:onticket.adminapp.tickets', $route->gatherMiddleware()); + $this->assertContains('tenant.menu:adminapp.tickets', $route->gatherMiddleware()); } } } diff --git a/tests/Feature/Ticket/AdminAppTicketEventScopeTest.php b/tests/Feature/Ticket/AdminAppTicketEventScopeTest.php index 8820c3be..3b698584 100644 --- a/tests/Feature/Ticket/AdminAppTicketEventScopeTest.php +++ b/tests/Feature/Ticket/AdminAppTicketEventScopeTest.php @@ -91,8 +91,8 @@ class AdminAppTicketEventScopeTest extends TestCase }); DB::table('tenants')->insert(['codigo' => 'onticket']); - DB::table('menues')->insert(['code' => 'onticket.adminapp.tickets']); - DB::table('tenants_menues')->insert(['tenant_code' => 'onticket', 'menu_code' => 'onticket.adminapp.tickets']); + DB::table('menues')->insert(['code' => 'adminapp.tickets']); + DB::table('tenants_menues')->insert(['tenant_code' => 'onticket', 'menu_code' => 'adminapp.tickets']); foreach ([1 => ['onticket', 10], 2 => ['onticket', 20], 3 => ['onticket', null], 4 => ['other', 10]] as $id => [$tenant, $event]) { DB::table('tickets')->insert([ 'id' => $id, 'tenant_code' => $tenant, 'event_id' => $event,