feat(website-extras): refactor WebsiteExtra management to use 'codigo' for identification, update routes, requests, and services

tests/Feature/Seeders/TenantSeederTest.php

@@ -63,7 +63,7 @@ class TenantSeederTest extends TestCase
         $this->assertSame('shopit', $sonder->website_type_code);
 
         $carousel = $sonder->websiteExtras
-            ->firstWhere('websiteTypeExtra.nombre', 'carousel');
+            ->firstWhere('websiteTypeExtra.codigo', 'carousel');
 
         $this->assertNotNull($carousel);
         $this->assertCount(6, $carousel->config);
@@ -82,7 +82,7 @@ class TenantSeederTest extends TestCase
 
         $this->assertSame('onticket', $fiesta->website_type_code);
 
-        $extras = $fiesta->websiteExtras->keyBy('websiteTypeExtra.nombre');
+        $extras = $fiesta->websiteExtras->keyBy('websiteTypeExtra.codigo');
         $this->assertEqualsCanonicalizing(
             ['heroConfig', 'eventConfig'],
             $extras->keys()->all(),

tests/Feature/Seeders/WebsiteTypeSeederTest.php

@@ -24,7 +24,8 @@ class WebsiteTypeSeederTest extends TestCase
             ->sole();
 
         $this->assertSame('ShopIt', $shopIt->nombre);
-        $this->assertSame(['carousel'], $shopIt->extras->pluck('nombre')->all());
+        $this->assertSame(['carousel'], $shopIt->extras->pluck('codigo')->all());
+        $this->assertSame('Carrusel principal', $shopIt->extras->sole()->nombre);
         $this->assertSame([
             'request_rules' => [
                 '$' => 'required|array|max:10',
@@ -50,10 +51,10 @@ class WebsiteTypeSeederTest extends TestCase
         $this->assertSame('OnTicket', $onTicket->nombre);
         $this->assertEqualsCanonicalizing(
             ['heroConfig', 'eventConfig'],
-            $onTicket->extras->pluck('nombre')->all(),
+            $onTicket->extras->pluck('codigo')->all(),
         );
 
-        $heroSchema = $onTicket->extras->firstWhere('nombre', 'heroConfig')->config_schema;
+        $heroSchema = $onTicket->extras->firstWhere('codigo', 'heroConfig')->config_schema;
         $this->assertSame([
             'request_rules' => [
                 '$' => 'required|array',
@@ -79,7 +80,7 @@ class WebsiteTypeSeederTest extends TestCase
             ],
         ], $heroSchema);
 
-        $eventSchema = $onTicket->extras->firstWhere('nombre', 'eventConfig')->config_schema;
+        $eventSchema = $onTicket->extras->firstWhere('codigo', 'eventConfig')->config_schema;
         $this->assertSame([
             'request_rules' => [
                 '$' => 'required|array',

tests/Feature/Tenant/AdminAppWebsiteExtraControllerTest.php

@@ -29,7 +29,8 @@ class AdminAppWebsiteExtraControllerTest extends TestCase
         ]);
 
         $this->websiteType->extras()->create([
-            'nombre' => 'contactConfig',
+            'codigo' => 'contactConfig',
+            'nombre' => 'Configuración de contacto',
             'descripcion' => 'Datos de contacto visibles en la tienda.',
             'is_required' => false,
             'config_schema' => [
@@ -79,16 +80,29 @@ class AdminAppWebsiteExtraControllerTest extends TestCase
         $this->getJson('/api/v1/adminapp/tenant/website-extras')
             ->assertOk()
             ->assertJsonPath('data.website_type.codigo', 'test-store')
+            ->assertJsonPath('data.definitions.contactConfig.codigo', 'contactConfig')
+            ->assertJsonPath('data.definitions.contactConfig.nombre', 'Configuración de contacto')
             ->assertJsonPath('data.definitions.contactConfig.is_required', false)
             ->assertJsonPath('data.extras.contactConfig.phone', '+54 341 555 0101')
             ->assertJsonPath('data.resolved_extras.contactConfig.phone', '+54 341 555 0101');
     }
 
-    public function test_adminapp_user_replaces_only_its_tenant_extras(): void
+    public function test_adminapp_user_updates_one_extra_without_touching_other_tenants(): void
     {
         $tenant = $this->createTenant('acme');
         $otherTenant = $this->createTenant('other');
         $definition = $this->websiteType->extras()->firstOrFail();
+        $secondaryDefinition = $this->websiteType->extras()->create([
+            'codigo' => 'footerConfig',
+            'nombre' => 'Configuración del pie',
+            'descripcion' => 'Configuración adicional del pie.',
+            'is_required' => false,
+            'config_schema' => [
+                'request_rules' => ['$' => 'required|array'],
+                'transforms' => [],
+                'database_rules' => ['$' => 'required|array'],
+            ],
+        ]);
 
         $tenant->websiteExtras()->create([
             'website_type_extra_id' => $definition->id,
@@ -98,14 +112,16 @@ class AdminAppWebsiteExtraControllerTest extends TestCase
             'website_type_extra_id' => $definition->id,
             'config' => ['phone' => 'untouched'],
         ]);
+        $tenant->websiteExtras()->create([
+            'website_type_extra_id' => $secondaryDefinition->id,
+            'config' => ['text' => 'also untouched'],
+        ]);
 
         Sanctum::actingAs($this->createAdminAppUser($tenant));
 
-        $this->putJson('/api/v1/adminapp/tenant/website-extras', [
-            'extras' => [
-                'contactConfig' => [
-                    'phone' => '+54 341 555 9999',
-                ],
+        $this->putJson('/api/v1/adminapp/tenant/website-extras/contactConfig', [
+            'config' => [
+                'phone' => '+54 341 555 9999',
             ],
         ])
             ->assertOk()
@@ -119,20 +135,24 @@ class AdminAppWebsiteExtraControllerTest extends TestCase
             ['phone' => 'untouched'],
             $otherTenant->websiteExtras()->firstOrFail()->config
         );
+        $this->assertSame(
+            ['text' => 'also untouched'],
+            $tenant->websiteExtras()
+                ->where('website_type_extra_id', $secondaryDefinition->id)
+                ->firstOrFail()
+                ->config
+        );
     }
 
-    public function test_update_rejects_extras_not_supported_by_the_website_type(): void
+    public function test_update_returns_not_found_for_an_unsupported_extra_code(): void
     {
         $tenant = $this->createTenant('acme');
         Sanctum::actingAs($this->createAdminAppUser($tenant));
 
-        $this->putJson('/api/v1/adminapp/tenant/website-extras', [
-            'extras' => [
-                'unknown' => ['enabled' => true],
-            ],
+        $this->putJson('/api/v1/adminapp/tenant/website-extras/unknown', [
+            'config' => ['enabled' => true],
         ])
-            ->assertUnprocessable()
-            ->assertJsonValidationErrors('extras');
+            ->assertNotFound();
     }
 
     private function createTenant(string $code): Tenant

tests/Feature/Tenant/StoreTenantWithExtrasTest.php

@@ -153,7 +153,7 @@ class StoreTenantWithExtrasTest extends TestCase
             ->websiteExtras()
             ->whereHas(
                 'websiteTypeExtra',
-                fn ($query) => $query->where('nombre', 'heroConfig')
+                fn ($query) => $query->where('codigo', 'heroConfig')
             )
             ->sole()
             ->config;

tests/Feature/Tenant/WebsiteExtrasTest.php

@@ -27,6 +27,7 @@ class WebsiteExtrasTest extends TestCase
         $this->assertEqualsCanonicalizing([
             'id',
             'website_type_code',
+            'codigo',
             'nombre',
             'descripcion',
             'is_required',
@@ -52,6 +53,7 @@ class WebsiteExtrasTest extends TestCase
             'nombre' => 'Tienda',
         ]);
         $typeExtra = $type->extras()->create([
+            'codigo' => 'whatsapp',
             'nombre' => 'WhatsApp',
             'descripcion' => 'Configuracion del canal de WhatsApp',
             'is_required' => true,
@@ -69,6 +71,7 @@ class WebsiteExtrasTest extends TestCase
 
         $this->assertTrue($type->extras()->firstOrFail()->is($typeExtra));
         $this->assertSame($type->codigo, $typeExtra->website_type_code);
+        $this->assertSame('whatsapp', $typeExtra->codigo);
         $this->assertTrue($type->tenants()->firstOrFail()->is($tenant));
         $this->assertTrue($tenant->websiteType()->firstOrFail()->is($type));
         $this->assertSame($type->codigo, $tenant->website_type_code);
@@ -91,6 +94,7 @@ class WebsiteExtrasTest extends TestCase
             'nombre' => 'Tienda',
         ]);
         $typeExtra = $type->extras()->create([
+            'codigo' => 'whatsapp',
             'nombre' => 'WhatsApp',
             'descripcion' => 'Configuracion del canal de WhatsApp',
             'config_schema' => ['type' => 'object'],