feat: remove EventProductType references and related logic from catalog and fiesta futbol infantil components

2026-08-10 16:37:28 -03:00
parent 5bfc8b9f70
commit 69320c54d4
21 changed files with 90 additions and 79 deletions
--- a/app/Domains/Catalog/Enums/EventProductType.php
+++ b/app/Domains/Catalog/Enums/EventProductType.php
@@ -1,15 +0,0 @@
-<?php
-
-namespace App\Domains\Catalog\Enums;
-
-enum EventProductType: string
-{
-    case Entry = 'entrada';
-    case Product = 'producto';
-
-    /** @return list<string> */
-    public static function values(): array
-    {
-        return array_column(self::cases(), 'value');
-    }
-}
--- a/app/Domains/Catalog/Models/CatalogItem.php
+++ b/app/Domains/Catalog/Models/CatalogItem.php
@@ -4,7 +4,6 @@ namespace App\Domains\Catalog\Models;

 use App\Domains\Attachable\Models\Attachment;
 use App\Domains\Catalog\Enums\CatalogItemType;
-use App\Domains\Catalog\Enums\EventProductType;
 use App\Domains\Catalog\Enums\InventoryPolicy;
 use App\Domains\Catalog\Services\CatalogInventoryService;
 use App\Domains\Tenant\Models\Tenant;
@@ -20,7 +19,6 @@ use Illuminate\Support\Collection;

 #[Fillable([
    'tenant_code',
-    'event_product_type',
    'category_id',
    'brand_id',
    'inventory_id',
@@ -54,7 +52,6 @@ class CatalogItem extends Model
            'category_id' => 'integer',
            'brand_id' => 'integer',
            'inventory_id' => 'integer',
-            'event_product_type' => EventProductType::class,
            'type' => CatalogItemType::class,
            'precio' => 'decimal:2',
            'inventory_policy' => InventoryPolicy::class,
--- a/app/Domains/Catalog/Requests/StoreCatalogItemRequest.php
+++ b/app/Domains/Catalog/Requests/StoreCatalogItemRequest.php
@@ -3,7 +3,6 @@
 namespace App\Domains\Catalog\Requests;

 use App\Domains\Catalog\Enums\CatalogItemType;
-use App\Domains\Catalog\Enums\EventProductType;
 use App\Domains\Catalog\Enums\InventoryPolicy;
 use App\Domains\Shared\Rules\ImageOrBase64Rule;
 use Illuminate\Foundation\Http\FormRequest;
@@ -26,11 +25,6 @@ class StoreCatalogItemRequest extends FormRequest
        return [
            'tenant_code' => ['prohibited'],
            'type' => ['sometimes', Rule::enum(CatalogItemType::class)],
-            'event_product_type' => [
-                'sometimes',
-                'nullable',
-                Rule::enum(EventProductType::class),
-            ],
            'category_id' => [
                'sometimes',
                'nullable',
--- a/app/Domains/Catalog/Resources/CatalogItemDetailResource.php
+++ b/app/Domains/Catalog/Resources/CatalogItemDetailResource.php
@@ -24,7 +24,6 @@ class CatalogItemDetailResource extends JsonResource
        return [
            'id' => $this->id,
            'type' => $this->type->value,
-            'event_product_type' => $this->event_product_type?->value,
            'category_id' => $this->category_id,
            'brand_id' => $this->brand_id,
            'slug' => $this->slug,
--- a/app/Domains/Catalog/Resources/CatalogItemResource.php
+++ b/app/Domains/Catalog/Resources/CatalogItemResource.php
@@ -16,7 +16,6 @@ class CatalogItemResource extends JsonResource
        return [
            'id' => $this->id,
            'type' => $this->type->value,
-            'event_product_type' => $this->event_product_type?->value,
            'category_id' => $this->category_id,
            'brand_id' => $this->brand_id,
            'slug' => $this->slug,
--- a/app/Domains/Catalog/Services/CatalogService.php
+++ b/app/Domains/Catalog/Services/CatalogService.php
@@ -5,7 +5,6 @@ namespace App\Domains\Catalog\Services;
 use App\Domains\Attachable\Models\Attachment;
 use App\Domains\Attachable\Services\AttachmentService;
 use App\Domains\Catalog\Enums\CatalogItemType;
-use App\Domains\Catalog\Enums\EventProductType;
 use App\Domains\Catalog\Models\Attribute;
 use App\Domains\Catalog\Models\CatalogItem;
 use App\Domains\Catalog\Models\Category;
@@ -65,7 +64,6 @@ class CatalogService
                ]);
            }

-            $this->validateEventProductType($data);
            $this->validateUniqueVariantCombinations($variants, $attributeCodes);

            if ($type === CatalogItemType::Bundle) {
@@ -622,22 +620,6 @@ class CatalogService
        return $variant;
    }

-    /** @param array<string, mixed> $data */
-    private function validateEventProductType(array $data): void
-    {
-        $eventProductType = $data['event_product_type'] ?? null;
-
-        if ($eventProductType === null) {
-            return;
-        }
-
-        if (! in_array($eventProductType, EventProductType::values(), true)) {
-            throw ValidationException::withMessages([
-                'event_product_type' => [__('api.catalog.invalid_event_product_type')],
-            ]);
-        }
-    }
-
    /**
     * @param  array<int, array<string, mixed>>  $variants
     * @param  array<int, string>  $attributeCodes
--- a/app/Domains/FiestaFutbolInfantil/Requests/UpsertEntriesRequest.php
+++ b/app/Domains/FiestaFutbolInfantil/Requests/UpsertEntriesRequest.php
@@ -29,7 +29,11 @@ class UpsertEntriesRequest extends FormRequest
                Rule::exists('catalog_items', 'id')->where(
                    fn ($query) => $query
                        ->where('tenant_code', $tenantCode)
-                        ->where('event_product_type', 'entrada')
+                        ->whereIn('category_id', fn ($categoryQuery) => $categoryQuery
+                            ->select('id')
+                            ->from('categorias')
+                            ->where('tenant_code', $tenantCode)
+                            ->where('nombre', 'Entradas'))
                ),
            ],
            'entries.*.title' => ['required', 'string', 'max:255'],
--- a/app/Domains/FiestaFutbolInfantil/Requests/UpsertMerchandiseRequest.php
+++ b/app/Domains/FiestaFutbolInfantil/Requests/UpsertMerchandiseRequest.php
@@ -28,7 +28,11 @@ class UpsertMerchandiseRequest extends FormRequest
                Rule::exists('catalog_items', 'id')->where(
                    fn ($query) => $query
                        ->where('tenant_code', $tenantCode)
-                        ->where('event_product_type', 'producto')
+                        ->whereIn('category_id', fn ($categoryQuery) => $categoryQuery
+                            ->select('id')
+                            ->from('categorias')
+                            ->where('tenant_code', $tenantCode)
+                            ->where('nombre', 'Merchandising'))
                ),
            ],
            'items.*.title' => ['required', 'string', 'max:255'],
--- a/app/Domains/FiestaFutbolInfantil/Services/AccommodationService.php
+++ b/app/Domains/FiestaFutbolInfantil/Services/AccommodationService.php
@@ -2,7 +2,6 @@

 namespace App\Domains\FiestaFutbolInfantil\Services;

-use App\Domains\Catalog\Enums\EventProductType;
 use App\Domains\Catalog\Enums\InventoryPolicy;
 use App\Domains\Catalog\Models\Attribute;
 use App\Domains\Catalog\Models\AttributeOption;
@@ -135,7 +134,6 @@ class AccommodationService
        if ($accommodation !== null) {
            $accommodation->update([
                'category_id' => $category->id,
-                'event_product_type' => EventProductType::Product->value,
                'inventory_policy' => InventoryPolicy::Tracked->value,
                'has_tickets' => true,
            ]);
@@ -150,7 +148,6 @@ class AccommodationService
            'descripcion' => 'Alojamiento',
            'category_id' => $category->id,
            'precio' => collect($variants)->min('price') ?? 0,
-            'event_product_type' => EventProductType::Product->value,
            'inventory_policy' => InventoryPolicy::Tracked->value,
            'has_tickets' => true,
            'inventory_id' => null,
--- a/app/Domains/FiestaFutbolInfantil/Services/EntryService.php
+++ b/app/Domains/FiestaFutbolInfantil/Services/EntryService.php
@@ -2,7 +2,6 @@

 namespace App\Domains\FiestaFutbolInfantil\Services;

-use App\Domains\Catalog\Enums\EventProductType;
 use App\Domains\Catalog\Enums\InventoryPolicy;
 use App\Domains\Catalog\Models\CatalogItem;
 use App\Domains\Catalog\Models\Category;
@@ -24,7 +23,7 @@ class EntryService
    {
        return CatalogItem::query()
            ->where('tenant_code', $tenant->codigo)
-            ->where('event_product_type', EventProductType::Entry->value)
+            ->whereHas('category', fn ($query) => $query->where('nombre', 'Entradas'))
            ->with([
                'variants.inventory',
                'variants.eventDate',
@@ -62,7 +61,6 @@ class EntryService
                    'descripcion' => $entry['description'] ?? null,
                    'category_id' => $category->id,
                    'precio' => $entry['price'],
-                    'event_product_type' => EventProductType::Entry->value,
                    'has_tickets' => true,
                    'inventory_policy' => InventoryPolicy::Tracked->value,
                    'attribute_codes' => ['event_date'],
@@ -81,7 +79,6 @@ class EntryService
        $entry = CatalogItem::query()
            ->whereKey($entryId)
            ->where('tenant_code', $tenant->codigo)
-            ->where('event_product_type', EventProductType::Entry->value)
            ->whereHas('category', fn ($query) => $query->where('nombre', 'Entradas'))
            ->firstOrFail();

@@ -94,7 +91,7 @@ class EntryService
        $catalogItem = CatalogItem::query()
            ->whereKey($entry['id'])
            ->where('tenant_code', $tenant->codigo)
-            ->where('event_product_type', EventProductType::Entry->value)
+            ->whereHas('category', fn ($query) => $query->where('nombre', 'Entradas'))
            ->lockForUpdate()
            ->firstOrFail();

--- a/app/Domains/FiestaFutbolInfantil/Services/FoodService.php
+++ b/app/Domains/FiestaFutbolInfantil/Services/FoodService.php
@@ -2,7 +2,6 @@

 namespace App\Domains\FiestaFutbolInfantil\Services;

-use App\Domains\Catalog\Enums\EventProductType;
 use App\Domains\Catalog\Enums\InventoryPolicy;
 use App\Domains\Catalog\Models\Attribute;
 use App\Domains\Catalog\Models\AttributeOption;
@@ -146,7 +145,6 @@ class FoodService
        if ($food !== null) {
            $food->update([
                'category_id' => $category->id,
-                'event_product_type' => EventProductType::Product->value,
                'inventory_policy' => InventoryPolicy::Tracked->value,
                'has_tickets' => true,
            ]);
@@ -161,7 +159,6 @@ class FoodService
            'descripcion' => 'Comida',
            'category_id' => $category->id,
            'precio' => collect($variants)->min('price') ?? 0,
-            'event_product_type' => EventProductType::Product->value,
            'inventory_policy' => InventoryPolicy::Tracked->value,
            'has_tickets' => true,
            'inventory_id' => null,
--- a/app/Domains/FiestaFutbolInfantil/Services/MerchandiseService.php
+++ b/app/Domains/FiestaFutbolInfantil/Services/MerchandiseService.php
@@ -2,7 +2,6 @@

 namespace App\Domains\FiestaFutbolInfantil\Services;

-use App\Domains\Catalog\Enums\EventProductType;
 use App\Domains\Catalog\Enums\InventoryPolicy;
 use App\Domains\Catalog\Models\Attribute;
 use App\Domains\Catalog\Models\AttributeOption;
@@ -29,7 +28,6 @@ class MerchandiseService
    {
        return CatalogItem::query()
            ->where('tenant_code', $tenant->codigo)
-            ->where('event_product_type', EventProductType::Product->value)
            ->whereHas('category', fn ($query) => $query->where('nombre', 'Merchandising'))
            ->with([
                'itemAttributes.attribute.options',
@@ -74,7 +72,6 @@ class MerchandiseService
                    'descripcion' => $data['description'] ?? null,
                    'category_id' => $category->id,
                    'max_units_per_user' => (int) $data['max_units_per_user'],
-                    'event_product_type' => EventProductType::Product->value,
                    'inventory_policy' => InventoryPolicy::Tracked->value,
                    'has_tickets' => true,
                ]);
@@ -129,7 +126,6 @@ class MerchandiseService
            ->whereKey($merchandiseId)
            ->whereHas('catalogItem', fn ($query) => $query
                ->where('tenant_code', $tenant->codigo)
-                ->where('event_product_type', EventProductType::Product->value)
                ->whereHas('category', fn ($categoryQuery) => $categoryQuery
                    ->where('nombre', 'Merchandising')))
            ->firstOrFail();
@@ -170,7 +166,6 @@ class MerchandiseService
            ->whereKey($itemId)
            ->where('tenant_code', $tenant->codigo)
            ->where('category_id', $category->id)
-            ->where('event_product_type', EventProductType::Product->value)
            ->lockForUpdate()
            ->first();

@@ -201,7 +196,6 @@ class MerchandiseService
            'category_id' => $category->id,
            'precio' => collect($data['variants'])->min('price') ?? 0,
            'max_units_per_user' => (int) $data['max_units_per_user'],
-            'event_product_type' => EventProductType::Product->value,
            'inventory_policy' => InventoryPolicy::Tracked->value,
            'has_tickets' => true,
            'inventory_id' => null,