From 64e965aff7bbbab5ab4b098bac7e3118612c59f6 Mon Sep 17 00:00:00 2001 From: ncoronel Date: Wed, 9 Sep 2026 08:47:10 -0300 Subject: [PATCH] feat(scanner): update scan attempt result labels for consistency --- .../Ticket/Resources/Scanner/ScanAttemptResource.php | 9 ++------- tests/Feature/Ticket/ScannerTicketControllerTest.php | 4 ++-- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/app/Domains/Ticket/Resources/Scanner/ScanAttemptResource.php b/app/Domains/Ticket/Resources/Scanner/ScanAttemptResource.php index 87f7a2a..0d777b6 100644 --- a/app/Domains/Ticket/Resources/Scanner/ScanAttemptResource.php +++ b/app/Domains/Ticket/Resources/Scanner/ScanAttemptResource.php @@ -23,15 +23,10 @@ class ScanAttemptResource extends JsonResource 'resolved_at' => $this->resolved_at, 'result' => $this->result->value, 'result_label' => match ($this->result) { - ScanAttemptResult::Processing => 'Procesando', ScanAttemptResult::Accepted => 'Verificado', - ScanAttemptResult::InvalidQr => 'QR inválido', - ScanAttemptResult::TicketNotFound => 'Ticket inexistente', - ScanAttemptResult::CategoryForbidden => 'Categoría no permitida', - ScanAttemptResult::AlreadyScanned => 'Ya escaneado', + ScanAttemptResult::AlreadyScanned => 'Usado', ScanAttemptResult::Expired => 'Vencido', - ScanAttemptResult::NotValid => 'No válido', - ScanAttemptResult::UnexpectedError => 'Error', + default => 'Error', }, 'result_detail_label' => match ($this->result) { ScanAttemptResult::Processing => 'Error', diff --git a/tests/Feature/Ticket/ScannerTicketControllerTest.php b/tests/Feature/Ticket/ScannerTicketControllerTest.php index dd2b014..38d7754 100644 --- a/tests/Feature/Ticket/ScannerTicketControllerTest.php +++ b/tests/Feature/Ticket/ScannerTicketControllerTest.php @@ -190,7 +190,7 @@ class ScannerTicketControllerTest extends TestCase $this->getJson("/api/v1/scanner/attempts/{$scanAttempt->id}") ->assertOk() ->assertJsonPath('data.scan_attempt.id', $scanAttempt->id) - ->assertJsonPath('data.scan_attempt.result_label', 'Ticket inexistente') + ->assertJsonPath('data.scan_attempt.result_label', 'Error') ->assertJsonPath('data.scan_attempt.result_detail_label', 'Error') ->assertJsonPath('data.ticket', null) ->assertJsonPath('data.client', null); @@ -205,7 +205,7 @@ class ScannerTicketControllerTest extends TestCase $this->getJson("/api/v1/scanner/attempts/{$scanAttempt->id}") ->assertOk() - ->assertJsonPath('data.scan_attempt.result_label', 'QR inválido') + ->assertJsonPath('data.scan_attempt.result_label', 'Error') ->assertJsonPath('data.scan_attempt.result_detail_label', 'QR no pertenece al evento'); }