Refactor ticket validity handling and improve tests

- Updated tests for Accommodation, Entry, Food, Merchandise, and Sale controllers to use soft deletes for variants and ensure proper inventory counts.
- Enhanced ticket generation logic to resolve validity from soft-deleted catalog sources.
- Introduced a new TicketValidityResolver service to manage ticket validity based on event dates and variant definitions.
- Removed unnecessary database assertions and improved the clarity of validity checks in tests.
- Added comprehensive tests for the new TicketValidityResolver service, ensuring correct handling of event dates and multi-select options.
- Cleaned up unused code and assertions in existing tests for better maintainability.

app/Domains/Catalog/Resources/CatalogFeaturedItemResource.php

@@ -7,7 +7,6 @@ use App\Domains\Catalog\Enums\ProductLayout;
 use App\Domains\Catalog\Models\CatalogItem;
 use App\Domains\Catalog\Models\FeaturedGroup;
 use App\Domains\Catalog\Models\Variant;
-use App\Domains\Ticket\Resources\ValidityTimeResource;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;
 
@@ -31,9 +30,6 @@ class CatalogFeaturedItemResource extends JsonResource
             'nombre' => $catalogItem->nombre,
             'descripcion' => $catalogItem->descripcion,
             'precio' => $catalogItem->precio,
-            'ticket_generation_policy' => $catalogItem->ticket_generation_policy->value,
-            'validity_time_id' => $catalogItem->validity_time_id,
-            'validity_time' => ValidityTimeResource::make($catalogItem->validityTime),
             'stock_tecnico' => $catalogItem->availableStock(),
             'variants' => $catalogItem->visibleVariants()
                 ->map(fn (Variant $variant): array => [
@@ -67,9 +63,6 @@ class CatalogFeaturedItemResource extends JsonResource
             'type' => $catalogItem->type->value,
             'nombre' => $catalogItem->nombre,
             'precio' => $catalogItem->precio,
-            'ticket_generation_policy' => $catalogItem->ticket_generation_policy->value,
-            'validity_time_id' => $catalogItem->validity_time_id,
-            'validity_time' => ValidityTimeResource::make($catalogItem->validityTime),
             'image' => $this->firstImageUrl($catalogItem),
         ];
     }

app/Domains/Catalog/Resources/CatalogItemDetailResource.php

@@ -36,11 +36,6 @@ class CatalogItemDetailResource extends JsonResource
             'inventory_subject' => $this->inventory_subject->value,
             'max_units_per_user' => $this->max_units_per_user,
             'has_tickets' => $this->has_tickets,
-            'ticket_generation_policy' => $this->ticket_generation_policy->value,
-            'validity_time_id' => $this->validity_time_id,
-            'validity_time' => $this->validityTime === null
-                ? null
-                : ValidityTimeResource::make($this->validityTime),
             'attributes' => $this->attributesData(),
             'stock_tecnico' => $this->when(
                 $selectedVariant === null,

app/Domains/Catalog/Resources/CatalogItemResource.php

@@ -3,7 +3,6 @@
 namespace App\Domains\Catalog\Resources;
 
 use App\Domains\Catalog\Models\CatalogItem;
-use App\Domains\Ticket\Resources\ValidityTimeResource;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;
 
@@ -26,12 +25,6 @@ class CatalogItemResource extends JsonResource
             'inventory_subject' => $this->inventory_subject->value,
             'max_units_per_user' => $this->max_units_per_user,
             'has_tickets' => $this->has_tickets,
-            'ticket_generation_policy' => $this->ticket_generation_policy->value,
-            'validity_time_id' => $this->validity_time_id,
-            'validity_time' => $this->whenLoaded(
-                'validityTime',
-                fn () => ValidityTimeResource::make($this->validityTime),
-            ),
             'real_stock' => $this->whenLoaded('inventory', fn () => $this->inventory?->real_stock),
             'images' => $this->whenLoaded('attachments', fn () => $this->attachments
                 ->map(fn ($attachment) => $attachment->getTemporaryUrl(1440))

app/Domains/Catalog/Resources/CatalogSearchItemResource.php

@@ -5,7 +5,6 @@ namespace App\Domains\Catalog\Resources;
 use App\Domains\Catalog\Enums\InventoryPolicy;
 use App\Domains\Catalog\Models\CatalogItem;
 use App\Domains\Catalog\Models\Variant;
-use App\Domains\Ticket\Resources\ValidityTimeResource;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\Json\JsonResource;
 
@@ -26,9 +25,6 @@ class CatalogSearchItemResource extends JsonResource
             'nombre' => $this->nombre,
             'descripcion' => $this->descripcion,
             'precio' => $this->precio,
-            'ticket_generation_policy' => $this->ticket_generation_policy->value,
-            'validity_time_id' => $this->validity_time_id,
-            'validity_time' => ValidityTimeResource::make($this->validityTime),
             'image' => $attachment?->getTemporaryUrl(1440),
             'stock_tecnico' => $this->availableStock(),
             'variants' => $this->visibleVariants()