Squashed commit of the following:

commit cd99a6489b Merge: ebcbbb1 e63a036 Author: ncoronel <ncoronel@quo.ar> Date: Wed Aug 26 10:12:44 2026 -0300 Merge branch 'fix/simplify_stock_reservations' of https://gitea.quo.ar/tbianchini/shopit-back into fix/simplify_stock_reservations commit ebcbbb1774 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:33:39 2026 -0300 fix(cart): reconcile expired cart mutations commit 3dd378ed06 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:15 2026 -0300 docs(stock): describe associated entity expiration commit 4f705175bd Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:14 2026 -0300 test(stock): cover propagated reservation expiration commit 82570fe941 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:09:52 2026 -0300 refactor(stock): propagate reservation expiration commit d2a2b323e0 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 docs(stock): document terminal reservation recovery commit ec67623b7b Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 test(stock): cover terminal reservation lifecycle commit f6f138e180 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:41 2026 -0300 refactor(stock): make expired reservations terminal commit d612b7a118 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:30 2026 -0300 docs(stock): describe unified expiration ownership commit 49f42d4507 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:23 2026 -0300 test(stock): cover authoritative reservation expiration commit 1881cc1d4b Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:17 2026 -0300 refactor(stock): make reservation expiration authoritative commit 00ec37d8a0 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:34 2026 -0300 docs(stock): document centralized reservation flow commit d9f374c718 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:29 2026 -0300 test(stock): cover aggregate reservation lifecycle commit bbfdf8f342 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:23 2026 -0300 refactor(stock): centralize reservation aggregate commit 8a0f29bdae Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:33:39 2026 -0300 fix(cart): reconcile expired cart mutations commit 198ed400a9 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:15 2026 -0300 docs(stock): describe associated entity expiration commit 23d83166e6 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:14 2026 -0300 test(stock): cover propagated reservation expiration commit cb090402d0 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:09:52 2026 -0300 refactor(stock): propagate reservation expiration commit c120b6f7c0 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 docs(stock): document terminal reservation recovery commit 1106fa28b4 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 test(stock): cover terminal reservation lifecycle commit 896fb81bcf Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:41 2026 -0300 refactor(stock): make expired reservations terminal commit 8545fbc645 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:30 2026 -0300 docs(stock): describe unified expiration ownership commit dd6dcb708a Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:23 2026 -0300 test(stock): cover authoritative reservation expiration commit 624b246ff5 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:17 2026 -0300 refactor(stock): make reservation expiration authoritative commit 007b95b904 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:34 2026 -0300 docs(stock): document centralized reservation flow commit 0b3c8c93be Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:29 2026 -0300 test(stock): cover aggregate reservation lifecycle commit ede718e448 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:23 2026 -0300 refactor(stock): centralize reservation aggregate commit e63a03601a Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:33:39 2026 -0300 fix(cart): reconcile expired cart mutations commit 389373ad8c Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:15 2026 -0300 docs(stock): describe associated entity expiration commit ace02a3133 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:10:14 2026 -0300 test(stock): cover propagated reservation expiration commit d69a6210f6 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 16:09:52 2026 -0300 refactor(stock): propagate reservation expiration commit 3c0b43fea3 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 docs(stock): document terminal reservation recovery commit 9b0008626b Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:47 2026 -0300 test(stock): cover terminal reservation lifecycle commit 61861e331a Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:58:41 2026 -0300 refactor(stock): make expired reservations terminal commit 2cc9d7dd97 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:30 2026 -0300 docs(stock): describe unified expiration ownership commit f982bcead1 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:23 2026 -0300 test(stock): cover authoritative reservation expiration commit 7a85e1731d Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:28:17 2026 -0300 refactor(stock): make reservation expiration authoritative commit 6db99e775a Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:34 2026 -0300 docs(stock): document centralized reservation flow commit e5f7ba3615 Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:29 2026 -0300 test(stock): cover aggregate reservation lifecycle commit 24bfef431b Author: ncoronel <ncoronel@quo.ar> Date: Tue Aug 25 15:05:23 2026 -0300 refactor(stock): centralize reservation aggregate
2026-08-26 10:30:16 -03:00
parent d0424c5589
commit 414df97e9d
40 changed files with 1839 additions and 764 deletions
--- a/tests/Unit/Catalog/ExpireStockReservationsServiceTest.php
+++ b/tests/Unit/Catalog/ExpireStockReservationsServiceTest.php
@@ -2,77 +2,102 @@

 namespace Tests\Unit\Catalog;

-use App\Domains\Cart\Services\ExpireCartReservationsService;
+use App\Domains\Catalog\Models\Inventory;
+use App\Domains\Catalog\Models\StockReservation;
+use App\Domains\Catalog\Models\StockReservationLine;
 use App\Domains\Catalog\Services\ExpireStockReservationsService;
-use App\Domains\Purchase\Services\CheckoutService;
-use Illuminate\Support\Facades\Log;
-use Psr\Log\LoggerInterface;
+use App\Domains\Catalog\Services\StockReservationService;
+use App\Domains\Purchase\Services\Checkout\ReleaseCheckoutService;
+use Illuminate\Foundation\Testing\RefreshDatabase;
 use RuntimeException;
 use Tests\TestCase;

 class ExpireStockReservationsServiceTest extends TestCase
 {
-    public function test_it_expires_purchases_before_abandoned_cart_items(): void
+    use RefreshDatabase;
+
+    public function test_it_expires_an_orphan_reservation_and_releases_its_inventory(): void
    {
-        $checkout = \Mockery::mock(CheckoutService::class);
-        $checkout->shouldReceive('expireOverduePurchases')
-            ->once()
-            ->ordered()
-            ->andReturn(2);
+        $inventory = Inventory::query()->create([
+            'real_stock' => 10,
+            'reserved_stock' => 2,
+        ]);
+        $reservation = StockReservation::query()->create([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinute(),
+        ]);
+        StockReservationLine::query()->create([
+            'stock_reservation_id' => $reservation->id,
+            'inventory_id' => $inventory->id,
+            'quantity' => 2,
+            'tracks_inventory' => true,
+        ]);

-        $carts = \Mockery::mock(ExpireCartReservationsService::class);
-        $carts->shouldReceive('expireOverdue')
-            ->once()
-            ->ordered()
-            ->andReturn(3);
-
-        $logger = \Mockery::mock(LoggerInterface::class);
-        Log::shouldReceive('channel')
-            ->once()
-            ->with('commands')
-            ->andReturn($logger);
-        $logger->shouldReceive('info')
-            ->once()
-            ->with('Stock reservation cleanup completed.', [
-                'command' => 'reservations:expire',
-                'expired_purchases' => 2,
-                'expired_cart_items' => 3,
-                'total_expired' => 5,
-            ]);
-
-        $result = (new ExpireStockReservationsService($checkout, $carts))->expireOverdue();
+        $result = app(ExpireStockReservationsService::class)->expireOverdue();

        $this->assertSame([
-            'purchases' => 2,
-            'cart_items' => 3,
+            'purchases' => 0,
+            'cart_reservations' => 0,
+            'orphan_reservations' => 1,
+            'failed' => 0,
        ], $result);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $reservation->id,
+            'status' => StockReservation::STATUS_EXPIRED,
+            'expires_at' => null,
+        ]);
+        $this->assertDatabaseHas('inventories', [
+            'id' => $inventory->id,
+            'reserved_stock' => 0,
+        ]);
    }

-    public function test_it_logs_failed_cleanup_attempts_and_rethrows_the_error(): void
+    public function test_one_failed_reservation_does_not_stop_the_remaining_batch(): void
    {
-        $exception = new RuntimeException('Unable to clean carts.');
-        $checkout = \Mockery::mock(CheckoutService::class);
-        $checkout->shouldReceive('expireOverduePurchases')->once()->andReturn(2);
+        $first = StockReservation::query()->create([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinutes(2),
+        ]);
+        $second = StockReservation::query()->create([
+            'status' => StockReservation::STATUS_ACTIVE,
+            'expires_at' => now()->subMinute(),
+        ]);

-        $carts = \Mockery::mock(ExpireCartReservationsService::class);
-        $carts->shouldReceive('expireOverdue')->once()->andThrow($exception);
+        $reservations = \Mockery::mock(StockReservationService::class);
+        $reservations->shouldReceive('expire')
+            ->twice()
+            ->andReturnUsing(function (StockReservation $reservation) use ($first): void {
+                if ($reservation->is($first)) {
+                    throw new RuntimeException('Broken reservation.');
+                }

-        $logger = \Mockery::mock(LoggerInterface::class);
-        Log::shouldReceive('channel')
-            ->once()
-            ->with('commands')
-            ->andReturn($logger);
-        $logger->shouldReceive('error')
-            ->once()
-            ->with('Stock reservation cleanup failed.', [
-                'command' => 'reservations:expire',
-                'expired_purchases' => 2,
-                'expired_cart_items' => null,
-                'exception' => $exception,
-            ]);
+                $reservation->update([
+                    'status' => StockReservation::STATUS_EXPIRED,
+                    'expires_at' => null,
+                    'expired_at' => now(),
+                ]);
+            });

-        $this->expectExceptionObject($exception);
+        $service = new ExpireStockReservationsService(
+            \Mockery::mock(ReleaseCheckoutService::class),
+            $reservations,
+        );

-        (new ExpireStockReservationsService($checkout, $carts))->expireOverdue();
+        $result = $service->expireOverdue();
+
+        $this->assertSame([
+            'purchases' => 0,
+            'cart_reservations' => 0,
+            'orphan_reservations' => 1,
+            'failed' => 1,
+        ], $result);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $first->id,
+            'status' => StockReservation::STATUS_ACTIVE,
+        ]);
+        $this->assertDatabaseHas('stock_reservations', [
+            'id' => $second->id,
+            'status' => StockReservation::STATUS_EXPIRED,
+        ]);
    }
 }