refactor(cart): own checkout item editing

app/Domains/Purchase/Controllers/PurchaseController.php

@@ -7,7 +7,6 @@ use App\Domains\Purchase\Models\Purchase;
 use App\Domains\Purchase\Requests\PaymentIntentRequest;
 use App\Domains\Purchase\Requests\StartCheckoutRequest;
 use App\Domains\Purchase\Requests\UpdatePurchaseCustomerRequest;
-use App\Domains\Purchase\Requests\UpdatePurchaseItemQuantityRequest;
 use App\Domains\Purchase\Resources\PurchaseResource;
 use App\Domains\Purchase\Services\CheckoutService;
 use App\Domains\Tenant\Models\Tenant;
@@ -83,37 +82,6 @@ class PurchaseController extends Controller
         );
     }
 
-    public function updateItemQuantity(
-        UpdatePurchaseItemQuantityRequest $request,
-        Tenant $tenant,
-        Purchase $compra,
-        int $item,
-        CheckoutService $checkoutService,
-    ): PurchaseResource {
-        $compra = $this->resolveScopedPurchase($tenant, $request->user()->id, $compra);
-
-        return PurchaseResource::make(
-            $checkoutService->updateItemQuantity(
-                $compra,
-                $item,
-                (int) $request->validated('quantity'),
-            ),
-        );
-    }
-
-    public function prepareItemEditing(
-        Request $request,
-        Tenant $tenant,
-        Purchase $compra,
-        CheckoutService $checkoutService,
-    ): PurchaseResource {
-        $compra = $this->resolveScopedPurchase($tenant, $request->user()->id, $compra);
-
-        return PurchaseResource::make(
-            $checkoutService->prepareItemEditing($compra),
-        );
-    }
-
     public function paymentIntent(
         PaymentIntentRequest $request,
         Tenant $tenant,

app/Domains/Purchase/Requests/UpdatePurchaseItemQuantityRequest.php

@@ -1,23 +0,0 @@
-<?php
-
-namespace App\Domains\Purchase\Requests;
-
-use Illuminate\Foundation\Http\FormRequest;
-
-class UpdatePurchaseItemQuantityRequest extends FormRequest
-{
-    public function authorize(): bool
-    {
-        return $this->user() !== null;
-    }
-
-    /**
-     * @return array<string, mixed>
-     */
-    public function rules(): array
-    {
-        return [
-            'quantity' => ['required', 'integer', 'min:1', 'max:100'],
-        ];
-    }
-}

app/Domains/Purchase/Services/Checkout/EditCheckoutService.php

@@ -2,23 +2,12 @@
 
 namespace App\Domains\Purchase\Services\Checkout;
 
-use App\Domains\Cart\Models\CartItem;
-use App\Domains\Catalog\Models\Variant;
-use App\Domains\Catalog\Services\StockReservationService;
 use App\Domains\Purchase\Models\Purchase;
-use App\Domains\Purchase\Services\UserPurchaseLimitService;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Validation\ValidationException;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 class EditCheckoutService
 {
-    public function __construct(
-        private readonly StockReservationService $reservations,
-        private readonly UserPurchaseLimitService $purchaseLimits,
-        private readonly CatalogSelectionResolver $selections,
-    ) {}
-
     /** @param array<string, string> $customerData */
     public function updateCustomer(Purchase $purchase, array $customerData): Purchase
     {
@@ -32,112 +21,6 @@ class EditCheckoutService
         });
     }
 
-    public function updateItemQuantity(
-        Purchase $purchase,
-        int $itemId,
-        int $quantity,
-    ): Purchase {
-        return DB::transaction(function () use ($purchase, $itemId, $quantity): Purchase {
-            $purchase = $this->lockPurchase($purchase);
-
-            if ($purchase->status !== Purchase::STATUS_CREATED || $this->hasExpired($purchase)) {
-                throw ValidationException::withMessages([
-                    'purchase' => __('api.purchase.not_editable'),
-                ]);
-            }
-
-            return $this->updateCartItemQuantity($purchase, $itemId, $quantity);
-        });
-    }
-
-    public function prepareItemEditing(Purchase $purchase): Purchase
-    {
-        return DB::transaction(function () use ($purchase): Purchase {
-            $purchase = $this->lockPurchase($purchase);
-            $this->assertEditable($purchase);
-
-            $purchase->telepagosQr()->delete();
-            $purchase->update([
-                'status' => Purchase::STATUS_CREATED,
-                'payment_method' => null,
-                'transfer_payer_dni' => null,
-                'expires_at' => now()->addMinutes(
-                    max(1, (int) config('purchase.checkout_expiration_minutes', 30)),
-                ),
-            ]);
-
-            $this->attachCartReservations($purchase);
-
-            return $this->loadPurchase($purchase);
-        });
-    }
-
-    private function updateCartItemQuantity(Purchase $purchase, int $itemId, int $quantity): Purchase
-    {
-        $cart = $purchase->cart()->lockForUpdate()->first();
-        if ($cart === null || $cart->status !== 'checkout') {
-            throw new NotFoundHttpException('Checkout cart not found.');
-        }
-
-        /** @var CartItem|null $cartItem */
-        $cartItem = $cart->items()->whereKey($itemId)->lockForUpdate()->first();
-        if ($cartItem === null) {
-            throw new NotFoundHttpException('Checkout item not found.');
-        }
-
-        $selection = $this->selections->resolve(
-            $purchase->tenant,
-            (int) $cartItem->catalog_item_id,
-            $cartItem->variant_id === null ? null : (int) $cartItem->variant_id,
-            'item',
-        );
-        $difference = $quantity - (int) $cartItem->cantidad;
-
-        try {
-            if ($difference > 0) {
-                $otherItemQuantity = (int) $cart->items()
-                    ->where('catalog_item_id', $cartItem->catalog_item_id)
-                    ->whereKeyNot($cartItem->getKey())
-                    ->sum('cantidad');
-                $catalogItem = $selection instanceof Variant ? $selection->catalogItem : $selection;
-                $this->purchaseLimits->assertCanPurchase(
-                    $catalogItem,
-                    (int) $purchase->user_id,
-                    $otherItemQuantity + $quantity,
-                    $purchase->getKey(),
-                );
-                $this->reservations->reserve($cartItem, $selection, $difference);
-            } elseif ($difference < 0) {
-                $this->reservations->release($cartItem, $selection, abs($difference));
-            }
-        } catch (\InvalidArgumentException) {
-            throw ValidationException::withMessages([
-                'quantity' => __('api.purchase.insufficient_stock'),
-            ]);
-        }
-
-        $cartItem->update(['cantidad' => $quantity]);
-        $cart->unsetRelation('items');
-        $purchase->setRelation('cart', $cart);
-        $purchase->update(['total' => $cart->getTotalAmount()]);
-
-        return $this->loadPurchase($purchase);
-    }
-
-    private function attachCartReservations(Purchase $purchase): void
-    {
-        $cartItems = $purchase->cart?->items()->lockForUpdate()->get() ?? collect();
-        foreach ($cartItems as $cartItem) {
-            $selection = $this->selections->resolve(
-                $purchase->tenant,
-                (int) $cartItem->catalog_item_id,
-                $cartItem->variant_id === null ? null : (int) $cartItem->variant_id,
-                'item',
-            );
-            $this->reservations->attachToPurchase($cartItem, $selection, $purchase);
-        }
-    }
-
     private function assertEditable(Purchase $purchase): void
     {
         if (

app/Domains/Purchase/Services/CheckoutService.php

@@ -48,19 +48,6 @@ class CheckoutService
         return $this->editor->updateCustomer($purchase, $customerData);
     }
 
-    public function updateItemQuantity(
-        Purchase $purchase,
-        int $itemId,
-        int $quantity,
-    ): Purchase {
-        return $this->editor->updateItemQuantity($purchase, $itemId, $quantity);
-    }
-
-    public function prepareItemEditing(Purchase $purchase): Purchase
-    {
-        return $this->editor->prepareItemEditing($purchase);
-    }
-
     public function confirmPurchase(Purchase $purchase): void
     {
         $this->completer->confirm($purchase);

app/Domains/Purchase/documentacion/README.md

@@ -16,14 +16,16 @@ Implementa el ciclo de compra y checkout: crea la cabecera de compra desde un ca
 `CheckoutService` es la fachada estable. Delega en:
 
 - `StartCheckoutService`: inicia la compra desde el carrito o crea un carrito técnico para compra directa, sin crear todavía `PurchaseItem`.
-- `EditCheckoutService`: modifica cliente o cantidades del carrito de checkout antes del cierre.
+- `EditCheckoutService`: modifica los datos del comprador antes del cierre.
 - `CompleteCheckoutService`: completa, envía a revisión o materializa los `PurchaseItem` al confirmar el pago.
 - `ReleaseCheckoutService`: cancela, vence y procesa vencimientos pendientes.
-- `SourceCartService`: sincroniza, restaura o finaliza el carrito fuente.
+- `SourceCartService`: restaura o finaliza el carrito fuente.
 - `CatalogSelectionResolver` y `PurchaseItemSnapshotFactory`: resuelven selecciones y generan snapshots.
 
 Durante `created` y `pending_payment`, `PurchaseResource` publica las líneas del carrito con `items_source=cart`; una compra materializada publica `items_source=purchase`. Los datos descriptivos y económicos del checkout se resuelven siempre desde el catálogo vigente.
 
+Las cantidades y variantes se editan mediante el dominio Cart. Los endpoints autenticados `POST /checkout-carts/{cart}/edit` y `PATCH /checkout-carts/{cart}/items/{cartItem}` validan que el carrito pertenezca al usuario y a una compra editable; Purchase no expone operaciones sobre líneas antes de la confirmación.
+
 `UserPurchaseLimitService` controla límites de compra y `CheckoutService` conserva el punto de entrada para controladores e integraciones.
 
 ## Endpoints

app/Domains/Purchase/routes/api.php

@@ -7,8 +7,6 @@ Route::prefix('tenants/{tenant:codigo}')->middleware('auth:sanctum')->group(func
     Route::get('compras', [PurchaseController::class, 'index']);
     Route::post('compras/start-checkout', [PurchaseController::class, 'startCheckout']);
     Route::get('compras/{compra}', [PurchaseController::class, 'show']);
-    Route::post('compras/{compra}/edit-items', [PurchaseController::class, 'prepareItemEditing']);
-    Route::patch('compras/{compra}/items/{item}', [PurchaseController::class, 'updateItemQuantity']);
     Route::patch('compras/{compra}/customer-data', [PurchaseController::class, 'updateCustomerData']);
     Route::post('compras/{compra}/payment-intent', [PurchaseController::class, 'paymentIntent']);
     Route::post('compras/{compra}/complete', [PurchaseController::class, 'complete']);