Merge branch 'fix/website_types_favicons' into dev

tests/Feature/Migrations/SetWebsiteTypeFaviconTest.php

@@ -0,0 +1,61 @@
+<?php
+
+namespace Tests\Feature\Migrations;
+
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Storage;
+use Tests\TestCase;
+
+class SetWebsiteTypeFaviconTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_it_uploads_one_favicon_and_shares_the_attachment_between_website_types(): void
+    {
+        Storage::fake('s3');
+
+        DB::table('website_type')->insert([
+            [
+                'codigo' => 'shopit',
+                'nombre' => 'ShopIt',
+                'created_at' => now(),
+                'updated_at' => now(),
+            ],
+            [
+                'codigo' => 'onticket',
+                'nombre' => 'OnTicket',
+                'created_at' => now(),
+                'updated_at' => now(),
+            ],
+        ]);
+
+        $migration = require database_path(
+            'migrations/2026_08_26_000000_set_website_type_favicon.php'
+        );
+
+        $migration->up();
+        $migration->up();
+
+        $faviconIds = DB::table('website_type')
+            ->whereIn('codigo', ['shopit', 'onticket'])
+            ->pluck('favicon_id');
+
+        $this->assertCount(2, $faviconIds);
+        $this->assertNotNull($faviconIds->first());
+        $this->assertSame(1, $faviconIds->unique()->count());
+
+        $attachment = DB::table('attachments')->where('id', $faviconIds->first())->first();
+
+        $this->assertNotNull($attachment);
+        $this->assertSame('onticket_favicon.svg', $attachment->filename);
+        $this->assertSame('image/svg+xml', $attachment->mime_type);
+        $this->assertSame('svg', $attachment->extension);
+        $this->assertSame(1, DB::table('attachments')->where('filename', 'onticket_favicon.svg')->count());
+        Storage::disk('s3')->assertExists($attachment->path);
+        $this->assertSame(
+            file_get_contents(public_path('images/website_types/onticket_favicon.svg')),
+            Storage::disk('s3')->get($attachment->path),
+        );
+    }
+}

tests/Feature/Seeders/WebsiteTypeSeederTest.php

@@ -21,7 +21,7 @@ class WebsiteTypeSeederTest extends TestCase
         $this->seed(WebsiteTypeSeeder::class);
 
         $this->assertSame(2, WebsiteType::query()->count());
-        $this->assertSame(4, Attachment::query()->count());
+        $this->assertSame(5, Attachment::query()->count());
 
         $expectedPresentation = [
             'primary_color' => '#FF7006',
@@ -49,6 +49,8 @@ class WebsiteTypeSeederTest extends TestCase
         Storage::disk('s3')->assertExists($shopIt->siteLogo->path);
         $this->assertSame('onticket_footer_logo.png', $shopIt->footerLogo->filename);
         Storage::disk('s3')->assertExists($shopIt->footerLogo->path);
+        $this->assertSame('onticket_favicon.svg', $shopIt->favicon->filename);
+        Storage::disk('s3')->assertExists($shopIt->favicon->path);
         $this->assertSame(['carousel'], $shopIt->extras->pluck('codigo')->all());
         $this->assertSame('Carrusel principal', $shopIt->extras->sole()->nombre);
         $this->assertSame([
@@ -79,6 +81,8 @@ class WebsiteTypeSeederTest extends TestCase
         Storage::disk('s3')->assertExists($onTicket->footerLogo->path);
         $this->assertNotSame($shopIt->site_logo, $onTicket->site_logo);
         $this->assertNotSame($shopIt->footer_logo, $onTicket->footer_logo);
+        $this->assertSame($shopIt->favicon_id, $onTicket->favicon_id);
+        $this->assertSame('onticket_favicon.svg', $onTicket->favicon->filename);
         $this->assertEqualsCanonicalizing(
             ['heroConfig', 'eventConfig', 'additionalInfoConfig'],
             $onTicket->extras->pluck('codigo')->all(),

tests/Feature/Tenant/BootstrapAdminAppControllerTest.php

@@ -14,6 +14,7 @@ class BootstrapAdminAppControllerTest extends TestCase
     public function test_it_publicly_bootstraps_the_admin_app_by_domain(): void
     {
         $footerLogo = Attachment::factory()->create();
+        $favicon = Attachment::factory()->create();
 
         WebsiteType::query()->create([
             'codigo' => 'shopit',
@@ -31,6 +32,7 @@ class BootstrapAdminAppControllerTest extends TestCase
             'border_color' => '#eaeaea',
             'login_header_footer_color' => '#313131',
             'footer_logo' => $footerLogo->id,
+            'favicon_id' => $favicon->id,
         ]);
 
         $this->getJson('/api/v1/adminapp/bootstrap/ADMIN.SHOPIT.TEST')
@@ -41,6 +43,7 @@ class BootstrapAdminAppControllerTest extends TestCase
             ->assertJsonPath('data.login_header_footer_color', '#313131')
             ->assertJsonPath('data.site_logo', null)
             ->assertJsonPath('data.footer_logo', $footerLogo->getTemporaryUrl(1440))
+            ->assertJsonPath('data.favicon', $favicon->getTemporaryUrl(1440))
             ->assertJsonMissingPath('data.forms')
             ->assertJsonMissingPath('data.codigo')
             ->assertJsonMissingPath('data.nombre')

tests/Feature/Tenant/BootstrapScannerControllerTest.php

@@ -14,6 +14,7 @@ class BootstrapScannerControllerTest extends TestCase
     public function test_it_publicly_bootstraps_the_scanner_by_scanner_domain(): void
     {
         $siteLogo = Attachment::factory()->create();
+        $favicon = Attachment::factory()->create();
 
         WebsiteType::query()->create([
             'codigo' => 'shopit',
@@ -32,6 +33,7 @@ class BootstrapScannerControllerTest extends TestCase
             'border_color' => '#eaeaea',
             'login_header_footer_color' => '#313131',
             'site_logo' => $siteLogo->id,
+            'favicon_id' => $favicon->id,
         ]);
 
         $this->getJson('/api/v1/scanner/bootstrap/SCANNER.SHOPIT.TEST')
@@ -40,6 +42,7 @@ class BootstrapScannerControllerTest extends TestCase
             ->assertJsonPath('data.primary_color', '#112233')
             ->assertJsonPath('data.site_logo', $siteLogo->getTemporaryUrl(1440))
             ->assertJsonPath('data.footer_logo', null)
+            ->assertJsonPath('data.favicon', $favicon->getTemporaryUrl(1440))
             ->assertJsonMissingPath('data.codigo')
             ->assertJsonMissingPath('data.nombre')
             ->assertJsonMissingPath('data.dominio')

tests/Feature/Tenant/WebsiteTypeServiceTest.php

@@ -69,4 +69,31 @@ class WebsiteTypeServiceTest extends TestCase
             'favicon_id' => $favicon->id,
         ]);
     }
+
+    public function test_it_keeps_a_shared_favicon_when_one_website_type_replaces_it(): void
+    {
+        Storage::fake('s3');
+
+        $service = app(WebsiteTypeService::class);
+        $shopIt = $service->create([
+            'codigo' => 'shopit',
+            'nombre' => 'ShopIt',
+            'favicon' => UploadedFile::fake()->image('shared-favicon.png', 32, 32),
+        ]);
+        $sharedFavicon = $shopIt->favicon()->firstOrFail();
+        $onTicket = $service->create([
+            'codigo' => 'onticket',
+            'nombre' => 'OnTicket',
+            'favicon' => $sharedFavicon->key,
+        ]);
+
+        $service->updateOrCreate(
+            ['codigo' => 'shopit'],
+            ['favicon' => UploadedFile::fake()->image('shopit-favicon.png', 32, 32)],
+        );
+
+        $this->assertSame($sharedFavicon->id, $onTicket->fresh()->favicon_id);
+        $this->assertDatabaseHas('attachments', ['id' => $sharedFavicon->id]);
+        Storage::disk('s3')->assertExists($sharedFavicon->path);
+    }
 }

tests/Unit/Bootstrap/AdminAppBootstrapResourceTest.php

@@ -17,11 +17,13 @@ class AdminAppBootstrapResourceTest extends TestCase
         ]);
         $websiteType->setRelation('siteLogo', null);
         $websiteType->setRelation('footerLogo', null);
+        $websiteType->setRelation('favicon', null);
         $data = AdminAppBootstrapResource::make([
             'website_type' => $websiteType,
         ])->resolve(request());
 
         $this->assertSame('shopit', $data['website_type_code']);
+        $this->assertNull($data['favicon']);
         $this->assertArrayNotHasKey('forms', $data);
     }
 }