tbianchini/shopit-back
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove PaymentProviderInterface and TelepagosProvider, simplify CheckoutService and related tests

Browse Source
This commit is contained in:
ncoronel
2026-07-03 16:55:11 -03:00
parent 057e6757dc
commit 0cb1c37566
7 changed files with 9 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/Domains/Integration/Services/Contracts/PaymentProviderInterface.php
View File

@@ -1,15 +0,0 @@
<?php
namespace App\Domains\Integration\Services\Contracts;
interface PaymentProviderInterface
{
/**
* Procesa un pago con las credenciales específicas del Tenant.
*
* @param array $paymentData Datos del pago, incluyendo el método (ej. qr, transferencia).
* @param array $credentials Credenciales encriptadas previamente configuradas por el Tenant.
* @return array
*/
public function process(array $paymentData, array $credentials): array;
}

18
app/Domains/Integration/Services/PaymentProviderFactory.php
View File

@@ -1,18 +0,0 @@
<?php
namespace App\Domains\Integration\Services;
use App\Domains\Integration\Services\Contracts\PaymentProviderInterface;
use App\Domains\Integration\Services\Providers\TelepagosProvider;
use InvalidArgumentException;
class PaymentProviderFactory
{
public function make(string $integrationCode): PaymentProviderInterface
{
return match ($integrationCode) {
'telepagos' => new TelepagosProvider(),
default => throw new InvalidArgumentException("Integración de pago no soportada: {$integrationCode}"),
};
}
}

19
app/Domains/Integration/Services/Providers/TelepagosProvider.php
View File

@@ -1,19 +0,0 @@
<?php
namespace App\Domains\Integration\Services\Providers;
use App\Domains\Integration\Services\Contracts\PaymentProviderInterface;
use BadMethodCallException;
class TelepagosProvider implements PaymentProviderInterface
{
public function process(array $paymentData, array $credentials): array
{
// Mocked response for development and local testing
return [
'status' => 'approved',
'transaction_id' => 'mock_tp_' . uniqid(),
'payment_method' => $paymentData['payment_method'] ?? 'qr',
];
}
}

9
app/Domains/Purchase/Controllers/PurchaseController.php
View File

@@ -31,18 +31,11 @@ class PurchaseController extends Controller
public function store(StorePurchaseRequest $request, Tenant $tenant, CheckoutService $checkoutService): JsonResponse
{
$data = $request->validated();
$integrationCode = $data['integration_code'];
$paymentData = $data['payment_data'];
unset($data['integration_code'], $data['payment_data']);
$purchase = $checkoutService->processCheckout(
$tenant,
$request->user()->id,
$data,
$integrationCode,
$paymentData
$data
);
return PurchaseResource::make($purchase)->response()->setStatusCode(201);

1
app/Domains/Purchase/Services/CheckoutService.php
View File

@@ -7,7 +7,6 @@ use App\Domains\Purchase\Models\Purchase;
use App\Domains\Tenant\Models\Tenant;
use Illuminate\Support\Facades\DB;
use Illuminate\Validation\ValidationException;
use Exception;
class CheckoutService
{