feat(cart): implement cart editing policies and update related functionality

2026-08-19 10:15:37 -03:00
parent 67e6211857
commit 014b5bb012
20 changed files with 305 additions and 39 deletions
--- a/tests/Feature/Cart/CartControllerTest.php
+++ b/tests/Feature/Cart/CartControllerTest.php
@@ -121,6 +121,7 @@ class CartControllerTest extends TestCase
            ->assertOk()
            ->assertJsonPath('data.items.0.catalog_item_id', $item->id)
            ->assertJsonPath('data.items.0.variant_id', $variant->id)
+            ->assertJsonPath('data.items.0.variants.0.id', $variant->id)
            ->assertJsonPath('data.items.0.cantidad', 5)
            ->assertJsonPath('data.subtotal', '125.00');

@@ -383,6 +384,83 @@ class CartControllerTest extends TestCase
        ]);
    }

+    public function test_quantity_and_remove_policy_hides_variants_and_rejects_variant_changes(): void
+    {
+        $tenant = $this->createTenant('acme');
+        $tenant->update(['cart_editing_policy' => 'quantity_and_remove']);
+        [$item, $firstVariant] = $this->createVariantItem($tenant, 10, '15.00');
+        $secondInventory = Inventory::query()->create(['real_stock' => 10]);
+        $secondVariant = $item->variants()->create(['inventory_id' => $secondInventory->id]);
+        $createResponse = $this->postJson('/api/tenants/acme/cart/items', [
+            'catalog_item_id' => $item->id,
+            'variant_id' => $firstVariant->id,
+            'cantidad' => 1,
+        ])->assertJsonMissingPath('data.items.0.variants');
+        $guestToken = $createResponse->getCookie('guest_token', false)?->getValue();
+        $cartItemId = $createResponse->json('data.items.0.id');
+
+        $this->call(
+            'PATCH',
+            "/api/tenants/acme/cart/items/{$cartItemId}",
+            [],
+            ['guest_token' => $guestToken],
+            [],
+            ['HTTP_Accept' => 'application/json', 'CONTENT_TYPE' => 'application/json'],
+            json_encode(['cantidad' => 2]),
+        )->assertOk()->assertJsonPath('data.items.0.cantidad', 2);
+
+        $this->call(
+            'PATCH',
+            "/api/tenants/acme/cart/items/{$cartItemId}",
+            [],
+            ['guest_token' => $guestToken],
+            [],
+            ['HTTP_Accept' => 'application/json', 'CONTENT_TYPE' => 'application/json'],
+            json_encode(['cantidad' => 2, 'variant_id' => $secondVariant->id]),
+        )->assertUnprocessable()->assertJsonValidationErrors('variant_id');
+
+        $this->call(
+            'DELETE',
+            "/api/tenants/acme/cart/items/{$cartItemId}",
+            [],
+            ['guest_token' => $guestToken],
+            [],
+            ['HTTP_Accept' => 'application/json'],
+        )->assertOk()->assertJsonPath('data.items', []);
+    }
+
+    public function test_disabled_policy_rejects_quantity_changes_and_removal(): void
+    {
+        $tenant = $this->createTenant('acme');
+        $tenant->update(['cart_editing_policy' => 'disabled']);
+        $item = $this->createDirectItem($tenant, 10, '15.00');
+        $createResponse = $this->postJson('/api/tenants/acme/cart/items', [
+            'catalog_item_id' => $item->id,
+            'cantidad' => 1,
+        ])->assertOk();
+        $guestToken = $createResponse->getCookie('guest_token', false)?->getValue();
+        $cartItemId = $createResponse->json('data.items.0.id');
+
+        $this->call(
+            'PATCH',
+            "/api/tenants/acme/cart/items/{$cartItemId}",
+            [],
+            ['guest_token' => $guestToken],
+            [],
+            ['HTTP_Accept' => 'application/json', 'CONTENT_TYPE' => 'application/json'],
+            json_encode(['cantidad' => 2]),
+        )->assertUnprocessable()->assertJsonValidationErrors('cantidad');
+
+        $this->call(
+            'DELETE',
+            "/api/tenants/acme/cart/items/{$cartItemId}",
+            [],
+            ['guest_token' => $guestToken],
+            [],
+            ['HTTP_Accept' => 'application/json'],
+        )->assertUnprocessable()->assertJsonValidationErrors('cart_item');
+    }
+
    public function test_it_requires_a_variant_when_the_item_has_variant_inventory(): void
    {
        $tenant = $this->createTenant('acme');
--- a/tests/Feature/Migrations/AddCartEditingEnabledToTenantsTest.php
+++ b/tests/Feature/Migrations/AddCartEditingEnabledToTenantsTest.php
@@ -10,10 +10,10 @@ class AddCartEditingEnabledToTenantsTest extends TestCase
 {
    use RefreshDatabase;

-    public function test_it_disables_cart_editing_only_for_desfile(): void
+    public function test_it_migrates_the_boolean_to_the_equivalent_policy(): void
    {
        $migration = require database_path(
-            'migrations/2026_08_18_060000_add_cart_editing_enabled_to_tenants_table.php'
+            'migrations/2026_08_19_000000_replace_cart_editing_enabled_with_policy.php'
        );

        $migration->down();
@@ -21,7 +21,17 @@ class AddCartEditingEnabledToTenantsTest extends TestCase

        $this->assertDatabaseHas('tenants', [
            'codigo' => 'desfile_pura_tendencia',
-            'cart_editing_enabled' => false,
+            'cart_editing_policy' => 'disabled',
+        ]);
+
+        $this->assertDatabaseHas('tenants', [
+            'codigo' => 'sonder',
+            'cart_editing_policy' => 'quantity_and_remove',
+        ]);
+
+        $this->assertDatabaseHas('tenants', [
+            'codigo' => 'fiesta_futbol_infantil',
+            'cart_editing_policy' => 'full',
        ]);

        DB::table('tenants')->insert([
@@ -32,7 +42,7 @@ class AddCartEditingEnabledToTenantsTest extends TestCase

        $this->assertDatabaseHas('tenants', [
            'codigo' => 'cart-editing-default',
-            'cart_editing_enabled' => true,
+            'cart_editing_policy' => 'full',
        ]);
    }
 }
--- a/tests/Feature/Seeders/DesfilePuraTendenciaSeederTest.php
+++ b/tests/Feature/Seeders/DesfilePuraTendenciaSeederTest.php
@@ -44,7 +44,7 @@ class DesfilePuraTendenciaSeederTest extends TestCase
            'footer_bg_color' => '#D4441C',
            'display_categories' => false,
            'display_seach_bar' => false,
-            'cart_editing_enabled' => false,
+            'cart_editing_policy' => 'disabled',
            'display_cart_item_images' => false,
            'site_title' => 'Desfile Pura Tendencia',
        ]);
--- a/tests/Feature/Seeders/TenantSeederTest.php
+++ b/tests/Feature/Seeders/TenantSeederTest.php
@@ -61,6 +61,7 @@ class TenantSeederTest extends TestCase
            ->sole();

        $this->assertSame('shopit', $sonder->website_type_code);
+        $this->assertSame('quantity_and_remove', $sonder->cart_editing_policy->value);

        $carousel = $sonder->websiteExtras
            ->firstWhere('websiteTypeExtra.codigo', 'carousel');
@@ -81,6 +82,7 @@ class TenantSeederTest extends TestCase
            ->sole();

        $this->assertSame('onticket', $fiesta->website_type_code);
+        $this->assertSame('full', $fiesta->cart_editing_policy->value);

        $extras = $fiesta->websiteExtras->keyBy('websiteTypeExtra.codigo');
        $this->assertEqualsCanonicalizing(
--- a/tests/Feature/Tenant/BootstrapTenantControllerTest.php
+++ b/tests/Feature/Tenant/BootstrapTenantControllerTest.php
@@ -73,7 +73,7 @@ class BootstrapTenantControllerTest extends TestCase
            'display_categories' => false,
            'display_seach_bar' => false,
            'display_cart' => false,
-            'cart_editing_enabled' => false,
+            'cart_editing_policy' => 'disabled',
            'display_cart_item_images' => false,
        ]);

@@ -91,7 +91,11 @@ class BootstrapTenantControllerTest extends TestCase
            ->assertJsonPath('data.display_categories', false)
            ->assertJsonPath('data.display_seach_bar', false)
            ->assertJsonPath('data.display_cart', false)
-            ->assertJsonPath('data.cart_editing_enabled', false)
+            ->assertJsonPath('data.cart_editing_policy.code', 'disabled')
+            ->assertJsonPath('data.cart_editing_policy.allow_modify', false)
+            ->assertJsonPath('data.cart_editing_policy.allow_delete', false)
+            ->assertJsonPath('data.cart_editing_policy.allow_update_quantity', false)
+            ->assertJsonPath('data.cart_editing_policy.allow_update_variant', false)
            ->assertJsonPath('data.display_cart_item_images', false)
            ->assertJsonPath('data.header_bg_color', '#ffffff')->assertJsonPath('data.footer_bg_color', '#ffffff');

@@ -758,7 +762,7 @@ class BootstrapTenantControllerTest extends TestCase

        $response = $this->putJson("/api/tenants/{$tenant->codigo}", [
            'primary_color' => '#000000',
-            'cart_editing_enabled' => false,
+            'cart_editing_policy' => 'quantity_and_remove',
            'display_cart_item_images' => false,
        ]);

@@ -767,7 +771,11 @@ class BootstrapTenantControllerTest extends TestCase
            ->assertJsonPath('data.codigo', 'acme')
            ->assertJsonPath('data.nombre', 'Acme')
            ->assertJsonPath('data.primary_color', '#000000')
-            ->assertJsonPath('data.cart_editing_enabled', false)
+            ->assertJsonPath('data.cart_editing_policy.code', 'quantity_and_remove')
+            ->assertJsonPath('data.cart_editing_policy.allow_modify', true)
+            ->assertJsonPath('data.cart_editing_policy.allow_delete', true)
+            ->assertJsonPath('data.cart_editing_policy.allow_update_quantity', true)
+            ->assertJsonPath('data.cart_editing_policy.allow_update_variant', false)
            ->assertJsonPath('data.display_cart_item_images', false);

        $this->assertDatabaseHas('tenants', [
@@ -775,7 +783,7 @@ class BootstrapTenantControllerTest extends TestCase
            'codigo' => 'acme',
            'nombre' => 'Acme',
            'primary_color' => '#000000',
-            'cart_editing_enabled' => false,
+            'cart_editing_policy' => 'quantity_and_remove',
            'display_cart_item_images' => false,
        ]);
    }